7ba5a0cc58
CSceneNode: Convert 0 literal to nullptr
2020-06-15 15:31:12 -04:00
77248960f8
CModel: Simplify InternalGetIBO() a little
...
We can use the result of the emplace_back directly.
2020-06-15 14:55:50 -04:00
79f7b62960
CMaterialSet/CModel: Make use of size_t where applicable
...
Prevents type truncation warnings internally and also provides slightly
better code-gen, given the upper half of 64-bit registers don't need to
be constantly cleared.
2020-06-15 14:49:38 -04:00
6edea6a225
CMaterialSet: Make Clone() return a unique_ptr
...
Makes the returned pointer leak-free by default.
2020-06-15 14:12:06 -04:00
95f6c3360d
CMaterialPass: Make use of size_t where applicable
...
Plays nicer with standard types.
2020-06-15 14:08:36 -04:00
b90bd90e03
CMaterial: std::move string in SetName()
...
Allows callers to avoid copies.
2020-06-15 14:02:59 -04:00
e7b3015f08
CMaterial: Make use of size_t where applicable
...
Prevents truncation warnings from occurring.
2020-06-15 14:02:55 -04:00
5b96480a45
CMaterial: Simplify Clone() a little
...
Given we use std::array now, we can perform a direct assignment instead
of a loop.
2020-06-15 13:55:22 -04:00
28587fb622
CSceneNode: std::move string in SetName()
...
Allows for calling code to completely avoid copies being made.
2020-06-15 13:48:57 -04:00
e962d9ba96
CLight: Correct lack of assignment in SetSpotCutoff()
...
Brought this up with Antidote and was told that this is likely what was
intended to be done.
2020-06-14 20:16:54 -04:00
9e3018809f
CWorld: Eliminate sign conversion warnings
2020-06-14 19:48:23 -04:00
35ea47e473
CWorld: Make use of in-class initializers
...
Same behavior, less code.
2020-06-14 19:47:05 -04:00
128ee0d01c
CMaterialLoader: Make use of static
...
This function doesn't touch instance state at all
2020-06-14 19:43:43 -04:00
cc376d3e21
CMaterialLoader: Make use of std::array
2020-06-14 19:41:42 -04:00
903f6dfe7e
CGameArea: Make use of in-class initializers where applicable
...
Same behavior, less code.
2020-06-14 19:27:54 -04:00
2c274897c9
CLightParameters: Make EWorldLightingOptions an enum class
...
Avoids polluting the global namespace.
2020-06-14 19:21:30 -04:00
cec88d182b
CLightNode: Mark member functions as const where applicable
...
Several functions don't modify internal member state.
2020-06-14 19:13:35 -04:00
f2201ca03c
CLight: Make CalculateSpotAngleAtten() const
...
This member function doesn't modify internal member state.
2020-06-14 19:05:29 -04:00
b439e4bba1
CLight: Make use of in-class initializers where applicable
...
Same behavior, less code.
2020-06-14 19:03:32 -04:00
f942ad6551
CGameTemplate: Mark getter functions as const
...
These don't modify internal class state, so we can mark them as const.
2020-06-14 18:58:05 -04:00
15708b8624
CGameTemplate: Collapse loops into ranged for where applicable
2020-06-14 18:49:37 -04:00
d9bb255518
CGameTemplate: Use in-class initializers where applicable
...
Same behavior, less code.
2020-06-14 18:35:10 -04:00
332be356de
CIndexBuffer: Make use of size_t where applicable
...
Provides a nicer interface for operating with standard types, etc.
2020-06-14 18:29:39 -04:00
d4564434c3
FShowFlags: Remove use of cpp file
...
Now that these constructs are constexpr capable, we can make use of
constexpr here to contain it fully within the header.
2020-06-14 17:12:37 -04:00
b2db6a21fa
CFlagsProperty: Mark HasValidValue() as const
...
This doesn't modify internal state.
2020-06-14 17:07:47 -04:00
d5a33b631a
CFlagsProperty: Make use of a ranged for loop
2020-06-14 17:06:46 -04:00
84184da66d
CFont: Prevent Wmaybe-uninitialized warning
2020-06-14 17:04:35 -04:00
4861f118fb
CFont: Make PtsToFloat() internally linked
...
This is only ever used within the cpp file
2020-06-14 17:04:35 -04:00
1c292f5e2d
CFont: Make use of std::array
...
Same behavior, stronger typing.
2020-06-14 17:04:32 -04:00
b6b7bcace1
CFont: In-class initialize members where applicable
...
Provides a consistent initial state.
2020-06-14 16:54:16 -04:00
01e68ec5d8
CFontLoader: Default constructor
2020-06-14 16:51:13 -04:00
e49315a645
CSkeleton: Make use of unique_ptr where applicable
...
Makes ownership semantics explicit.
2020-06-14 16:49:51 -04:00
4dcb539763
CSkeletonLoader: Make use of ranged for where applicable
...
Same behavior, less code.
2020-06-14 16:13:28 -04:00
6909c75d64
CTextureDecoder: Misc cleanup
...
Const correctness, unimplemented prototypes, reducing copies, etc.
2020-06-14 16:07:43 -04:00
68455c54e8
CTextureDecoder: Make utility functions internally linked
...
Same behavior, but keeps implementation details internal.
2020-06-14 15:41:32 -04:00
f0cd6ee99b
CStructProperty: Make use of ranged for
2020-06-12 17:25:06 -04:00
7b40eec19c
CScriptObject: Collapse for loops into ranged for loops
...
While we're at it, eliminate sign conversion warnings.
2020-06-12 17:12:37 -04:00
5c42bcc580
CLink: Resolve sign conversion warnings
2020-06-12 16:46:49 -04:00
38d245b460
CLink: Make constructor explicit
2020-06-12 16:45:33 -04:00
f5e9254c9a
CIndexBuffer: Make use of in-class initializers where applicable
2020-06-12 16:43:54 -04:00
721c4d8121
CIndexBuffer: Make constructor explicit
...
Prevents implicit constructions.
2020-06-12 16:41:47 -04:00
ece0aec27a
CGraphics: Make use of std::array
2020-06-12 16:36:34 -04:00
bf9233779a
CGraphics: Make skDefaultAmbientColor constexpr
...
Same behavior, no runtime initializer.
2020-06-12 16:19:59 -04:00
e8a20933de
CVirtualDirectory: Resolve -Wreorder warnings
2020-06-12 16:09:20 -04:00
1ae5462cd7
CGameProject: Make use of unique_ptr where applicable
...
Makes the ownership semantics explicit.
2020-06-12 16:07:04 -04:00
1bdcdb85de
CResourceStore: Use unique_ptr where applicable
...
Makes the ownership semantics explicit and prevents leaks from occurring
a little better.
2020-06-12 14:43:39 -04:00
137b2395c9
CResourceStore: Use in-class initializers where applicable
2020-06-12 14:11:57 -04:00
7da16efe9d
CDependencyTree: Make use of unique_ptr
...
Makes the ownership semantics explicit in the interface.
2020-06-12 14:09:08 -04:00
e2190793fd
CDependencyTree: Tidying up
...
- Convert for loops to ranged for loops.
- Collapse loop into an any_of.
2020-06-12 13:37:54 -04:00
7d4ce7e909
CDependencyGroupLoader: Default constructor
2020-06-12 13:26:39 -04:00
10cbcd4024
Merge pull request #31 from lioncash/properties
...
Property: Make use of override where applicable
2020-06-12 13:17:05 -04:00
c020084587
CCollisionMaterial: Make use of std::array
...
Allows simplifying some size calculations.
2020-06-12 13:14:39 -04:00
a51604ca91
CCollisionMeshGroup: Make use of unique_ptr
2020-06-12 13:08:48 -04:00
48d8d361b6
CCollisionLoader: Collapse for loop into ranged for pt. 2
2020-06-12 12:57:18 -04:00
3b3b2cc80f
CCollisionLoader: Collapse for loop into ranged for
...
Also removes a delete left behind in an error case.
2020-06-12 12:52:28 -04:00
3449f60317
CCollisionLoader: Make use of unique_ptr more
...
Same behavior, but makes the allocation ownership explicit
2020-06-12 12:50:19 -04:00
d43f2dab31
CAudioGroupLoader: Default constructor
2020-06-12 12:44:27 -04:00
9e2a8bd693
CAnimationLoader: Make use of std::array
...
Prevents implicit array to pointer decay.
2020-06-12 12:43:09 -04:00
12ccb2fbd4
CGameArea: Simplify allocation handling
...
Eliminates manual new/delete and also makes the lifecycle of allocations
enforced within the interface.
2020-06-12 12:38:54 -04:00
674ae65e56
CAnimSetLoader: Collapse for loops into ranged for loops
2020-06-12 11:28:05 -04:00
9921ccfe25
IMetaTransition: Always initialize CMetaTransTrans members
...
Always provides a deterministic initial state.
2020-06-12 10:47:22 -04:00
eabc789910
CAnimSet: Simplify allocation code
...
We can make use of std::unique_ptr to prevent any potential memory leaks
from occurring and simplifying the destruction code.
2020-06-12 10:43:29 -04:00
4eb1027362
CAnimSet: Collapse loops into ranged for where applicable
2020-06-12 10:03:02 -04:00
2a5ab1ed32
CAnimEventLoader: Use unique_ptr more
...
Makes memory handling a little more robust.
2020-06-11 21:10:02 -04:00
ecbd3eb83d
CAnimEventLoader: Default destructor
...
Allows the constructor to be considered trivial.
2020-06-11 21:00:08 -04:00
114742fc37
CCamera: Resolve -Wreorder warnings
2020-06-11 20:58:59 -04:00
6f0c8669de
CCollisionLoader: Formatting
2020-06-11 20:53:11 -04:00
d0bd7eb292
CCollisionLoader: Make LoadAreaCollision() return a unique_ptr
...
Same behavior, less boilerplate
2020-06-11 20:46:39 -04:00
907f1270bd
CResourceFactory: Make use of unique_ptr
...
Makes the API more memory safe
2020-06-11 20:22:21 -04:00
ce315280c3
CResource: Make BuildDependencyTree() return a unique_ptr
...
Makes the functions more memory safe in terms of freeing memory in
exceptional paths .
2020-06-11 18:39:07 -04:00
eb8ca98a8a
CAnimEventData: Collapse for loop into a ranged for loop
2020-06-11 18:02:52 -04:00
044efcf59d
CAnimEventData: Remove unnecessary inline specifiers
2020-06-11 18:01:18 -04:00
aeea0f8052
CMaterialPass: Make use of std::array
2020-06-11 17:50:40 -04:00
7b81aa5268
CMaterialPass: Simplify initialization code
2020-06-11 17:41:54 -04:00
92811a9309
CShader: Simplify initialization
2020-06-11 17:34:52 -04:00
b8078e7419
CShaderGenerator: Fix compiler warning
...
MSVC desires the namespace version
2020-06-11 15:55:06 -04:00
012da6fb6d
General: Remove unnecessary inline specifiers and add overrides
2020-06-11 15:49:42 -04:00
2d76c5865a
CCharacterNode: Add missing override specifiers
2020-06-11 13:44:20 -04:00
060101c718
CCharacterNode: Remove unnecessary inline specifiers
...
Functions defined in class declarations are implicitly inline
2020-06-11 13:43:19 -04:00
100453b356
CCamera: Remove unnecessary inline specifiers
...
Functions defined within a class declaration are inline by default.
2020-06-11 13:41:33 -04:00
53b257fb8a
CBoneTransformData: Remove unnecessary inline keywords
...
Functions defined within the class declaration are inline by default.
2020-06-11 13:40:00 -04:00
9ec61de2ca
CAudioManager: Make LogSoundInfo() a const member function
...
This function doesn't modify internal state.
2020-06-11 13:38:00 -04:00
872c38b384
CAudioManager: Make GetSoundInfo() a const member function
...
This doesn't modify internal member state.
2020-06-11 13:35:38 -04:00
9692a064cd
CAudioManager: Make constructor explicit
...
Prevents potentially error-prone constructions from occurring
2020-06-11 13:34:17 -04:00
7f881b1b10
CAudioMacro: Make use of ranged for where applicable
...
Same behavior, less moving parts.
2020-06-11 13:32:29 -04:00
f9031283d0
CAudioMacro: Add missing override specifier
2020-06-11 13:31:40 -04:00
416608a76a
CAudioMacro: Remove unnecessary inline specifiers
...
Functions defined within a class declaration are already inline by
default.
2020-06-11 13:31:00 -04:00
edaafd4bcf
CAudioMacro: Make constructor explicit
...
Prevents implicit error-prone constructions from occurring.
2020-06-11 13:30:07 -04:00
e95cb1117a
CAudioLookupTable: Include used headers
2020-06-11 13:28:11 -04:00
1b4ebd5f7b
CAudioLookupTable: Make FindSoundDefineID() const
...
This doesn't mutate any contained state, so it can be const.
2020-06-11 13:26:32 -04:00
a82f9c197b
CAudioLookupTable: Make use of explicit constructors
...
Prevents implicit constructions
2020-06-11 13:25:19 -04:00
d223bac56a
CAudioGroup: Make use of in-class initializers
2020-06-11 13:23:50 -04:00
7ce0e14e29
CAssetNameMap: Eliminate file-scope string allocations
2020-06-11 13:21:33 -04:00
9925925b6f
TResPtr: Use in-class initializers where applicable
2020-06-11 13:14:33 -04:00
11f156352a
CAnimSetLoader: Default constructor
2020-06-11 13:11:38 -04:00
61a6151afe
externals: Update LibCommon
2020-06-11 11:10:04 -04:00
b5ddc20771
Merge pull request #26 from lioncash/scene
...
CSceneNode: Minor cleanup
2020-06-11 10:53:51 -04:00
1fb554fa4c
Merge pull request #24 from lioncash/cook
...
CAreaCooker: Minor cleanup
2020-06-11 10:53:17 -04:00
8babcc13bb
Merge pull request #22 from lioncash/anim2
...
CAnimation: Minor clean up
2020-06-11 10:52:59 -04:00
9c2b7e4c95
Merge pull request #23 from lioncash/iter
...
CResourceIterator: Cleanup and undefined behavior prevention
2020-06-11 10:52:41 -04:00
Lioncash