Commit Graph

672 Commits

Author SHA1 Message Date
Lioncash e9df5625e6 CScriptLayer: std::move string in SetName()
Allows calling code to avoid copies.
2020-06-18 04:48:15 -04:00
Lioncash a55fafac22 CScriptLayer: Add const overload for operator[]
Behavioral symmetry.
2020-06-18 04:47:17 -04:00
Lioncash 2b7c322e59 CScriptLayer: Make use of prefix increment on iterators 2020-06-18 04:46:38 -04:00
Lioncash 363b19ebe6 CScriptLayer: Make use of explicit 2020-06-18 04:45:40 -04:00
Lioncash 26f847494e CDynamicVertexBuffer: Make use of std::array where applicable
Same behavior, but eliminates hardcoded sizes.
2020-06-18 04:42:57 -04:00
Lioncash 65482ba272 CCollisionMeshData: Make use of size_t where applicable
Plays nicer with standard types.
2020-06-18 04:37:20 -04:00
Lioncash ce97d79fa3 CBoneTransformData: Make use of size_t where applicable
Plays nicer with standard containers and prevents truncation warnings.
2020-06-18 04:30:57 -04:00
Lioncash cc04eee1b7 NGameList: Tidying up
Cleans up linkage and casts.
2020-06-18 04:20:41 -04:00
Lioncash a54bd900c0 NPropertyMap: Make use of ranged for where applicable
While we're at it, we can tidy up a few other things like linkage
2020-06-18 04:13:18 -04:00
Lioncash 6799e40ef5 IProperty: Make use of ranged for where applicable
Same behavior, less moving parts.
2020-06-17 17:54:57 -04:00
Lioncash e4feff9930 CTweakManager: Remove unnecessary inline specifier 2020-06-17 17:34:34 -04:00
Lioncash b2ad9cf13b CTweakData: Fix -Wreorder warnings 2020-06-17 04:32:14 -04:00
Lioncash 4a020d1d4a CSkin: Make use of ranged for where applicable
Same behavior, less code.
2020-06-17 04:27:54 -04:00
Lioncash 32dafc6bb8 CSkeleton: Make use of size_t where applicable
Prevents truncation warnings.
2020-06-17 04:24:49 -04:00
Lioncash 566a32fd75 General: Migrate off non-constexpr constants 2020-06-16 22:48:11 -04:00
Lioncash c8ebbc860b CMaterialSet: Collapse loop into find_if
Same behavior, explicit intent.
2020-06-16 18:45:52 -04:00
Lioncash 2d2210cd9e CMaterial: Make use of size_t for loops where applicable
Consistency.

While we're at it, remove an unused include.
2020-06-16 18:42:28 -04:00
Lioncash f44a5fc8d2 CShader: Mark several functions as const
These don't modify internal member state.
2020-06-16 18:33:01 -04:00
Lioncash a67df9865e CShader: Make use of unique_ptr where applicable
Prevents unsafe allocations by default.
2020-06-16 18:27:13 -04:00
Lioncash 4d34589816 CDrawUtil: Make use of std::array
While we're at it, we can make several arrays constexpr.
2020-06-16 18:04:10 -04:00
Lioncash 43596280c5 CVertexBuffer: Make use of size_t in Reserve() 2020-06-16 17:42:24 -04:00
Lioncash 3d1ced47e2 CVertex: Make use of std::array where applicable
Allows dehardcoding sizes and simplifies comparison code.
2020-06-16 17:17:20 -04:00
Lioncash a17d43a87d CVertexBuffer: Make use of size_t where applicable
Same behavior, less truncations.
2020-06-16 16:48:25 -04:00
Lioncash d081dd87cf CVertexBuffer: Make use of std::array
Same behavior, but without hardcoded array sizes.
2020-06-16 16:13:47 -04:00
Lioncash 09f5163184 CStringTable: Make use of size_t
Plays nicer with standard containers. While we're at it, we can use
std::move where applicable.
2020-06-16 15:17:23 -04:00
Lioncash f71ef1e615 CStringList: Make use of size_t
Prevents truncation warnings.
2020-06-16 14:25:07 -04:00
Lioncash c980df5188 CSourceAnimData: Make use of ranged for where applicable 2020-06-16 14:21:02 -04:00
Lioncash 84a42cd3c2 CWorld: Make use of size_t where applicable
Plays nicer with standard types and prevents type truncations.
2020-06-15 20:14:17 -04:00
Lioncash c9270b65ed CWorld: Make use of std::move in SetName()
Allows calling code to avoid copies.
2020-06-15 19:55:43 -04:00
Lioncash e18e73cca5 CBasicModel: Make use of size_t where applicable
Same behavior, but without some internal variable truncation.
2020-06-15 19:48:25 -04:00
Lioncash 4978bc9e5c CBasicModel: Make use of explicit 2020-06-15 19:32:44 -04:00
Lioncash fa883930db CAudioManager: Make use of ranged for 2020-06-15 19:28:34 -04:00
Lioncash 7a6c30861d CAreaAttributes: Make constructor explicit 2020-06-15 18:59:04 -04:00
Lioncash 9bcb2f288d CAnimationParameters: Provide operator!=
Provides logical symmetry.
2020-06-15 15:41:58 -04:00
Lioncash f498088bed CAnimationParameters: Default copy constructor and assignment operator
Same behavior, less code.
2020-06-15 15:36:33 -04:00
Lioncash 247fcd37a8 CAnimationParameters: Remove unnecessary inline specifiers 2020-06-15 15:34:57 -04:00
LC d0a32518cd
Merge pull request #21 from lioncash/anim
CAnimationParameters: Add missing break in switch cases in SetUnknown()
2020-06-15 15:33:31 -04:00
Lioncash 7ba5a0cc58 CSceneNode: Convert 0 literal to nullptr 2020-06-15 15:31:12 -04:00
Lioncash 77248960f8 CModel: Simplify InternalGetIBO() a little
We can use the result of the emplace_back directly.
2020-06-15 14:55:50 -04:00
Lioncash 79f7b62960 CMaterialSet/CModel: Make use of size_t where applicable
Prevents type truncation warnings internally and also provides slightly
better code-gen, given the upper half of 64-bit registers don't need to
be constantly cleared.
2020-06-15 14:49:38 -04:00
Lioncash 6edea6a225 CMaterialSet: Make Clone() return a unique_ptr
Makes the returned pointer leak-free by default.
2020-06-15 14:12:06 -04:00
Lioncash 95f6c3360d CMaterialPass: Make use of size_t where applicable
Plays nicer with standard types.
2020-06-15 14:08:36 -04:00
Lioncash b90bd90e03 CMaterial: std::move string in SetName()
Allows callers to avoid copies.
2020-06-15 14:02:59 -04:00
Lioncash e7b3015f08 CMaterial: Make use of size_t where applicable
Prevents truncation warnings from occurring.
2020-06-15 14:02:55 -04:00
Lioncash 5b96480a45 CMaterial: Simplify Clone() a little
Given we use std::array now, we can perform a direct assignment instead
of a loop.
2020-06-15 13:55:22 -04:00
Lioncash 28587fb622 CSceneNode: std::move string in SetName()
Allows for calling code to completely avoid copies being made.
2020-06-15 13:48:57 -04:00
Lioncash e962d9ba96 CLight: Correct lack of assignment in SetSpotCutoff()
Brought this up with Antidote and was told that this is likely what was
intended to be done.
2020-06-14 20:16:54 -04:00
Lioncash 9e3018809f CWorld: Eliminate sign conversion warnings 2020-06-14 19:48:23 -04:00
Lioncash 35ea47e473 CWorld: Make use of in-class initializers
Same behavior, less code.
2020-06-14 19:47:05 -04:00
Lioncash 128ee0d01c CMaterialLoader: Make use of static
This function doesn't touch instance state at all
2020-06-14 19:43:43 -04:00
Lioncash cc376d3e21 CMaterialLoader: Make use of std::array 2020-06-14 19:41:42 -04:00
Lioncash 903f6dfe7e CGameArea: Make use of in-class initializers where applicable
Same behavior, less code.
2020-06-14 19:27:54 -04:00
Lioncash 2c274897c9 CLightParameters: Make EWorldLightingOptions an enum class
Avoids polluting the global namespace.
2020-06-14 19:21:30 -04:00
Lioncash cec88d182b CLightNode: Mark member functions as const where applicable
Several functions don't modify internal member state.
2020-06-14 19:13:35 -04:00
Lioncash f2201ca03c CLight: Make CalculateSpotAngleAtten() const
This member function doesn't modify internal member state.
2020-06-14 19:05:29 -04:00
Lioncash b439e4bba1 CLight: Make use of in-class initializers where applicable
Same behavior, less code.
2020-06-14 19:03:32 -04:00
Lioncash f942ad6551 CGameTemplate: Mark getter functions as const
These don't modify internal class state, so we can mark them as const.
2020-06-14 18:58:05 -04:00
Lioncash 15708b8624 CGameTemplate: Collapse loops into ranged for where applicable 2020-06-14 18:49:37 -04:00
Lioncash d9bb255518 CGameTemplate: Use in-class initializers where applicable
Same behavior, less code.
2020-06-14 18:35:10 -04:00
Lioncash 332be356de CIndexBuffer: Make use of size_t where applicable
Provides a nicer interface for operating with standard types, etc.
2020-06-14 18:29:39 -04:00
Lioncash d4564434c3 FShowFlags: Remove use of cpp file
Now that these constructs are constexpr capable, we can make use of
constexpr here to contain it fully within the header.
2020-06-14 17:12:37 -04:00
Lioncash b2db6a21fa CFlagsProperty: Mark HasValidValue() as const
This doesn't modify internal state.
2020-06-14 17:07:47 -04:00
Lioncash d5a33b631a CFlagsProperty: Make use of a ranged for loop 2020-06-14 17:06:46 -04:00
Lioncash 84184da66d CFont: Prevent Wmaybe-uninitialized warning 2020-06-14 17:04:35 -04:00
Lioncash 4861f118fb CFont: Make PtsToFloat() internally linked
This is only ever used within the cpp file
2020-06-14 17:04:35 -04:00
Lioncash 1c292f5e2d CFont: Make use of std::array
Same behavior, stronger typing.
2020-06-14 17:04:32 -04:00
Lioncash b6b7bcace1 CFont: In-class initialize members where applicable
Provides a consistent initial state.
2020-06-14 16:54:16 -04:00
Lioncash 01e68ec5d8 CFontLoader: Default constructor 2020-06-14 16:51:13 -04:00
Lioncash e49315a645 CSkeleton: Make use of unique_ptr where applicable
Makes ownership semantics explicit.
2020-06-14 16:49:51 -04:00
Lioncash 4dcb539763 CSkeletonLoader: Make use of ranged for where applicable
Same behavior, less code.
2020-06-14 16:13:28 -04:00
Lioncash 6909c75d64 CTextureDecoder: Misc cleanup
Const correctness, unimplemented prototypes, reducing copies, etc.
2020-06-14 16:07:43 -04:00
Lioncash 68455c54e8 CTextureDecoder: Make utility functions internally linked
Same behavior, but keeps implementation details internal.
2020-06-14 15:41:32 -04:00
Lioncash f0cd6ee99b CStructProperty: Make use of ranged for 2020-06-12 17:25:06 -04:00
Lioncash 7b40eec19c CScriptObject: Collapse for loops into ranged for loops
While we're at it, eliminate sign conversion warnings.
2020-06-12 17:12:37 -04:00
Lioncash 5c42bcc580 CLink: Resolve sign conversion warnings 2020-06-12 16:46:49 -04:00
Lioncash 38d245b460 CLink: Make constructor explicit 2020-06-12 16:45:33 -04:00
Lioncash f5e9254c9a CIndexBuffer: Make use of in-class initializers where applicable 2020-06-12 16:43:54 -04:00
Lioncash 721c4d8121 CIndexBuffer: Make constructor explicit
Prevents implicit constructions.
2020-06-12 16:41:47 -04:00
Lioncash ece0aec27a CGraphics: Make use of std::array 2020-06-12 16:36:34 -04:00
Lioncash bf9233779a CGraphics: Make skDefaultAmbientColor constexpr
Same behavior, no runtime initializer.
2020-06-12 16:19:59 -04:00
Lioncash e8a20933de CVirtualDirectory: Resolve -Wreorder warnings 2020-06-12 16:09:20 -04:00
Lioncash 1ae5462cd7 CGameProject: Make use of unique_ptr where applicable
Makes the ownership semantics explicit.
2020-06-12 16:07:04 -04:00
Lioncash 1bdcdb85de CResourceStore: Use unique_ptr where applicable
Makes the ownership semantics explicit and prevents leaks from occurring
a little better.
2020-06-12 14:43:39 -04:00
Lioncash 137b2395c9 CResourceStore: Use in-class initializers where applicable 2020-06-12 14:11:57 -04:00
Lioncash 7da16efe9d CDependencyTree: Make use of unique_ptr
Makes the ownership semantics explicit in the interface.
2020-06-12 14:09:08 -04:00
Lioncash e2190793fd CDependencyTree: Tidying up
- Convert for loops to ranged for loops.
- Collapse loop into an any_of.
2020-06-12 13:37:54 -04:00
Lioncash 7d4ce7e909 CDependencyGroupLoader: Default constructor 2020-06-12 13:26:39 -04:00
LC 10cbcd4024
Merge pull request #31 from lioncash/properties
Property: Make use of override where applicable
2020-06-12 13:17:05 -04:00
Lioncash c020084587 CCollisionMaterial: Make use of std::array
Allows simplifying some size calculations.
2020-06-12 13:14:39 -04:00
Lioncash a51604ca91 CCollisionMeshGroup: Make use of unique_ptr 2020-06-12 13:08:48 -04:00
Lioncash 48d8d361b6 CCollisionLoader: Collapse for loop into ranged for pt. 2 2020-06-12 12:57:18 -04:00
Lioncash 3b3b2cc80f CCollisionLoader: Collapse for loop into ranged for
Also removes a delete left behind in an error case.
2020-06-12 12:52:28 -04:00
Lioncash 3449f60317 CCollisionLoader: Make use of unique_ptr more
Same behavior, but makes the allocation ownership explicit
2020-06-12 12:50:19 -04:00
Lioncash d43f2dab31 CAudioGroupLoader: Default constructor 2020-06-12 12:44:27 -04:00
Lioncash 9e2a8bd693 CAnimationLoader: Make use of std::array
Prevents implicit array to pointer decay.
2020-06-12 12:43:09 -04:00
Lioncash 12ccb2fbd4 CGameArea: Simplify allocation handling
Eliminates manual new/delete and also makes the lifecycle of allocations
enforced within the interface.
2020-06-12 12:38:54 -04:00
Lioncash 674ae65e56 CAnimSetLoader: Collapse for loops into ranged for loops 2020-06-12 11:28:05 -04:00
Lioncash 9921ccfe25 IMetaTransition: Always initialize CMetaTransTrans members
Always provides a deterministic initial state.
2020-06-12 10:47:22 -04:00
Lioncash eabc789910 CAnimSet: Simplify allocation code
We can make use of std::unique_ptr to prevent any potential memory leaks
from occurring and simplifying the destruction code.
2020-06-12 10:43:29 -04:00
Lioncash 4eb1027362 CAnimSet: Collapse loops into ranged for where applicable 2020-06-12 10:03:02 -04:00