e6d2421de3
externals: Update LibCommon
2020-06-16 19:58:36 -04:00
c8ebbc860b
CMaterialSet: Collapse loop into find_if
...
Same behavior, explicit intent.
2020-06-16 18:45:52 -04:00
2d2210cd9e
CMaterial: Make use of size_t for loops where applicable
...
Consistency.
While we're at it, remove an unused include.
2020-06-16 18:42:28 -04:00
f44a5fc8d2
CShader: Mark several functions as const
...
These don't modify internal member state.
2020-06-16 18:33:01 -04:00
a67df9865e
CShader: Make use of unique_ptr where applicable
...
Prevents unsafe allocations by default.
2020-06-16 18:27:13 -04:00
4d34589816
CDrawUtil: Make use of std::array
...
While we're at it, we can make several arrays constexpr.
2020-06-16 18:04:10 -04:00
43596280c5
CVertexBuffer: Make use of size_t in Reserve()
2020-06-16 17:42:24 -04:00
3d1ced47e2
CVertex: Make use of std::array where applicable
...
Allows dehardcoding sizes and simplifies comparison code.
2020-06-16 17:17:20 -04:00
a17d43a87d
CVertexBuffer: Make use of size_t where applicable
...
Same behavior, less truncations.
2020-06-16 16:48:25 -04:00
d081dd87cf
CVertexBuffer: Make use of std::array
...
Same behavior, but without hardcoded array sizes.
2020-06-16 16:13:47 -04:00
09f5163184
CStringTable: Make use of size_t
...
Plays nicer with standard containers. While we're at it, we can use
std::move where applicable.
2020-06-16 15:17:23 -04:00
f71ef1e615
CStringList: Make use of size_t
...
Prevents truncation warnings.
2020-06-16 14:25:07 -04:00
c980df5188
CSourceAnimData: Make use of ranged for where applicable
2020-06-16 14:21:02 -04:00
84a42cd3c2
CWorld: Make use of size_t where applicable
...
Plays nicer with standard types and prevents type truncations.
2020-06-15 20:14:17 -04:00
c9270b65ed
CWorld: Make use of std::move in SetName()
...
Allows calling code to avoid copies.
2020-06-15 19:55:43 -04:00
e18e73cca5
CBasicModel: Make use of size_t where applicable
...
Same behavior, but without some internal variable truncation.
2020-06-15 19:48:25 -04:00
4978bc9e5c
CBasicModel: Make use of explicit
2020-06-15 19:32:44 -04:00
fa883930db
CAudioManager: Make use of ranged for
2020-06-15 19:28:34 -04:00
7a6c30861d
CAreaAttributes: Make constructor explicit
2020-06-15 18:59:04 -04:00
9bcb2f288d
CAnimationParameters: Provide operator!=
...
Provides logical symmetry.
2020-06-15 15:41:58 -04:00
f498088bed
CAnimationParameters: Default copy constructor and assignment operator
...
Same behavior, less code.
2020-06-15 15:36:33 -04:00
247fcd37a8
CAnimationParameters: Remove unnecessary inline specifiers
2020-06-15 15:34:57 -04:00
d0a32518cd
Merge pull request #21 from lioncash/anim
...
CAnimationParameters: Add missing break in switch cases in SetUnknown()
2020-06-15 15:33:31 -04:00
7ba5a0cc58
CSceneNode: Convert 0 literal to nullptr
2020-06-15 15:31:12 -04:00
77248960f8
CModel: Simplify InternalGetIBO() a little
...
We can use the result of the emplace_back directly.
2020-06-15 14:55:50 -04:00
79f7b62960
CMaterialSet/CModel: Make use of size_t where applicable
...
Prevents type truncation warnings internally and also provides slightly
better code-gen, given the upper half of 64-bit registers don't need to
be constantly cleared.
2020-06-15 14:49:38 -04:00
6edea6a225
CMaterialSet: Make Clone() return a unique_ptr
...
Makes the returned pointer leak-free by default.
2020-06-15 14:12:06 -04:00
95f6c3360d
CMaterialPass: Make use of size_t where applicable
...
Plays nicer with standard types.
2020-06-15 14:08:36 -04:00
b90bd90e03
CMaterial: std::move string in SetName()
...
Allows callers to avoid copies.
2020-06-15 14:02:59 -04:00
e7b3015f08
CMaterial: Make use of size_t where applicable
...
Prevents truncation warnings from occurring.
2020-06-15 14:02:55 -04:00
5b96480a45
CMaterial: Simplify Clone() a little
...
Given we use std::array now, we can perform a direct assignment instead
of a loop.
2020-06-15 13:55:22 -04:00
28587fb622
CSceneNode: std::move string in SetName()
...
Allows for calling code to completely avoid copies being made.
2020-06-15 13:48:57 -04:00
e962d9ba96
CLight: Correct lack of assignment in SetSpotCutoff()
...
Brought this up with Antidote and was told that this is likely what was
intended to be done.
2020-06-14 20:16:54 -04:00
9e3018809f
CWorld: Eliminate sign conversion warnings
2020-06-14 19:48:23 -04:00
35ea47e473
CWorld: Make use of in-class initializers
...
Same behavior, less code.
2020-06-14 19:47:05 -04:00
128ee0d01c
CMaterialLoader: Make use of static
...
This function doesn't touch instance state at all
2020-06-14 19:43:43 -04:00
cc376d3e21
CMaterialLoader: Make use of std::array
2020-06-14 19:41:42 -04:00
903f6dfe7e
CGameArea: Make use of in-class initializers where applicable
...
Same behavior, less code.
2020-06-14 19:27:54 -04:00
2c274897c9
CLightParameters: Make EWorldLightingOptions an enum class
...
Avoids polluting the global namespace.
2020-06-14 19:21:30 -04:00
cec88d182b
CLightNode: Mark member functions as const where applicable
...
Several functions don't modify internal member state.
2020-06-14 19:13:35 -04:00
f2201ca03c
CLight: Make CalculateSpotAngleAtten() const
...
This member function doesn't modify internal member state.
2020-06-14 19:05:29 -04:00
b439e4bba1
CLight: Make use of in-class initializers where applicable
...
Same behavior, less code.
2020-06-14 19:03:32 -04:00
f942ad6551
CGameTemplate: Mark getter functions as const
...
These don't modify internal class state, so we can mark them as const.
2020-06-14 18:58:05 -04:00
15708b8624
CGameTemplate: Collapse loops into ranged for where applicable
2020-06-14 18:49:37 -04:00
d9bb255518
CGameTemplate: Use in-class initializers where applicable
...
Same behavior, less code.
2020-06-14 18:35:10 -04:00
332be356de
CIndexBuffer: Make use of size_t where applicable
...
Provides a nicer interface for operating with standard types, etc.
2020-06-14 18:29:39 -04:00
d4564434c3
FShowFlags: Remove use of cpp file
...
Now that these constructs are constexpr capable, we can make use of
constexpr here to contain it fully within the header.
2020-06-14 17:12:37 -04:00
b2db6a21fa
CFlagsProperty: Mark HasValidValue() as const
...
This doesn't modify internal state.
2020-06-14 17:07:47 -04:00
d5a33b631a
CFlagsProperty: Make use of a ranged for loop
2020-06-14 17:06:46 -04:00
84184da66d
CFont: Prevent Wmaybe-uninitialized warning
2020-06-14 17:04:35 -04:00
Lioncash