Lioncash
5a5c6f76a4
CStateManager: Make bracing explicit
...
Makes one of the most heavily read parts of the codebase fully
consistent across the board.
While we're at it, we can mark variables const where applicable to make
mutability explicit.
2020-05-09 19:34:17 -04:00
Lioncash
439a55ed98
CStateManager: Silence sign conversion and truncation warnings in LoadScriptObjects()
2020-05-09 19:33:33 -04:00
Luke Street
f8670a2bdb
Shaders: Fix CFluidPlaneShaderMetal
2020-05-09 19:15:31 -04:00
Luke Street
9608efc222
CMetroid: Implement KnockBack, TelegraphAttack & more
2020-05-09 18:39:11 -04:00
Luke Street
7759b3f0dc
CBodyStateCmdMgr: constexpr CBodyStateCmds
2020-05-09 18:37:34 -04:00
Luke Street
977912a1be
rstl::reserved_vector: constexpr constructors
2020-05-09 18:36:57 -04:00
Luke Street
e8ce4c2e27
CMetroid: More function implementations
2020-05-09 02:51:02 -04:00
Lioncash
ef15fd5b18
RetroTypes: Eliminate casts where applicable
...
Same behavior, minus any type casting.
2020-05-08 19:39:23 -04:00
Lioncash
fba8849ed3
rstl: Remove need for manual reverse iterators
...
We can make use of std::make_reverse_iterator to automatically create
the reverse iterators. This allows eliminating some code specifically
for handling the reverse iterators.
2020-05-08 19:31:15 -04:00
Lioncash
5d209c8dc8
General: Mark a handful of deduced const variables as const explicitly
...
Same behavior, but makes it explicit to the reader that these are const.
Prevents cases where the reader might assume that just because the
variable isn't const qualified that it must be mutable, when it actually
isn't.
2020-05-08 18:41:29 -04:00
Lioncash
6658be66c2
CTextParser: Mark parameter to u16stof as const
...
The data being pointed to isn't modified.
2020-05-08 18:34:51 -04:00
Lioncash
73bb7c71b4
CGameArea: Make use of [[maybe_unused]] in WarmupShaders()
...
Same behavior, but silences compilation warnings about unused locals.
2020-05-08 17:12:58 -04:00
Lioncash
fef9e6ff2d
CAuxWeapon: Make skComboNames contain std::string_view instances
...
Removes unnecessary runtime strlen calls.
2020-05-08 17:01:49 -04:00
Lioncash
a0c4b6b3ec
CAiFuncMap: Store std::string_view instances instead of std::string
...
We only make use of static string entries, so we can make use of
std::string view to elide several memory allocations.
2020-05-08 16:38:19 -04:00
Lioncash
a9be7b45b2
CAiFuncMap: Reserve containers before adding entries
...
Eliminates some reallocation churn.
2020-05-08 16:30:59 -04:00
Lioncash
10c6c6729f
CParticleSwoosh: Make virtual call in constructor explicit
...
virtual functions statically resolve in constructors and destructors.
This makes it obvious that we want the statically resolving behavior to
the reader.
2020-05-08 16:09:57 -04:00
Lioncash
b495472ee7
CPathFindRegion: Brace statements where applicable
...
Makes code fully consistent across the board. While we're at it, we can
make intended constness explicit.
2020-05-08 16:00:29 -04:00
Lioncash
8baab44a5d
CPathFindRegion: Make const variant of Data() return a const qualified member
...
Enforces read-only pointer semantics
2020-05-08 15:52:17 -04:00
Lioncash
ed37919018
CPathFindRegion: Resolve sign conversion warning
...
The only place this is used is in an unsigned context.
2020-05-08 15:49:29 -04:00
Luke Street
78b364a445
CMetroid: Add EGammaType
2020-05-08 05:22:12 -04:00
Luke Street
ac30616efb
CMetroid: Implement GetDamageVulnerability
2020-05-08 05:05:47 -04:00
Luke Street
ca659bdcbc
CMetroid: Add fields & function definitions
2020-05-08 04:19:51 -04:00
Lioncash
dc8a0d0d88
CRelayTracker: Simplify RemoveRelay()
...
We can make this significantly nicer to read by making use of C++20's
consistent container erasure functions.
2020-05-08 01:16:23 -04:00
Lioncash
49836025f7
CObjectList: Simplify cbegin() and cend()
...
We can just use the const variants of begin() and end() now.
2020-05-08 00:25:20 -04:00
Luke Street
34b2383dfd
MP1/CMain: Add missing fields
2020-05-07 23:20:23 -04:00
Luke Street
1c775a7ea7
CElitePirate/COmegaPirate: Cleanup & renaming
2020-05-07 19:13:43 -04:00
Luke Street
8aef93473e
Merge pull request #319 from lioncash/object
...
CObjectList: Minor interface modifications
2020-05-07 17:38:32 -04:00
Lioncash
579ae79291
General: Mark CMaterialFilter instances constexpr where applicable
...
Allows omission of runtime overhead.
2020-05-07 14:14:18 -04:00
Lioncash
33411ceeca
CScriptDistanceFog: Brace conditionals where applicable
2020-05-07 13:44:13 -04:00
Lioncash
470d649604
CScriptDock: Brace conditionals where applicable
2020-05-07 13:43:08 -04:00
Lioncash
49dd7a874b
CScriptDockAreaChange: Brace conditionals where applicable
2020-05-07 13:38:59 -04:00
Lioncash
269b28f391
CScriptDoor: Brace conditionals where applicable
2020-05-07 13:38:20 -04:00
Lioncash
631c449453
CScriptEffect: Brace conditionals where applicable
2020-05-07 13:33:17 -04:00
Lioncash
e4abedf16f
CScriptEMPulse: Brace conditionals where applicable
2020-05-07 13:29:46 -04:00
Lioncash
51ffc0ef26
CScriptGenerator: Brace conditionals where applicable
2020-05-07 13:28:30 -04:00
Lioncash
bea6709cc4
CScriptGunTurret: Brace conditionals where applicable
2020-05-07 13:25:29 -04:00
Lioncash
34d989c443
CScriptHUDMemo: Brace conditionals where applicable
2020-05-07 13:06:47 -04:00
Lioncash
beb7884b54
CScriptMemoryRelay: Brace conditionals where applicable
2020-05-07 13:05:21 -04:00
Lioncash
c3d6324ea1
CScriptMidi: Brace conditionals where applicable
2020-05-07 13:04:19 -04:00
Lioncash
510778b7cd
CScriptPickup: Brace conditionals where applicable
2020-05-07 13:02:52 -04:00
Lioncash
c3f723007e
CScriptPickupGenerator: Brace conditionals where applicable
2020-05-07 13:00:45 -04:00
Lioncash
8698cc3cd5
CScriptPlayerActor: Brace conditionals where applicable
2020-05-07 12:41:00 -04:00
Lioncash
c308b2e3c5
CScriptPlayerHint: Brace conditionals where applicable
2020-05-07 12:36:06 -04:00
Lioncash
e47d0446b1
CScriptPointOfInterest: Brace conditionals where applicable
2020-05-07 12:35:31 -04:00
Lioncash
192cbd5e14
CScriptRandomRelay: Brace conditionals where applicable
2020-05-07 12:34:57 -04:00
Lioncash
7145917e30
CScriptRelay: Brace conditionals where applicable
2020-05-07 12:33:25 -04:00
Lioncash
1315189990
CScriptRipple: Brace conditionals where applicable
2020-05-07 12:29:43 -04:00
Lioncash
2bf190048d
CScriptRoomAcoustics: Brace conditionals where applicable
2020-05-07 12:28:45 -04:00
Lioncash
e691628289
CScriptShadowProjector: Brace conditionals where applicable
2020-05-07 12:27:49 -04:00
Lioncash
7186e57a9d
CScriptSound: Brace conditionals where applicable
2020-05-07 12:26:05 -04:00