4e718a805f
CFluidPlaneShader: Replace explicit operator bool calls with the analogous named function
...
Same behavior, more informative to the reader about what is being
checked for.
2020-05-12 20:45:32 -04:00
942b972398
CTweaks: Collapse namespace specifiers into nested namespaces
...
Same behavior, less code.
2020-05-12 20:39:18 -04:00
a17ff08662
CPhazonHealingNodule: It helps to commit your editor changes before pushing
...
Intended to be part of 4b5074b298
2020-05-12 20:33:59 -04:00
4b5074b298
RuntimeCommon: Const qualify auto references where source is const
...
Marks references that would be deduced as const automatically with const
to be explicit to the reader.
2020-05-12 20:32:51 -04:00
8e77d6175c
CTextureBoo: Make use of std::array where applicable
...
Allows dehardcoding some array sizes.
2020-05-12 20:23:27 -04:00
e0a44bdf45
CTextureBoo: Prevent signed conversion warnings from occurring in Convert* helper functions
2020-05-12 20:03:58 -04:00
fee8d91dca
CTextureBoo: Make use of anonymous namespace
...
Makes some helper functions have internal linkage, silencing some
-Wmissing-declarations warnings, and also allows preventing ODR
violations from ever occurring with the RGBA8 and DXT1Block structs.
2020-05-12 20:01:58 -04:00
bfbb027117
CSlideShow: Collapse loop into std::all_of
...
Same behavior, less code. We can also make this function fully
internally linked, given it doesn't depend on instance state.
2020-05-12 19:53:19 -04:00
fd2f2e146c
CFluidPlaneCPU: Convert define into a typed constant
...
Same behavior, less preprocessor.
2020-05-12 17:00:00 -04:00
75494a501a
CFluidPlaneCPU: Early exit in CTurbulence constructor
...
Allows unindenting code.
2020-05-12 16:58:30 -04:00
dc32bee499
CFluidPlaneCPU: Eliminate sign conversions in CTurbulence constructor
2020-05-12 16:57:42 -04:00
c60290819e
CMorphBall: Collapse common code within ApplyGravity()
...
All that differs between the conditionals is the gravity value used, so
we can collapse all of this down to simply conditionally retrieve that.
2020-05-11 18:42:39 -04:00
0af9b16b92
CMorphBall: Take torque by const reference in SpinToSpeed()
...
Same behavior, minus unnecessary copies and consistency with the rest of
the API.
2020-05-11 18:23:54 -04:00
37138fb584
CMorphBall: Convert TCastToPtr to TCastToConstPtr
...
Same behavior, but makes the read-only intent explicit.
2020-05-11 14:23:15 -04:00
a73a7b22e7
CMorphBall: Brace statements where applicable
...
Makes the code consistent and also makes mutability explicit in large
calculations.
2020-05-10 22:18:33 -04:00
e9ea73ec98
CRidley: Amend formatting of skFloats
...
Makes the formatting less wonky.
2020-05-10 19:47:28 -04:00
c0a0a35f01
CRidley: Collapse for loop into ranged for loop
...
Same behavior, no unnecessary induction variable.
2020-05-10 19:41:13 -04:00
98ce18385a
CRidley: Fix missing comma in skWingEffects
...
Previously all the elements past WingSmokeSmall8 would be off by one.
This corrects that.
2020-05-10 19:32:11 -04:00
8508524479
CRidley: Amend formatting of skSomeStruct
...
Makes it consistent with the other arrays.
2020-05-10 19:30:59 -04:00
a79c42862c
CRidley: Join namespace into nested namespace specifiers
...
Same behavior, less noise.
2020-05-10 19:30:19 -04:00
9929c9ab02
CRidley: Correct breastPlate_LCTR sphere joint radius
...
GM8Ev0 sets this as 0.3.
2020-05-09 23:39:12 -04:00
306b8ad289
CRidley: Mark skDirectNormal and skIceWeakness as constexpr
...
Allows elimination of runtime initializers.
2020-05-09 22:41:32 -04:00
ec79a9de89
CPlayer: Resolve unused variable warnings
2020-05-09 22:35:56 -04:00
f7ce3f2133
CEnvFxManager: Silence unused variable warnings
2020-05-09 22:30:10 -04:00
25ea6d98bc
CFlameThrower: Silence unused variable warning
2020-05-09 22:28:56 -04:00
0f11a00cc0
CBeamProjectile: Silence unused variable warning
2020-05-09 22:27:54 -04:00
5f80504e6e
CCompoundTargetReticle: Silence unused variable warning
2020-05-09 22:26:46 -04:00
b3d6901f56
CGuiPane: Make static resolving of virtual function in ctor explicit
...
virtual functions statically resolve in the constructor and destructor.
This makes it explicit to the user that this static resolving behavior
is indeed what is intended
2020-05-09 22:23:44 -04:00
665b4f496d
CFlameThrower: Assign thermal hot to xe6_27_thermalVisorFlags instead of ORing
...
Previously the code was neglecting to clear the flags entirely before
assigning the new value to it.
2020-05-09 22:05:55 -04:00
77861a9b9f
CWaveBuster: Add AcceptScriptMsg implementation
2020-05-09 21:55:19 -04:00
cd13a49649
CWaveBuster: Add Accept implementation
...
More low hanging fruit that can be resolved.
2020-05-09 21:17:22 -04:00
3dddfa63cf
CWaveBuster: Add AddToRenderer implementation
...
Low hanging fruit and fairly trivial to implement.
2020-05-09 21:12:12 -04:00
5a5c6f76a4
CStateManager: Make bracing explicit
...
Makes one of the most heavily read parts of the codebase fully
consistent across the board.
While we're at it, we can mark variables const where applicable to make
mutability explicit.
2020-05-09 19:34:17 -04:00
439a55ed98
CStateManager: Silence sign conversion and truncation warnings in LoadScriptObjects()
2020-05-09 19:33:33 -04:00
Luke Street
f8670a2bdb
Shaders: Fix CFluidPlaneShaderMetal
2020-05-09 19:15:31 -04:00
ef15fd5b18
RetroTypes: Eliminate casts where applicable
...
Same behavior, minus any type casting.
2020-05-08 19:39:23 -04:00
5d209c8dc8
General: Mark a handful of deduced const variables as const explicitly
...
Same behavior, but makes it explicit to the reader that these are const.
Prevents cases where the reader might assume that just because the
variable isn't const qualified that it must be mutable, when it actually
isn't.
2020-05-08 18:41:29 -04:00
6658be66c2
CTextParser: Mark parameter to u16stof as const
...
The data being pointed to isn't modified.
2020-05-08 18:34:51 -04:00
73bb7c71b4
CGameArea: Make use of [[maybe_unused]] in WarmupShaders()
...
Same behavior, but silences compilation warnings about unused locals.
2020-05-08 17:12:58 -04:00
fef9e6ff2d
CAuxWeapon: Make skComboNames contain std::string_view instances
...
Removes unnecessary runtime strlen calls.
2020-05-08 17:01:49 -04:00
a0c4b6b3ec
CAiFuncMap: Store std::string_view instances instead of std::string
...
We only make use of static string entries, so we can make use of
std::string view to elide several memory allocations.
2020-05-08 16:38:19 -04:00
a9be7b45b2
CAiFuncMap: Reserve containers before adding entries
...
Eliminates some reallocation churn.
2020-05-08 16:30:59 -04:00
10c6c6729f
CParticleSwoosh: Make virtual call in constructor explicit
...
virtual functions statically resolve in constructors and destructors.
This makes it obvious that we want the statically resolving behavior to
the reader.
2020-05-08 16:09:57 -04:00
b495472ee7
CPathFindRegion: Brace statements where applicable
...
Makes code fully consistent across the board. While we're at it, we can
make intended constness explicit.
2020-05-08 16:00:29 -04:00
8baab44a5d
CPathFindRegion: Make const variant of Data() return a const qualified member
...
Enforces read-only pointer semantics
2020-05-08 15:52:17 -04:00
ed37919018
CPathFindRegion: Resolve sign conversion warning
...
The only place this is used is in an unsigned context.
2020-05-08 15:49:29 -04:00
dc8a0d0d88
CRelayTracker: Simplify RemoveRelay()
...
We can make this significantly nicer to read by making use of C++20's
consistent container erasure functions.
2020-05-08 01:16:23 -04:00
49836025f7
CObjectList: Simplify cbegin() and cend()
...
We can just use the const variants of begin() and end() now.
2020-05-08 00:25:20 -04:00
Luke Street
34b2383dfd
MP1/CMain: Add missing fields
2020-05-07 23:20:23 -04:00
Luke Street
1c775a7ea7
CElitePirate/COmegaPirate: Cleanup & renaming
2020-05-07 19:13:43 -04:00
Lioncash
Luke Street