3c8ce3dc99
CGuiTextSupport: Amend typo in debug group label
...
This is within the Render() function, so we can rename the group name.
2020-04-14 13:34:50 -04:00
Luke Street
112322be5a
Merge pull request #311 from lioncash/sign
...
CScanDisplay: Eliminate implicit sign conversions
2020-04-14 02:10:13 -04:00
2c7d10c4b4
CCompoundTargetReticle: Brace statements where applicable
2020-04-13 17:16:23 -04:00
85f930ef2e
CCompoundTargetReticle: Convert unnecessary floats into bools
...
Using floats here is extremely suspect and almost certainly
unintentional.
2020-04-13 16:54:45 -04:00
1767338aba
CCompoundTargetReticle: Make eliminate hardcoded size
...
We can just query the capacity to dehardcode it.
2020-04-13 16:52:01 -04:00
e26afe887f
CCompoundTargetReticle: Make use of std::array where applicable
...
Same behavior, stronger typing.
While we're at it, we can eliminate a case of variable shadowing.
2020-04-13 16:50:37 -04:00
c6278c0e9f
CCompoundTargetReticle: Initialize all data members
...
Provides deterministic initial state.
2020-04-13 16:41:28 -04:00
786675f307
CTextExecuteBuffer: Move initialization of xa8_curWordIt into initializer list
2020-04-13 16:18:38 -04:00
50ba80247b
CTextExecuteBuffer: Initialize xac_curY and xb0_curX in the constructor
...
Provides a deterministic initial state upon construction for easier
debugging.
2020-04-13 16:18:02 -04:00
6806d4914c
CHudBossEnergyInterface: Initialize x0_alpha on construction
...
Provides a deterministic initial state which is helpful for debugging.
2020-04-13 15:00:44 -04:00
67786721ff
CHudBossEnergyInterface: Make use of structured bindings in constructor
...
Same behavior, minus a verbose type name.
2020-04-13 14:59:47 -04:00
4e6150acc4
CHudDecoInterface: Make missed virtual call in constructor explicit
...
Missed this one in the previous commit.
2020-04-13 14:54:15 -04:00
c8be142846
CHudDecoInterface: Make virtual calls in constructor explicitly qualified
...
Virtual functions called in a constructor or destructor are statically
resolved. Given this is a potential source of bugs, we qualify these
functions to make it explicit that this is indeed the kind of behavior
desired.
2020-04-13 14:52:34 -04:00
3a5a3e2011
CHudRadarInterface: Make use of const where applicable
...
Same behavior, but makes it obvious some references are only used in a
read-only manner.
2020-04-13 14:25:59 -04:00
0a01a30bf5
CScanDisplay: Eliminate implicit sign conversions
...
Removes implicit sign conversions and also dehardcodes quite a bit of
sizes.
2020-04-12 22:05:52 -04:00
96e3eaf726
CSplashScreen: Make use of std::array where applicable
...
Same behavior, stronger typing.
2020-04-12 11:30:09 -04:00
d5e57b5348
CCompoundTargetReticle: Make skZeroRenderState constexpr
...
Allows eliding runtime initializers where applicable. Particularly for
the static data.
2020-04-12 04:19:53 -04:00
5b4441ac36
Update fmtlib
2020-04-11 12:51:39 -10:00
Luke Street
e38a7f97bd
Runtime/GuiSys: Replace bitfield unions with constructor initializers
2020-04-10 15:11:10 -04:00
1e6b6622fe
CGuiFrame: Remove unnecessary mutable specifiers
...
We can just drop the const qualifier on ProcessMouseInput() to make the
mutable specifier unnecessary.
2020-04-10 02:17:50 -04:00
2fadaf544d
CCompoundTargetReticle: Remove mutable specifier on x28_noDrawTicks
...
This is no longer needed at all.
2020-04-09 21:35:16 -04:00
b72d217a68
CCompoundTargetingReticle: Remove mutable specifier on m_scanRetRenderer
...
This can be trivially resolved by dropping const qualifiers on the
necessary member functions.
2020-04-09 21:31:22 -04:00
35ca901784
CHudRadarInterface: Remove mutable specifiers from class members
...
We can just drop the const qualifiers on the relevant member functions
to make these unnecessary.
2020-04-09 21:23:50 -04:00
db0091e9cd
CWordBreakTables: Make use of std::array where applicable
...
Same behavior, but allows directly querying iterators. We can also make
these arrays constexpr.
2020-04-07 13:24:23 -04:00
f7962cb3f7
CRasterFont: Extend CFontInfo buffer to 64 characters
...
GM8E v0 seems to be using at least a buffer 64 characters in size, not
40.
2020-04-06 06:59:22 -04:00
94264f6fe6
CRasterFont: Collapse loop into a std::find_if in InternalGetGlyph()
...
Same behavior, less code.
2020-04-05 06:01:29 -04:00
67f6666ea1
Runtime: Add more usages of explicit
...
Prevents error-prone implicit conversions where applicable.
This targets the regular RuntimeCommon target this time around.
2020-03-31 03:53:49 -04:00
6dce70895c
CIOWin: Make Draw() non-const
...
Allows removing several const_cast usages within the codebase.
2020-03-29 21:56:49 -04:00
0d3bab4c14
CScanDisplay: Remove use of const_cast
...
The draw function is essentially not fully const in behavior, so we can
remove the const qualifiers where necessary.
2020-03-29 21:44:10 -04:00
2d8e94911a
CGuiTextSupport: Eliminate the use of const_cast
...
We can supply a const and non-const variant to eliminate the need to
const_cast here.
2020-03-29 21:37:11 -04:00
f3afcf7299
CGuiTextPane: Remove stray unnecessary const_cast in Draw()
...
Draw() isn't const qualified, so there's no need to cast away const
here.
2020-03-29 21:25:47 -04:00
603942daaf
CTextRenderBuffer: Remove use of const_cast in Render()
...
Makes for much less casting.
2020-03-29 20:27:04 -04:00
04a42980ab
Revert "Revert "CTextRenderBuffer: Forward declare structs where applicable""
...
This reverts commit 16745f3a7b
2020-03-29 20:09:16 -04:00
Phillip Stephens
16745f3a7b
Revert "CTextRenderBuffer: Forward declare structs where applicable"
2020-03-29 16:35:02 -07:00
Phillip Stephens
f3721844b9
Merge pull request #282 from lioncash/struct
...
CTextRenderBuffer: Forward declare structs where applicable
2020-03-29 16:04:32 -07:00
232ae12802
CGuiTextPane: Make use of std::array where applicable
...
Same behavior, but with stronger typing and allows removing of a
hardcoded array size.
2020-03-29 08:00:40 -04:00
0aff4dc21e
CTextRenderBuffer: Remove use of const_cast within Render()
...
Same behavior but way less casting.
2020-03-29 04:42:58 -04:00
20b74c4818
CTextRenderBuffer: Forward declare structs where applicable
...
These are only used internally, so we can completely hide these structs
from external view.
This allows their implementation to be changed without needing to
recompile all the headers that include it.
2020-03-29 03:54:29 -04:00
fda08db9b1
CHudVisorBeamMenu: Dehardcode array sizes
...
Same behavior, but queries the container for the size rather than
hardcoding it in loop bounds.
2020-03-29 03:08:41 -04:00
413483a996
CHudFreeLookInterfaceXRay: Assign free look and control held flags in SetFreeLookState()
...
GM8Ev0 does this.
2020-03-29 02:08:51 -04:00
ad07b993c8
CHudFreeLookInterface: Collapse conditional within SetFreeLookState()
...
Same behavior, less code.
2020-03-29 02:03:20 -04:00
59fbefbd58
CGuiWidget: Provide names for all function prototypes
...
Makes parameter introspection nicer with IDEs and also renames ambiguous
"v" names to something more self-descriptive.
2020-03-29 01:52:23 -04:00
194cdf145f
Runtime: Use nullptr where applicable
...
Same behavior, but no magic 0 value.
While we're in the same area, we can do minor cosmetic changes.
2020-03-27 20:18:54 -04:00
Phillip Stephens
e0fe365dfd
Merge pull request #278 from lioncash/explicit
...
General: Make use of explicit constructors where applicable
2020-03-27 14:10:19 -07:00
241a66dc0a
General: Make use of explicit constructors where applicable
...
Gets rid of potential error prone implicitly constructing constructors.
2020-03-27 06:00:17 -04:00
fcf70aeb2a
CGuiWidgetIdDB: Remove redundant std::make_pair funcs
...
Same behavior, less code.
2020-03-26 03:55:28 -04:00
f4b3fb947e
CScanDisplay: Make constructor explicit
...
Prevents error-prone implicit construction from occurring.
2020-03-25 20:46:08 -04:00
Luke Street
8314d5b6ef
Merge branch 'pr-255'
2020-03-25 02:09:02 -04:00
Luke Street
3734a09ed3
CGuiWidget: Make GetIsFinishedLoading non-const
2020-03-25 02:01:47 -04:00
40fc3f9dd8
CModelBoo: Remove usages of const_cast
...
Many functions are modifying internals of CBooModel and const-casting
is performed in order to work around functions being const when they
really shouldn't be.
This amends the function signatures in order to allow these functions to
exist without const_cast, making code much nicer to read.
2020-03-25 02:01:46 -04:00
Lioncash
Luke Street
Jack Andersen
Phillip Stephens