encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/src/tests/BUILD.gn

518 lines
16 KiB
Plaintext
Raw Normal View History

Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
# Copyright 2012 The Dawn Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import("../../scripts/dawn_overrides_with_defaults.gni")
import("//testing/test.gni")
import("${dawn_root}/generator/dawn_generator.gni")
import("${dawn_root}/scripts/dawn_features.gni")
group("dawn_tests") {
testonly = true
deps = [
BUILD.gn: Remove leftover temporary test target. This target was forgotten in the previous cleanup. Bug: chromium:1064305 Change-Id: Ibf35df4393927ac8cc08d4965b8b8098c36e4bd3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19860 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-17 16:05:09 +00:00
":dawn_end2end_tests",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
":dawn_perf_tests",
":dawn_unittests",
]
}
###############################################################################
# Gtest Gmock - Handle building inside and outside of Chromium.
###############################################################################
# When building outside of Chromium we need to define our own targets for GTest
# and GMock. However when compiling inside of Chromium we need to reuse the
# existing targets, both because Chromium has a special harness for swarming
# and because otherwise the "gn check" fails.
if (!build_with_chromium) {
# When we aren't in Chromium we define out own targets based on the location
# of the googletest repo.
googletest_dir = dawn_googletest_dir
config("gtest_config") {
include_dirs = [
"${googletest_dir}/googletest",
"${googletest_dir}/googletest/include",
]
}
static_library("gtest") {
testonly = true
Introduce Device::GetDefaultQueue and deprecate CreateQueue This makes all backends register the default queue at device initialization time, so that the same queue is returned by each call to GetDefaultQueue. All usages of CreateQueue are replaced by GetDefaultQueue except a couple ones that could use the queue initialized by DawnTest::SetUp. A deprecation warning mechanism is added so that users of Dawn can now that they should upgrade their usage of the API. It also comes with a backdoor so we can test that they are emitted. New DeprecatedAPITests are added that will contain tests for deprecated APIs, and will also check that deprecation warnings are produced. The special casing of GetDefaultQueue in the wire will be done in a follow-up CL to ease the review. It happens to work through the regular wire mechanisms at the moment but returns a different object on each GetDefaultQueue call. Bug: dawn:22 Change-Id: I78dc1fa474769674278d30040e8d05c658b88360 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19724 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-17 16:45:17 +00:00
sources = [ "${googletest_dir}/googletest/src/gtest-all.cc" ]
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
public_configs = [ ":gtest_config" ]
}
config("gmock_config") {
include_dirs = [
"${googletest_dir}/googlemock",
"${googletest_dir}/googlemock/include",
"${googletest_dir}/googletest/include",
]
}
static_library("gmock") {
testonly = true
Introduce Device::GetDefaultQueue and deprecate CreateQueue This makes all backends register the default queue at device initialization time, so that the same queue is returned by each call to GetDefaultQueue. All usages of CreateQueue are replaced by GetDefaultQueue except a couple ones that could use the queue initialized by DawnTest::SetUp. A deprecation warning mechanism is added so that users of Dawn can now that they should upgrade their usage of the API. It also comes with a backdoor so we can test that they are emitted. New DeprecatedAPITests are added that will contain tests for deprecated APIs, and will also check that deprecation warnings are produced. The special casing of GetDefaultQueue in the wire will be done in a follow-up CL to ease the review. It happens to work through the regular wire mechanisms at the moment but returns a different object on each GetDefaultQueue call. Bug: dawn:22 Change-Id: I78dc1fa474769674278d30040e8d05c658b88360 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19724 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-17 16:45:17 +00:00
sources = [ "${googletest_dir}/googlemock/src/gmock-all.cc" ]
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
public_configs = [ ":gmock_config" ]
}
group("gmock_and_gtest") {
testonly = true
public_deps = [
":gmock",
":gtest",
]
}
} else {
# When we are in Chromium we reuse its targets, and also add some deps that
# are needed to launch the test in swarming mode.
group("gmock_and_gtest") {
testonly = true
public_deps = [
"//base",
"//base/test:test_support",
"//testing/gmock",
"//testing/gtest",
]
}
}
Do not use Dawn's warnings for compiling Chromium's gtest main. When building in Chromium, Dawn's gtest targets use sources files in Chromium so it can use Chromium's GTest harness. These source files were compiled with the "dawn_internal" config included. This made them include Dawn-specific warnings that trigger on parts of Chromium's //base. Instead compile these "main" files as separate source_sets without dawn_internal and link them in the dawn test executables. Bug: chromium:1075817 Change-Id: I573390ca3e6a7dfd1e8a949dc10ed268f0d0f63e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/20520 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-28 17:12:05 +00:00
###############################################################################
# Wrapping of Chromium targets
###############################################################################
# These targets are separated because they are Chromium sources files that
# can't use the dawn_internal config, otherwise Dawn's warning flags get
# applied while compiling a bunch of Chromium's //base (via header inclusion)
if (build_with_chromium) {
source_set("dawn_unittests_main") {
testonly = true
deps = [ ":gmock_and_gtest" ]
sources = [ "//gpu/dawn_unittests_main.cc" ]
}
source_set("dawn_end2end_tests_main") {
testonly = true
deps = [ ":gmock_and_gtest" ]
sources = [ "//gpu/dawn_end2end_tests_main.cc" ]
}
source_set("dawn_perf_tests_main") {
testonly = true
deps = [ ":gmock_and_gtest" ]
sources = [ "//gpu/dawn_perf_tests_main.cc" ]
}
}
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
###############################################################################
# Dawn unittests
###############################################################################
dawn_json_generator("mock_webgpu_gen") {
target = "mock_webgpu"
outputs = [
"src/dawn/mock_webgpu.h",
"src/dawn/mock_webgpu.cpp",
]
}
test("dawn_unittests") {
configs += [ "${dawn_root}/src/common:dawn_internal" ]
deps = [
":gmock_and_gtest",
":mock_webgpu_gen",
"${dawn_root}/src/common",
Remove temporary GN proxy groups. It also changes remaining deps for internal targets from libdawn_proc to dawn_proc. Bug: chromium:1064305 Change-Id: I36df2b5d7793be9d6c878b6a1f2ec238603a8205 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19289 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-14 17:36:44 +00:00
"${dawn_root}/src/dawn:dawn_proc",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"${dawn_root}/src/dawn:dawncpp",
"${dawn_root}/src/dawn_native",
"${dawn_root}/src/dawn_native:dawn_native_sources",
"${dawn_root}/src/dawn_wire",
"${dawn_root}/src/utils:dawn_utils",
]
# Add internal dawn_native config for internal unittests.
configs += [ "${dawn_root}/src/dawn_native:dawn_native_internal" ]
sources = get_target_outputs(":mock_webgpu_gen")
sources += [
"${dawn_root}/src/dawn_wire/client/ClientMemoryTransferService_mock.cpp",
"${dawn_root}/src/dawn_wire/client/ClientMemoryTransferService_mock.h",
"${dawn_root}/src/dawn_wire/server/ServerMemoryTransferService_mock.cpp",
"${dawn_root}/src/dawn_wire/server/ServerMemoryTransferService_mock.h",
Add WireClient::Disconnect to stop serializing commands This prevents the client from continuing to send commands when the wire connection has dropped. In Chromium this may be because the connection to the GPU process is lost and the transfer buffer may be destroyed. This CL also adds a new helper to make testing callbacks with mocks easier. Bug: chromium:1070392 Change-Id: I6a69c32cc506069554ead18ee83a156ca70e2ce2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19160 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2020-04-15 02:00:14 +00:00
"MockCallback.h",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/BitSetIteratorTests.cpp",
"unittests/BuddyAllocatorTests.cpp",
"unittests/BuddyMemoryAllocatorTests.cpp",
"unittests/CommandAllocatorTests.cpp",
"unittests/EnumClassBitmasksTests.cpp",
Rephrase Format::aspect enum as an enum class mask Format::aspect should be a mask so that it is easier to iterate over and test if an aspect is present. This CL also re-exports wgpu's EnumClassBitMask helpers in dawn_native. It also adds an EnumMaskIterator which wraps BitSetIterator to allow iterating over the enums in an enum mask. Bug: dawn:439 Change-Id: I08180a45b27c6031e2f80b0fa1801716677fd813 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24682 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> Commit-Queue: Austin Eng <enga@chromium.org>
2020-07-30 15:25:37 +00:00
"unittests/EnumMaskIteratorTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/ErrorTests.cpp",
"unittests/ExtensionTests.cpp",
"unittests/GetProcAddressTests.cpp",
Add TypedInteger This CL adds a TypedInteger helper which provides additional type safety in Dawn. It is a compile-time restriction that prevents integers of different types from being used interchangably in Debug builds. It also adds ityp::{array,bitset,span} as helper classes to wrap std:: versions (not span). These accept a template paramter as the Index type so that typed integers, or enum classes, may be used as a type-safe index. For now, bind group layout binding indices use TypedInteger. Future CLs will convert other indices to be type-safe as well. Bug: dawn:442 Change-Id: I5b63b1e4f6154322db0227a7788a4e9b8303410e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19902 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2020-06-17 22:35:19 +00:00
"unittests/ITypArrayTests.cpp",
"unittests/ITypBitsetTests.cpp",
"unittests/ITypSpanTests.cpp",
Add ityp::vector class and unittests In order to remove the kMaxBindingsPerGroup limit in Dawn, some static ityp::arrays need to be made dynamically sized. This CL adds ityp::vector wrapping std::vector. This CL also fixes the assumption that ityp::stack_vec iterators are pointers Bug: dawn:442, dawn:443 Change-Id: I8698cbba3ea80ac063ab918a77f223c527720d08 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24480 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org>
2020-07-14 01:32:43 +00:00
"unittests/ITypVectorTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/LinkedListTests.cpp",
"unittests/MathTests.cpp",
"unittests/ObjectBaseTests.cpp",
"unittests/PerStageTests.cpp",
Reland "Add a per-thread proc table using thread local storage" This is a reland of b04a92f01be0e7dc2faf91e0f6f974f990e8b2f2 with the deletion of a duplicate exported function in dawn_wire that was causing a compilation failure on Windows. Original change's description: > Add a per-thread proc table using thread local storage > > In situations where both dawn_wire and dawn_native are used on separate > threads (Chrome with --single-process or --in-process-gpu), it's > desirable to have a per-thread proc table so that the WebGPU C++ API can > still be used. This eliminates classes of bugs with manual > reference/release errors. > > This also changes many of the GetProcs functions to return const > references to the static proc tables known at compile time, instead of a > copy. > > Bug: none > Change-Id: I8775bb715b312dd9476a1903fbd797d4b1302614 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/29240 > Reviewed-by: Stephen White <senorblanco@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> Bug: none Change-Id: Id90e5372132cd93a2f8631c8185d0e71b01bc1af Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/29443 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org>
2020-10-06 16:13:42 +00:00
"unittests/PerThreadProcTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/PlacementAllocatedTests.cpp",
"unittests/RefCountedTests.cpp",
"unittests/ResultTests.cpp",
"unittests/RingBufferAllocatorTests.cpp",
"unittests/SerialMapTests.cpp",
"unittests/SerialQueueTests.cpp",
"unittests/SlabAllocatorTests.cpp",
Add Chromium's StackVector base class and ityp::stack_vec In order to lift Dawn's restriction on the number of bindings per bind group, static sized arays need to be converted to dynamically sized vectors. This CL adds Chromium's StackVector class which behaves like std::vector but provides a stack allocator to allocate small vectors on the stack. Dawn can use this to avoid making separate heap allocations for a smaller, realistic binding counts. The CL also adds an ityp::stack_vec class to support using a StackVector with TypedInteger indices. Bug: dawn:442, dawn:443 Change-Id: I7604c02b3ea52cd63990a2e8b45ed238a5d52232 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/23681 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2020-07-08 20:27:30 +00:00
"unittests/StackContainerTests.cpp",
Introduce SubresourceStorage (1/N) This CL adds the start of the implementation of a SubresourceStorage<T> container class that stores per-subresource state in a compressed fashion. Only the getter methods and Update() modifying methods are added because they are the first step necessary to test the behavior of SubresourceStorage. Subsequent CLs will: - add the Merge() operation - move the per-aspect storage to be inlined and avoid allocation of mData and mLayerCompressed if possible - use the container where applicable in dawn_native - (maybe) move clear-state tracking in the backends as part of barrier tracking Bug: dawn:441 Change-Id: Ic93e5af16dd705b260424f05e4dc3e0c9f6fbd0a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/34464 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com>
2020-12-09 15:38:27 +00:00
"unittests/SubresourceStorageTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/SystemUtilsTests.cpp",
"unittests/ToBackendTests.cpp",
Add TypedInteger This CL adds a TypedInteger helper which provides additional type safety in Dawn. It is a compile-time restriction that prevents integers of different types from being used interchangably in Debug builds. It also adds ityp::{array,bitset,span} as helper classes to wrap std:: versions (not span). These accept a template paramter as the Index type so that typed integers, or enum classes, may be used as a type-safe index. For now, bind group layout binding indices use TypedInteger. Future CLs will convert other indices to be type-safe as well. Bug: dawn:442 Change-Id: I5b63b1e4f6154322db0227a7788a4e9b8303410e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19902 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2020-06-17 22:35:19 +00:00
"unittests/TypedIntegerTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/validation/BindGroupValidationTests.cpp",
"unittests/validation/BufferValidationTests.cpp",
"unittests/validation/CommandBufferValidationTests.cpp",
"unittests/validation/ComputeIndirectValidationTests.cpp",
"unittests/validation/ComputeValidationTests.cpp",
"unittests/validation/CopyCommandsValidationTests.cpp",
"unittests/validation/DebugMarkerValidationTests.cpp",
"unittests/validation/DrawIndirectValidationTests.cpp",
"unittests/validation/DynamicStateCommandValidationTests.cpp",
"unittests/validation/ErrorScopeValidationTests.cpp",
"unittests/validation/FenceValidationTests.cpp",
"unittests/validation/GetBindGroupLayoutValidationTests.cpp",
Add a size argument to Set[Vertex|Index]Buffer Bug: dawn:22 Change-Id: I06a4fc2b651e5a4692893f710ca11785976c1fa4 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/20200 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2020-04-24 09:42:03 +00:00
"unittests/validation/IndexBufferValidationTests.cpp",
Add minimum buffer size validation Bug: dawn:459 Change-Id: I755cc0ada7be7b1cb71724cb410ab0c3a88cea24 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/22421 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-06-19 21:39:23 +00:00
"unittests/validation/MinimumBufferSizeValidationTests.cpp",
Add maximum limitation for query count in CreateQuerySet - Limit the maximum query count to 8192 to fit Metal restriction. - Add unittest tests of query count and remove the test of buffer size overflow validation on 32-bits. Bug: dawn:434 Change-Id: Ie573b715cc3f67ec158996119a8b4a49e493680a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/36021 Commit-Queue: Hao Li <hao.x.li@intel.com> Reviewed-by: Austin Eng <enga@chromium.org>
2020-12-24 02:57:07 +00:00
"unittests/validation/QueryValidationTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/validation/QueueSubmitValidationTests.cpp",
Adding Queue::WriteTexture Added Queue::WriteTexture with validation but no actual implementation. Tests were mostly taken from validation tests for copying buffer to texture. Validation tests for CopyB2T and WriteTexture do not cover 2d-array textures yet. Bug: dawn:483 Change-Id: I9027eb615c02fe2265cde912f6ba17a235b94728 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24440 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Tomek Ponitka <tommek@google.com>
2020-07-08 18:42:30 +00:00
"unittests/validation/QueueWriteTextureValidationTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/validation/RenderBundleValidationTests.cpp",
"unittests/validation/RenderPassDescriptorValidationTests.cpp",
"unittests/validation/RenderPipelineValidationTests.cpp",
"unittests/validation/ResourceUsageTrackingTests.cpp",
"unittests/validation/SamplerValidationTests.cpp",
"unittests/validation/ShaderModuleValidationTests.cpp",
"unittests/validation/StorageTextureValidationTests.cpp",
Add validation code for texture subresource usage tracking This patch also add validation tests for texture subresource tracking for render pass. Resource usage tracking for compute is per each dispatch() call, I will add it in next patch. BUG=dawn:157 Change-Id: I6c4b932e317d66521fa428311e727876d0adf4ea Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/17661 Commit-Queue: Yunchao He <yunchao.he@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-05-04 17:10:49 +00:00
"unittests/validation/TextureSubresourceTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/validation/TextureValidationTests.cpp",
"unittests/validation/TextureViewValidationTests.cpp",
"unittests/validation/ToggleValidationTests.cpp",
Add the disallow_unsafe_apis toggle. Some APIs exposed by Dawn are not expected to be fully secured until after the first Origin Trial of WebGPU. To prevent their usage we add a new toggle that will be set by default by Chromium. This toggle throws a validation error when an unsafe API is used. Bug: chromium:1138528 Change-Id: I831db70bdac5128ebc32d36d55a0eaefc42c1807 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/31443 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-11-03 10:54:56 +00:00
"unittests/validation/UnsafeAPIValidationTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/validation/ValidationTest.cpp",
"unittests/validation/ValidationTest.h",
"unittests/validation/VertexBufferValidationTests.cpp",
"unittests/validation/VertexStateValidationTests.cpp",
"unittests/wire/WireArgumentTests.cpp",
"unittests/wire/WireBasicTests.cpp",
"unittests/wire/WireBufferMappingTests.cpp",
Add the entry point of CreateReadyComputePipeline This patch adds the entry point of CreateReadyComputePipeline in both dawn_native and dawn_wire. TODOs: 1. Add more tests in dawn_unittests and dawn_end2end_tests. 2. Put the main logic of creating a pipeline into a separate thread. BUG=dawn:529 TEST=dawn_end2end_tests Change-Id: I7edd269a5422a8b85320a7f9173df925decba633 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/30060 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Austin Eng <enga@chromium.org>
2020-10-19 01:56:08 +00:00
"unittests/wire/WireCreateReadyPipelineTests.cpp",
Add WireClient::Disconnect to stop serializing commands This prevents the client from continuing to send commands when the wire connection has dropped. In Chromium this may be because the connection to the GPU process is lost and the transfer buffer may be destroyed. This CL also adds a new helper to make testing callbacks with mocks easier. Bug: chromium:1070392 Change-Id: I6a69c32cc506069554ead18ee83a156ca70e2ce2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19160 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2020-04-15 02:00:14 +00:00
"unittests/wire/WireDisconnectTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/wire/WireErrorCallbackTests.cpp",
"unittests/wire/WireExtensionTests.cpp",
"unittests/wire/WireFenceTests.cpp",
"unittests/wire/WireInjectTextureTests.cpp",
"unittests/wire/WireMemoryTransferServiceTests.cpp",
dawn_wire: Validate all objects are from the same device in the client This is a temporary fix until dawn_wire can support multiple devices. When using objects from different devices, the wire will inject an error into the receiver object's device. Methods that return objects will return a dummy object. Using the dummy object will cause a fatal error on the server. Without this fix, the server would blindly lookup an ObjectId which could point to some other object. This would bypass same-device validation and have incorrect results. Bug: dawn:383 Change-Id: I898f07d4b26f2a97ef952b82af488e7f807c36f0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19261 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2020-04-15 17:58:25 +00:00
"unittests/wire/WireMultipleDeviceTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"unittests/wire/WireOptionalTests.cpp",
"unittests/wire/WireTest.cpp",
"unittests/wire/WireTest.h",
"unittests/wire/WireWGPUDevicePropertiesTests.cpp",
]
if (dawn_enable_d3d12) {
sources += [ "unittests/d3d12/CopySplitTests.cpp" ]
}
# When building inside Chromium, use their gtest main function because it is
# needed to run in swarming correctly.
if (build_with_chromium) {
Do not use Dawn's warnings for compiling Chromium's gtest main. When building in Chromium, Dawn's gtest targets use sources files in Chromium so it can use Chromium's GTest harness. These source files were compiled with the "dawn_internal" config included. This made them include Dawn-specific warnings that trigger on parts of Chromium's //base. Instead compile these "main" files as separate source_sets without dawn_internal and link them in the dawn test executables. Bug: chromium:1075817 Change-Id: I573390ca3e6a7dfd1e8a949dc10ed268f0d0f63e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/20520 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-28 17:12:05 +00:00
deps += [ ":dawn_unittests_main" ]
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
} else {
sources += [ "UnittestsMain.cpp" ]
}
}
###############################################################################
# Dawn end2end tests targets
###############################################################################
source_set("dawn_end2end_tests_sources") {
configs += [ "${dawn_root}/src/common:dawn_internal" ]
testonly = true
deps = [
":gmock_and_gtest",
"${dawn_root}/src/common",
Remove temporary GN proxy groups. It also changes remaining deps for internal targets from libdawn_proc to dawn_proc. Bug: chromium:1064305 Change-Id: I36df2b5d7793be9d6c878b6a1f2ec238603a8205 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19289 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-14 17:36:44 +00:00
"${dawn_root}/src/dawn:dawn_proc",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"${dawn_root}/src/dawn:dawncpp",
"${dawn_root}/src/dawn_native",
"${dawn_root}/src/dawn_wire",
"${dawn_root}/src/utils:dawn_utils",
]
sources = [
"DawnTest.h",
Don't forward device lost errors to the uncaptured error callback This issue was discovered in http://crrev.com/c/2613517 where a device lost error on page teardown was bubbling up to the Renderer's uncaptured error callback. Bug: chromium:1160459 Change-Id: I64b8c7779f4808d5a4b87c131aaf2e041c512bb9 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/36960 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2021-01-13 17:53:29 +00:00
"MockCallback.h",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/BasicTests.cpp",
"end2end/BindGroupTests.cpp",
"end2end/BufferTests.cpp",
Implement buffer lazy initialization before writeBuffer This patch implements buffer lazy initialization before writeBuffer(): if the buffer is not initialized and writeBuffer() doesn't cover the whole buffer, the buffer will be cleared to 0, otherwise the buffer shouldn't be cleared. This patch also introduces a toggle LazyClearBufferOnFirstUse for the development of buffer lazy initialization: before buffer lazy initialization being completely supported, all the related code will only be enabled behind this toggle to prevent the buffers with valid content being unexpectedly cleared. BUG=dawn:414 TEST=dawn_end2end_tests Change-Id: I99a2aa98ca4b9b21d69c6b32080afb525e2c4ad3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24041 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-07-06 08:24:30 +00:00
"end2end/BufferZeroInitTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/ClipSpaceTests.cpp",
"end2end/ColorStateTests.cpp",
"end2end/CompressedTextureFormatTests.cpp",
"end2end/ComputeCopyStorageBufferTests.cpp",
"end2end/ComputeIndirectTests.cpp",
"end2end/ComputeSharedMemoryTests.cpp",
"end2end/ComputeStorageBufferBarrierTests.cpp",
"end2end/CopyTests.cpp",
Support internal pipelines for Dawn Like copyTextureCHROMIUM in Chromium, CopyImageBitmapToTexture can use internal pipeline to do the GPU uploading. But Dawn doesn't support internal pipeline now. This patch adds the first internal pipeline for Dawn and add the API CopyTextureForBrowser to use internal pipeline to do gpu uploading. The patch integrates very simple wgsl vertex/fragment shaders to do simple direct blit to verify the whole system works. BUG=dawn:465 Change-Id: I8b566af38a10eea00f7426c39e752958ef057abd Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/30960 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by: Austin Eng <enga@chromium.org>
2020-11-04 02:30:16 +00:00
"end2end/CopyTextureForBrowserTests.cpp",
Add the entry point of CreateReadyComputePipeline This patch adds the entry point of CreateReadyComputePipeline in both dawn_native and dawn_wire. TODOs: 1. Add more tests in dawn_unittests and dawn_end2end_tests. 2. Put the main logic of creating a pipeline into a separate thread. BUG=dawn:529 TEST=dawn_end2end_tests Change-Id: I7edd269a5422a8b85320a7f9173df925decba633 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/30060 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Austin Eng <enga@chromium.org>
2020-10-19 01:56:08 +00:00
"end2end/CreateReadyPipelineTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/CullingTests.cpp",
"end2end/DebugMarkerTests.cpp",
Introduce Device::GetDefaultQueue and deprecate CreateQueue This makes all backends register the default queue at device initialization time, so that the same queue is returned by each call to GetDefaultQueue. All usages of CreateQueue are replaced by GetDefaultQueue except a couple ones that could use the queue initialized by DawnTest::SetUp. A deprecation warning mechanism is added so that users of Dawn can now that they should upgrade their usage of the API. It also comes with a backdoor so we can test that they are emitted. New DeprecatedAPITests are added that will contain tests for deprecated APIs, and will also check that deprecation warnings are produced. The special casing of GetDefaultQueue in the wire will be done in a follow-up CL to ease the review. It happens to work through the regular wire mechanisms at the moment but returns a different object on each GetDefaultQueue call. Bug: dawn:22 Change-Id: I78dc1fa474769674278d30040e8d05c658b88360 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19724 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-17 16:45:17 +00:00
"end2end/DeprecatedAPITests.cpp",
Add support for depthBias, depthBiasSlope, and depthBiasClamp Bug: dawn:524 Change-Id: I2586aadbc326f58889314a2d10794bcc0572aaba Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/28300 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-10-06 08:12:29 +00:00
"end2end/DepthBiasTests.cpp",
Implement depth-only/stencil-only copies on Vulkan and Metal Bug: dawn:439 Change-Id: I07ab014f4f13b73c09b2eecc48cd38b06d88166a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24684 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> Commit-Queue: Austin Eng <enga@chromium.org>
2020-08-04 19:46:37 +00:00
"end2end/DepthStencilCopyTests.cpp",
Rename DepthSamplingTests to DepthStencilSamplingTests Bug: none Change-Id: I2d1fc8bfd35ddb80f34724639ff14ad3fd1ed4d9 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/32581 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2020-11-12 20:57:42 +00:00
"end2end/DepthStencilSamplingTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/DepthStencilStateTests.cpp",
"end2end/DestroyTests.cpp",
"end2end/DeviceLostTests.cpp",
"end2end/DrawIndexedIndirectTests.cpp",
"end2end/DrawIndexedTests.cpp",
"end2end/DrawIndirectTests.cpp",
"end2end/DrawTests.cpp",
"end2end/DynamicBufferOffsetTests.cpp",
ShaderModule: Add support for multiple entryPoints Also adds validation tests that reflection data is correctly computed by entryPoint, and end2end tests that using a shader module with multiple entryPoints works correctly. Bug: dawn:216 Change-Id: Id2936bb220d4480872a68624996e4c42452a507d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/28244 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2020-09-09 23:11:57 +00:00
"end2end/EntryPointTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/FenceTests.cpp",
"end2end/GpuMemorySynchronizationTests.cpp",
"end2end/IndexFormatTests.cpp",
"end2end/MultisampledRenderingTests.cpp",
Add support for multisampled sampling This CL adds support for multisampled sampling on the D3D12 backend. This was already working on other backends. It also adds tests that all of the sample locations are correct. Bug: dawn:431 Change-Id: I6849e5e2d708ad4824e6db2665d668d43a4ef5ea Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/23245 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-06-19 16:21:33 +00:00
"end2end/MultisampledSamplingTests.cpp",
Metal: Enable nonzero_clear_resources_on_creation_for_testing on buffer This patch enables nonzero_clear_resources_on_creation_for_testing toggle on buffer on Metal backends as a preparation of supporting buffer lazy-initializations in Dawn. BUG=dawn:414 TEST=dawn_end2end_tests Change-Id: Ia7106482922aeb0521affa206f459d40938a0131 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/22861 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2020-06-09 17:09:04 +00:00
"end2end/NonzeroBufferCreationTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/NonzeroTextureCreationTests.cpp",
"end2end/ObjectCachingTests.cpp",
"end2end/OpArrayLengthTests.cpp",
D3D12: Fix pipeline layout overflow when using dynamic offsets. Pipeline layout incorrectly indexes into a root table array when there are more root descriptors than root tables. To fix, the array is dynamically sized where parameters are appended instead of indexed into the root signature. Bug: dawn:449 Change-Id: I6d7f65fb791d323704b1c3a3af9c871a79e32a30 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/22960 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-06-10 16:09:45 +00:00
"end2end/PipelineLayoutTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/PrimitiveTopologyTests.cpp",
Query API: QuerySet on D3D12 - Implement QuerySet object creation on D3D12 backend. - Add end2end tests for the creation on D3D12 backend. Bug: dawn:434 Change-Id: I9657792ca5cba8f156471783a7c13f6d36b7a19e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25225 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Hao Li <hao.x.li@intel.com>
2020-07-25 14:48:12 +00:00
"end2end/QueryTests.cpp",
Introduce Device::GetDefaultQueue and deprecate CreateQueue This makes all backends register the default queue at device initialization time, so that the same queue is returned by each call to GetDefaultQueue. All usages of CreateQueue are replaced by GetDefaultQueue except a couple ones that could use the queue initialized by DawnTest::SetUp. A deprecation warning mechanism is added so that users of Dawn can now that they should upgrade their usage of the API. It also comes with a backdoor so we can test that they are emitted. New DeprecatedAPITests are added that will contain tests for deprecated APIs, and will also check that deprecation warnings are produced. The special casing of GetDefaultQueue in the wire will be done in a follow-up CL to ease the review. It happens to work through the regular wire mechanisms at the moment but returns a different object on each GetDefaultQueue call. Bug: dawn:22 Change-Id: I78dc1fa474769674278d30040e8d05c658b88360 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19724 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-17 16:45:17 +00:00
"end2end/QueueTests.cpp",
Have Queue timeline tasks resolve in order Use QueueBase to track fences in flight and map requests so that they can be resolved in the order they were added. Before these tasks were separately tracked in FenceSignalTracker and MapRequestTracker, so tasks would be resolving out of order. Bug: dawn:404 Change-Id: I8b58fb72c99f43bc4593f56e08920d48ac506157 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/29441 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Natasha Lee <natlee@microsoft.com>
2020-10-12 22:32:33 +00:00
"end2end/QueueTimelineTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/RenderBundleTests.cpp",
"end2end/RenderPassLoadOpTests.cpp",
"end2end/RenderPassTests.cpp",
Add maxAnisotropy to GPUSamplerDescriptor Adds some maxAnisotropy implementation. Adds an end2end test, drawing a slanted plane with a texture of which each mipmap has a different color, with different maxAnisotropy values. You can get an idea of what it does at https://jsfiddle.net/t64kpu81/85/ Needs further CTS. Bug: dawn:568 Change-Id: I89ac56d8cf0fbb655358bf6effa016ddc1f8426f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/35143 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2020-12-24 03:11:17 +00:00
"end2end/SamplerFilterAnisotropicTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/SamplerTests.cpp",
"end2end/ScissorTests.cpp",
Reland "Check FP16 support on vulkan backend" This reverts commit 0357eed7de15e901d14f6149e91bfe03d86958de and reland commit bdc05c3d5fef780382c3fd5e5ebcb14bd929819a. The Vulkan-Loader has a bug where if the instance is created with Vulkan 1.1 and not the promoted extensions, it will skip emulation and if the ICD doesn't support Vulkan 1.1 nor the extensions. Enable the promoted extensions, even when creating a Vulkan 1.1 instance. Original change's description: > Check FP16 support on vulkan backend > > This patch check FP16 support on vulkan backend, and introduces > the shader_float16 extension. > > BUG=dawn:426 > TEST=dawn_end2end_tests > > Change-Id: Ie09568a416ce9eb2c11afeede3e7da520550d5fb > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/21901 > Commit-Queue: Xinghua Cao <xinghua.cao@intel.com> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Austin Eng <enga@chromium.org> Bug: chromium:1087896, dawn:426 Change-Id: I2c4465fb2fe957966b44d3e5840112219481c639 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/22781 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-06-08 12:18:21 +00:00
"end2end/ShaderFloat16Tests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/StorageTextureTests.cpp",
s/OutputAttachment/RenderAttachment/g But also keep OutputAttachment so it can be gradually changed in all dependants. See https://github.com/gpuweb/gpuweb/pull/1168 and https://github.com/gpuweb/gpuweb/pull/1168 Bug: dawn:22 Change-Id: I6a1ec1de6c22ca4deac88b7fffde4b98d9d54a84 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/31040 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-10-27 15:35:56 +00:00
"end2end/SubresourceRenderAttachmentTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/TextureFormatTests.cpp",
Add end2end tests for texture subresource The tests can pass on Metal and OpenGL backend as expected. But they can't pass on D3D12 and Vulkan backend. I will work on that soon. Bug: dawn:157 Change-Id: I4fcf229f7a24369004d5594a3801f0acad804fd0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/21341 Commit-Queue: Yunchao He <yunchao.he@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-05-16 00:34:57 +00:00
"end2end/TextureSubresourceTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"end2end/TextureViewTests.cpp",
"end2end/TextureZeroInitTests.cpp",
"end2end/VertexFormatTests.cpp",
"end2end/VertexStateTests.cpp",
"end2end/ViewportOrientationTests.cpp",
"end2end/ViewportTests.cpp",
]
# Validation tests that need OS windows live in end2end tests.
sources += [
"unittests/validation/ValidationTest.cpp",
"unittests/validation/ValidationTest.h",
]
libs = []
if (dawn_enable_d3d12) {
D3D12: Support caching DX shaders. This change is a prerequisite to D3D pipeline caching. This change introduces: - Caching interface which enables the cache. - Helper for backends to load/store blobs to be cached. - Ability to cache HLSL shaders. Bug:dawn:549 Change-Id: I2af759882d18b3f45dc63e49dcb6a3caa1be3485 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/32305 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-11-20 20:38:37 +00:00
sources += [
"end2end/D3D12CachingTests.cpp",
"end2end/D3D12ResourceWrappingTests.cpp",
]
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
libs += [
"d3d11.lib",
"dxgi.lib",
]
}
if (dawn_enable_metal) {
sources += [ "end2end/IOSurfaceWrappingTests.cpp" ]
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I0b57a3c4c995887a57937317db30b67cf7a7f0f7 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24281 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-07-15 09:59:46 +00:00
frameworks = [ "IOSurface.framework" ]
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
}
Add Metal vertex pulling behind a flag Implements vertex pulling on the Metal backend, hidden behind a flag until ready for use (we are missing support for more complicated vertex input types). Bug: dawn:480 Change-Id: I38028b80673693ebf21309ad5336561fb99f40dc Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26522 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2020-08-13 23:53:59 +00:00
if (dawn_enable_wgsl) {
sources += [ "end2end/VertexBufferRobustnessTests.cpp" ]
}
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
if (dawn_enable_opengl) {
assert(dawn_supports_glfw_for_windowing)
}
if (dawn_supports_glfw_for_windowing) {
sources += [
"end2end/SwapChainTests.cpp",
"end2end/SwapChainValidationTests.cpp",
"end2end/WindowSurfaceTests.cpp",
]
deps += [ "${dawn_root}/src/utils:dawn_glfw" ]
}
}
source_set("dawn_white_box_tests_sources") {
configs += [ "${dawn_root}/src/dawn_native:dawn_native_internal" ]
testonly = true
deps = [
":gmock_and_gtest",
"${dawn_root}/src/common",
Remove temporary GN proxy groups. It also changes remaining deps for internal targets from libdawn_proc to dawn_proc. Bug: chromium:1064305 Change-Id: I36df2b5d7793be9d6c878b6a1f2ec238603a8205 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19289 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-14 17:36:44 +00:00
"${dawn_root}/src/dawn:dawn_proc",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"${dawn_root}/src/dawn:dawncpp",
"${dawn_root}/src/dawn_native:dawn_native_sources",
"${dawn_root}/src/dawn_wire",
"${dawn_root}/src/utils:dawn_utils",
# Static because the tests both link against and have dawn_native
# sources. MSVC errors when both importing and exporting symbols.
"${dawn_root}/src/dawn_native:dawn_native_static",
]
Introduce Device::GetDefaultQueue and deprecate CreateQueue This makes all backends register the default queue at device initialization time, so that the same queue is returned by each call to GetDefaultQueue. All usages of CreateQueue are replaced by GetDefaultQueue except a couple ones that could use the queue initialized by DawnTest::SetUp. A deprecation warning mechanism is added so that users of Dawn can now that they should upgrade their usage of the API. It also comes with a backdoor so we can test that they are emitted. New DeprecatedAPITests are added that will contain tests for deprecated APIs, and will also check that deprecation warnings are produced. The special casing of GetDefaultQueue in the wire will be done in a follow-up CL to ease the review. It happens to work through the regular wire mechanisms at the moment but returns a different object on each GetDefaultQueue call. Bug: dawn:22 Change-Id: I78dc1fa474769674278d30040e8d05c658b88360 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19724 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-17 16:45:17 +00:00
sources = [ "DawnTest.h" ]
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
if (dawn_enable_vulkan) {
Split third_party/BUILD.gn in per-project files. Bug: chromium:1064305 Change-Id: I6fc2da97e20865b62ff34a9d1c3f42120ac90348 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19202 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:24:00 +00:00
deps += [ "${dawn_root}/third_party/khronos:vulkan_headers" ]
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
if (is_chromeos) {
sources += [ "white_box/VulkanImageWrappingTestsDmaBuf.cpp" ]
} else if (is_linux) {
sources += [ "white_box/VulkanImageWrappingTestsOpaqueFD.cpp" ]
}
if (dawn_enable_error_injection) {
sources += [ "white_box/VulkanErrorInjectorTests.cpp" ]
}
}
Query API: Test the accuracy of timestamp compute shader Because the uint64 is not supported on all GPU drivers, we use uint32 and float to simulate the multiplication of uint64, but there is accuracy loss between the results and the expected results computed by uint64. This test checks that the accuracy loss is less than 0.2%. Bug: dawn:434 Change-Id: I6f5c842b6915f101441886bdfa4f9feb2827d174 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/34120 Commit-Queue: Hao Li <hao.x.li@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-12-22 06:55:36 +00:00
sources += [
"white_box/InternalResourceUsageTests.cpp",
"white_box/QueryInternalShaderTests.cpp",
]
Validate texture usage scope with storage textures in one render pass This patch adds the validation rules on the texture usage scope with storage textures in one render pass. 1. Write-only storage cannot be used in combination with anything else in the same render pass. 2. Sampled and read-only storage are allowed to be used in the same render pass. This patch also adds dawn_unittests to test the storage texture usage scope in one render pass: 1. read-only or write-only storage only 2. read-only or write-only storage + sampled 3. read-only or write-only storage + output attachment 4. read-only + write-only This patch also removes kWritableBufferUsages as it is not used in Dawn at all. BUG=dawn:267 TEST=dawn_unittests Change-Id: Ib2a0f06ec8d183c5f812f87459c6b1b8f79937e0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19820 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-04-21 00:48:10 +00:00
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
if (dawn_enable_d3d12) {
sources += [
"white_box/D3D12DescriptorHeapTests.cpp",
"white_box/D3D12ResidencyTests.cpp",
D3D12: Align UBO sizes to 256B. D3D debug layer uses the descriptor size (width) to validate CBV bounds when directly allocating UBOs. This causes validation failure when the buffer size is misaligned (ie. not a multiple of 256B) even through the underlying resource heap size is always 64KB aligned. This change always aligns the buffer size to be 256B to avoid such validation error should sub-allocation fail. BUG=dawn:506 Change-Id: Ic9072934cac65cfd25d0e2a20cb364bd3ca88e3b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26820 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2020-09-17 23:30:40 +00:00
"white_box/D3D12ResourceHeapTests.cpp",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
]
}
if (dawn_enable_metal) {
sources += [ "white_box/MetalAutoreleasePoolTests.mm" ]
}
if (dawn_enable_opengl) {
deps += [ "${dawn_root}/src/utils:dawn_glfw" ]
}
libs = []
}
BUILD.gn: Move dawn_end2end_tests to its final location Bug: chromium:1064305 Change-Id: Ie51377301117a8ffbc6c21dc4c58349871bcf232 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19285 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-13 21:23:46 +00:00
test("dawn_end2end_tests") {
configs += [ "${dawn_root}/src/common:dawn_internal" ]
deps = [
":dawn_end2end_tests_sources",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
":dawn_white_box_tests_sources",
":gmock_and_gtest",
"${dawn_root}/src/common",
Remove temporary GN proxy groups. It also changes remaining deps for internal targets from libdawn_proc to dawn_proc. Bug: chromium:1064305 Change-Id: I36df2b5d7793be9d6c878b6a1f2ec238603a8205 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19289 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-14 17:36:44 +00:00
"${dawn_root}/src/dawn:dawn_proc",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"${dawn_root}/src/dawn:dawncpp",
"${dawn_root}/src/dawn_native",
"${dawn_root}/src/dawn_wire",
"${dawn_root}/src/utils:dawn_utils",
]
sources = [
"DawnTest.cpp",
"DawnTest.h",
]
libs = []
# When building inside Chromium, use their gtest main function because it is
# needed to run in swarming correctly.
if (build_with_chromium) {
Do not use Dawn's warnings for compiling Chromium's gtest main. When building in Chromium, Dawn's gtest targets use sources files in Chromium so it can use Chromium's GTest harness. These source files were compiled with the "dawn_internal" config included. This made them include Dawn-specific warnings that trigger on parts of Chromium's //base. Instead compile these "main" files as separate source_sets without dawn_internal and link them in the dawn test executables. Bug: chromium:1075817 Change-Id: I573390ca3e6a7dfd1e8a949dc10ed268f0d0f63e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/20520 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-28 17:12:05 +00:00
deps += [ ":dawn_end2end_tests_main" ]
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
} else {
sources += [ "End2EndTestsMain.cpp" ]
}
if (dawn_enable_opengl) {
deps += [ "${dawn_root}/src/utils:dawn_glfw" ]
}
if (is_chromeos) {
libs += [ "gbm" ]
}
}
###############################################################################
# Dawn perf tests
###############################################################################
test("dawn_perf_tests") {
configs += [ "${dawn_root}/src/common:dawn_internal" ]
deps = [
":gmock_and_gtest",
"${dawn_root}/src/common",
Remove temporary GN proxy groups. It also changes remaining deps for internal targets from libdawn_proc to dawn_proc. Bug: chromium:1064305 Change-Id: I36df2b5d7793be9d6c878b6a1f2ec238603a8205 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19289 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-14 17:36:44 +00:00
"${dawn_root}/src/dawn:dawn_proc",
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
"${dawn_root}/src/dawn:dawncpp",
"${dawn_root}/src/dawn_native",
"${dawn_root}/src/dawn_platform",
"${dawn_root}/src/dawn_wire",
"${dawn_root}/src/utils:dawn_utils",
]
sources = [
"DawnTest.cpp",
"DawnTest.h",
"ParamGenerator.h",
"perf_tests/BufferUploadPerf.cpp",
"perf_tests/DawnPerfTest.cpp",
"perf_tests/DawnPerfTest.h",
"perf_tests/DawnPerfTestPlatform.cpp",
"perf_tests/DawnPerfTestPlatform.h",
"perf_tests/DrawCallPerf.cpp",
]
libs = []
Add proper data_deps to dawn_perf_tests. Currently the Chromium build defines a wrapper build target for Dawn (//chrome/test:dawn_perf_tests) that seems to exist only to specify some extra data dependencies. By moving this data dependencies onto the Dawn dawn_perf_tests itself, this removes a problematic target in Chromium that would otherwise block my planned changes for crbug.com/816629. Bug: chromium:816629 Change-Id: I428698fe164bd1aad09c8dba14e57a4b7acebb1c Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24302 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-07-03 05:47:07 +00:00
# When building inside Chromium, use their gtest main function and the
# other perf test scaffolding in order to run in swarming correctly.
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
if (build_with_chromium) {
Do not use Dawn's warnings for compiling Chromium's gtest main. When building in Chromium, Dawn's gtest targets use sources files in Chromium so it can use Chromium's GTest harness. These source files were compiled with the "dawn_internal" config included. This made them include Dawn-specific warnings that trigger on parts of Chromium's //base. Instead compile these "main" files as separate source_sets without dawn_internal and link them in the dawn test executables. Bug: chromium:1075817 Change-Id: I573390ca3e6a7dfd1e8a949dc10ed268f0d0f63e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/20520 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-28 17:12:05 +00:00
deps += [ ":dawn_perf_tests_main" ]
Add proper data_deps to dawn_perf_tests. Currently the Chromium build defines a wrapper build target for Dawn (//chrome/test:dawn_perf_tests) that seems to exist only to specify some extra data dependencies. By moving this data dependencies onto the Dawn dawn_perf_tests itself, this removes a problematic target in Chromium that would otherwise block my planned changes for crbug.com/816629. Bug: chromium:816629 Change-Id: I428698fe164bd1aad09c8dba14e57a4b7acebb1c Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24302 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-07-03 05:47:07 +00:00
data_deps = [ "//testing:run_perf_test" ]
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
} else {
sources += [ "PerfTestsMain.cpp" ]
}
if (dawn_enable_metal) {
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I0b57a3c4c995887a57937317db30b67cf7a7f0f7 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24281 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-07-15 09:59:46 +00:00
frameworks = [ "IOSurface.framework" ]
Split examples, test and utils in their own BUILD.gn The basic change was to copy-paste targets in the new BUILD.gn files and fixup paths / add includes. There's a couple more changes that had to be done at the same time: - Multiple files need to know if GLFW is supported so the variable was moved to dawn_features.gni. - The gtest_and_gmock target used to abstract between Dawn's copy of GTest/GMock is only needed by tests and was moved in src/tests/BUILD.gn. - A leftover dawn_end2end_tests target is left in the main BUILD.gn file that is an exact copy of the on in src/tests/BUILD.gn. This is because the GN path is hardcoded in Chromium's isolate_map.pyl that also can't support GN groups. The only way to move a target I could figure out was to duplicate it temporarily. Bug: chromium:1064305 Change-Id: I96820e9d6510b8c9b9112c3e6cd8df2413f04287 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19201 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:20:10 +00:00
}
if (dawn_enable_opengl) {
deps += [ "${dawn_root}/src/utils:dawn_glfw" ]
}
}