Commit Graph

10390 Commits

Author SHA1 Message Date
Ben Clayton cc636273da tint: Validate no f16 sampled textures
Bug: chromium:1370417
Change-Id: Id78178ab61cd882ff8fcbbe96aa8123de512f9aa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/105120
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-10-10 11:37:57 +00:00
Dawn Autoroller 3e1501af29 Roll ANGLE from 85631d24ddf9 to 54d094fe1de5 (1 revision)
85631d24dd..54d094fe1d

2022-10-08 gbiv@google.com angle: fix potential nullptr dereference

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I162ec11f6b13de000b0e682bbad5067f8a521b97
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/105080
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-09 02:56:14 +00:00
Dawn Autoroller a32ce7d8a0 Roll ANGLE from cad7979e9270 to 85631d24ddf9 (4 revisions)
cad7979e92..85631d24dd

2022-10-08 lubosz.sarnecki@collabora.com Tests: Add 3D Pool Ball trace.
2022-10-07 jmadill@chromium.org run_perf_tests: Reduce warmup trials from 3 to 2.
2022-10-07 jmadill@chromium.org Capture/Replay: Make retrace restore touch output files.
2022-10-07 jmadill@chromium.org infra: Update timeout for perf tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: Iea202d9b2bcb879278d8a094c417fecca17df794
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/105060
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-08 12:54:13 +00:00
Dawn Autoroller 690e601f61 Roll SwiftShader from 65066ae6d9cd to acdfa394561f (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/65066ae6d9cd..acdfa394561f

2022-10-07 capn@google.com Update Marl to 14549e9d1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I576aba5b581ac94be7b91774ef55c8204c821f11
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104962
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-08 07:38:49 +00:00
Dawn Autoroller acbd308614 Roll ANGLE from 2b3c8aaf1a93 to cad7979e9270 (10 revisions)
2b3c8aaf1a..cad7979e92

2022-10-07 tvignatti@igalia.com Metal: Build fix TextureMtl code
2022-10-07 chris@rive.app Include Apple1 in the Metal framebuffer-fetch impl of PLS
2022-10-07 jmadill@chromium.org Perf Tests: Divide test samples between shards.
2022-10-07 jmadill@chromium.org Roll third_party/OpenGL-Registry/src/ 11d7b7bae..5bae8738b (5 commits)
2022-10-07 jmadill@chromium.org Perf Tests: Simplify merger script.
2022-10-07 chh@google.com Fix cert-dcl16-c warnings
2022-10-07 solti@google.com fix typo
2022-10-07 m.maiya@samsung.com Vulkan: Bug fix in GL_QCOM_shading_rate
2022-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7d797ec7d6bb to 1172dba33888 (4 revisions)
2022-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 2b155acd6a90 to 01fade1fc521 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I96d1fd676c1a489b205a692c4e575950974a8cf6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104961
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-07 23:36:58 +00:00
Corentin Wallez 174b6bd5d9 Make GetBindGroupLayout error for indices past the last defined BGL.
Fixed: dawn:1565
Change-Id: I8a482623fcbd68648c451499ce769b871cf89c0a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104820
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2022-10-07 22:02:20 +00:00
Brandon Jones b68cd1a212 Split Vulkan command buffers to work around bug
There's a bug in some Qualcomm devices where using a depth/stencil
texture as a render attachment and then sampling it in a compute pass
causes a crash. This only happens, however, if the two passes occur as
part of the same Vulkan command buffer.

To work around the issue, this change splits the Vulkan command buffer
while recording any time it identifies that the problematic scenario may
occur.

Bug: dawn:1564
Change-Id: Ie137e9118ef9cc41f5908ca32c72c33f3798cd71
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104860
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2022-10-07 20:53:17 +00:00
Dawn Autoroller 007ddcad32 Roll SwiftShader from 01fade1fc521 to 65066ae6d9cd (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/01fade1fc521..65066ae6d9cd

2022-10-07 capn@google.com Fix enabling XCB and Wayland WSI builds on Linux

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I9d68382ef561543a53cb9ad79cfdc3c2508ed229
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104960
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-07 18:39:32 +00:00
Corentin Wallez cf8e404c7c Triage a few WebGPU expectations
Bug: dawn:1345 dawn:1512
Change-Id: I3f824b3779005c9f39742d900930045560e5f080
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104940
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2022-10-07 15:15:13 +00:00
dawn-autoroll 95f59412a6 Roll vulkan-deps from 2514a680a159 to 1172dba33888 (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/2514a680a159..1172dba33888

Changed dependencies:
* vulkan-loader: cd9b4afed4..6c64537135
* vulkan-validation-layers: 8963bb6715..96595a7710

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I9a360699e288713f303a6f39e8b4c2484040bfeb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104920
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-07 12:17:55 +00:00
Dawn Autoroller 1a3f01ed6a Roll ANGLE from c19ec9481a70 to 2b3c8aaf1a93 (2 revisions)
c19ec9481a..2b3c8aaf1a

2022-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7903a06a3c9a to 475715430cb8 (558 revisions)
2022-10-06 dino@apple.com Remove unnecessary fprintf of Metal shader output type

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I14035c542159fe237271bdb66072e24511a8695a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104785
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-07 10:45:42 +00:00
Dawn Autoroller 39e4d0df3f Roll SwiftShader from 782eb8546f75 to 01fade1fc521 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/782eb8546f75..01fade1fc521

2022-10-07 nicolascapens@google.com Merge changes Ie0e663e1,I97918fd5
2022-10-06 sugoi@google.com Regres main.go cleanup

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I3aebecab44f29141757cb0190c01c50cc5b2c773
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104784
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-07 04:32:02 +00:00
dawn-autoroll bb55ac595a Roll vulkan-deps from 7d797ec7d6bb to 2514a680a159 (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/7d797ec7d6bb..2514a680a159

Changed dependencies:
* spirv-tools: a6e6454ef2..1cecf91701
* vulkan-validation-layers: a02d471126..8963bb6715

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: Ie316e68c1ab1cbbfdc913599b260fd92c661d06b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104880
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-06 23:16:53 +00:00
Dawn Autoroller 9ba9e6ea87 Roll ANGLE from 13195f8a9000 to c19ec9481a70 (8 revisions)
13195f8a90..c19ec9481a

2022-10-06 abdolrashidi@google.com Vulkan: Implement imageless framebuffers
2022-10-06 jmadill@chromium.org Vulkan: Ensure we sync the draw FB before beingQuery.
2022-10-06 chris@rive.app Implement PLS on Apple Silicon
2022-10-06 jmadill@chromium.org Perf Tests: Use specified trial time for warmup.
2022-10-06 robert.mader@collabora.com Reland "EGL: Implement EGL_EXT_image_dma_buf_import_modifiers"
2022-10-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a93889caf313 to 7d797ec7d6bb (9 revisions)
2022-10-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3d7faaa40575 to 2b155acd6a90 (3 revisions)
2022-10-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cbf7ac747397 to 7903a06a3c9a (479 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I249853a3b7af2df3b6d69eb632b5a27913f80fcf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104783
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-06 21:32:32 +00:00
Ben Clayton a1c8527f6c tint/sem: Add Type::HoldsAbstract()
Tells you if there's an abstract numeric somewhere in the type.

Change-Id: I0573be9e57ec48f2fa63c46944214e7f5be7d67c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104823
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: dan sinclair <dsinclair@google.com>
2022-10-06 20:58:46 +00:00
Ben Clayton 933eb5159e tint: Add _tint_materialize internal builtin
Returns a materialization of the given argument.

Bug: tint:1697
Change-Id: Id25f7e10baa884047af21f89245884c551560f7b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104822
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-10-06 19:54:07 +00:00
Ben Clayton 73683027a3 tint: Use PascalCase for builtin enum names
Nicer names if we add some "_tint_*" builtins

Change-Id: I7574f5cfeeeb04ec5910b20068aa0dd12a460bd5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104821
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-10-06 19:23:29 +00:00
David Neto 76a709c760 spirv-reader: track module scope variables
Bug: tint:1041 tint:1643
Change-Id: Ifc0aed85eae758e674e90bb73693503888847f76
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104761
Auto-Submit: David Neto <dneto@google.com>
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-06 19:08:22 +00:00
David Neto 861099fc81 spirv-reader: refactor definition info pertaining to pointers
Change-Id: I3999f85c60a08f3eeb921b6931c07ca3bdd1f417
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104760
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-10-06 16:55:10 +00:00
Dawn Autoroller d71caf7f58 Roll SwiftShader from 2b155acd6a90 to 782eb8546f75 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/2b155acd6a90..782eb8546f75

2022-10-06 martin.troiber@gmail.com Fix repeated character

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I950f3ba9a0d41cbba198ef423f041ef6fb06cfb5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104782
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-06 15:00:22 +00:00
dawn-autoroll ce87349b62 Roll vulkan-deps from ea19efbfecb2 to 7d797ec7d6bb (5 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/ea19efbfecb2..7d797ec7d6bb

Changed dependencies:
* glslang: 28b53119bd..89db4e1caa
* spirv-tools: 4dbc66380d..a6e6454ef2
* vulkan-validation-layers: daa951337f..a02d471126

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I49d5c7e8eb8b074074d084bed1d2480192a81e03
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104800
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-06 09:46:42 +00:00
Dawn Autoroller 529bd06284 Roll ANGLE from d64c54e34d03 to 13195f8a9000 (11 revisions)
d64c54e34d..13195f8a90

2022-10-06 syoussefi@chromium.org Vulkan: Fix missing input attachment usage on MSRTT
2022-10-06 syoussefi@chromium.org Vulkan: Make sure spirv-val doesn't generate friendly names
2022-10-06 chris@rive.app Support pixel local storage on ES 3.0
2022-10-05 hailinzhang@google.com Vulkan: Choose host visiable device local based on heap size.
2022-10-05 cnorthrop@google.com restricted_trace_perf: Switch to --warmup-trials
2022-10-05 cnorthrop@google.com restricted_trace_perf: Sleep between tests option
2022-10-05 syoussefi@chromium.org Revert "Suppress DrawBuffersTest.MidRenderPassClearWithGapsRGB"
2022-10-05 cnorthrop@google.com restricted_trace_perf: Use Android platform loader
2022-10-05 syoussefi@chromium.org Vulkan: Use VK_EXT_rasterization_order_attachment_access
2022-10-05 jmadill@chromium.org Perf Tests: Reduce resource usage.
2022-10-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5d66d3e5917b to a93889caf313 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I6dae8f715a945a042c4a457bc2c93ec06826f6ff
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104781
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-06 08:20:11 +00:00
Dawn Autoroller 3a7c6bd595 Roll SwiftShader from 3d7faaa40575 to 2b155acd6a90 (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/3d7faaa40575..2b155acd6a90

2022-10-05 capn@google.com Remove Unicode handling from Subzero
2022-10-05 capn@google.com Use local XCB header copies
2022-10-05 capn@google.com Use local Wayland header copies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I60d2d6446378488c426c46c0cba62fbb23f4e502
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104780
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-06 00:23:41 +00:00
dawn-autoroll 17317e02e9 Roll vulkan-deps from 5d66d3e5917b to ea19efbfecb2 (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/5d66d3e5917b..ea19efbfecb2

Changed dependencies:
* spirv-headers: 4bd8fc0c8c..85a1ed200d
* vulkan-tools: 467f61cd34..2446b5b849
* vulkan-validation-layers: ed24831042..daa951337f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I2175cabdb2f3d531bd6be8c346b772402caa6e52
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104740
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-05 20:12:18 +00:00
Dawn Autoroller 6a74325fc3 Roll ANGLE from d26ee6191908 to d64c54e34d03 (6 revisions)
d26ee61919..d64c54e34d

2022-10-05 lehoangquyen@chromium.org D3D11: Make  DebugAnnotator11 thread safe.
2022-10-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e0aed16f882f to 5d66d3e5917b (11 revisions)
2022-10-05 abdolrashidi@google.com Remove leftover code regarding render pass serial
2022-10-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 08dfcbb37734 to 3d7faaa40575 (5 revisions)
2022-10-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ea588e320b5b to cbf7ac747397 (579 revisions)
2022-10-05 cnorthrop@google.com Tests: Add Survivor.io trace

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I52b7c267f9f16bb350438540682e6027b25e4aca
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104720
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-05 18:52:27 +00:00
Antonio Maiorano 7aaf23eac9 Fix 32-bit build
Bug: oss-fuzz:51844
Change-Id: I7e6583c67ffa72659e00b5c8a4b692b44fe92a57
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104642
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-10-05 18:25:22 +00:00
dan sinclair 8fd4ef26f5 Fix MSL packed_int casting.
In 104681 the vectors were cast to themselves to fixup an issue
with `packed_int`. That CL used an `as_type` which does a bit cast.
A `packed_int` can not be bitcast to an `int`. This CL changes to
a type cast, so instead of `as_type<int3>()` it does `int3()`.

Bug: tint:1677
Change-Id: I72218c06853e4e5ae1a0d34e2fc3e1ca597de993
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104682
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-10-05 17:49:00 +00:00
Brandon Jones f35c719054 Allow tolerance on compressed texture verification
Qualcomm GPUs are apparently decoding textures with a lower precision,
resulting in some of the rendered values when verifying the texture in
a test to be off by +-1 on any given channel. This change adds a
tolerance to those tests to allow a little wiggle room, since compressed
textures are inherently lossy anyway.

Allows Qualcomm GPUs to pass all compressed texture end2end tests.

Bug: dawn:1562
Change-Id: I08a21b9ce361486c247c34640080b369ae2b799d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104622
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-05 16:10:44 +00:00
John Stiles 761536d941 Improve robustness of FloatToString.
When converting floats to string, we now enforce the "C" locale, so
decimal points will be written as "." rather than the "," separator
used natively in some European locales.

Also, we now use operator>> to read back the number instead of
std::stof. std::stof works in the system locale, and will fail to
read back floats with the wrong decimal separator. (Also, std::stof
will throw if the number is out of range and can't fit in the
destination, which implies that the `if` check was probably never
failing.)

Skia encountered similar issues: see http://review.skia.org/587536
for the Skia implementation.

Change-Id: I5aded6acc7cfcf2ad4d5b974bc30c3b645eaec51
Bug: dawn:1686
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104680
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2022-10-05 15:47:25 +00:00
Antonio Maiorano 8a833840d1 Enable CTS test for const `select`
Bug: tint:1581
Change-Id: I4821a555527d91a59099548ebfa7ab3a406397e8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104641
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-10-05 15:06:42 +00:00
Dawn Autoroller 2eba3fd385 Roll SwiftShader from 7776bf0e3175 to 3d7faaa40575 (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7776bf0e3175..3d7faaa40575

2022-10-04 capn@google.com Consistently format pointer-to-const
2022-10-04 capn@google.com Consistently format const references
2022-10-04 capn@google.com Remove unnecessary vector component indexing

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I86c9fedd783e9d41bedd549a77beb17c22a943a0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104564
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-05 11:09:52 +00:00
dawn-autoroll 7d8f4ebb78 Roll vulkan-deps from 5aeb9d1e5858 to 5d66d3e5917b (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/5aeb9d1e5858..5d66d3e5917b

Changed dependencies:
* vulkan-loader: 925eb27e51..cd9b4afed4
* vulkan-validation-layers: 219d513eb6..ed24831042

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: Ic6f0c411831201efe6750f790420f2657a8ecafa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104640
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-05 06:48:23 +00:00
Dawn Autoroller 511be900b0 Roll ANGLE from 5b3781ecfffe to d26ee6191908 (5 revisions)
5b3781ecff..d26ee61919

2022-10-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cce3d29fab2b to e0aed16f882f (8 revisions)
2022-10-04 ianelliott@google.com Suppress DrawBuffersTest.MidRenderPassClearWithGapsRGB
2022-10-04 syoussefi@chromium.org Vulkan: Fix VK_EXT_pipeline_robustness vs compute
2022-10-04 syoussefi@chromium.org Infra: Use smaller batches for GLES1 tests
2022-10-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 34801c7ce64b to ea588e320b5b (503 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I78fc9eb0ff029a8739ccf429a2b919b0fab17d7e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104563
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-05 04:57:51 +00:00
Antonio Maiorano 8800d885e7 tint: const eval of 'select' builtin
Bug: tint:1581
Change-Id: I222433acb6a30245ab319a15081811f691aca9ff
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104440
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-05 01:39:53 +00:00
Kai Ninomiya 44f7b8ddf7 Rebuild webgpu-cts when files are deleted
Bug: chromium:1371251
Change-Id: I4837df026bb49f5f9542fb61ae37c506f86f06ae
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104621
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-10-05 00:00:05 +00:00
Antonio Maiorano 6b3f4aaf26 tint: add vector cases for const eval builtin tests
- Make the const eval builtin tests use the same framework as the
unary/binary op tests, allowing for Vector cases.
- No longer always use float compare, instead enable it per case.
  Currently this is necessary because atan2 doesn't always return the
  same constant for PI on all platforms.
- Add vector cases for atan2 and clamp.

Bug: tint:1581
Change-Id: I7eaec10b4f9685c913a9d0d17b47c413f659be7a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104424
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-10-04 22:40:32 +00:00
Antonio Maiorano fc7994ba4c tint: fix intrinsic table lookup of mixed const and non-const with non-matching arg element types
Bug: tint:1581
Change-Id: I7676ec6857c5fd790cb9c5644bfe674a603113ab
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104545
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-04 22:19:48 +00:00
Dawn Autoroller 2e25382707 Roll SwiftShader from 08dfcbb37734 to 7776bf0e3175 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/08dfcbb37734..7776bf0e3175

2022-10-04 capn@google.com Fix CMAKE_BUILD_PARALLEL_LEVEL link
2022-10-04 swiftshader.regress@gmail.com Regres: Update test lists @ 08dfcbb3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: Idec2324b72900710347d401608d237cdfdbff2c4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104562
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-04 21:16:38 +00:00
dan sinclair 7a69a3411f Update type_decl grammar element name.
The `type_decl` term in the spec was updated to `type_specifier`. This
CL updates Tint to match.

Bug: tint:1633
Change-Id: I264ae78a4b09c3c69d8673e24fe4f60975539b8f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104421
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
2022-10-04 21:12:01 +00:00
Antonio Maiorano cf47d6147c tint: add parse_hlsl_errors.py to help triage hlsl errors
Change-Id: If160a8c72c407874060024c365faca83722b541f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103760
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-10-04 19:48:41 +00:00
dan sinclair 1dbda6f254 Update variables in address space template.
This CL updates the address space template to remove some usages of
`stoarge`.

Bug: tint:1404
Change-Id: I4c10f62886d2be4b03bce85dac9d58e3547ca60b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104423
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-10-04 19:44:48 +00:00
dan sinclair e89c27c648 Remove some DISABLED tests.
Several of the disabled tests were added for things we may want to add
in the future. This CL removes those tests and we can add back if/when
we decide to implement the feature.

This brings the disabled tests from 69 to 31.

Change-Id: I22b66256ce4086f223d3be059450eab1a2ff7693
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104462
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
2022-10-04 19:10:02 +00:00
dan sinclair 82023d6980 Enable disabled const eval tests.
The const evaluation of `<` has been implemented so the DISABLED const
evaluation tests can now be enabled.

Bug: tint:1581
Change-Id: I0cddad12aa637da6ae4cf8299517be723e410692
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104463
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-04 18:35:20 +00:00
dawn-autoroll d883c0b168 Roll vulkan-deps from daf416b93bfd to 5aeb9d1e5858 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/daf416b93bfd..5aeb9d1e5858

Changed dependencies:
* vulkan-validation-layers: 2576742a66..219d513eb6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I461897c5cd424e98eecd7c9a743a7f166cd5b461
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104600
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-04 17:49:58 +00:00
Austin Eng 663932d741 vulkan: Validate that exporting a texture uses VK_IMAGE_LAYOUT_UNDEFINED
Using any other desiredLayout is deprecated. This simplifies future
changes which as much as possible eliminate any transitions during
texture export.

Bug: chromium:1359106
Change-Id: Ifb5818775e8f15ec77a229d3cbf593348740da46
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104543
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-10-04 17:27:21 +00:00
Dawn Autoroller 9ecc310210 Roll ANGLE from 1d73bad50b31 to 5b3781ecfffe (4 revisions)
1d73bad50b..5b3781ecff

2022-10-04 jmadill@chromium.org Remove namespacing from all ANGLE loaders.
2022-10-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 666fb5f89f5a to 08dfcbb37734 (3 revisions)
2022-10-04 cnorthrop@google.com Test: Add The Gardens Between trace
2022-10-04 syoussefi@chromium.org Vulkan: Don't flush depth/stencil on color blit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I2554e0425f6aeeec3a75556af85eab50eb999f89
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104561
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-04 15:29:27 +00:00
Austin Eng 327cc706c2 vulkan: Use a static method to close semaphore handles
These functions don't need the device or external semaphore service
at all. Make them free functions so that a future change can allow
the handles to be closed after the device has destroyed its semaphore
service.

Bug: chromium:1359106
Change-Id: I246dd0a8f3f972c4547503d16bf8b00db14cdf58
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104542
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-04 15:14:04 +00:00
Austin Eng 70c3a4d605 vulkan: Move handling texture wait requirements to SubmitPendingCommands
This moves handling the wait semaphores to the same place that the
signal semaphores are handled. It fixes a bug where the semaphores are
never waited on and never deleted if a texture is imported and then
exported without being used.

Bug: chromium:1359106
Change-Id: If226a38946d4a16598d78841e7b204ea91f8bbea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104541
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
2022-10-04 15:12:32 +00:00
Austin Eng 5a687b084e Fix leak of D3D12 fence share handle
The D3D12 fence share handle should be closed when the device is
deleted.

A future change will make it valid to call EndAccess after the device
is destroyed, thus the handle is closed in ~Device instead of
Device::DestroyImpl. It needs to live as long as ExternalImageDXGI
holds a reference onto the device.

Bug: chromium:1359106
Change-Id: Ib9c9aaa7fb0b5a3de035b512f8fc0316d4bd225e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104540
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-04 15:10:26 +00:00
Dan Sinclair 2a3eae7371 Revert "Replace std::stof with std::strtof."
This reverts commit 5f9996dc9c.

Reason for revert: Issues around locale, will be revisited in a different fashion.

Original change's description:
> Replace std::stof with std::strtof.
>
> std::stof can throw std::out_of_range if the input is not actually
> representable. We had similar code in Skia which was using stof to
> test that a stringized float would round-trip successfully, and it
> would throw an exception on some older versions of libc++ for edge-
> case inputs like FLT_MIN.
>
> std::stof is documented as using strtof to do its conversion, so this
> shouldn't change your results in practice; it just removes the part
> where it could potentially throw for some inputs.
>
> Tangentially, have you ever seen a case where the scientific-notation
> path gets used? According to brucedawson@, nine digits should always
> safely round-trip (in 2013, testing gcc and MSVC). See
> https://randomascii.wordpress.com/2013/02/07/float-precision-revisited-nine-digit-float-portability/
>
> Change-Id: Ie215fb8502dd8c554020c6f73432f91e3d756563
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104500
> Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
> Auto-Submit: John Stiles <johnstiles@google.com>
> Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
> Commit-Queue: John Stiles <johnstiles@google.com>

TBR=dsinclair@chromium.org,johnstiles@google.com,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,dsinclair@google.com

Change-Id: I825f5677f98dea1a13b6423ec18ae3a1e750ce09
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104502
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2022-10-04 14:44:22 +00:00