Commit Graph

12513 Commits

Author SHA1 Message Date
Gregg Tavares 0bdf2da9b8 Compat: Reject CubeArrays via Validation
Bug: dawn:1825
Change-Id: I32917a479c3eea457c8f315cfc089351b64292b6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133320
Commit-Queue: Gregg Tavares <gman@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-24 12:39:46 +00:00
James Price 23c0451377 [ir] Add scalar type helpers to type::Manager
Creating scalar types is extremely common when using builders.

Bug: tint:1718
Change-Id: I2c2f0f521af1384bd8dee344ddfa525583535911
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/132284
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: James Price <jrprice@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2023-05-24 11:53:06 +00:00
jchen10 028726497a d3d11: enable MaxLimitTests
Bug: dawn:1705

Change-Id: I3f977913ed808db7a949a64fdb360a3c84e48d50
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133282
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-05-24 02:30:30 +00:00
Dawn Autoroller 6343f298fd Roll ANGLE from 98d6dd38ecb2 to 9e47cbd300ca (6 revisions)
98d6dd38ec..9e47cbd300

2023-05-23 mark@lunarg.com Capture/Replay: Rework trace EGLDisplay handling
2023-05-23 geofflang@chromium.org Metal: Disable Metal support on NVIDIA GPUs
2023-05-23 abdolrashidi@google.com Vulkan: Update last CRC check for pipeline cache
2023-05-23 geofflang@chromium.org Remove assertion in SyncEGL::onDestroy that the sync is valid
2023-05-23 lexa.knyazev@gmail.com Vulkan: Enable VK_EXT_depth_clamp_zero_one
2023-05-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dc49e5c6de1e to 8a3971e5e9c5 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I6b18ef352559193289a00982501df911c57217f0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134160
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-24 01:33:45 +00:00
dan sinclair 07a1d65fbc [ir] Cleanup composite creation in tests
This CL adds some helpers to make composites easier to use in tests.

Bug: tint:1718
Change-Id: I16a0e94978c43efa619b31b6815089c8fff6983f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133920
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: James Price <jrprice@google.com>
2023-05-24 00:27:17 +00:00
Shrek Shao 4e2be2d083 Suppress Mac AMD sample_mask CTS tests
Bug: dawn:1843
Change-Id: Id67f4d276143d625ae0ecf72b4b50a6bbdcf5af6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134121
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Shrek Shao <shrekshao@google.com>
2023-05-23 23:58:38 +00:00
Peng Huang 6197fd1468 d3d11: support FeatureLevel::Core if D3D11 FL 11.1 is supported
Bug: dawn:1820
Change-Id: Iba76d9aa519b555d10c6a9d6ffdf529268ac6737
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134080
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-05-23 23:53:03 +00:00
dawn-autoroll 89172687c1 Roll vulkan-deps from 8a3971e5e9c5 to 86f4f667c327 (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/8a3971e5e9c5..86f4f667c327

Changed dependencies:
* glslang: a5bf69936d..9fbc561947
* vulkan-validation-layers: 8f4fc4c98a..658e97b6ed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC shrekshao@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I2f71a0f4be28b30b341a4d8a28a4ebb31e6aec5d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134101
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-23 23:20:04 +00:00
dan sinclair c4722c2f0b [ir] Test cleanup
Add a builder helper function to create a `Function` with a
`string_view` name instead of requiring the creation of a symbol.

Bug: tint:1718
Change-Id: I5d85736b49719246cb31825c3f4ad7a25131cb77
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133900
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2023-05-23 22:28:33 +00:00
dan sinclair 68b4e6460f [ir] Dissolve the flow graph
The ir::Value objects each have a list of instructions in which their
used. These lists allow us to determine all the places the value is
used. Currently this is unable to track the usage of a value in an
`if` or `switch` condition. It is also unable to track the usage of a
value as a branch argument.

In order to facilitate this tracking, the flow graph has been resolved.
Branches are moved to branch instructions (and jump instructions). A
jump is walk continue branch. A branch is a walk terminating branch. The
`if`, `switch` and `loop` flow nodes are moved to instructions as well.

Bug: tint:1718
Change-Id: I8e4cc4688bb1bdd5c7eecc72d366e6531ec685b3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133840
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
2023-05-23 22:26:24 +00:00
Min Lee e9ee094d28 [dawn-test] On D3D12, limit the texels in a buffer to 1<<27
On D3D12, there is a limit of the number of texels in a buffer which is 1<<27. See D3D11_REQ_BUFFER_RESOURCE_TEXEL_COUNT_2_TO_EXP and the spec. This patch limits it according to the spec in case of D3D12 in MaxLimitTests.cpp. This fixes MaxLimitTests failure on Arm device.

Bug: dawn:884
Change-Id: Ia14ebca92855ec7b7e8d81b7bd547108948da567
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133961
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Min Lee <lemi@microsoft.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-23 20:57:17 +00:00
James Price 506b4f05d0 [spirv-reader] Use type inference for var and let
When an initializer is present, use type inference instead of
explicitly typing `var` and `let` declarations. This reduces the size
of the generated WGSL and improves readability.

Change-Id: I241ee2108279b550735945940f2b62bbbd493708
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/132142
Commit-Queue: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: James Price <jrprice@google.com>
Reviewed-by: David Neto <dneto@google.com>
2023-05-23 18:28:44 +00:00
Corentin Wallez 858ccc8a0c Make GetCurrentTextureView use an internal GetCurrentTexture
This is a small refactor in preparation for exposing GetCurrentTexture
on the SwapChain.

Bug: dawn:1551
Change-Id: I7cc8ec4a9042f48c4af7b2cc2126b1d9248a2003
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133462
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
2023-05-23 12:30:36 +00:00
Dawn Autoroller 26e41edeea Roll ANGLE from 3f633521356d to 98d6dd38ecb2 (1 revision)
3f63352135..98d6dd38ec

2023-05-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 853c619b8b56 to 33c4f6d48650 (640 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I67db4e98485cb4f63cc536603254a1de2b716892
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134003
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-23 12:05:19 +00:00
dawn-autoroll a3e197fba4 Roll vulkan-deps from 94da37147569 to 8a3971e5e9c5 (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/94da37147569..8a3971e5e9c5

Changed dependencies:
* vulkan-validation-layers: 5617da3b3b..8f4fc4c98a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC shrekshao@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I1c7521c5a73a6c2a335ce01fd22723b8e8cb3112
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133966
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-23 09:54:46 +00:00
Corentin Wallez deef739bb9 Remove suppression for a fixed VVL issue.
See https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/2256

Change-Id: I3fc05688f8b3ae365df5071b86796d8aceb14a30
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133461
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-05-23 09:40:17 +00:00
Corentin Wallez 2c89f5c5b7 Add ref release for webgpu.h
Change-Id: Id1a7baea8c77a98dab39bcf3449c9ec81df255b9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/70022
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-23 09:39:29 +00:00
Corentin Wallez 8d45d44905 webgpu.h: Add overridable (default empty) attributes to all types
See https://github.com/webgpu-native/webgpu-headers/issues/179

Also changes WGPU_NULLABLE instead of /* nullable */ and make a couple
formatting fixes.

Bug: None
Change-Id: Ieb4315cddd3c806144892221fba11888171f072f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133102
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2023-05-23 08:16:55 +00:00
Corentin Wallez 47245bc33f Remove wgpu::TextureUsage::Present
This is an internal usage only used for barriers management in some
backends, and doesn't need to be exposed publicly.

Fixed: dawn:1535
Change-Id: I0474977227230acbf7dd3cfa91bf589ffd9464fd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133460
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2023-05-23 08:16:01 +00:00
jchen10 7aed27a2b0 d3d11: enable PipelineLayoutTests
Bug: dawn:1705

Change-Id: I4b194b1471abfcfb1688c0e87b81c99b2ed8f42a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133283
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-05-23 06:42:42 +00:00
Austin Eng 40bf2a0110 Cleanup stale expectations.txt
Most now passing except for crbug.com/tint/1943

Bug: dawn:1107, tint:1943
Change-Id: Iaa19287e76b87826a34ff0ac1895b57c8ad1233d
Include-Ci-Only-Tests: true
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133963
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2023-05-23 05:17:20 +00:00
jchen10 cd1fb68767 d3d11: enable DynamicBufferOffsetTests
This binds UAV slots all together at the same time.

Bug: dawn:1816
Bug: dawn:1705

Change-Id: Iea7af9cf00caf126a3964cc43bbf2162b35f80e0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/132600
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2023-05-23 00:54:15 +00:00
Dawn Autoroller bfa1d3a870 Roll ANGLE from a4b1d12cd5ba to 3f633521356d (2 revisions)
a4b1d12cd5..3f63352135

2023-05-22 syoussefi@chromium.org Vulkan: Fix handling inactive unnamed I/O blocks in SPIR-V
2023-05-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3600ed906bb4 to dc49e5c6de1e (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I7fa886d18e182e3b14c77b86b561918fa4552977
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134002
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-22 22:40:25 +00:00
Austin Eng 731b4a6b48 Roll third_party/webgpu-cts/ 4fd26fe4a..b033a4f1a (8 commits)
Regenerated:
 - expectations.txt
 - ts_sources.txt
 - test_list.txt
 - cache_list.txt
 - resource_files.txt
 - webtest .html files


4fd26fe4ab..b033a4f1ae
 - b033a4 Fix floating_point AbsoluteErrorInterval unittests (#2616)
 - 5570bf Add more uniformity validation tests (#2597)
 - 7b9d28 Fix gruntfile generate-listings ordering (#2615)
 - 6ac65a Switch to using sparseF32Range in f32 arithmetic tests (#2614)
 - db412d Factor out and dedup 'validate' step of presubmit (#2608)
 - e218a9 Split up the matrix f32 arithmetic tests (#2606)
 - 7a56a9 Handle uncaught internal errors in device_pool (#2611)
 - 13476e Move texture format info to its own file (#2607)

Created with './tools/run cts roll'

Change-Id: I66d1da50d5913b95bee2f1a29fa45bb878a04d39
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134001
Kokoro: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2023-05-22 21:56:44 +00:00
dawn-autoroll 0e2834c559 Roll vulkan-deps from dc49e5c6de1e to 94da37147569 (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/dc49e5c6de1e..94da37147569

Changed dependencies:
* glslang: 9caca7a17b..a5bf69936d
* vulkan-loader: 35b005a579..b95d065ec5
* vulkan-tools: 695887a994..80b010b1e1
* vulkan-validation-layers: 1d74f4c7d1..5617da3b3b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC shrekshao@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I95b729079fafb914e7a61580adafb470baa32c1f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133962
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-22 20:27:45 +00:00
dan sinclair 0f203b1282 [ir] Cleanup deleted methods
Because of the CastableBase, the copy and move constructors and
assignment operators can't be used. They don't need to be explicitly
deleted.

Bug: tint:1718
Change-Id: Iafa000a00f779e1cac0aca8125330906ebd63446
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133660
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2023-05-22 16:48:42 +00:00
Yuly Novikov 29da93754e Revert "Add dawn-try-mac-intel-exp to CTS rolls"
This reverts commit a03e55d577.

Reason for revert: experiment finished

Original change's description:
> Add dawn-try-mac-intel-exp to CTS rolls
>
> We don't have CTS results for the associated CI bot.
>
> Change-Id: I3cfc62bd299e2c7bdb30fd0389f20159ab2f154e
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/132482
> Kokoro: Austin Eng <enga@chromium.org>
> Commit-Queue: Austin Eng <enga@chromium.org>
> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>

Change-Id: I7b83b73a50bda2a4596601e319a534bcc140d342
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134040
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-05-22 16:20:14 +00:00
Albin Bernhardsson dbaf032dc2 Fix more broken links in docs
The first patch missed some broken links. Also, the directory structure
has changed.

Change-Id: I44631e371896b74d8a4dc9dc2c942dee32ce5340
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134020
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Albin Bernhardsson <albin.bernhardsson@arm.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2023-05-22 15:16:39 +00:00
Dawn Autoroller 55e57b362b Roll ANGLE from c04ad8e025ee to a4b1d12cd5ba (1 revision)
c04ad8e025..a4b1d12cd5

2023-05-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from be870e411d55 to 853c619b8b56 (679 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,bajones@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bajones@google.com
Change-Id: Ic6952e0e8b7cadb99f869c69f8f34bde61bb60f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134000
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-22 09:14:03 +00:00
dawn-autoroll 26c77058ba Roll vulkan-deps from 2968842d10ac to dc49e5c6de1e (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/2968842d10ac..dc49e5c6de1e

Changed dependencies:
* vulkan-validation-layers: 96a3152dc9..1d74f4c7d1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bajones@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bajones@google.com
Change-Id: I99e77969beae08657cc82add63d4a77af50bbb5c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133960
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-22 06:55:05 +00:00
dawn-autoroll 30dc1b5abb Roll vulkan-deps from 44392282e953 to 2968842d10ac (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/44392282e953..2968842d10ac

Changed dependencies:
* vulkan-validation-layers: 28cd0024cb..96a3152dc9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bajones@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bajones@google.com
Change-Id: I1d3815e1c226423f88464f74d5b9ff7488519222
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133940
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-21 02:21:28 +00:00
Dawn Autoroller ec97bd0834 Roll ANGLE from ea0b1b7b0e04 to c04ad8e025ee (1 revision)
ea0b1b7b0e..c04ad8e025

2023-05-19 cnorthrop@google.com Tests: Add Honkai: Star Rail trace

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,bajones@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bajones@google.com
Change-Id: I7ab4e6b2673d3bb224a690592cd7688b418d7314
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133804
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-20 13:22:25 +00:00
dawn-autoroll 7ccfd85574 Roll vulkan-deps from 303074feac15 to 44392282e953 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/303074feac15..44392282e953

Changed dependencies:
* vulkan-validation-layers: eceb65d562..28cd0024cb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bajones@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bajones@google.com
Change-Id: If1cde62cd8d71fcee7abf92614f231f7e32b9462
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133570
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-20 12:40:40 +00:00
Dawn Autoroller eacbbc9e55 Roll ANGLE from c9029ddff73f to ea0b1b7b0e04 (7 revisions)
c9029ddff7..ea0b1b7b0e

2023-05-19 hob@chromium.org Selectively advertise base vertex and instance fns
2023-05-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from a46ca6e9c7bb to f7a3350256a6 (1 revision)
2023-05-19 romanl@google.com Add ci/linux-trace disabling logic to ANGLE script
2023-05-19 ynovikov@chromium.org Stop ANGLE Mac Intel 13.3 experiment
2023-05-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 876d164bd88a to a46ca6e9c7bb (7 revisions)
2023-05-19 romanl@google.com Print signal to stdout before calling crash handler
2023-05-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e7ec2c32c984 to 3600ed906bb4 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,bajones@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bajones@google.com
Change-Id: Ic01ac5d646fd84be0e26570aa1dc559bece05997
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133803
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-19 23:49:32 +00:00
Peng Huang 956a2fc780 d3d11: fix ASSERT() crash in d3d11::BindGroupTracker::unApplyNindGroup()
Bug: dawn:1705
Change-Id: I87d464c5321375a96aa4926a0968e6acab7194e4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133760
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-05-19 23:21:44 +00:00
dawn-autoroll 3d3584793b Roll vulkan-deps from 3600ed906bb4 to 303074feac15 (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/3600ed906bb4..303074feac15

Changed dependencies:
* glslang: d1517d64cf..9caca7a17b
* spirv-cross: 28b11e010a..12542fc6fc
* vulkan-tools: fec27a3f6e..695887a994
* vulkan-validation-layers: 84788d43ee..eceb65d562

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bajones@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bajones@google.com
Change-Id: I380fa7d27db11b92fa8ca7da088604742231d44b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133860
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-19 23:16:27 +00:00
Austin Eng 56ccf40666 Remove KEEP tags and Slow expectations
Mac arm64 is now part of CTS rolls
Slow expectations now live in slow_tests.txt

Bug: chromium:1442214
Bug: dawn:1832
Change-Id: If839fc7bffdd0fe4be01373d082ce56b3e1481cf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133821
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Austin Eng <enga@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-19 21:41:55 +00:00
Peng Huang 919d48fda4 d3d11: Add GetD3D11Device() for querying ID3D11Device from WGPUDevice
Chrome needs to get a ID3D11Device for DComp

Bug: dawn:1705
Change-Id: Ia6a586a38f381b7fddcbc94fe41a7011af59b333
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133780
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-05-19 21:41:33 +00:00
Peng Huang ba073b7e09 d3d11: add Feature DepthClipControl and Depth32FloatStencil8
Bug: dawn:1705
Change-Id: I5a1cec55a261ca01329f24af882b8501260ce0fc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133740
Commit-Queue: Peng Huang <penghuang@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-05-19 21:41:23 +00:00
Austin Eng beb31d4611 Add Mac arm64 to CTS roll config
Bug: chromium:1442214
Change-Id: I3d0bcdb715f51213ccde0c3b23f5739be72be41b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133820
Kokoro: Kokoro <noreply+kokoro@google.com>
Kokoro: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2023-05-19 21:36:44 +00:00
Corentin Wallez 047bca4306 dawn.json: add tags to not expose Dawn-specificities upstream.
Bug: None
Change-Id: Idfda83227dbc6958f49d824d593026b9fc6d78c0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133101
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
2023-05-19 19:17:22 +00:00
vikas soni 70f9becc0d Revert "Suppress WebGPU tests flaky on Mac"
This reverts commit 8a224f6d04.

Reason for revert: Fix landed

Original change's description:
> Suppress WebGPU tests flaky on Mac
>
> webgpu:api,validation,render_pipeline,fragment_state:targets_format_renderable:isAsync=true;format="rg8uint"
> webgpu:api,validation,render_pipeline,vertex_state:vertex_attribute_offset_alignment:*
>
> Bug: chromium:1444865
> Change-Id: Ifadf8dd376198947589fa1de7b6dd33a5986ee38
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133380
> Commit-Queue: Austin Eng <enga@chromium.org>
> Kokoro: Austin Eng <enga@chromium.org>
> Reviewed-by: Austin Eng <enga@chromium.org>
> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>

TBR=enga@chromium.org,ynovikov@chromium.org,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I03b3a794bb03d0753d9050d0196b6c5509f03c2f
Bug: chromium:1444865
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133361
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
2023-05-19 18:48:24 +00:00
Austin Eng 74dcafc17b Add a slow_tests.txt file
This file should hold all Slow expectations.
Overlaps here are allowed.

Bug: dawn:1832
Change-Id: I69b4e53614d9eeed68315b127f2d37ed76b00026
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133565
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2023-05-19 15:35:38 +00:00
Ben Clayton 7b2dbeb634 [tint][GN]: wrap all IR rules in 'if (tint_build_ir)'
Change-Id: Idc75849e337c9436e8a74a9abdb61f71d9370293
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133700
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-19 12:00:39 +00:00
Dawn Autoroller ced1cf33ce Roll ANGLE from d238e8b97df5 to c9029ddff73f (5 revisions)
d238e8b97d..c9029ddff7

2023-05-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bc320a94824d to be870e411d55 (839 revisions)
2023-05-19 chris@rive.app Allow glDelete* while PLS is active
2023-05-19 syoussefi@chromium.org Vulkan: Separate image and sampler 2D view of 3D features
2023-05-18 mark@lunarg.com Revert "Don't export ANGLE platform methods."
2023-05-18 syoussefi@chromium.org Vulkan: Enable VK_EXT_image_2d_view_of_3d and set flag

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,bajones@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bajones@google.com
Change-Id: Icadb931adb9cd8633a5d0238ee9ea0203c3dcfd5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133569
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-19 10:27:55 +00:00
dawn-autoroll 189e781236 Roll vulkan-deps from b6677ac099fd to 3600ed906bb4 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/b6677ac099fd..3600ed906bb4

Changed dependencies:
* vulkan-loader: 823209c89e..35b005a579

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bajones@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bajones@google.com
Change-Id: I44ef0246076ccc27afc8bd26a4b496c55f18953e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133568
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-19 09:47:27 +00:00
Li Hao d3875fc9b6 Add workaround for resolving overlapping queries on Intel Gen12
TimestampQueryTests.ResolveTwiceToSameBuffer fails on Mesa driver >=
21.2.0 and D3D driver >= 31.0.101.3413 on Intel Gen12 GPUs due to driver
bugs with different root causes, but the workaround of clearing
destination buffer before resolving queries works for both.

Bug: dawn:1546, dawn:1823

Change-Id: I3f20a9100f4b6d3386e9685b351ad4fed69195bd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133284
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Hao Li <hao.x.li@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-19 08:07:40 +00:00
Austin Eng 34fd751bd7 Fix namespacing of DynamicLib.cpp
`namespace dawn {` was written before some #includes

Bug: dawn:302
Change-Id: I1f0e507f63cc47b180d2021cf859d7964cfa4613
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133622
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@google.com>
Kokoro: Austin Eng <enga@chromium.org>
2023-05-19 01:25:37 +00:00
Austin Eng 5107db5637 Add DAWN_DEBUG_BREAK_ON_ERROR environment var and debugging docs
DAWN_DEBUG_BREAK_ON_ERROR executes dawn::BreakPoint inside
ErrorData::Create so that an application can inspect their callstack
immediately when an error is generated.

Bug: dawn:1789
Change-Id: I3f31b9713414d31b69ed469474e0f3c0f714540a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133562
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-18 23:29:25 +00:00
dan sinclair 24cb81116d [ir] Shift back to accessors.
Some of the IR classes require setters in order to update dependant
information. In order to keep the IR access symmetrical this CL moves
the IR back to using accessors and private fields.

Bug: tint:1718
Change-Id: I101edda004671e07c4594bdcae4b1576e5771782
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/133640
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-05-18 22:16:08 +00:00