Commit Graph

206 Commits

Author SHA1 Message Date
Ben Clayton 7fe75f4a68 expectations.txt: Remove inputSource="const" [ Skip ] expectations
The new heartbeat logic can now detect that these are just slow, and no longer trigger the timeout failures.

Fixed: tint:1613
Change-Id: I2e29b0e2b7002f29984841ed4f421ec6e47be83f
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102960
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-20 20:34:04 +00:00
Austin Eng 21920ec7f7 Remove most of the Slow test expectations
Change-Id: I31a1cedd36fd755aa226c3e03d3bdc81702f2653
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102821
Auto-Submit: Austin Eng <enga@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-09-20 09:41:31 +00:00
Ben Clayton 4f8ed34b94 Roll third_party/webgpu-cts/ dec4d77ee..0fee76f32 (3 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


dec4d77ee3..0fee76f32e
 - 0fee76 Overrides: add operation tests for compute pipeline ()
 - 120c34 Add the buffer_dynamic_offsets test to setBindGroup.spec.ts ()
 - fc6864 Add pipeline overridable constants validation tests ()

Created with './tools/run cts roll'

Change-Id: I31e8afdfdb5fcfbf55682f69b67af1e2ca78d247
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102643
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-19 15:00:01 +00:00
Ben Clayton aad2e9c0b5 tools/cts: Add `cts validate`, improvements & fixes
• Add `cts validate` command used to check for expectation collisions.
  Can be used as a presubmit check.
  This is more tightly checked than the previous logic, as this works on just
  the expectations, instead of results.

• Fix an issue where the test result reduction could introduce collisions with
  'Skip' expectations.
  To fix this, the update process first adds 'consumed' results for the skipped
  tests, preventing test tree reduction for that part of the tree.

• Fix a bug in the generation of 'New failures' and 'New flakes' which produced
  more expectations than was necessary.
  The issue here was that the tree roots could contain overlaps, and roots could
  be processed before sub-trees, resulting in inefficient expectations.

• Fix collisions in the expectations file, and update with results from
  the most recent roll.

Change-Id: I7b64553408998fb4416458ce564fc49c8f6d4d07
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101860
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-17 19:30:29 +00:00
Austin Eng 91fc1fd57e Roll third_party/webgpu-cts/ 5e70787c4..dec4d77ee (6 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


5e70787c4d..dec4d77ee3
 - dec4d7 Implement `normalize` f32 tests ()
 - 691143 not_lost_on_gc: use assertNotSettledWithinTime instead of raceWithRejectOnTimeout ()
 - 087838 fix dev server for float16.js ()
 - 372985 Add 'buffer,resource_binding_size' to createBindGroup.spec.ts ()
 - 399c52 Add RENDER_ATTACHMENT usage in createBindGroup:multisampled_validation:* ()
 - d33144 Fix f16 hex literal testcases of having suffix "h" without "p" ()

Created with './tools/run cts roll'

Change-Id: Iaaf8882e9acfe7612c060cf1f81b2c4b52b9733c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102600
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Shrek Shao <shrekshao@google.com>
2022-09-16 20:37:58 +00:00
Austin Eng 505e1a9368 Revert "Make it invalid to use sampleType "float" with multisampled textures"
This reverts commit 9b2f273d36.

Reason for revert: Breaking change needs deprecation period.

Original change's description:
> Make it invalid to use sampleType "float" with multisampled textures
>
> Fixed: dawn:1540
> Change-Id: I31f197d802c20ed7e6ef2ae00d4e107ab6f94278
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102420
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Austin Eng <enga@chromium.org>

TBR=cwallez@chromium.org,enga@chromium.org,shrekshao@google.com,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I5ac4b5691b0c4fb0ce76223c1997855e1b3485f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102500
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-09-16 01:14:28 +00:00
Jiawei Shao 233d64066c Make the validation on inter-stage shader variables match latest WebGPU SPEC
This patch updates the validations on the inter-stage shader variables to
match the latest WebGPU SPEC (in chapter "validating-inter-stage-interfaces").

With this patch the below validation tests in WebGPU CTS will pass:
- render_pipeline,inter_stage:max_shader_variable_location:*
- render_pipeline,inter_stage:max_components_count,*

Fixed: dawn:1448
Test: dawn_unittests
Change-Id: I3e4d98f03ec18e5d1642a4d7ecd3eed1b7ae04d0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102104
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-16 00:30:38 +00:00
Austin Eng 9b2f273d36 Make it invalid to use sampleType "float" with multisampled textures
Fixed: dawn:1540
Change-Id: I31f197d802c20ed7e6ef2ae00d4e107ab6f94278
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102420
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-15 23:03:38 +00:00
Jiawei Shao ee1996ba9e Enable validation tests about createBindGroupLayout:storage_texture,*
This patch enables the below validation tests in WebGPU CTS after a
fix in chromium:

- webgpu:api,validation,createBindGroupLayout:storage_texture,*
- webgpu:api,validation,createBindGroupLayout:visibility,
  VERTEX_shader_stage_storage_texture_access:*

Fixed: chromium:1363484
Change-Id: If23dc242f0c38dec4e11de0fd8434ab32e0822f9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102341
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-09-15 14:07:49 +00:00
Austin Eng a659937918 Roll third_party/webgpu-cts/ a6451cc67..5e70787c4 (7 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files

a6451cc673..5e70787c4d
 - 5e7078 Add global option noRaceWithRejectOnTimeout ()
 - cf51bc Add a 'storage_texture,format' test to createBindGroup.spec.ts ()
 - 446c22 Fix type error when trying to .writeBuffer a Float16Array ()
 - a0408e shader/execution: Add heartbeats to expression tests
 - 3c579b Add `length` F32 tests ()
 - fee036 Make `make*ToF32IntervalCase`s more idiomatic ()
 - a20c0a Implement `quantizeToF16` f32 tests ()

Created with './tools/run cts roll'

Change-Id: I98bb79ac57585a5b57d3e4303bd7a2c4ca576598
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102150
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-09-14 16:01:37 +00:00
Yan,Shaobo 876bd3bf87 Enable external_texture/* cts
Change-Id: Ieb153292c78ea8197b4309d796d352ce820646d1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99241
Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-14 01:09:42 +00:00
Austin Eng ddc53ea856 Update expectations in preparation for removing --retry-limit=3
Ensure that all actually known flaky tests are marked RetryOnFailure.
Generated with some manual changes, then `./tools/run cts update`
pointing at the Chromium CL to disable retries.

Bug: chromium:1343969, chromium:1344876, chromium:1359106, dawn:1500
Change-Id: Ia92a83e55bd64f39ecd8ff1be194dca95febd9bb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101801
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-09 22:37:19 +00:00
Ben Clayton 1524d9e1bf Roll third_party/webgpu-cts/ 27dc745ca..a6451cc67 (19 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


27dc745ca1..a6451cc673
 - a6451c Update 'buffer,usage' test in createBindGroup.spec.ts ()
 - 0007e6 Add 'buffer,resource_offset' to createBindGroup.spec.ts ()
 - a40f43 shader/execution: Fix shader creation errors ()
 - 25c9f4 Add 'buffer,usage' test to createBindGroup.spec.ts ()
 - 888ada slightly broaden/simplify pipeline_output_targets ()
 - 708441 test ~all cases of pipeline_output_targets,blend ()
 - 399cd2 Fix a wrong bit operation to decide the validation in indirect_dispatch_buffer,usage ()
 - 73c9e8 Add storage_texture,mip_level_count test to createBindGroup.spec.ts ()
 - 65fdb8 Minor clean up in life_of.md ()
 - e53aff Add storage_texture,usage test to createVindGroup.spec.ts ()
 - 39f597 Add `smoothstep` F32 Tests ()
 - e97d14 Add tests to fullI32Range ()
 - 7c4e02 Remove old implementation of correctlyRounded ()
 - e93c41 Add 'multisampled_validation' test to createBindGroup.spec.ts ()
 - cc7a40 Use trackForCleanup() for dst texture in copyToTexture cases ()
 - 3c353f Adds remaining adapter.requestDevice tests. ()
 - fd9cf4 Implement 'texture_buffer_usage' test to buffer_texture_copies.spec.ts ()
 - f7f601 Add RENDER_ATTACHMENT usage when creating multisampled textures ()
 - 63c716 Add 'texture_buffer_usage' test to buffer_texture_copies.spec.ts ()

Created with './tools/run cts roll'

Change-Id: I608a519f30d75d18efd9edb6b1ece61e856ac2f5
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101681
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-09 16:14:19 +00:00
Corentin Wallez aa93cb8d5a Suppress tests failing to due VVL error on depthStencilReadOnly
Bug: dawn:1512
Change-Id: Id0b281735604dbb226893d05879af5417e15a672
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101120
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-08 17:23:46 +00:00
Ben Clayton d7f9836a30 cts: Remove collisions in expectations.txt
Change-Id: I854c975650ec471466467fe47797242016f81f1f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101580
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-08 01:09:04 +00:00
Austin Eng 183c87e4f6 Mark error scope stackDepth=100000 tests as slow
These tests regularly take 7+ seconds to complete due to their size

Change-Id: I5ee554610275ed68f4eab7a821c4278a2c478595
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100820
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-08-31 03:25:18 +00:00
Loko Kung 79334fedce Manual cleanup of CTS expectations.
Change-Id: I4ce31d6cadd4506385d39b4754347fa4838ea757
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100501
Auto-Submit: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-08-27 04:27:18 +00:00
Austin Eng a993e1913e Roll third_party/webgpu-cts/ c0c5cce30..27dc745ca (20 commits)
c0c5cce305..27dc745ca1

$ git log c0c5cce30..27dc745ca --date=short --no-merges --format='%ad %ae %s'
2022-08-26 gyuyoung Add sample_count test to buffer_texture_copies.spec.ts ()
2022-08-26 gyuyoung Implement 'texture,device_mismatch' test in writeTexture.spec.ts ()
2022-08-26 gyuyoung Add 'maximum_binding_limit' test to createBindGroupLayout.spec.ts ()
2022-08-25 enga Add global test config ()
2022-08-25 enga Mark root .eslintrc.json as "root: true" ()
2022-08-25 bajones Address Kai's feedback
2022-08-24 tojiro Style fixes
2022-08-24 tojiro Refactor image_copy and unified data generator between the two test files.
2022-08-23 bajones Optimizing GetInitialData function
2022-08-25 kainino fix merge error
2022-08-25 rharrison Clarify comments in ULP code ()
2022-08-23 kainino tweak to make safer against accidental awaits
2022-08-23 bclayton webgpu/shader/execution: Check validation before testing results
2022-08-24 rharrison Linearly spread `f32FullRange` values over possible f32 values ()
2022-08-24 rharrison Implement `remainder (%)` f32 test ()
2022-08-24 rharrison Rename `make*F32IntervalCase` to `make*ToF32IntervalCase` ()
2022-08-24 zhaoming.jiang Revert "Use let declarations for literal input in shader,execution,expression tests ()" ()
2022-08-24 zhaoming.jiang Use let declarations for literal input in shader,execution,expression tests ()
2022-08-24 gyuyoung Add storage_texture,formats test to createBindGroupLayout.spec.ts ()
2022-08-23 rharrison Refactor binary arithmetic tests to use common test values ()

Change-Id: I75a810698616f74d02480ccee369564030aa4a32
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100462
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
2022-08-26 19:48:25 +00:00
Ben Clayton 98d7eb4009 Roll third_party/webgpu-cts/ e204a3c37..c0c5cce30 (7 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


e204a3c377..c0c5cce305
 - c0c5cc Remove pushing lists of numbers through Set to guarantee uniqueness ()
 - 3d958d wgsl: Replace module-scope 'let' with 'const' ()
 - 4827c0 Add storage_texture,layout_dimension test to createBindGroupLayout.spec.ts ()
 - dcdeec Add visibility,VERTEX_shader_stage_storage_texture_access test to createBindGroupLayout.spec.ts ()
 - f4db91 Make F32Interval unittests more idiomatic ()
 - d82d4e Updates error scope tests and remove outdated README. ()
 - f102e6 Add brackets to robust buffer access test.

Created with './tools/run cts roll'

Change-Id: Ib5ca02d41a7638c06361e8e33b23f1ceb32db884
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100200
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-08-24 15:24:45 +00:00
Ben Clayton bace05e499 Roll third_party/webgpu-cts/ ed11c6ba3..e204a3c37 (24 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


ed11c6ba35..e204a3c377
 - e204a3 Add visibility,VERTEX_shader_stage_buffer_type test to createBindGroupLayout.spec.ts ()
 - 2d7291 Change sourceOrigin in GPUImageCopyTexture from 3D to 2D ()
 - fef5f1 Fix f16 and u32 testcases in webgpu:shader,validation,parse,literal:* ()
 - 32bacf Add timestamp_query_set,device_mismatch test to beginRenderPass tests ()
 - c48887 Add _mimeType for input videos in external_texture cases ()
 - 8bd50a Use common `sparseF32Range` instead of defining it multiple different places ()
 - 4e8df0 Add timestamp_query_set,device_mismatch test to beginComputePass tests ()
 - 168bc9 Refactor *SubnormalNumber functions to not depends on *SubnormalScalar functions ()
 - 581498 Implementing dot f32 tests ()
 - 30e9e0 Add indirect_dispatch_buffer,usage validation test ()
 - dd0150 Update compositingAlphaMode -> alphaMode ()
 - 8a9afc Add a query_set_type test to beginComputePass tests ()
 - 19aecd Track all the resources with trackForCleanup in copy and resource ini… ()
 - 147d16 Add more texture usages to image_copy,texture_related:usage test ()
 - 78ba78 Add beginComputePass validation test ()
 - 2fe73f Implement `asinh` f32 tests ()
 - 727a39 Implement `atanh` f32 tests ()
 - e1795b Implement `acosh` f32 tests ()
 - 583eaa Implementat `tanh` f32 tests ()
 - b36ce1 Use containerss for alternate interval generators ()
 - 242105 Update val:CopyExternalImageToTexture:OOB,source ()
 - 40e52d upgrade typescript to 4.7.4 ()
 - 2c9134 Implement GPURenderPassDescriptor.maxDrawCount test ()
 - 05b229 Add 'VideoFrame' in 'SourceType' for external_texture cts ()

Created with './tools/run cts roll'

Change-Id: Ib8bb7e412fd597ed7d56c493b40a227223f23765
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100040
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-08-23 13:32:24 +00:00
Austin Eng 9de123fc85 Suppress Win Intel x86 tests failing after parallelization disabled
These tests used to be flaky, and now fail consistently after jobs
is set to 1 instead of 4. Suppressing so parallelization can be
disabled to make test results more consistent.

Bug: chromium:1353938
Change-Id: Ia99445ddd43d55d7ac3f67dd8e177b0fd34d51f3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99762
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-08-19 05:36:21 +00:00
Loko Kung 8812809ea7 Roll third_party/webgpu-cts/ 94fd83896..ed11c6ba3 (3 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files

94fd83896c..ed11c6ba35
 - ed11c6 Implement `cosh` f32 tests ()
 - 3fac1b Implement `sinh` f32 tests ()
 - d36896 Implement `sqrt` f32 tests ()

Created with './tools/run cts roll'

Change-Id: I6604dc66ea7d7d43fb441f3f0092e7afd746266f
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98360
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
2022-08-09 18:29:22 +00:00
Loko Kung eaca2ebd4c Update cts expectations to be sorted by bug first.
- Run format on the current expectations file to make it up to date.
- It's a lot easier to read the failures when they are grouped by the bug.

Change-Id: I333a0b237ccd405d204e47809eb7ab723824fddd
No-Try: True
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98241
Auto-Submit: Loko Kung <lokokung@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
2022-08-09 16:40:32 +00:00
Alexis Hetu c8f03f9f99 Remove unused "swiftshader-gl" tag
This is a follow-up of the chromium side cleanup here:
https://chromium-review.googlesource.com/c/chromium/src/+/3799192

Bug: chromium:1099959
Change-Id: I6cd442d8512afe6b845c1f1e6d06406ed27d61db
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98261
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-08-07 11:21:00 +00:00
Austin Eng c20fa4eae5 Triage some entries in expectations.txt
Change-Id: I51db1f499db3037a0ff572434efd141610dd0542
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98066
Commit-Queue: Austin Eng <enga@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-08-04 03:39:07 +00:00
Loko Kung e40bd8e964 Suppresses failing CTS tests for tint:1632
Bug: tint:1632
Change-Id: Ic21ce0e401a4af2f7b3aebc6d1823fad7e3b9643
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98067
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-03 22:06:36 +00:00
Li Hao e37f0a1943 cts: Use intel-gen-9 instead of intel-hd-630-family tag
There are many devices in Intel HD630 family, we cannot enumerate all
their device ids in the tag. We want cts to run as expected on other
Intel devices of the same architecture, add generation-based tag
intel-gen-9 to include a broad range of devices in the expectations.

Bug: dawn:1444
Change-Id: I80b6ae64ea2efc41bcc68e1c917919a86ec87f44
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97760
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-02 17:32:44 +00:00
Loko Kung cbadf96e79 Roll third_party/webgpu-cts/ 65130c197..94fd83896 (9 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


65130c1970..94fd83896c
 - 94fd83 Expand readbackFromWebGPUCanvas test with alphaMode ()
 - 7af1f6 Implement `mix` f32 tests ()
 - 3fefce Validate a shader without an entry point is valid. ()
 - 3dc2fe Add non-entrypoint tests to the builtin validation. ()
 - 573361 Add test to validate parsing of `@builtin` ()
 - c660f5 Trailing comma in `@align` should be valid. ()
 - d1c579 Add test to allow builtin values as identifiers ()
 - bab564 Implement `trunc` f32 tests ()
 - 8fd9d5 Add `frag_depth` builtin validation. ()

Created with './tools/run cts roll'

Change-Id: I55c38e9b2b32f6fdebd3d7d9fc5d29ef8f8054ee
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97862
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-02 00:49:14 +00:00
Ben Clayton 271ba0edb3 Roll third_party/webgpu-cts/ e88fcf99d..65130c197 (8 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


e88fcf99da..65130c1970
 - 65130c shader/execution: Optimize "const" shader exeuction
 - c8964b Implement `round` f32 tests ()
 - 62ea12 Implement `step` f32 tests ()
 - f2ab44 Implement `sign` f32 tests ()
 - 8fed55 Implement `saturate` f32 tests ()
 - 0eee5f Implement f32 `radians` tests ()
 - a37fad Add WebCodec VideoFrame as input source for GPUExternalTexture cases ()
 - 41f838 Add validation tests for @align. ()

Created with './tools/run cts roll'

Change-Id: I3d16fefab8f70e858284792fb127a8e4ea673363
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97580
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-28 19:43:01 +00:00
Yuly Novikov 7e33dcba5b Remove Linux Intel suppressions fixed in Mesa 20.0.8
Bug: dawn:1111, dawn:1050
Change-Id: If3036921655abca967ed2793b03982dfb1b815b0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97100
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-07-25 17:04:28 +00:00
Ben Clayton f122fd52a8 Roll third_party/webgpu-cts/ 72e3a2249..e88fcf99d (3 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


72e3a22491..e88fcf99da
 - e88fcf Implement val:queue,writeTexture:sample_count ()
 - 75268b Implement val:queue,writeTexture:texture_state ()
 - c4eb1d Fix testing of the offset in image_copy,layout_related:required_bytes_in_copy ()

Created with './tools/run cts roll'

Change-Id: Ic1986bfac317aabfb623213bbc84dc3c38cd9a2a
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97001
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-23 00:21:26 +00:00
Yuly Novikov 9ec7893ad4 Follow up on Roll third_party/webgpu-cts/ a41bc407a..72e3a2249
1. Restore Optiplex 7080 Linux in the suppressions removed in
   https://dawn-review.googlesource.com/c/dawn/+/96880
2. Generalize depth_clip_clamp suppressions, since other combinations
   fail on Intel UHD 630 bot, see:
https://luci-milo.appspot.com/ui/p/chromium/builders/ci/Dawn%20Linux%20x64%20Release%20(Intel%20UHD%20630)/764/overview

Change-Id: Ia88d2c9903180db7c5ce7d6b366cfc6e6b2135d0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97000
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-07-22 15:55:56 +00:00
Kai Ninomiya 5f5bd214f7 Roll third_party/webgpu-cts/ a41bc407a..72e3a2249 (15 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


a41bc407a8..72e3a22491
 - 72e3a2 Expand map_detach test for buffer should detach on device.destroy ()
 - d5e662 Enhance val:render_pass_descriptor:depth_stencil_attachment_depth_clear_value ()
 - 12b775 Implement val:CopyExternalImageToTexture,destination_texture,dimension ()
 - 2834ce Add an out-of-range check to the ranges test in writeBuffer.spec.ts ()
 - bee493 Implement val:queue:writeTexture:usage ()
 - ea0057 Add GPURenderPassDescriptor.maxDrawCount test plan ()
 - d30940 Generate full range of `atan2` cases ()
 - 5b9641 Correct the order of params in atan2 message ()
 - 228c28 Implement f32 `degrees` tests ()
 - 4786c2 Remove obsolete f32 testing infrastructure ()
 - 8e1167 Add f32 tests for `pow` ()
 - aa0719 Make `render_pass_descriptor:resolveTarget,usage` test a valid case together ()
 - 6dfee4 Submit all shader batches before checking for results
 - bbd744 Convert `ldexp` tests to use interval framework ()
 - 9d3043 Update f32 tests to handle returning undefined for infinity ()

Created with './tools/run cts roll'

Change-Id: Ibdf6a28ea84e2115103c9c9637b3e648a62b8364
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96880
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-22 01:13:15 +00:00
Austin Eng 8d73198aca Remove depth-clamping and add depth-clip-control feature
Fixed: dawn:1178
Change-Id: I251a7e05fec9ecef44300d4f948b2d0611888109
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96320
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-18 20:38:05 +00:00
Yuly Novikov cd74244614 Follow up on Roll third_party/webgpu-cts/ 8cfc317e2..a41bc407a
Include Optiplex 7080 Linux in the suppressions added in
https://dawn-review.googlesource.com/c/dawn/+/96200

Change-Id: I8f99da7e6e42b675b40e200f0c668e638e2238f2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96402
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-18 14:06:42 +00:00
Austin Eng 30d672963c Skip CTS tests crashing with SwiftShader
Some web_platform:* tests are crashing due to issues with SharedImage
and canvas formats.

Bug: chromium:1344876
Change-Id: I0a708bad15b3d19299ce614ad43ab58c888e5291
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96300
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-07-15 19:12:29 +00:00
Ben Clayton e21267fe94 Roll third_party/webgpu-cts/ 8cfc317e2..a41bc407a (23 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


8cfc317e23..a41bc407a8
 - a41bc4 Implement val:render_pass_descriptor:timestampWrite,same_query_index ()
 - 167076 Implement val:render_pass_descriptor:timestamp_writes_query_set_type ()
 - 06954d Implement val:render_pass_descriptor:timestampWrite,query_index ()
 - deec4f Implement val:render_pass_descriptor:occlusion_query_set_type ()
 - 3bef26 Succinct the test names of render_pass_descriptor.spec.ts (3/3) ()
 - 425fc8 Convert `clamp` f32 tests to use interval framework ()
 - 46fce2 Add support for multiple intervals to FP testing framework ()
 - 09c7fb Address feedback from Kai
 - f803ff Add context configuration tests
 - d620a1 Address feedback from Kai
 - 77633d Add tests for getCurrentTexture and getPreferredCanvasFormat
 - 781ad8 Succinct the test names of render_pass_descriptor.spec.ts (2/n) ()
 - d7ca02 Implement val:render_pass_descriptor:timestamp_writes_location ()
 - 09793f Test zero levels or layers is invalid in render_pass,resolve:resolve_attachment ()
 - daf0da Split shader_stages_and_visibility and add control cases
 - 496182 Rewrite usage validation scope tests
 - f4e9a3 refactor: split out makeConflictingBindGroups from testValidationScope
 - bc278d nits: simplify a few things in this file
 - a65914 Implement val:render_pass_descriptor:depth_stencil_attachment_depth_clear_value ()
 - a6bab7 Implement api,validation,capability_checks,features,texture_formats:canvas_configuration_view_formats ()
 - e7f8fe Succinct the test names of render_pass_descriptor.spec.ts (1/n) ()
 - 7f3683 Convert `fract` tests to use interval framework ()
 - d8009f Correct logInterval & log2Interval handling of out of bounds inputs ()

Created with './tools/run cts roll'

Change-Id: I10d895c4a11252317619f7ea480c97d821cbf81c
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96200
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
2022-07-15 16:25:39 +00:00
Ben Clayton e1bcb0b416 cts: Clean up expectations.txt
• Add `intel-hd-630-family` to the list of GPU tags (crbug.com/dawn/1444).
• `[ Skip ]` all the `inputSource="const"` expression tests for now (crbug.com/tint/1613).
• Reorder / normalize the rest of the expectations with `./tools/run cts update`.

Bug: dawn:1444
Bug: tint:1613
Change-Id: I39efc454ecff6e804417bcade744a4251acbda07
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95842
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-07-14 09:54:11 +00:00
Yuly Novikov 9fecd7ef8a Suppress WebGPU CTS failures on Linux UHD630
webgpu:shader,execution,expression,call,builtin,abs:f32:inputSource="const";*
webgpu:shader,execution,expression,call,builtin,atan:f32:inputSource="const";*
webgpu:shader,execution,expression,call,builtin,clamp:f32:inputSource="const";*

Bug: tint:1612
Change-Id: I3151cb02142f4a7b38d1f419bd5c49e981dce3a3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96103
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-07-13 18:49:10 +00:00
Dan Sinclair caead5d3a5 Roll third_party/webgpu-cts/ 5de908c54..8cfc317e2 (1 commit)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


5de908c54a..8cfc317e23
 - 8cfc31 Seperate out interval operation definitions from builder functions ()

Created with './tools/run cts roll'

Change-Id: Iddda2eebb44375a83f697b22f4969911f0944fcc
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95661
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2022-07-06 18:01:40 +00:00
Dan Sinclair c1f9e47a9b Roll third_party/webgpu-cts/ 7334f06d2..6c0f3bab4 (11 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


7334f06d2b..6c0f3bab40
 - 6c0f3b Update the descriptions of the tests of in_pass_encoder.spec.ts ()
 - 7c96bd Fix an arithmitic error in memcpy
 - 6121d9 Address feedback from Austin
 - 145914 Optimized several expensive methods texture tests
 - dd6ecd Adjust skip criteria based on suggestion from Austin
 - a5c733 Guard against writeTimestamp() calls without the proper feature
 - 85f975 Describe each test of the validation tests in render|compute pass encoder ()
 - 0bf125 Convert `min` tests to use interval framework ()
 - 88a46e Convert multiplication tests to use interval framework ()
 - 2379b9 Convert division tests to use interval framework ()
 - 7cdef8 Convert `max` tests to use interval framework ()

Created with './tools/run cts roll'

Change-Id: Ife3d6b89275ad66887d037aa4c66b385b2e1acbc
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95480
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2022-07-05 21:20:42 +00:00
Zhaoming Jiang 531ce3fe53 CTS: Update expectation for non-ASCII entry point name
Remove failure expectation of entry_point_name_must_match CTS tests that
test non-ASCII entry point name. The fix CL is landed at
https://chromium-review.googlesource.com/c/chromium/src/+/3732308.

Bug: dawn:1474
Change-Id: Ib3379083696040aa3e6e8eb11fd12b9e0b26cc93
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95321
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
2022-07-01 15:58:40 +00:00
Austin Eng 959a7696d9 Roll third_party/webgpu-cts/ cef4c7678..7334f06d2 (18 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files

https: //chromium.googlesource.com/external/github.com/gpuweb/cts/+log/cef4c7678130..7334f06d2b28
 - 7334f0 Convert `atan2` tests to use interval framework ()
 - 31b648 Convert addition tests to use interval framework ()
 - 4be8db Implement the writeTimestamp test to expect an exception ()
 - 8276ee Convert `log2` tests to using new interval framework ()
 - a1cde6 Convert `log` tests to using new interval framework ()
 - 3d4386 Remove storage write tests ()
 - 0d908a Update the createQuerySet test of query_types.spec.ts to expect an exception ()
 - 426583 Convert `sin` tests to use interval framework ()
 - 33df4b Convert negation tests to new interval framework ()
 - 9c96bd Update 'zero_size' test to check 'usage' field ()
 - e058d2 Convert `floor` tests to use new interval framework ()
 - c9e0c0 Convert `exp2` tests to use new interval framework ()
 - a7989f Convert `exp` tests to using new interval framework
 - bb12dc Add escape hatch for precisely expressing expectations
 - 610b24 Replace `;` with `,` in WGSL structs. ()
 - 21e01f Use paramsSubcasesOnly()
 - 7ff215 Add tests for container type reflection attributes
 - 614d1a Move buffer_texture_copies.spec.ts from encoding/cmds to image_copy path ()
Change-Id: I7ec19f87f049a06f0d24d2981ea941fa717dddf7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95281
Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-06-30 19:42:54 +00:00
Austin Eng e093819064 Mark another flaky f32_logical inputSource="const" as Failure on Linux
This was missed in a previous roll.

Bug: none
Change-Id: If1be03751b99152d4f63324a298dc13ebb3067be
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94920
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-06-28 06:43:56 +00:00
Brandon Jones 14e6dfbd95 Remove failing depth32float-stencil8 expectations
The issue causing these tests to fail was resolved in
https://chromium-review.googlesource.com/c/chromium/src/+/3716961

Bug: 1069302
Change-Id: Iacf06539a0415431b3355bc4b2345c2eb7cab61a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94761
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Brandon Jones <bajones@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2022-06-28 00:11:10 +00:00
Austin Eng c8a276a28e Skip inputSource="const";* f32_logical on Win NVIDIA x86
Also timing out on this platform. For example see:
https://ci.chromium.org/ui/p/chromium/builders/ci/Dawn%20Win10%20x86%20Release%20(NVIDIA)/63134/test-results

Bug: none
Change-Id: I922763a22899b11a9b95fb18248757c5d1ca5e61
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94643
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-06-24 18:30:59 +00:00
Brandon Jones 01e4d44e1e Roll third_party/webgpu-cts/ 5a30cb44c..cef4c7678 (33 commits)
Change-Id: Ie4943f8dcda0cc9d485c6c0b586ccb132a05389b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94500
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-06-24 08:10:29 +00:00
Brian Sheedy 67973e6706 Suppress Mac Intel 12.4 failures
Suppresses failures found when switching from 11.5.2 to 12.4
on the Intel Mac Minis.

Bug: dawn:1461, dawn:1462, dawn:1463, chromium:1334335

Change-Id: Ie0d42a1b4aa81f457145a53eebb1501a5eb77fbe
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/93308
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Commit-Queue: Brian Sheedy <bsheedy@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-06-10 22:12:43 +00:00
Ben Clayton bd67ffe0f0 Roll third_party/webgpu-cts/ fee6d96eb..5a30cb44c (7 commits)
Update expectations and ts_sources

fee6d96eb3..5a30cb44c5
 - 5a30cb [wgsl] use subcases in texture tests ()
 - edd275 Add api,validation,resource_usages,buffer,in_pass_misc:* - Part II ()
 - 484ae3 Update @stage attributes. ()
 - 6ff559 Remove references to depth24unorm-stencil8 ()
 - 9474c0 Implement new F32Interval class for floating point tests ()
 - 3ebdea Add api,validation,resource_usages,buffer,in_pass_misc:* - Part I ()
 - f19f0c Specify RENDER_ATTACHMENT usage when creating multisampled texture ()

Created with './tools/run cts roll'

Change-Id: Icc2d66e8367ef58a35817afdce6ec87d6373c79c
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/93143
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-06-09 14:07:34 +00:00
Austin Eng 225e39880d Remove comment that expectations.txt should not be manually edited
Bug: none
Change-Id: I6ff9dc090c7201bb5ed3fa7f6853d9f4177518fd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/92909
Commit-Queue: Austin Eng <enga@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-06-07 20:52:54 +00:00
Ben Clayton 2880e7062c Roll third_party/webgpu-cts/ d275c5e1e..fee6d96eb (5 commits)
Update expectations and ts_sources

d275c5e1e3..fee6d96eb3
 - fee6d9 Roll @webgpu/types to 0.1.18 ()
 - 70df7a Add api,validation,resource_usages,buffer,in_pass_encoder:* - Part V () ()
 - 6302a6 Change importExternalTexture,destroy to importExternalTexture,expired ()
 - f188c0 Fix unnecessary imports
 - 8afdd9 Update texture format tests to expect exceptions

Created with './tools/run cts roll'

Change-Id: I8bcbca1747f0a2f1414b883860144817a1e16a8a
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/92721
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-06-07 20:26:04 +00:00
Ben Clayton a614993294 Roll third_party/webgpu-cts/ 70091fdb8..d275c5e1e (3 commits)
Update expectations and ts_sources

70091fdb8d..d275c5e1e3
 - d275c5 Factor copyToTexture:canvas tests common code. ()
 - e4ee0a Add api,validation,resource_usages,buffer,in_pass_encoder:* - Part IV ()
 - 24c2a7 Add api,validation,resource_usages,buffer,in_pass_encoder:* - Part III ()

Created with './tools/run cts roll'

Change-Id: I95e875667222fcd3f262ed253ac9179f1cd941f2
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/92260
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-06-01 17:22:49 +00:00
Ben Clayton 8cbfad7e5d cts: Remove use of intel-0x5912 and intel-0x3e9b tags
The CTS runner can randomly pick between these two GPUs, leading to unstable expectations.

Just use 'intel' for now. We might get a more targetted tag in the future, but this will do for today.

Bug: dawn:1387
Bug: dawn:1444
Change-Id: I2c77ab0060976c40e34b1597b5594894867b7edd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/92242
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
2022-06-01 12:15:49 +00:00
Ben Clayton 8b09bc97c0 tint: Lex abstract integers
Check that the parsed number fits in an abstract-integer.

Refactor the unit tests so that they're maintainable. Add missing tests.

Bug: tint:1504
Change-Id: I04b6604820d527da66e3f6fcb47391efc0c3330a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91701
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: David Neto <dneto@google.com>
2022-05-30 17:54:38 +00:00
Ben Clayton 1b69b8ad99 Roll third_party/webgpu-cts/ 5f05d6d5e..70091fdb8 (2 commits)
Update expectations and ts_sources

5f05d6d5e6..70091fdb8d
 - 70091f Draw buffer validation test for unused and overlapped cases ()
 - cc8668 Revise ExternalTexture Video Test Expectations ()

Created with './tools/run cts roll'

Change-Id: I9d46b7b6582301daaf1f74ddbc41f2ef3bb6b31f
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91848
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-05-30 16:33:38 +00:00
Ben Clayton cc32bccc77 Roll third_party/webgpu-cts/ 9618103c4..5f05d6d5e (1 commit)
Update expectations and ts_sources

9618103c4a..5f05d6d5e6
 - 5f05d6 Draw vertex buffer validation for instance step mode buffer ()

Created with './tools/run cts roll'

Change-Id: Ib88732d694038b975581c389a84d6bc2a21f5583
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91364
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
2022-05-25 22:42:19 +00:00
Corentin Wallez ce425feef5 Remove expectations for fixed createView default dimension.
Fixed: dawn:1380
Change-Id: I01c8de526208beea9733a4443e5fd6f50d7e0719
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91620
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
2022-05-25 18:16:47 +00:00
Yunchao He 4e34192f9e Re-suppress WebGPU expectations
Bug: chromium:1328469, dawn:1319
Change-Id: Ic8a39707239fbe5b02a1be7a7a53be9d3afa3d46
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91341
Commit-Queue: Yunchao He <yunchao.he@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-05-24 06:58:34 +00:00
Corentin Wallez cc2efbcdbf Roll third_party/webgpu-cts/ e48651de0..9618103c4 (3 commits)
Update expectations and ts_sources

e48651de01..9618103c4a
 - 961810 refresh origin trial tokens
 - 666c19 resource_init: Specify view dimension in checkContentsBySampling
 - b5cc68 Fix memory leak in vertex_buffer_OOB,vertex_step_mode ()

Created with './tools/run cts roll'

Change-Id: If30569b2b6aaf98c30c363671793f990136021fc
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90644
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-23 13:44:10 +00:00
Corentin Wallez a4216e72d4 Remove passing WebGPU expectations
Bug: dawn:1319
Change-Id: Iae82a3ea568f1a178e4f516ee55f7028defd528a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90665
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-05-20 17:29:50 +00:00
Corentin Wallez afbc260f14 Roll third_party/webgpu-cts/ 8f2742e4a..e48651de0 (6 commits)
Update expectations and ts_sources

8f2742e4a4..e48651de01
 - e48651 Draw vertex buffer access test for vertex step mode buffer ()
 - 0dd740 sort and comment
 - 36b070 part 4: no-floating-promises
 - bd4473 part 3: no-unnecessary-type-assertion
 - 31154b part 2: unbound-method
 - 05a264 Add "recommended" typescript-eslint lints (part 1)

Created with './tools/run cts roll'

Change-Id: If45ec0f188f2b875bd6a839a3385403ddc33dcf4
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90802
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-05-20 13:31:15 +00:00
Austin Eng 0c5aaf4833 Update expectations.txt for passing tests
Bug: chromium:1322180, dawn:1410
Change-Id: Iee9baa1a68961217664862c6e8bd31394ae6bf0b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91061
Auto-Submit: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-20 08:19:40 +00:00
Corentin Wallez 92244ec9d4 Roll third_party/webgpu-cts/ e518bfe8a..8f2742e4a (15 commits)
Update expectations and ts_sources

e518bfe8a4..8f2742e4a4
 - 8f2742 Raise maxComputeWorkgroupStorageSize from 16352 to 16384 ()
 - 706082 wgsl: Add stubs for the pack and unpack methods. ()
 - 33d851 wgsl: Stub tests for the textureStore builtin. ()
 - 8610c8 wgsl: Add stub tests for textureSampleLevel. ()
 - 5d6c16 wgsl: Stub synchronization builtin functions. ()
 - c57922 Duplicate params: catch in ParamsBuilder, improve error in loadTreeForQuery ()
 - f923e0 Update pipeline output targets validation with different writeMask ()
 - 17582e wgsl: Add stub tests for textureSampleGrad. ()
 - dc8142 wgsl: Add stub tests for textureSampleCompareLevel. ()
 - fe9154 wgsl: Stub tests for textureSampleCompare ()
 - a0c703 wgsl: Add stubs for the read-write-modify atomic operations. ()
 - 2b89c0 wgsl: Add stubs for the atomicStore builtin. ()
 - 776015 wgsl: Stub tests for the atomicLoad builtin. ()
 - 544877 wgsl: Add stub tests for the textureSample builtin. ()
 - d6dc47 wgsl: Fixup coord parameters in texture tests. ()

Created with './tools/run cts roll'

Change-Id: Ibe57ebc6643921cae7bc3fae6f82459673106dd9
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90860
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-19 16:57:40 +00:00
Corentin Wallez aed7eb4b4c Temporarily mark requestDevice_limits as failing.
It will be reverted to RetryOnFailure.

Bug: dawn:1410
Change-Id: I0e66e0a622d4fcd568692255325545f5531762f3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90525
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2022-05-18 18:38:08 +00:00
Corentin Wallez 3676701f84 Remove expectations for passing WebGPU CTS tests
Bug: dawn:1398
Fixed: dawn:1325
Change-Id: I0ed77f202525460a991461155f9dce52690c5412
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90661
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-05-18 10:15:51 +00:00
Ben Clayton ff192cee35 expectations.txt: Remove rules for passing tests
The following are now all passing:
• webgpu:shader,execution,expression,call,builtin,ceil:*
• webgpu:shader,execution,expression,call,builtin,floor:*
• webgpu:shader,execution,expression,call,builtin,fract:*

Remove the `KEEP` for the bulk of the shader execution failures.
This will enable the chunk to remove rules for tests when they start passing.

Bug: dawn:1546
Change-Id: I927804b81192efaed00b95aeebd268ec15f358c9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90521
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-05-18 09:26:51 +00:00
Corentin Wallez 8ee1e11be7 Roll third_party/webgpu-cts/ bf5409992..e518bfe8a (3 commits)
Update expectations and ts_sources

bf54099927..e518bfe8a4
 - e518bf Add skipLibCheck to tsconfig.json ()
 - 9f4227 attachment_compatibility: Properly set d/sReadOnly when testing it. ()
 - 524b5e Fix tests using DS attachments not encompassing all aspects. ()

Created with './tools/run cts roll'

Change-Id: I4188c4fbdef8d9e299817ada88ebecfd16813534
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90660
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-05-17 14:15:22 +00:00
Antonio Maiorano 34d2d1ba02 cts: skip atan2 tests on Windows
This is still under investigation, but let's skip for now as it makes
the CTS run very long.

Bug: tint:1524
Change-Id: Ic238ea22119f6165a3d22582bfb93ffd57efed3b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90560
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Antonio Maiorano <amaiorano@google.com>
2022-05-16 22:32:01 +00:00
Ben Clayton 58c9dad06b Roll third_party/webgpu-cts/ 11f61c5f9..bf5409992 (8 commits)
Update expectations and ts_sources

11f61c5f91..bf54099927
 - bf5409 Remove dupes in anyOf to clean up error messages ()
 - f124d7 Fix WGSL deprecation warnings in operation/rendering/draw.spec.ts ()
 - 2f5bb7 wgsl: Add stub tests for textureNumSamples ()
 - 8dae94 wgsl: Stub tests for textureNumLevels builtin. ()
 - ba9abf wgsl: Stub tests for textureNumLayers builtin ()
 - 591a45 wgsl: Stub tests for textureLoad builtin. ()
 - b32ac3 Replace flushSubnormalNumber with isSubnormalNumber ()
 - 5a1def Fix unary tests with subnormal inputs ()

Created with './tools/run cts roll'

Change-Id: I0b8bdf31a333d90e2ca8a71294fabe85a092d02b
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90260
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-05-16 09:01:01 +00:00
Corentin Wallez 500f4eedd3 Prune CTS expectations for passing tests.
Change-Id: I0cb412648437df6c3e1ed9561fa1f28706b629ae
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90201
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-05-13 14:41:57 +00:00
Ben Clayton e2d7f86872 Roll third_party/webgpu-cts/ 0a1288f5e..11f61c5f9 (10 commits)
Update expectations and ts_sources

0a1288f5e8..11f61c5f91
 - 11f61c [dawn-node]: Move TSC config to file. ()
 - 6822b9 wgsl: Cleanup duplicate description text ()
 - aafa50 Add comprehensive memory model tests ()
 - d7d754 Reland "Simplify device selection" with fix ()
 - 999e39 Output whether value is subnormal in Scalar.toString() ()
 - 490d2a wgsl: Stub textureSampleBias tests ()
 - 41afbc wgsl: Use `kValue.`... instead of converting bit-fields to `Scalar`s ()
 - 93aea0 wgsl: update textureGather tests ()
 - d26a4c wgsl: Extend `anyOf` to accept `Comparator`s ()
 - 09bcde Fix atan2 test failures when Y is subnormal ()

Created with './tools/run cts roll'

Change-Id: I407a3d90b855721dbeb157c78682d3de5c6d4e05
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89980
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-05-12 16:18:36 +00:00
Antonio Maiorano bf1fe84d35 Create tracking bug for certain CTS failures
Bug: tint:1546

Change-Id: I2052c489eeddcf6362f95ac9d12ae0a37e957507
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89824
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-05-12 11:29:07 +00:00
Austin Eng ca8a54ed35 Raise base maxComputeWorkgroupStorageSize limit. 16352 -> 16384
Bug: dawn:1410
Change-Id: I0ad4873474614bcd62638583bf905ff2742eaae2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89821
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
2022-05-11 18:28:46 +00:00
Corentin Wallez cd98763946 Triage the createView:array_layers failure.
Bug: dawn:1380
Change-Id: I6a7117bfcab76fe55e8901c4da78415ef517ceeb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89665
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-05-11 16:32:35 +00:00
Ben Clayton 6a8cfd4153 Roll third_party/webgpu-cts/ ecf480422..0a1288f5e (21 commits)
Update expectations and ts_sources

ecf4804228..0a1288f5e8
 - 0a1288 Revert "Simplify device selection" and dependent commits ()
 - 0afe04 Merge pull request  from kainino0x/nit
 - ccfaca wgsl: Add support for f64 to Scalar ()
 - 3ab573 Fix crash in GPUTest.init awaiting provider ()
 - 753740 Fix order in package.json ()
 - fb4eee wgsl: Stub tests for the textureGather builtin. ()
 - c676c8 wgsl: Stub tests for textureDimension. ()
 - 96f821 wgsl: Adds stub tests for textureGatherCompare ()
 - d4a2b9 Skip whole case if there is no device
 - e38ab0 Fix skipping tests when device isn't available
 - dae9db [wgsl] Add missing @const decorations. ()
 - 90d78b [wgs] fixup mix signature to match spec. ()
 - 35c672 [wgs] sync modf text with spec update. ()
 - 2398e8 [wgsl] reserve binding_array. ()
 - a4f874 Explicitly specify 2d texture views in some cases ()
 - a91256 Remove 'await's from selectDevice calls
 - c072e8 Simplify device selection
 - 47bd25 Encapsulate OOM-cleanup in DevicePool
 - 9be8bf factor out DeviceSelectionDescriptor
 - 229e43 Allow eventualExpectOk to accept Promise.all ()
 - a6e1f5 wgsl: Generalize unary and binary f32 arithmetic case generation ()

Created with './tools/run cts roll'

Change-Id: I9cc819aa118220b44f1df6511a7f557ec38a01c6
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89663
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-05-11 09:53:45 +00:00
Corentin Wallez dd5947ff76 Triage WebGPU CTS expectations
Bug: chromium:1234041, chromium:1309194
Bug: dawn:1319, dawn:1357, dawn:1398

Change-Id: Id7ad9350b6294d986f4ac6235d47bf36378344c6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88307
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-05-10 13:57:24 +00:00
Ben Clayton f214e8bdad webgpu-cts/expectations.txt: Remove expectations that now pass
Cq-Include-Trybots: luci.chromium.try:win-dawn-rel,mac-dawn-rel,linux-dawn-rel,dawn-try-win10-x86-rel
Change-Id: I9214d1333931e193cdfce10a52289255685f4150
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88844
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-05-04 16:44:59 +00:00
Ben Clayton ff371efdc6 Roll third_party/webgpu-cts/ 249f2b797..ecf480422 (21 commits)
Update expectations and ts_sources

249f2b797b..ecf4804228
 - ecf480 wgsl: Add missing parameterizations ()
 - febc61 wgsl: Stub tests for the fwidthFine builtin. ()
 - 50261d wgsl: Stub tests for the fwidthCoarse builtin. ()
 - b2f135 wgsl: Stub tests for the fwidth builtin. ()
 - 1d3403 wgsl: Stub tests for the dpdyFine builtin. ()
 - 1c717a wgsl: Stub tests for the dpdyCoarse builtin. ()
 - ef805c wgsl: Stub tests for the dpdy builtin ()
 - 8f5f61 wgsl: Stub tests for the dpdxFine builtin. ()
 - 59d1c3 wgsl: Stub tests for dpdxCoarse builtin ()
 - aa6096 wgsl: Stub tests for dpdx builtin ()
 - 2ee8b6 wgsl: Stub tests for the dot builtin. ()
 - 9646eb wgsl: Stub tests for the transpose builtin. ()
 - 0415ba wgsl: Stub tests for determinant builtin. ()
 - e817a5 wgsl: Stub tests for trunc builtin. ()
 - 9edb35 wgsl: Stub tests for the tanh builtin. ()
 - 1b109c wgsl: Stub tests for tan builtin. ()
 - 92f64a wgsl: Stub tests for step builtin. ()
 - ca915e wgsl: Stub tests for sqrt builtin. ()
 - b1f2fb wgsl: Stub tests for smoothstep builtin. ()
 - 9ea198 wgsl: Stub tests for sinh builtin. ()
 - 423400 wgsl: Stub for sign builtin. ()

Created with './tools/run cts roll'

Change-Id: I29b09f6d4808c8b33d39d390def05f72599965f2
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88860
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-05-04 16:00:39 +00:00
Austin Eng 9483b741a8 Mark requestDevice_limits:supported_limits:* RetryOnFailure
Change-Id: I38f6ddf9b39f7f98ccb5ec047341ffa1ffe49de5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88782
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-05-03 23:53:13 +00:00
Austin Eng 84958ea2f2 Roll third_party/webgpu-cts/ 547d67bc2..249f2b79 (8 commits)
Update expectations and ts_sources

547d67bc22..249f2b797b
 - 249f2b Don't block on subcases until the end of a testcase ()
 - 170d7b Sparse color attachment fix ()
 - 423df1 DevicePool: merge default holder into the DescriptorToHolderMap ()
 - 10ce93 remove doInit/doFinalize ()
 - d5cf9a Handle backends flushing inputs in `atan2` tests ()
 - 318d3d Move test device selection to an optional before clause ()
 - ece4eb Fix non-object-type test-parameter values ()
 - 5906dc Add --colors flag for enabling color output ()

Created with './tools/run cts roll'

Change-Id: I070d813ffe3017e1bd4e425247f1ea174ee63887
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88720
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-05-03 22:07:16 +00:00
Ben Clayton f05cba72c3 Roll third_party/webgpu-cts/ 21af43c62..547d67bc2 (15 commits)
Update expectations and ts_sources

21af43c62a..547d67bc22
 - 547d67 Add sparse color attachments operation tests ()
 - fd45c7 Roll @webgpu/types to 0.1.15
 - db30f9 wgsl: Implement `exp2` f32 tests ()
 - 44d6ab wgsl: Stub normalize builtin test ()
 - e1397f wgsl: Stub test for `pow` builtin. ()
 - a1676d wgsl: Stub test for radians builtin. ()
 - b09a65 wgsl: Stub tests for reflect builtin ()
 - 3442cf wgsl: Stub tests for refract builtin. ()
 - 651670 wgsl: Add stub tests for round builtin ()
 - de3c00 wgsl: Stub tests for modf builtin. ()
 - 6c85f4 wgsl: Stub tests for mix builtin. ()
 - 2dcf97 depth_clip_clamp: Fix validation error for stencil-less formats ()
 - 83b2ea Allow 1 ULP difference for copyToTexture ImageBitmap tests ()
 - 972308 Add literal parsing tests ()
 - 65104c wgsl: Stub tests for degrees builtin. ()

Created with './tools/run cts roll'

Change-Id: Iac0527fee588a29c04959c7932acba1b6d04a847
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88560
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-05-02 21:21:45 +00:00
Corentin Wallez bd8de5d2a4 Add MetalRenderR8RG8UnormSmallMipToTempTexture workaround
This workaround replaces the toggle that forbids creating mipmapped
R8Unorm and RG8Unorm textures on Metal. Instead it adds a Metal render
pass workaround that renders to a temporary texture under certain
conditions, then copies back to the correct mip level.

The texture lazy-clearing code is also changed to use the helper that
does workarounds for Metal render passes.

A test is added that triggers the issue with a small amount of code, but
more extensive coverage is left to the CTS. For example texture_zero
tests caught multiple issues during the creation of this CL.

Bug: dawn:1071

Change-Id: I7ef1151524e71e5a9a8e8f5205d9b554bee438b3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87864
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-04-28 19:00:53 +00:00
Ben Clayton e119ff452a Roll third_party/webgpu-cts/ 900765392..21af43c62 (10 commits)
Update expectations and ts_sources

9007653926..21af43c62a
 - 21af43 wgsl: Implement f32 `exp` test ()
 - 0f86e0 Remove redundant information from unittest names ()
 - 23dab0 wgsl: Stub acosh builtin tests. ()
 - 7cea4a wgsl: stub distance builtin tests ()
 - 8829c3 wgsl: stub length builtin tests ()
 - 7eec30 wgsl: stub tests for atanh builtin. ()
 - e442a7 wgsl: Stub asinh builtin tests ()
 - 969db1 Implement OneULP and related ULP functions ()
 - 7845e2 wgsl: Stub asin builtin tests ()
 - 8f8ab3 Sync reserved words to spec. ()

Created with './tools/run cts roll'

Change-Id: I6f549884d045b80b63a826a4282faa26aa992ec4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88260
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-04-28 13:32:23 +00:00
Corentin Wallez 144a4fb945 Suppress a flake for RGBA32Float zero init on Intel.
Bug: None
Change-Id: I53956baf1fc9fcd5b02e8f8069229bc86ec386dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88220
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-04-27 18:04:33 +00:00
Corentin Wallez 46bef8aae6 Tighten the suppression for texture_zero failures.
It is failing for a single format when trying to copy to a buffer
because the depth-specific format for depth23unorm-stencil8 buffer is
depth24plus which is not copyable.

Bug: dawn:1388
Change-Id: I034145bf55d42403ded23b1b9acf974d85770d42
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87701
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-27 11:28:20 +00:00
Ben Clayton 00e845cfdf Roll third_party/webgpu-cts/ 45d2ccd25..88c034819 (4 commits)
Update expectations and ts_sources

45d2ccd250..88c0348191
 - 88c034 ShaderValidationTest: remove string overload ()
 - 93932e Split WGSL test files ()
 - 40b847 Minor comment fixes
 - 6f46b8 Cleanup old WGSL test files. ()

Created with './tools/run cts roll'

Change-Id: I35ea8385af6ddc09c43833d40395c80f7d060002
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87703
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-04-23 01:11:22 +00:00
Austin Eng 390b5a2176 Generalize expectation for recently added suppression.
intel-0x3e92 was not added, but intel-0x5912 was - leading
to flaky CQ rejection depending on what bot happened to run
the task.

Generalize this expectation since it fails on all platforms
anyway.

Bug: dawn:1387
Change-Id: Iccd4806de456a817edf538041445ee2ac93099e7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87675
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-04-22 08:10:51 +00:00
Austin Eng 81a3c7cbdf Add back fail expectation on CTS Windows x86
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel
Change-Id: I229846e8a9a4e8b047f23fc5b9134691022c96a9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87611
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-04-22 02:39:51 +00:00
Ben Clayton 66b70ec1a0 Roll third_party/webgpu-cts/ a06666e00..45d2ccd25 (3 commits)
Update expectations and ts_sources

a06666e000..45d2ccd250
 - 45d2cc Fixed TS errors
 - 5eacfb Take new createView() dimension default logic into account
 - cbdcbd Explicitly destroy devices created by requestDevice_limits

Created with './tools/run cts roll'

Change-Id: I701bc9e6fa6b1996b1ed40b08766cc9dedaf20d8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87621
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-04-21 23:18:10 +00:00
Ben Clayton 931a4ddb1c Update WebGPU CTS expectations
• Remove a number of expectations that are no longer needed.
• Change a number of expectation tags to be more specific.
• Sort the expectations per chunk.
• Add a few more wide-wildcard 'Failure' rules for tests that commonly flake.

Bug: dawn:1342
Change-Id: I0e23cd546f7ab54a5720e24c52e3782b5df6b99f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87520
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-04-21 14:58:23 +00:00
Yunchao He 12d45e2068 Update webgpu-cts/expectations.txt
Fixed: dawn:1289
Change-Id: I5229653973990550d6c867e17100bf83de16a6e2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87500
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-04-21 02:55:55 +00:00
Enrico Galli 45ec7c3528 D3D12: Duplicate first/baseVertex on Draw[Indexed]Indirect
Adds support for non-zero first/baseVertex on Draw[Indexed]Indirect by
duplicating the first/baseVertex indirect parameter onto a root
constant in the indirect buffer.

Change-Id: I280149065179806d3e57b07f1a396f9e2e4e8fcb
Bug: dawn:548
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/84240
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Enrico Galli <enrico.galli@intel.com>
Auto-Submit: Enrico Galli <enrico.galli@intel.com>
2022-04-21 02:25:35 +00:00
Jiawei Shao 93a2bed032 Only allow creating 2D textures with RenderAttachment usage
BUG=dawn:1364
TEST=dawn_unittests

Change-Id: I49cdeeac8b951c3715211fc3b3b71934a19a6e64
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86622
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2022-04-20 04:01:39 +00:00
Shrek Shao 6a3373e419 Fix a webgpu-cts crbug ticket
Bug: dawn:1325
Change-Id: I204fd3777458871ef7d7c398a2023388b33f0aa5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87301
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
2022-04-19 22:22:20 +00:00
Austin Eng 89d6a1f376 Add D3D12 UAV barriers between multiple storage texture usages
Fixed: dawn:1370
Change-Id: I395b3e6e2506608ca4aefdbcef18443b90ca75ea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87302
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-04-19 20:51:40 +00:00
Corentin Wallez 344e001e6b Triage some of the webgpu-cts/expectations.txt
Bug: dawn:1111, dawn:1289, dawn:548

Change-Id: I4f867676c1127e1e131e19180f0de41745cea3e0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86783
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2022-04-19 15:40:15 +00:00
Jiawei Shao e1aa107ab3 Roll WebGPU-CTS
BUG=dawn:1364, dawn:1376

Change-Id: I5e4c5568572892129e196cb6ae73d0230c6dec5b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87201
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-19 12:01:04 +00:00
Corentin Wallez 9676fc66e8 Remove some WebGPU CTS expectations that are passing.
Change-Id: I2ca7e8aae1b3bf83c8ca30de5496b273ea9e5700
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86782
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-19 07:25:54 +00:00
Austin Eng b6d2dea049 Skip tests that crash deterministically on Linux
These are known crashes from the old WebGPUExpectations. Running
them is a waste of resources.

Bug: chromium:1309194, chromium:1234041, chromium:1236130, chromium:1315987
Change-Id: I7bbf70d0bc5abd09ebf47e2e65521d4a4fa5363e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86844
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-04-15 02:41:01 +00:00
Ben Clayton d9726b23cd Roll CTS and update expectations
Roll CTS to 9861f5e1d92559c03a8d769117124de97adc47c4
Update ts_sources.txt
Regenerate expectations

Change-Id: Ib422e2ee4d2e0c6307f06d0029eaed737fc5d2b9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86880
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-04-14 14:54:30 +00:00
Corentin Wallez 8b8b641326 Roll third_party/webgpu-cts/ dcba3ac6b..5e83d8349 (25 commits)
dcba3ac6b8..5e83d8349b

$ git log dcba3ac6b..5e83d8349 --date=short --no-merges --format='%ad %ae %s'
2022-04-13 cwallez Reduce the length of subresource test names ()
2022-04-13 cwallez zero_init: add constant zero to prevent driver unrolling loops. ()
2022-04-13 jiawei.shao Add validation,resource_usages,texture,in_render_misc:* - Part II ()
2022-04-13 jiawei.shao Add validation,resource_usages,texture,in_render_misc:* - Part I ()
2022-04-11 enga Test view format reinterpretation ()
2022-04-11 litherum Only 2D textures can be marked as render targets ()
2022-04-08 cwallez operation,image_copy: Add support for depth16unorm ()
2022-04-08 cwallez image_copy,mip_levels: reduce the mip level count. ()
2022-04-08 cwallez depth_compare_func: Don't use 0.5 as depth16unorm rounds either way ()
2022-04-08 cwallez Fix tests trying to copy aspects of depth-stencil textures. ()
2022-04-08 cwallez depth_clip_clamp: only set stencilLoadOp and friends when needed. ()
2022-04-08 cwallez Fix validation errors with depth/StencilLoad/StoreOp set when not allowed. ()
2022-04-08 enga Shorten test and param lengths in resource_usages,texture,in_render_common:* ()
2022-04-08 jiawei.shao Add validation,resource_usages,texture,in_render_common:* - Part V ()
2022-04-06 cwallez val,buffer,create: Buffer sizes don't have to be multiple of 4. ()
2022-04-06 cwallez image_copy: Ensure bufferOffset % 4 == 0 for depth-stencil. ()
2022-04-06 jiawei.shao Add validation,resource_usages,texture,in_render_common:* - Part IV ()
2022-04-05 enga Fix infinite recursion in CopyExternalImageToTexture.spec.ts ()
2022-04-05 cwallez Use globalThis instead of self. ()
2022-04-05 cwallez val/copyT2T,format_compat: Don't assume compressed is always 4x4 ()
2022-04-05 cwallez Fix DSAttachment load/store ops being specified when disallowed. ()
2022-04-05 cwallez Fix test of BGL binding limits to correctly check limits ()
2022-04-04 cwallez Fix a validation error caused by WriteTexture bytesPerRow: t.width ()
2022-04-04 cwallez Add unicode tests for entryPoint matching. ()
2022-04-04 cwallez writeBuffer: an unaligned bufferOffset is a validation error. ()

Created with:
  roll-dep third_party/webgpu-cts

Change-Id: I048afcaf3d33bcd67401412bf235181013ebf6d2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86533
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-04-13 18:52:46 +00:00
Austin Eng aef6389be9 Add WebGPU Adapter tags to the expectations file
So we can begin running the CTS on SwiftShader and add targeted
suppressions when necessary.

Bug: chromium:1315703
Change-Id: Ic68e43ad0d79830b3ef5559ea1de0133d48ea43c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86626
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-04-13 16:49:56 +00:00
Austin Eng 5752bbf63c Mark webgpu:shader,execution,shader_io,compute_builtins:inputs:* failing on Windows x86 NVIDIA
Bug: tint:1500
Change-Id: I6230e8ba1b8b7076a7276de207cd72729233435f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86480
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-04-12 04:36:10 +00:00
Ben Clayton 2bdabc748f Roll CTS and update expectations
Roll CTS to dcba3ac6b819abb0920e589ca1809ae5b5f87119
Update ts_sources.txt
Regenerate expectations

Change-Id: Ifa0cae3fa1abf9da9e4fbd63acf9cefe2683f50d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85560
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-04-11 18:38:51 +00:00
Austin Eng db68059da8 Unskip some CTS tests using the new harness
Bug: chromium:1306640
Change-Id: I1dd1d60490fdf2670d4a7ac189065eadf002e3cb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/84781
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-03-28 18:13:22 +00:00
Austin Eng 1cdea90f7b Add CTS telemetry harness support
Migrates harness support files added in
https://chromium-review.googlesource.com/c/chromium/src/+/3541414
into Dawn's repo.

Tested in
https://chromium-review.googlesource.com/c/chromium/src/+/3537743

Bug: chromium:1306640
Change-Id: I3000b1223219a1da293af910bf442570b70b7c92
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/84043
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-03-24 00:21:55 +00:00