Loko Kung
2552dd3c9f
Plumbs labels for the following Metal objects:
...
- Buffers
- Pipelines
- QuerySets
- Samplers
- Shaders
- Textures
Change also includes:
- Metal debug name utilities
Bug: dawn:1784
Change-Id: Iddd2546f842c794570c225577d35c82e56809c6c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130940
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
2023-05-03 05:57:06 +00:00
Dawn Autoroller
83ffcdecc2
Roll ANGLE from acbba2222ec7 to a73e546cf108 (8 revisions)
...
acbba2222e..a73e546cf1
2023-05-02 abdolrashidi@google.com Vulkan: Add pending memory size for VMA images
2023-05-02 cnorthrop@google.com Vulkan: Restore stencil write mask workaround for ARM
2023-05-02 lexa.knyazev@gmail.com Vulkan: Implement polygon mode extensions
2023-05-02 cclao@google.com Vulkan: Dirty VertexArray binding bit if buffer storage change
2023-05-02 cclao@google.com Vulkan: Add bit mask vertex array buffer binding point.
2023-05-02 syoussefi@chromium.org Initialize display TLS at thread creation time
2023-05-02 romanl@google.com angle_end2end_tests Pixel 6 shards: 4 -> 8
2023-05-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4b61bdad813f to 7873f429a5c2 (45 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC alanbaker@google.com ,angle-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I320c5808cf7ac24f026d5cd4c9552155ff6a0dab
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/131120
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-03 03:09:47 +00:00
Loko Kung
b27e2bfa71
Adds generation for WGSL descriptor to rename source->code.
...
- Adds a deprecation warning for the incorrect usage.
- Adds test to verify that the warning is emitted and that the results
are equal.
- Fixes all existing tests to use the newer code path.
Change-Id: I01bf85137ad1c66966e1aa0259ae03fc5247ba25
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130320
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-05-03 02:23:25 +00:00
Stephen White
fed6b6b35b
Turn AdapterBase into a wrapper class.
...
Change AdapterBase from an alias to PhysicalDeviceBase to a thin
wrapper class holding a ref to a PhysicalDeviceBase. This way,
mutiple AdapterBases can point at the same PhysicalDeviceBase.
For now, InstanceBase wraps all PhysicalDeviceBases discovered by a
backend in a single AdapterBase. In the future, this relationship will
become many-to-one.
Since Devices now maintain a ref on the AdapterBase wrapper (in order to
query toggles, etc), PhysicalDeviceBase::CreateDeviceImpl() now takes
the AdapterBase as an argument, so that the PhysicalDeviceBase knows
which AdapterBase to vend a Device for.
Note that the Toggles also still remain on the PhysicalDeviceBase, to
be moved up to the AdapterBase in a future change.
Bug: dawn:1774
Change-Id: Idef5d24fbd66d8552959230e246e453abddcc736
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/131001
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2023-05-03 01:29:44 +00:00
Austin Eng
5eb3619d3e
Add error context to clarify which depth/stencil function/op is validated
...
Fixed: dawn:1735
Change-Id: I5e3e3e67bb6fd01c10257a2a8c39ba29b49e0933
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/131081
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Brandon Jones <toji@google.com>
Kokoro: Austin Eng <enga@chromium.org>
2023-05-03 00:51:08 +00:00
Austin Eng
e89f88b600
Add error context on Queue::API* methods
...
Fixed: dawn:1747
Change-Id: Icc8f4dbc6fcf69c117f880b5ef9d54cf256f7062
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/131080
Reviewed-by: Brandon Jones <toji@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2023-05-03 00:43:42 +00:00
Peng Huang
80cf5e51cc
d3d11: enable some compute shader tests
...
Known issues:
d3d11 buffer cannot be uniform and storage at same time.
DispatchWorkgroupsIndirect doesn't work correctly.
Bug: dawn:1705
Bug: dawn:1791
Bug: dawn:1792
Change-Id: I14df33c441198fcde9063ad85251da30c4b12c6a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/131060
Commit-Queue: Peng Huang <penghuang@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-05-02 22:29:23 +00:00
dawn-autoroll
3aea647bc2
Roll vulkan-deps from 969451385cab to a2f18114f866 (5 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/969451385cab..a2f18114f866
Changed dependencies:
* spirv-tools: 0ce36ad785..a525dccbe8
* vulkan-validation-layers: ba3336fb8c..da863a2fc1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC alanbaker@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: Ia8275f3396fc1aa978895892ef0b7f4548a4418a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/131040
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-02 21:43:44 +00:00
Brendon Tiszka
1f8413f50a
Add Dawn Wire Server LPM Fuzzer [3/N]
...
Add ability to define custom protobuf structures for commands that
need to be hand written.
Bug: chromium:1374747
Change-Id: I69d5c55d69c3544835a23e4e0360900b991ccbd3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/114643
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Brendon Tiszka <tiszka@chromium.org>
2023-05-02 21:41:22 +00:00
Stephen White
ebafab6556
Rename vulkan::Adapter -> vulkan::PhysicalDevice.
...
Bug: dawn:1774
Change-Id: Iad2896033fc4ae04513444db1a0c941c6c1681ae
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/131000
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-02 20:48:09 +00:00
dan sinclair
c970e806db
[ir] Emit `var` and `let` into the IR
...
This CL adds a nodes for `var` variables. In order to support
global var a new module level block is added, the `root_block`. It only
exists if there are declarations which are emitted into it. The
initializer for the `var` is assigned through a `store` instruction.
A `let` declaration is just the initializer result.
Bug: tint:1897
Change-Id: Icb949699ef643988151cc52026f9ad6a12cdd93f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130761
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-05-02 15:47:29 +00:00
Dawn Autoroller
ae7df9e8c6
Roll ANGLE from 73f9cf004562 to acbba2222ec7 (4 revisions)
...
73f9cf0045..acbba2222e
2023-05-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from fe2d690d4674 to 4c9976e5d118 (429 revisions)
2023-05-02 syoussefi@chromium.org Vulkan: Adjust VVL suppression after VU consolidation
2023-05-02 syoussefi@chromium.org Vulkan: Remove DisplayVk param from ToEGL
2023-05-02 syoussefi@chromium.org Vulkan: Use thread-local space for EGL errors
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC alanbaker@google.com ,angle-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I446cc71ac0421c1b4ed8c7846b8a5f4660650827
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130980
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-02 13:48:35 +00:00
jchen10
1b01b665d7
Workaround for UpdateSubresource1 16-byte alignment
...
In case of misalignment, we write to a temp staging buffer first,
and then copy to the dest buffer using CopySubresourceRegion.
Bug: dawn:1776
Bug: dawn:1705
Change-Id: Iba44dd79d9ee4b02f8cc83263bcfc911e1cce136
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130140
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
2023-05-02 08:36:10 +00:00
dan sinclair
642a4f1d8c
[ir] Make dump output more consistent.
...
This Cl updates the dump output for the IR to be a bit more consistent.
Brackets are removed, named calls are used in place of symbols. Trailing
commas cleaned up. Values have their type appended to make it clearer
what they are when a literal is emitted.
Bug: tint:1718
Change-Id: Ie202d4a4f8267d00b9af4864063b7133f4c7f324
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130000
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2023-05-02 08:27:28 +00:00
dawn-autoroll
255a116ea1
Roll vulkan-deps from 077edbc2d56d to 969451385cab (8 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/077edbc2d56d..969451385cab
Changed dependencies:
* spirv-tools: 08d8fae589..0ce36ad785
* vulkan-validation-layers: 55e602e1f4..ba3336fb8c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC alanbaker@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: Ia1e2731674e5c2d6824325caccb7ad98d3d0aabb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130960
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-02 08:10:51 +00:00
Austin Eng
7b82609894
Make TextureComponentType an internal enum
...
Fixed: dawn:1682
Change-Id: Iadbe7e2829805fed9a7f7e3bb0925544f4318380
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130440
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-02 04:34:55 +00:00
Loko Kung
ba242e53cc
Removes remaining V1 deprecation utilities.
...
- Note: Any future deprecations should directly use
device->EmitDeprecationWarning and switch to a ValidationError after
the deprecation period if applicable.
Bug: dawn:1685
Change-Id: Ia2e51eca32a9645ce362718200c50240d51d6ea0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130840
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-05-02 00:38:56 +00:00
Dawn Autoroller
980afb7cca
Roll ANGLE from 568013739fe4 to 73f9cf004562 (14 revisions)
...
568013739f..73f9cf0045
2023-05-01 lexa.knyazev@gmail.com GL: Implement polygon mode extensions
2023-05-01 syoussefi@chromium.org Vulkan: Make eglPrepareSwapBuffersANGLE less special
2023-05-01 lexa.knyazev@gmail.com Add polygon mode extension stubs
2023-05-01 geofflang@chromium.org Metal: Embed precompiled default shaders.
2023-05-01 syoussefi@chromium.org Vulkan: Destroy the surface without holding the EGL lock
2023-05-01 romanl@google.com Android logs also go to stdout/err, line-buffered if possible
2023-05-01 romanl@google.com Re-enable angle_restricted_trace_gold_interpreted_tests
2023-05-01 romanl@google.com Capture/Replay: android_helper handles traces in/outside of apk
2023-05-01 romanl@google.com Capture/Replay: fix interpreter lib placed inside/outside APK
2023-05-01 romanl@google.com Capture/Replay: make failure to load a trace lib more clear
2023-05-01 zzyiwei@chromium.org Vulkan: use any available memory type for external
2023-05-01 yuxinhu@google.com Unconditionally enable append_aliased_memory_decorations_to_ssbo
2023-05-01 lexa.knyazev@gmail.com D3D11: Implement multisampling shader extensions
2023-05-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f0d31e0f4846 to b89ed2f23a03 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC alanbaker@google.com ,angle-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I6225312835c0d85cf99818950a942379ec4a4132
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130880
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-02 00:25:24 +00:00
Stephen White
9091b46278
Rename AdapterD3D* -> PhysicalDeviceD3D*.
...
Bug: dawn:1774
Change-Id: I9eca75c75c1ec162112915af3bd8371e808c2d60
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130421
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-01 23:10:47 +00:00
Peng Huang
5c2f1678be
d3d11: add tests in AdapterDiscoveryTests test suit for d3d11
...
Bug: dawn:1705
Change-Id: I0841e00b9595651882c7b1c5ae21f00d0201c5a9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130680
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-01 23:05:42 +00:00
Stephen White
8076b2ad73
Rename AdapterGL -> PhysicalDeviceGL.
...
Bug: dawn:1774
Change-Id: Ic137524027eb519af4cb46396b9a8cea9e4cb7f4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130420
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2023-05-01 21:51:16 +00:00
Stephen White
556147c333
Rename null::Adapter -> null::PhysicalDevice.
...
Bug: dawn:1774
Change-Id: I05f4578e08175c4ce5703c5555689ba517b4590d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130780
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2023-05-01 21:37:44 +00:00
Stephen White
be4b208ab6
Rename metal::Adapter -> metal::PhysicalDevice.
...
Change-Id: I558b7a22359437dd2a54f05a55a4128a806c7783
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130760
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2023-05-01 21:04:15 +00:00
Austin Eng
b15d853239
Split MakeVertexDesc so it is const
...
Fixed: dawn:1384
Change-Id: I6071097e8d78b8462459623443b66f3afa42d9d8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130480
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Brandon Jones <toji@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2023-05-01 19:57:35 +00:00
Loko Kung
4e9ebeff02
Deprecates PopErrorScope returning a bool.
...
Bug: dawn:526
Change-Id: Ia4e985fbe4fcb5edb3fe80849f5b0df0190eea00
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130340
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-01 19:25:18 +00:00
Peng Huang
fab65123e1
d3d11: remove the workaround in DeviceOutlivesInstance
...
Bug: dawn:1705
Change-Id: Ic10965ee246b197f72f2be063b6bf70122c5a4ed
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130700
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-01 19:16:33 +00:00
dawn-autoroll
2b9dbc81c7
Roll vulkan-deps from 1d74856fe8c0 to 077edbc2d56d (4 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/1d74856fe8c0..077edbc2d56d
Changed dependencies:
* spirv-tools: 8e1001e938..08d8fae589
* vulkan-validation-layers: a20ed9ad21..55e602e1f4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC alanbaker@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I3d4f14f23687259eb9eb10a05b340c1aeebd972b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130720
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-01 18:41:48 +00:00
Peng Huang
765cdc283a
d3d11: enable render related end2end tests
...
Set Toggle::ApplyClearBigIntegerColorValueWithDraw for device,
since D3D11 can only clear RTV with float values. It workarounds
issues for clearing some RTV with really big integer values.
Bug: dawn:1705
Change-Id: I2e7ec7f527b9a41edc28a004f7989842c6ced3b7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130600
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-05-01 18:06:39 +00:00
Stephen White
e4877b7e68
Rename AdapterBase -> PhysicalDeviceBase.
...
AdapterBase will become a (thin) wrapper class in an upcoming patch,
allowing a single PhysicalDeviceBase to be wrapped in multiple AdapterBases,
each with different toggles and flags.
For now, alias AdapterBase to PhysicalDeviceBase.
Design doc: https://docs.google.com/document/d/1Ag3UAD6D1OVt9-MwKltzLefVhwKRdX0RqML2etrYVS4/edit
Change-Id: Ie77e99508be5285b651aa24ccb412bc9ff8b0111
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130300
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2023-05-01 16:39:04 +00:00
Peng Huang
0e2a833da8
d3d11: enable entrypoint tests for d3d11 backend
...
Bug: dawn:1705
Change-Id: Ie8f29132726c015cbe4f552eb77afc1ecbc4a325
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130660
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-05-01 16:29:15 +00:00
Peng Huang
925b77605e
d3d11: enable d3d11 by default if it is not built with chromium
...
Bug: dawn:1705
Bug: dawn:1778
Change-Id: I8d84582f6f9e84676572ecb9c174d0117468888b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130580
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-05-01 16:13:00 +00:00
Dawn Autoroller
0b3f098435
Roll ANGLE from f9a700ee36d1 to 568013739fe4 (1 revision)
...
f9a700ee36..568013739f
2023-05-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 82c53dbf916a to fe2d690d4674 (760 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,enga@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: enga@google.com
Change-Id: I75cbf48ef3428104a97e45cf584d1ba36a6cfdbd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130640
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-01 10:18:36 +00:00
Corentin Wallez
8ddaa51889
Remove dawn::native::ExternalImageDescriptorIOSurface::plane
...
It is no longer used anywhere.
Bug: None
Change-Id: Ife3fa9470f3059efe34e29aa96adb2922ce91ebc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/129580
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-05-01 09:01:27 +00:00
dawn-autoroll
585787da55
Roll vulkan-deps from 493272235e76 to 1d74856fe8c0 (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/493272235e76..1d74856fe8c0
Changed dependencies:
* vulkan-validation-layers: 188c2c4363..a20ed9ad21
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC enga@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: enga@google.com
Change-Id: Ice085f10ed52994c1c0f7a4ab103c5e6562fcfeb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130620
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-05-01 05:22:56 +00:00
Dawn Autoroller
22f70bb098
Roll ANGLE from ae6b2d11dd71 to f9a700ee36d1 (1 revision)
...
ae6b2d11dd..f9a700ee36
2023-04-29 abdolrashidi@google.com Disable mutable texture upload for discrete GPUs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,enga@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: enga@google.com
Change-Id: I6d3a5608cf0bc577657b15ca539d53d0f4393b32
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130560
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-29 13:59:58 +00:00
dawn-autoroll
a47ca372de
Roll vulkan-deps from 62b5ec9c7076 to 493272235e76 (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/62b5ec9c7076..493272235e76
Changed dependencies:
* vulkan-validation-layers: c6f187b800..188c2c4363
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC enga@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: enga@google.com
Change-Id: Ib2ea4589b3073b2254d67f42f955cd88e9445a77
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130540
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-29 13:32:04 +00:00
Dawn Autoroller
8a0b3840ab
Roll SwiftShader from d3052046cbff to b89ed2f23a03 (2 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/d3052046cbff..b89ed2f23a03
2023-04-28 natsu@google.com Add Android host build support
2023-04-28 natsu@google.com UPSTREAM: Fix Android host build
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC enga@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: enga@google.com
Change-Id: Ib033fb49fe9bcda65ff484071b75db31d100a8c7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130520
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-29 07:21:11 +00:00
Peng Huang
6ffec70123
d3d11: fix link errors
...
Bug: dawn:1724
Change-Id: If27342937e450d11a54f1d36f4378feb69d5e98e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130400
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-04-29 00:57:59 +00:00
Dawn Autoroller
e17f341487
Roll ANGLE from d5eee882efc0 to ae6b2d11dd71 (4 revisions)
...
d5eee882ef..ae6b2d11dd
2023-04-28 geofflang@chromium.org Metal: Gracefully fail compilation of stencil blit shaders.
2023-04-28 sky@chromium.org Adds feature to output blob cache key and source for shader
2023-04-28 sky@chromium.org metal(ish): Adds platform function for logging cache hits/misses
2023-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3076b4c0d8ce to f0d31e0f4846 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,enga@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: enga@google.com
Change-Id: I5c600d1510120e449668a2115a4d4170cffdea98
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130380
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-29 00:23:23 +00:00
dawn-autoroll
f303dcc12a
Roll vulkan-deps from 14eaf973d52a to 62b5ec9c7076 (5 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/14eaf973d52a..62b5ec9c7076
Changed dependencies:
* spirv-tools: 6110f30a36..8e1001e938
* vulkan-validation-layers: 6e7ae19f04..c6f187b800
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC enga@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: enga@google.com
Change-Id: Iaf9db20e7e7d7d97a1ea44b11123519b792f8921
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130360
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-29 00:10:34 +00:00
Brandon Jones
df6cb23649
Change D3D12 Descriptor Allocator To Invalidate Submitted Descriptors
...
Changes D3D12 descriptor allocator to invalidate existing descriptors
after the descriptor heap was submitted for use. This fixes a
synchonization issue where stale descriptors were seen as valid because
command list execution ran long.
Bug: dawn:1701
Change-Id: Ibfd450b3be6cf91d66e8dce4ffd19ecf1a37f7f5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/129920
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Brandon1 Jones <brandon1.jones@intel.com>
2023-04-28 22:31:33 +00:00
Peng Huang
948ef4292f
d3d11: fix Queue::WriteTexture() and enable queue related tests
...
Bug: dawn:1705
Change-Id: I63540d46335401aeaa46efe157fdb7a191aa4637
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/128860
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-28 19:01:32 +00:00
Peng Huang
85d98a91f7
d3d11: fix and enable viewport end2end tests
...
Bug: dawn:1705
Change-Id: Ie75f301465b5000c9ebdd58ab0cb1901d251730e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/128862
Commit-Queue: Peng Huang <penghuang@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-04-28 19:01:18 +00:00
Dawn Autoroller
0621416bf4
Roll SwiftShader from f0d31e0f4846 to d3052046cbff (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/f0d31e0f4846..d3052046cbff
2023-04-28 natsu@google.com Fix vulkan.pastel.debug build
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC enga@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: enga@google.com
Change-Id: I2f0608aacdf0991cc487d8da26dbfe0b5afaa14e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130280
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-28 18:05:11 +00:00
Peng Huang
e5a4cfb935
d3d11: enable some CopyTests
...
To make B2B, B2T and T2B testes work, this CL implements several
missed functions:
- Texture::Clear() is need for initializing texture data
- Texture::Read() is need for readback data from 2d and 3d textures
Bug: dawn:1740,dawn:1768
Change-Id: Ib9e354c82fcdc8cc4e86b1699fa652cfc4a50721
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/128621
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-04-28 17:22:03 +00:00
François Beaufort
ad571cfb7c
Add new errors to WGPUBufferMapAsyncStatusStatus
...
This CL adds "mapping already pending", "offset out of range",
"size out of range", and "validation error".
Those errors will be used in future CLs both in Dawn and Blink.
Bug: chromium:1431622
Change-Id: I70121f49542042b47e30f4acc67a8e9a869fc452
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130260
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Fr <beaufort.francois@gmail.com>
2023-04-28 17:07:45 +00:00
Peng Huang
d7a4483148
d3d: move some external image related code to d3d namespace
...
Expect ExternalImageDXGIImpl, most external image related code can
be shared between d3d11 and d3d12. This CL move those code into
d3d namespace
Bug: dawn:1724
Change-Id: I6c32cfd36880d4d009b272886a9369dc99dffbe6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130100
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2023-04-28 16:53:28 +00:00
Austin Eng
220aa01153
Fix name of libdawn_webgpu_dawn to libwebgpu_dawn
...
Fixed: dawn:1298
Change-Id: I7a32b644349837fcfc5e258232285b591f7e99a8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/129860
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2023-04-28 15:14:37 +00:00
Corentin Wallez
96b61c56fa
Remove support for macOS 10.11 and 10.12
...
Fixed: dawn:1397
Change-Id: I58c899bb58c445d56c544828a52eddd720bc4847
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/129840
Reviewed-by: Brandon Jones <bajones@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2023-04-28 11:55:21 +00:00
Dawn Autoroller
161d8abf91
Roll ANGLE from b875f47b0fbf to d5eee882efc0 (3 revisions)
...
b875f47b0f..d5eee882ef
2023-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e055a80240d4 to 82c53dbf916a (663 revisions)
2023-04-27 romanl@google.com Revert "When asserts enabled, log validation errors as WARN"
2023-04-27 cclao@google.com Vulkan: Clean up some of trace events
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,enga@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: enga@google.com
Change-Id: I2021fa03ce838db7b6275ed7042dbec70a82f7d1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130240
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-28 11:05:21 +00:00