Antonio Maiorano
d733fdb85c
HLSL: work around FXC failures when dynamically indexing arrays in structs
...
FXC fails to compile code that assigns to dynamically-indexed fixed-size
arrays in structs on internal shader variables with:
error X3500: array reference cannot be used as an l-value; not natively
addressable
This CL detects this case, and transforms such assignments into copying
out the array to a local variable, assigning to that local, and then
copying the array back.
Also manually regenerate SKIPs for HLSL/FXC after this change, which
fixes 30 tests. Also exposes some "compilation aborted unexpectedly" now
that "array reference cannot be used as an l-value" has been fixed. For
tests that fail for both DXC and FXC, updating SKIPs to the DXC one to
help distinguish actual FXC bugs from valid errors.
Bug: tint:998
Bug: tint:1206
Change-Id: I09204d8d81ab27d1c257538ad702414ccc386543
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71620
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-12-13 15:55:11 +00:00
..
2021-07-13 16:41:56 +00:00
2021-11-16 15:15:36 +00:00
2021-07-13 16:41:56 +00:00
2021-10-20 16:12:33 +00:00
2021-07-13 16:41:56 +00:00
2021-07-13 16:41:56 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-11-25 18:44:50 +00:00
2021-10-28 15:00:39 +00:00
2021-06-10 17:34:44 +00:00
2021-12-09 15:45:03 +00:00
2021-06-16 09:50:11 +00:00
2021-11-16 15:15:36 +00:00
2021-08-04 22:15:28 +00:00
2021-08-04 22:15:28 +00:00
2021-08-05 17:34:19 +00:00
2021-06-16 09:50:11 +00:00
2021-12-09 15:45:03 +00:00
2021-11-16 15:15:36 +00:00
2021-06-16 09:19:36 +00:00
2021-10-28 15:00:39 +00:00
2021-06-16 09:19:36 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-11-16 15:15:36 +00:00
2021-07-08 12:00:31 +00:00
2021-10-28 15:00:39 +00:00
2021-07-08 12:00:31 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-04 22:15:28 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-06-10 18:49:14 +00:00
2021-11-19 19:06:23 +00:00
2021-10-14 10:10:45 +00:00
2021-10-20 16:12:33 +00:00
2021-10-14 10:10:45 +00:00
2021-11-04 19:55:57 +00:00
2021-11-04 19:55:57 +00:00
2021-11-19 19:06:23 +00:00
2021-10-14 10:10:45 +00:00
2021-10-20 16:12:33 +00:00
2021-10-14 10:10:45 +00:00
2021-11-04 19:55:57 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-06-16 09:19:36 +00:00
2021-10-28 15:00:39 +00:00
2021-06-10 17:34:44 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 18:54:35 +00:00
2021-11-25 18:44:50 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 18:54:35 +00:00
2021-11-25 18:44:50 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-05-17 21:01:37 +00:00
2021-12-09 15:45:03 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 18:54:35 +00:00
2021-11-25 18:44:50 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-06-10 18:49:14 +00:00
2021-11-16 15:15:36 +00:00
2021-06-16 09:19:36 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-05-17 21:01:37 +00:00
2021-11-16 15:15:36 +00:00
2021-07-05 15:20:57 +00:00
2021-06-16 09:19:36 +00:00
2021-05-18 09:24:18 +00:00
2021-05-18 09:24:18 +00:00
2021-06-10 18:49:14 +00:00
2021-11-16 15:15:36 +00:00
2021-12-09 15:45:03 +00:00
2021-11-08 20:16:48 +00:00
2021-11-08 20:16:48 +00:00
2021-11-08 20:16:48 +00:00
2021-06-10 18:49:14 +00:00
2021-11-16 15:15:36 +00:00
2021-12-09 15:45:03 +00:00
2021-11-08 20:16:48 +00:00
2021-11-08 20:16:48 +00:00
2021-11-08 20:16:48 +00:00
2021-06-16 17:42:53 +00:00
2021-11-16 15:15:36 +00:00
2021-08-04 22:15:28 +00:00
2021-10-20 16:12:33 +00:00
2021-08-05 17:34:19 +00:00
2021-06-16 17:42:53 +00:00
2021-06-16 17:42:53 +00:00
2021-11-16 15:15:36 +00:00
2021-11-23 20:45:51 +00:00
2021-11-23 20:45:51 +00:00
2021-06-16 17:42:53 +00:00
2021-06-16 17:42:53 +00:00
2021-12-09 15:45:03 +00:00
2021-11-19 19:06:23 +00:00
2021-08-04 22:15:28 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-06-16 09:50:11 +00:00
2021-12-09 15:45:03 +00:00
2021-11-25 18:44:50 +00:00
2021-10-28 15:00:39 +00:00
2021-06-17 09:10:04 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 18:54:35 +00:00
2021-08-04 22:15:28 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 18:54:35 +00:00
2021-11-25 18:44:50 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-11-16 15:15:36 +00:00
2021-09-20 14:38:45 +00:00
2021-10-28 15:00:39 +00:00
2021-09-20 14:38:45 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-04 22:15:28 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-11-25 18:44:50 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-07-02 22:17:25 +00:00
2021-11-19 17:46:13 +00:00
2021-11-25 18:44:50 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-11-16 15:15:36 +00:00
2021-11-25 18:44:50 +00:00
2021-12-03 21:50:23 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-11-16 19:13:36 +00:00
2021-11-25 18:44:50 +00:00
2021-12-03 21:50:23 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-07-06 09:43:49 +00:00
2021-11-18 13:11:43 +00:00
2021-08-04 22:15:28 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-10-22 00:21:44 +00:00
2021-10-28 15:00:39 +00:00
2021-10-22 00:21:44 +00:00
2021-12-09 15:45:03 +00:00
2021-07-15 22:36:44 +00:00
2021-11-16 19:13:36 +00:00
2021-08-04 22:15:28 +00:00
2021-10-28 15:00:39 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-07-14 18:01:36 +00:00
2021-11-16 15:15:36 +00:00
2021-08-04 22:15:28 +00:00
2021-08-12 19:47:20 +00:00
2021-08-05 17:34:19 +00:00
2021-07-14 18:01:36 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-04 22:15:28 +00:00
2021-12-03 21:50:23 +00:00
2021-08-05 17:34:19 +00:00
2021-12-09 15:45:03 +00:00
2021-07-15 22:20:29 +00:00
2021-11-16 15:15:36 +00:00
2021-11-25 18:44:50 +00:00
2021-07-15 22:20:29 +00:00
2021-07-15 22:20:29 +00:00
2021-07-15 22:20:29 +00:00
2021-07-18 15:41:25 +00:00
2021-11-22 16:14:16 +00:00
2021-08-04 22:15:28 +00:00
2021-08-04 22:15:28 +00:00
2021-08-05 17:34:19 +00:00
2021-07-18 15:41:25 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-07-15 20:29:09 +00:00
2021-10-28 15:00:39 +00:00
2021-07-15 20:29:09 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-10-28 15:00:39 +00:00
2021-07-15 20:29:09 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-11-16 15:15:36 +00:00
2021-10-22 00:21:44 +00:00
2021-10-28 15:00:39 +00:00
2021-10-22 00:21:44 +00:00
2021-12-09 15:45:03 +00:00
2021-07-29 18:05:19 +00:00
2021-11-16 15:15:36 +00:00
2021-11-25 18:44:50 +00:00
2021-07-29 18:05:19 +00:00
2021-07-29 18:05:19 +00:00
2021-07-29 18:05:19 +00:00
2021-08-04 22:15:28 +00:00
2021-11-16 15:15:36 +00:00
2021-08-04 22:15:28 +00:00
2021-08-04 22:15:28 +00:00
2021-08-05 17:34:19 +00:00
2021-08-04 22:15:28 +00:00
2021-11-10 14:38:34 +00:00
2021-11-16 15:15:36 +00:00
2021-11-25 18:44:50 +00:00
2021-11-10 14:38:34 +00:00
2021-11-10 14:38:34 +00:00
2021-11-10 14:38:34 +00:00
2021-07-29 18:05:19 +00:00
2021-11-16 15:15:36 +00:00
2021-10-14 10:10:45 +00:00
2021-07-29 18:05:19 +00:00
2021-07-29 18:05:19 +00:00
2021-07-29 18:05:19 +00:00
2021-08-04 19:18:38 +00:00
2021-11-16 15:15:36 +00:00
2021-08-04 19:18:38 +00:00
2021-08-04 19:18:38 +00:00
2021-08-04 19:18:38 +00:00
2021-08-04 19:18:38 +00:00
2021-08-06 19:48:32 +00:00
2021-12-09 15:45:03 +00:00
2021-08-10 16:16:55 +00:00
2021-10-28 15:00:39 +00:00
2021-08-10 16:16:55 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 18:54:35 +00:00
2021-08-12 18:23:10 +00:00
2021-12-03 21:50:23 +00:00
2021-08-12 18:23:10 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 18:54:35 +00:00
2021-11-25 18:44:50 +00:00
2021-12-03 21:50:23 +00:00
2021-11-05 16:51:38 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-11-16 15:15:36 +00:00
2021-08-26 15:40:06 +00:00
2021-10-28 15:00:39 +00:00
2021-08-26 15:40:06 +00:00
2021-12-09 15:45:03 +00:00
2021-11-25 18:02:36 +00:00
2021-11-26 15:28:49 +00:00
2021-11-25 18:02:36 +00:00
2021-11-25 18:02:36 +00:00
2021-11-25 18:02:36 +00:00