encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/test/tint/builtins
History
Antonio Maiorano 06844a5e24 tint/hlsl: remove [loop] attribute on all loops 
I added the forcing of the "loop" attribute to all loops to address FXC
failing on uniformity errors related to gradients in loops. Since then,
Tint now implements UA and it recently became an error, so we no longer
need this hack. As a result, FXC is now better able to cope with loops
that it determines executes 0 times.

Most e2e tests are affected because so many use loops, but 27 tests that
were previously failing are now passing with this change:

tint/bug/tint/1538.wgsl.expected.fxc.hlsl
tint/bug/tint/1604.wgsl.expected.fxc.hlsl
tint/bug/tint/1605.wgsl.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_ClassifyCFGEdges_LoopBreak_FromLoopHeader_SingleBlockLoop_TrueBranch.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_ComputeBlockOrder_Loop_HeaderHasBreakUnless.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_EmitBody_IfSelection_TrueBranch_LoopBreak.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_FindIfSelectionInternalHeaders_TrueBranch_LoopBreak_Ok.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserFunctionVarTest_EmitStatement_Phi_MultiBlockLoopIndex.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserFunctionVarTest_EmitStatement_Phi_SingleBlockLoopIndex.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/cov-dead-code-unreachable-merge/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/cov-dead-code-unreachable-merge/0-opt.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/similar-nested-ifs/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/similar-nested-ifs/0-opt.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/spv-load-from-frag-color/1.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/spv-load-from-frag-color/1.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/0.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/0.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/0.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/0.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/1.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/1.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/0-opt.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/1.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/1.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/write-red-after-search/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/write-red-after-search/0-opt.wgsl.expected.fxc.hlsl

Bug: tint:1522
Bug: tint:1538
Bug: tint:1604
Bug: tint:1605
Change-Id: I530b846b6b8df122ab351ff7b85d3e1c9ac11526
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104121
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 		2022-09-29 16:53:58 +00:00
..
arrayLength GLSL: Change Add[Spirv]BlockAttribute to support GLSL 2022-09-02 19:19:10 +00:00
atomicStore tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
atomics/from_gen tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
extractBits tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
gen tint/fxc: delete and regen skips for e2e tests to capture FXC error messages in expected file 2022-09-26 14:24:35 +00:00
insertBits tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
textureDimensions tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
textureGather tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
textureLoad GLSL: implement host-visible memory padding. 2022-09-13 19:48:51 +00:00
textureNumSamples tint/val: Make DXC validation output stable 2022-07-26 14:23:24 +00:00
degrees.spvasm tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
degrees.spvasm.expected.dxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
degrees.spvasm.expected.fxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
degrees.spvasm.expected.glsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
degrees.spvasm.expected.msl tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
degrees.spvasm.expected.spvasm tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
degrees.spvasm.expected.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
frexp.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
frexp.wgsl.expected.dxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
frexp.wgsl.expected.fxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
frexp.wgsl.expected.glsl tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
frexp.wgsl.expected.msl tint: Implement modf and frexp built-ins for f16 types 2022-08-05 15:11:44 +00:00
frexp.wgsl.expected.spvasm tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
frexp.wgsl.expected.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
modf.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
modf.wgsl.expected.dxc.hlsl tint: Implement modf and frexp built-ins for f16 types 2022-08-05 15:11:44 +00:00
modf.wgsl.expected.fxc.hlsl tint: Implement modf and frexp built-ins for f16 types 2022-08-05 15:11:44 +00:00
modf.wgsl.expected.glsl tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
modf.wgsl.expected.msl tint: Implement modf and frexp built-ins for f16 types 2022-08-05 15:11:44 +00:00
modf.wgsl.expected.spvasm tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
modf.wgsl.expected.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
radians.spvasm tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
radians.spvasm.expected.dxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
radians.spvasm.expected.fxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
radians.spvasm.expected.glsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
radians.spvasm.expected.msl tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
radians.spvasm.expected.spvasm tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
radians.spvasm.expected.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
repeated_use.wgsl tint: transform::RemovePhonies: skip builtins with no side effects 2022-08-01 17:21:54 +00:00
repeated_use.wgsl.expected.dxc.hlsl tint: transform::RemovePhonies: skip builtins with no side effects 2022-08-01 17:21:54 +00:00
repeated_use.wgsl.expected.fxc.hlsl tint: transform::RemovePhonies: skip builtins with no side effects 2022-08-01 17:21:54 +00:00
repeated_use.wgsl.expected.glsl tint: transform::RemovePhonies: skip builtins with no side effects 2022-08-01 17:21:54 +00:00
repeated_use.wgsl.expected.msl tint: transform::RemovePhonies: skip builtins with no side effects 2022-08-01 17:21:54 +00:00
repeated_use.wgsl.expected.spvasm Remove isNan, isInf, isFinite, and isNormal 2022-03-05 00:39:14 +00:00
repeated_use.wgsl.expected.wgsl tint: transform::RemovePhonies: skip builtins with no side effects 2022-08-01 17:21:54 +00:00