AxioDL
/
metaforce
mirror of https://github.com/AxioDL/metaforce.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,628 Commits 26 Branches 15 Tags 52 MiB
Commit Graph

3628 Commits

Author SHA1 Message Date
Lioncash dd7d9c024f CGameLight: Add parameter names to function prototypes 
Same behavior, but more self-documenting from interface alone. Also
allows better parameter introspection.
 2020-04-06 08:46:38 -04:00
Lioncash 5f7a33e2ec CThardus: convert 0 literal to false 
Same behavior, but matches the type of the parameter.
 2020-04-06 08:43:41 -04:00
Lioncash 0a0ac955b5 CThardus: std::move std::vector instance in constructor 
Same behavior, no reallocations.
 2020-04-06 08:41:18 -04:00
Lioncash 6e7e761126 CCollidableOBBTree: Don't cast away const in constructor 
Same behavior, minus a cast.
 2020-04-06 07:11:34 -04:00
Lioncash 0e0ca4caa9 CAnimSource: Eliminate variable shadowing 
Gets rid of two -Wshadow warnings.
 2020-04-06 07:04:49 -04:00
Lioncash f7962cb3f7 CRasterFont: Extend CFontInfo buffer to 64 characters 
GM8E v0 seems to be using at least a buffer 64 characters in size, not
40.
 2020-04-06 06:59:22 -04:00
Lioncash 296cb3df2b CMemoryCardDriver: Make use of std::array where applicable 
Stronger typing and also allows eliminating several hardcoded data
sizes.
 2020-04-06 06:23:48 -04:00
Lioncash c97fedd989 CCollisionSurface: Return std::array by reference from GetVerts() 
Same behavior, facilitates better static analysis for out-of-bounds
accesses, and also even allows size querying if necessary.
 2020-04-06 06:02:52 -04:00
Lioncash ecf3cfdb49 CCollisionSurface: Collapse separate CVector3f instances into std::array 
Will allow converting GetVertices() over to returning a reference to
std::array, rather than simply a pointer.
 2020-04-06 05:54:24 -04:00
Lioncash 41c2ede092 CScriptWater: Make private const data internally linked 
Same behavior, but allows completely hiding it from external view and
also allows making the data constexpr.
 2020-04-06 05:42:15 -04:00
Lioncash c9e8b3366d CFluidPlane: Resolve constness related compile errors that slipped through 
Gotta love Find References not, in fact, finding all the references.
 2020-04-06 05:31:09 -04:00
Lioncash f0eadfe56c CMetroidAreaCollider: Make use of std::array where applicable 
Makes arrays strongly typed and allows eliminating some hardcoded array
sizes. We can also use it to make input data to some data types and
functions significantly more informative.

This also makes it easier for static analysis tools to track out of
bounds accesses if they ever occur.
 2020-04-06 05:19:13 -04:00
Lioncash d708337e90 CScriptDamageableTrigger: Make member variables private 
Previously, everything about the class was made public.
 2020-04-06 04:48:10 -04:00
Lioncash 27f3078c8a CScriptDamageableTrigger: Mark x254_fluidPlane as mutable 
A temporary stop-gap to hold over until Render is made non-const.
 2020-04-06 04:45:33 -04:00
Lioncash 741adfe45c CPASAnimParm: Make constexpr capable 
Allows the type to be used in constexpr scenarios and allows for
compile-time elimination of initializers.
 2020-04-06 02:55:05 -04:00
Lioncash 402216447a CFluidPlane: Make Render() non-const 
Allows making the shader instances non-mutable.
 2020-04-06 02:18:14 -04:00
Lioncash 22eb5c837e CollisionUtil: Make use of const where applicable 
Makes it explicit which variables are mutating within algorithms, making
them nicer to follow.
 2020-04-06 02:02:52 -04:00
Lioncash 39f5fddd63 CollisionUtil: Make use of std::array where applicable 
Same behavior, stronger typing. Also allows dehardcoding some array
sizes.
 2020-04-06 01:41:16 -04:00
Lioncash 80c6424fd0 CCollidableOBBTree: Eliminate variable shadowing 
Resolves a -Wshadow warning.
 2020-04-06 01:23:08 -04:00
Lioncash c3ba3927db CCollidableOBBTree: Make use of std::array where applicable 
Same behavior, stronger typing.
 2020-04-06 01:21:20 -04:00
Lioncash e76804079d COBBTree: Return std::array from GetTriangleVertexIndices() directly 
While the game binary uses an out pointer here, we can slightly modify
it in this case in order to make it more difficult to misuse the
call-sites by returning the data directly as a std::array.
 2020-04-06 01:17:24 -04:00
Lioncash 248a4e57c9 COBBTree: Always initialize x4c_hit 
Same behavior, but provides deterministic state on construction, which
can make debugging much nicer.
 2020-04-06 01:05:29 -04:00
Lioncash c6952442c7 COBBTree: Remove use of operator bool directly 
Same behavior, but more idiomatic.
 2020-04-06 01:01:44 -04:00
Lioncash e34db8c0e6 COBBTree: Eliminate sign conversion warnings 
Multiplying a u16 results in an int.
 2020-04-06 01:00:58 -04:00
Lioncash 19cfb92d5d COBBTree: Simplify make_unique call 
We can use nullptr here instead of typing out the name of the type.
 2020-04-06 00:51:04 -04:00
Luke Street 58adce472a CMappableObject: Fix call to data() 2020-04-06 00:03:34 -04:00
Lioncash fa2f37a14c DNAMP3/PAK: Make use of unique_ptr in getBuffer() 
Same motivation as the previous change: seating the allocated memory
into a type that will always do the right thing immediately, rather than
later.
 2020-04-05 10:20:59 -04:00
Lioncash 9e503edaf1 PAK: Make use of unique_ptr in getBuffer() 
Same behavior, however we seat the allocated memory into a unique_ptr
from the get-go to prevent any possible memory being leaked.
 2020-04-05 10:16:09 -04:00
Lioncash f77fb2089b General: Pass std::nullopt to CAnimData::Render instead of {} 
Prevents some implementations (libstdc++ and libc++) from completely zeroing out the underlying
buffer and instead sets a single byte flag.

Eliminates unnecessary memsets.
 2020-04-05 08:24:42 -04:00
Phillip Stephens 786634e181
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde 2020-04-05 05:13:14 -07:00
Phillip Stephens eab08cbe2d
Merge branch 'lioncash-find' 2020-04-05 05:12:25 -07:00
Phillip Stephens 77bf10f8f1
Merge branch 'lioncash-constexpr5' 2020-04-05 05:12:12 -07:00
Lioncash 0a7ccace44 CCharacterFactory: Eliminate usages of const_cast within CreateCharacter() 
We can simply make this member function non-const and eliminate the need
for casts like this.
 2020-04-05 08:11:51 -04:00
Phillip Stephens 7feae73855
Merge branch 'lioncash-build' 2020-04-05 05:11:50 -07:00
Phillip Stephens 5fc8f2ccd2
Merge branch 'find' of https://github.com/lioncash/urde into lioncash-find 2020-04-05 05:11:20 -07:00
Phillip Stephens 28853f5ea6
Merge branch 'constexpr5' of https://github.com/lioncash/urde into lioncash-constexpr5 2020-04-05 05:10:42 -07:00
Phillip Stephens 5d803c76c4
Merge branch 'build' of https://github.com/lioncash/urde into lioncash-build 2020-04-05 05:09:51 -07:00
Lioncash b99122dae8 CFrontEndUI: Remove use of const_cast in Draw() 
These casts are no longer necessary.
 2020-04-05 07:12:07 -04:00
Lioncash 4d2e51c0b9 CSamusHud: Make Draw() non-const 
Allows eliminating usages of const_cast.
 2020-04-05 07:09:13 -04:00
Lioncash 3e9e434d96 CPlayerVisor: Make Draw() non-const 
Allows eliminating const_cast usages.
 2020-04-05 07:00:40 -04:00
Lioncash be4e7f8ff7 CMFGame: Remove unnecessary const_cast 
This is no longer necessary, considering that Draw() isn't const
qualified anymore.
 2020-04-05 06:52:19 -04:00
Lioncash a952ff1110 CCollisionEdge: Make constructors constexpr 
Makes the default and non-stream iterator constexpr, which allows for
elimination of a runtime initializer.
 2020-04-05 06:46:03 -04:00
Lioncash af6e3b21f8 COBBTree: Make use of std::array where applicable 2020-04-05 06:41:22 -04:00
Lioncash 039e43c511 CMapWorldInfo: Actually add the mutable specifiers 
Note to self, actually stage changes before pushing.
 2020-04-05 06:36:17 -04:00
Lioncash 42c560b9df CMapWorldInfo: Remove use of const_cast 
Same behavior, but explicitly marks the member variables as mutable.
This is fine given they act as an underlying cache and don't directly
alter the behavior of the interface.
 2020-04-05 06:30:25 -04:00
Lioncash 2755f3f4f8 CMapWorldInfo: Eliminate truncation and sign conversion warnings 2020-04-05 06:29:27 -04:00
Lioncash 755529b67a CMappableObject: Make use of std::array where applicable 
Same behavior, but also allows eliminating hardcoded array sizes.
 2020-04-05 06:15:18 -04:00
Lioncash 94264f6fe6 CRasterFont: Collapse loop into a std::find_if in InternalGetGlyph() 
Same behavior, less code.
 2020-04-05 06:01:29 -04:00
Lioncash 1279be5e56 CGraphics: Mark internal file-scope matrices as constexpr 
Same behavior, but allows omission of runtime initializers.
 2020-04-05 05:48:54 -04:00
Lioncash 95199848d3 CGraphics: Make use of std::array where applicable 2020-04-05 05:46:07 -04:00