James Price
3a4443a681
spirv: Add block decorations with a transform
...
Any struct which is used as the store type of a buffer variable needs
to have a block decoration. If that struct is nested inside an array
or another struct, we wrap it inside another struct first.
This removes the SPIR-V backend's reliance on the [[block]] attribute,
which will soon be deprecated and removed.
Bug: tint:1324
Change-Id: Ib6ad54f24a3e4a090da9faeed699f266abcb66ba
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/72082
Kokoro: Kokoro <noreply+kokoro@google.com >
Reviewed-by: Ben Clayton <bclayton@google.com >
2021-12-09 15:45:03 +00:00
James Price
ac8975f291
validation: Remove requirement for block attribute
...
Replace all validation rules that rely on the block attribute with the
new rules based on fixed-footprint types.
Bug: tint:1324
Change-Id: I02656537bee66e6e1af95875e503a37bf23d4a6b
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/72081
Kokoro: Kokoro <noreply+kokoro@google.com >
Reviewed-by: Ben Clayton <bclayton@google.com >
2021-12-09 15:45:03 +00:00
Ben Clayton
81b3948649
resolver: Implement element inference of vecN and matNxM
...
Fixed: tint:1334
Change-Id: Idc94d49ecd41e37354bb93138348e3af3e733932
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/72143
Reviewed-by: David Neto <dneto@google.com >
Kokoro: Kokoro <noreply+kokoro@google.com >
2021-12-09 14:37:37 +00:00
Ben Clayton
f91b02bba1
test: Add vector constructor tests
...
These test vector constructors with an explicit element type.
Bug: tint:1334
Change-Id: I3d0f626e42850e841cffd70241274e32dcb75fbb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/72142
Kokoro: Kokoro <noreply+kokoro@google.com >
Reviewed-by: Antonio Maiorano <amaiorano@google.com >
2021-12-09 14:37:37 +00:00
Ben Clayton
e306927ff5
test: Add matrix constructor tests that take a vector
...
Bug: tint:1334
Change-Id: I7e625da4bd270b6d0bfdb43fbd8dbe41682180f9
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/72141
Kokoro: Kokoro <noreply+kokoro@google.com >
Reviewed-by: Antonio Maiorano <amaiorano@google.com >
2021-12-09 14:37:37 +00:00
Ben Clayton
cf09c23a12
test: Shuffle matrix constructor tests
...
Move these under test/expressions, and rework the directory structure so we can test vector arguments and inferred element types.
Bug: tint:1334
Change-Id: I411fd7ce1ecdd50c6ef9b79be8407c09a6d38240
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/72140
Kokoro: Kokoro <noreply+kokoro@google.com >
Reviewed-by: Antonio Maiorano <amaiorano@google.com >
Commit-Queue: Ben Clayton <bclayton@google.com >
2021-12-09 14:37:37 +00:00
Dawn Autoroller
908f4fe689
Roll Tint from a8c202b8e7 to 0fe30b52a5 (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/a8c202b8e779..0fe30b52a5c9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Icadb6a70dc6a524c3ad98a2dc9b37f3ee8ab6d07
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/72280
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-09 10:44:39 +00:00
James Price
0fe30b52a5
single_entry_point: Retain applied transforms
...
This transform does not use the top-level ctx.Clone() method, so we
need to manually copy the applied transforms over to the destination
program.
This fixes the GLSL backend, where this transform was dropping the
applied transforms and breaking a required transform dependency later
in the chain.
Change-Id: I3db688fe35dfbe67468b9941f739cb2ecf3a843b
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/72220
Kokoro: Kokoro <noreply+kokoro@google.com >
Reviewed-by: Ben Clayton <bclayton@google.com >
Commit-Queue: Ben Clayton <bclayton@google.com >
2021-12-09 09:18:44 +00:00
Dawn Autoroller
3b06c01bbb
Roll ANGLE from 16ce5226e896 to 0e291f60ccbf (3 revisions)
...
16ce5226e8..0e291f60cc
2021-12-09 ynovikov@chromium.org Skip couple flaky end2end tests on Pixel 4
2021-12-08 jmadill@chromium.org Frame Capture: Fix client buffers in MEC.
2021-12-08 ynovikov@chromium.org Sync logdog with Chromium
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I857cebc23f6b0921ca7c2dd6f4022dbd4a87f0f4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/72260
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-09 07:55:09 +00:00
Jiawei Shao
264f239259
dawn_wire: Remove unused support of "const*const*"
...
This patch removes the support of annotation "const*const*" in
the template WireCmd.cpp as it is not used in current Dawn wire
implementation.
BUG=chromium:1266727
Change-Id: I4c4d68ccc050edb5f855094910440e90aef2bc4a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/72040
Reviewed-by: Corentin Wallez <cwallez@chromium.org >
Reviewed-by: Austin Eng <enga@chromium.org >
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com >
2021-12-09 02:43:28 +00:00
Jiawei Shao
b6d80e027d
dawn_wire: Rename Write{Buffer|Texture}Internal to Write{Buffer|Texture}
...
BUG=chromium:1266727
Change-Id: I3cad4c7b6b09ef4475ff030a5d239f544dc1cdef
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/72066
Reviewed-by: Corentin Wallez <cwallez@chromium.org >
Reviewed-by: Austin Eng <enga@chromium.org >
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com >
2021-12-09 02:42:47 +00:00
Dawn Autoroller
78b6b5ef31
Roll Tint from 3703522d41 to a8c202b8e7 (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/3703522d41de..a8c202b8e779
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I4280820154aa4c7ab0aa05a499b354356d462f2a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/72181
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-09 01:57:58 +00:00
Antonio Maiorano
a8c202b8e7
HLSL: work around FXC failures when dynamically indexing matrices
...
This fixes errors like "error X3500: array reference cannot be used as
an l-value; not natively addressable". Note that FXC treats matrices
like arrays. We still get this error for dynamically indexed arrays in
structs.
Also improved HLSL assign tests, and add missing ones for vector
indexing.
Manually removed 20 e2e skip hlsl SKIP files that are now passing with
this change.
Bug: tint:1333
Change-Id: If23881a667857a4d4ec6881e72666af0a666ef10
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71982
Reviewed-by: Ben Clayton <bclayton@google.com >
Kokoro: Kokoro <noreply+kokoro@google.com >
Commit-Queue: Antonio Maiorano <amaiorano@google.com >
2021-12-08 23:03:33 +00:00
Dawn Autoroller
a97f7520ec
Roll Tint from 2f7730a16e to 3703522d41 (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/2f7730a16ead..3703522d41de
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ice71a3c63feef46fb968979a763e5965b50699f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/72180
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-08 20:56:47 +00:00
Loko Kung
79f62081c0
Fixes bad mem-read in Vulkan's ~DescriptorSetAllocator.
...
Bug was a result of an external BGL reference that lingered after device was destroyed leading to a bad read on the device's FencedDeleter when the BGL reference was finally released. Fix just makes sure that the previous code path runs during the device destruction instead of afterwards.
- Removes passthrough call in BGL to the allocator and instead has the device keep track of the allocator directly so that the list can be used to both deallocate bind groups and bind group layouts at the end.
- Makes the allocator an ObjectBase so that we can have an explicit copy of the device since getting it from the layout can be dangerous now that the allocator may outlive the layout.
Bug: chromium:1276928
Change-Id: Ibca5e3c313fc0c0980ecaaa9ad2c871e204ac153
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71860
Reviewed-by: Austin Eng <enga@chromium.org >
Commit-Queue: Loko Kung <lokokung@google.com >
2021-12-08 20:27:14 +00:00
Ben Clayton
3703522d41
Implement textureGather, textureGatherCompare
...
All writers implemented, along with resolving and validation.
TODO: SPIR-V Reader.
Bug: tint:1330
Change-Id: I8ba2f6023749474f80efb8a5422ac187e6c73a69
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71820
Reviewed-by: David Neto <dneto@google.com >
Commit-Queue: Ben Clayton <bclayton@google.com >
Kokoro: Ben Clayton <bclayton@google.com >
2021-12-08 19:54:08 +00:00
Dawn Autoroller
bb62d62d31
Roll ANGLE from b007e667a8f9 to 16ce5226e896 (10 revisions)
...
b007e667a8..16ce5226e8
2021-12-08 timvp@google.com Vulkan: Re-enable RGB8 for pbuffers.
2021-12-08 syoussefi@chromium.org Vulkan: Fix deferred flush vs UtilsVk
2021-12-08 lubosz.sarnecki@collabora.com Reland "system_utils: Add memory protection functionality."
2021-12-08 timvp@google.com Add more support for GL_RGBX8_ANGLE
2021-12-08 jmadill@chromium.org Frame Capture: Track written files in ReplayWriter.
2021-12-08 jmadill@chromium.org Add a multi-context sample.
2021-12-08 jmadill@chromium.org Frame Capture: Track return value in max resource IDs.
2021-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5c0e64524982 to bc087f672f16 (3 revisions)
2021-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3e61a772b248 to a4232c15e287 (3 revisions)
2021-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 111e348dc9b4 to e1fa86b1827a (530 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ic7d2d31a2362b0c2a1a87e19d143ab293c0858ec
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/72120
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-08 19:11:27 +00:00
Brandon Jones
370e6bd734
Validate stripIndexFormat at draw time.
...
Updates validation logic to match the recent changes in
https://github.com/gpuweb/gpuweb/pull/2385 that allows stripIndexFormat
to be undefined at pipeline creation time, even for strip topologies.
Non indexed draw calls are valid with such pipelines. Indexed draw calls
fail validation at draw time.
Bug: dawn:1224
Change-Id: I28ff78eac726d46f99a099ffb2338b5da81a4a88
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/72000
Reviewed-by: Corentin Wallez <cwallez@chromium.org >
Commit-Queue: Brandon Jones <bajones@chromium.org >
2021-12-08 17:24:37 +00:00
fujunwei
ed33e05db1
Move EnumClassBitmasks from wgpu to dawn namespace
...
The EnumClassBitmasks is used by dawn/api_cpp.h that needs to be common.
Define a macro to export the operators from dawn to other various namespace.
BUG=dawn:1201
Change-Id: I20badd54e844fead6ecf12546a2c9e0afa2fd83f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71900
Reviewed-by: Corentin Wallez <cwallez@chromium.org >
Reviewed-by: Austin Eng <enga@chromium.org >
Commit-Queue: Junwei Fu <junwei.fu@intel.com >
2021-12-08 05:46:17 +00:00
Dawn Autoroller
ef572ba7a1
Roll Tint from b2bbb14bd4 to 2f7730a16e (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/b2bbb14bd413..2f7730a16ead
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ia0be3cba283986d5cdba69c85f2270d4e20e7b0f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/72061
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-08 05:09:57 +00:00
Dawn Autoroller
d33edeb08f
Roll ANGLE from f4553165703a to b007e667a8f9 (8 revisions)
...
f455316570..b007e667a8
2021-12-08 kainino@chromium.org Revert "system_utils: Add memory protection functionality."
2021-12-07 kbr@chromium.org Add kbr as code owner.
2021-12-07 ynovikov@chromium.org Reland "Decouple gl_BaseVertex/gl_BaseInstance uniforms"
2021-12-07 lubosz.sarnecki@collabora.com trace_fixture: Add UpdateClientBufferData2WithOffset.
2021-12-07 jmadill@chromium.org Frame Capture: Fix missing header include in shared setup.
2021-12-07 lubosz.sarnecki@collabora.com system_utils: Add memory protection functionality.
2021-12-07 lubosz.sarnecki@collabora.com tests/AndroidManifest: Disable allowNativeHeapPointerTagging.
2021-12-07 bsheedy@chromium.org Remove Skia Gold master usage
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ia19b4b55f32b3b4da4b9fa2fc0c8759334ff5e20
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/72060
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-08 04:30:59 +00:00
Antonio Maiorano
2f7730a16e
Manually generate HLSL skip files for vk-gl-cts e2e tests
...
It seems we haven't run our e2e tests with FXC validation in a long time
- at least not since we've added the vk-gl-cts corpus.
Locally disabled exclusion of "/test/vk-gl-cts/" in test-runner/main.go,
and ran:
./test/test-all.sh out/build/x64-Debug/tint.exe --format hlsl --fxc --generate-skip
These will need to be manually removed once the skips aren't needed by
deleting them all, and re-running as above.
Bug: tint:940
Change-Id: I27e395e69f5e1bd7d234f3155f40396b751720d4
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71981
Kokoro: Kokoro <noreply+kokoro@google.com >
Reviewed-by: Ben Clayton <bclayton@google.com >
Commit-Queue: Antonio Maiorano <amaiorano@google.com >
2021-12-08 04:26:58 +00:00
Zhaoming Jiang
53137bd57d
Remove wgpu::ErrorFilter::None
...
Remove wgpu::ErrorFilter::None from Dawn as it is removed from the
specification.
Bug: dawn:1206
Change-Id: If8ec2722cf1b2bad380011f191f296f0e591646d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71607
Reviewed-by: Corentin Wallez <cwallez@chromium.org >
Reviewed-by: Austin Eng <enga@chromium.org >
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com >
2021-12-08 02:42:17 +00:00
Dawn Autoroller
8b9e591f48
Roll Tint from c55c7715db to b2bbb14bd4 (2 revisions)
...
https://dawn.googlesource.com/tint.git/+log/c55c7715dbc8..b2bbb14bd413
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: dawn:1203
Tbr: cwallez@google.com
Change-Id: Ia280d17fc1e74aa2ae0199f4a9ec065aff67684a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71980
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-07 20:03:37 +00:00
Dawn Autoroller
227c9c9fc4
Roll ANGLE from ca3dfbe78d73 to f4553165703a (3 revisions)
...
ca3dfbe78d..f455316570
2021-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5b3be708ab2f to 5c0e64524982 (3 revisions)
2021-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 558e41ede9d4 to 111e348dc9b4 (338 revisions)
2021-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a465cca8ec8d to 3e61a772b248 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I1003d39e32b2fe82e80b162f17e5a043a63ea53e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71941
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-07 15:33:36 +00:00
Dawn Autoroller
b543acf567
Roll Tint from 9c7b39f365 to c55c7715db (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/9c7b39f365dc..c55c7715dbc8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I0b8042522154829b31fbf94a31f4787c767e50cd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71940
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-07 14:55:36 +00:00
Antonio Maiorano
b2bbb14bd4
Add TINT_SYMBOL_STORE_DEBUG_NAME option to help debugging the AST
...
If TINT_SYMBOL_STORE_DEBUG_NAME is 1, Symbol instances store a
`debug_name_` member initialized with the name of the identifier they
represent. This member is not exposed, but is useful for debugging
purposes.
Bug: tint:1331
Change-Id: Ia98e266aefc1ca26bbf30c6ece73d9eac8afdbd7
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71780
Kokoro: Kokoro <noreply+kokoro@google.com >
Commit-Queue: Antonio Maiorano <amaiorano@google.com >
Reviewed-by: Ben Clayton <bclayton@google.com >
2021-12-07 14:43:17 +00:00
Antonio Maiorano
cf3880201b
Make HLSL validation run with same flags as Dawn
...
FXC is buggy, and I recently landed changes in Dawn to run with "/O0"
rather than /"O2" because of these bugs. Let's make sure Tint end-to-end
tests do the same. Also do the same when running against DXC.
Bug: dawn:1203
Change-Id: I1a30f16dee8306bd645d87b3ccb0cc87691c5972
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71800
Reviewed-by: Ben Clayton <bclayton@google.com >
Kokoro: Kokoro <noreply+kokoro@google.com >
Commit-Queue: Antonio Maiorano <amaiorano@google.com >
2021-12-07 14:40:47 +00:00
Ben Clayton
c55c7715db
Fix Kokoro ASAN builds
...
The VM has been updated to Kokoro 14.04, and now the docker instance
requires escalated privileges in order to run some sanitizer builds.
Change-Id: Icebbb1597dcdb67a854cb61ff7b0c0c11952b7f2
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71921
Auto-Submit: Ben Clayton <bclayton@google.com >
Reviewed-by: Antonio Maiorano <amaiorano@google.com >
Commit-Queue: Antonio Maiorano <amaiorano@google.com >
Kokoro: Kokoro <noreply+kokoro@google.com >
2021-12-07 13:54:19 +00:00
Corentin Wallez
0766ce6ed1
Vulkan: Load procs for VK_KHR_get_memory_requirements2
...
Bug: dawn:1223
Change-Id: I14f6bfd66ac35a2d80b70fd121bd3be5e9670352
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71761
Reviewed-by: Austin Eng <enga@chromium.org >
Reviewed-by: Loko Kung <lokokung@google.com >
Commit-Queue: Corentin Wallez <cwallez@chromium.org >
2021-12-07 09:32:08 +00:00
Corentin Wallez
87ef49c461
Require semicolon after DAWN_TEST_PARAM_STRUCT
...
Bug: None
Change-Id: I6b9fb69c6d02abb2a210f10d91b02c5b77b48cdc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71760
Reviewed-by: Austin Eng <enga@chromium.org >
Reviewed-by: Brandon Jones <bajones@chromium.org >
Commit-Queue: Corentin Wallez <cwallez@chromium.org >
2021-12-07 09:29:46 +00:00
Dawn Autoroller
683401528f
Roll ANGLE from 60e457b8badc to ca3dfbe78d73 (6 revisions)
...
60e457b8ba..ca3dfbe78d
2021-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 840fab92609d to 558e41ede9d4 (627 revisions)
2021-12-06 syoussefi@chromium.org Vulkan: Fix xfb query ASSERT on end
2021-12-06 lfy@google.com Validate SamplerFormat
2021-12-06 ianelliott@google.com Point to ANGLE Wrangler schedule website in document
2021-12-06 lfy@google.com Vulkan: remove staged updates on storage set
2021-12-06 jmadill@chromium.org FrameCapture: Add ReplayWriter helper class.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Id3b092e04c0c4071f1ae48144c5dcc401e458bf3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71801
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-07 02:05:26 +00:00
Jiawei Shao
6a886b47de
Align offset to 4 bytes in writeTexture on depth stencil textures
...
This patch fixes a bug in the allocation of internal staging buffer
for Queue::WriteTexture() that we must ensure the buffer offset to
be 4 bytes when calling Queue::WriteTexture() on depth stencil
textures as is restricted by Vulkan SPEC.
BUG=dawn:1213
TEST=dawn_end2end_tests
Change-Id: Ia2d073ef12d48baff42fca97005c1185c9560f1c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71605
Reviewed-by: Corentin Wallez <cwallez@chromium.org >
Reviewed-by: Austin Eng <enga@chromium.org >
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com >
2021-12-07 01:33:36 +00:00
fujunwei
c7d4f2c9f1
Make templates webgpu_cpp.h and webgpu_cpp_print.h flexible
...
Rename webgpu_cpp.h to api_cpp.h and webgpu_cpp_print.h to api_cpp_print.h.
BUG=dawn:1201
Change-Id: Icceee0fd70fb6497a9e2b0891b5c5843787593f9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71720
Reviewed-by: Corentin Wallez <cwallez@chromium.org >
Reviewed-by: Austin Eng <enga@chromium.org >
Commit-Queue: Junwei Fu <junwei.fu@intel.com >
2021-12-07 00:46:35 +00:00
Loko Kung
4539a48355
Revert "Bump maxUniformBindingSize to 2^16 from 2^14"
...
This reverts commit 1a57ee9d4e .
Reason for revert: Swiftshader does not support 2^16 at the moment, and this is causing all Swiftshader tests to be skipped silently.
Original change's description:
> Bump maxUniformBindingSize to 2^16 from 2^14
>
> This was upped in https://github.com/gpuweb/gpuweb/pull/2159
>
> Bug: dawn:1173
> Change-Id: I98d46b9b5a339280d21ddcb2ab039ce7ebce4ec3
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71608
> Commit-Queue: Brandon Jones <bajones@chromium.org >
> Auto-Submit: Corentin Wallez <cwallez@chromium.org >
> Reviewed-by: Brandon Jones <bajones@chromium.org >
TBR=cwallez@chromium.org ,enga@chromium.org ,bajones@chromium.org ,bajones@google.com ,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: Ib7d6023adac3f99b8e7238035eed2a16f2ced6d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dawn:1173
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71840
Reviewed-by: Austin Eng <enga@chromium.org >
Commit-Queue: Loko Kung <lokokung@google.com >
2021-12-06 23:06:09 +00:00
Austin Eng
58c655b6b3
Complete per-backend AdapterDiscoveryOptions
...
D3D12, OpenGL, and OpenGLES have their own backend-specific
AdapterDiscoveryOptions. Add the same for Vulkan and Metal so we can
selectively discover just Vulkan or Metal adapters.
The Vulkan options include a boolean forceSwiftShader to force
Dawn to discover only SwiftShader on the Vulkan backend.
Also, refactor D3D12's DiscoverDefaultAdapters to simply call
DiscoverAdapters to match the other backends.
Bug: chromium:1266550
Change-Id: I137f94b40084b2d0ddeda39b6b7ef20f033d8a4b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/69522
Commit-Queue: Austin Eng <enga@chromium.org >
Reviewed-by: Loko Kung <lokokung@google.com >
2021-12-06 20:58:56 +00:00
Austin Eng
652293f14c
Support multiple Vulkan instances in the Vulkan backend
...
This will allow the Vulkan backend connection to be initialized, and
then selectively discover adapters on just one of the instances.
This is needed so that discovery of the fallback WebGPU adapter can
avoid initializing any adapters other than SwiftShader.
Bug: chromium:1266550
Change-Id: Ia8b31c0239da89a41aa89f1c09a66e9e56e10d95
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/69980
Reviewed-by: Loko Kung <lokokung@google.com >
Commit-Queue: Austin Eng <enga@chromium.org >
2021-12-06 19:31:12 +00:00
Corentin Wallez
1a57ee9d4e
Bump maxUniformBindingSize to 2^16 from 2^14
...
This was upped in https://github.com/gpuweb/gpuweb/pull/2159
Bug: dawn:1173
Change-Id: I98d46b9b5a339280d21ddcb2ab039ce7ebce4ec3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71608
Commit-Queue: Brandon Jones <bajones@chromium.org >
Auto-Submit: Corentin Wallez <cwallez@chromium.org >
Reviewed-by: Brandon Jones <bajones@chromium.org >
2021-12-06 16:17:21 +00:00
Dawn Autoroller
4cccaaa4cf
Roll Tint from 05eedd81b0 to 9c7b39f365 (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/05eedd81b018..9c7b39f365dc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I84d9667a939cab10e9db8098cbce6d2d5b6e2b7d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71741
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-06 15:23:26 +00:00
Ben Clayton
9c7b39f365
msl: Explicity validate against MSL 1.2
...
Fixed: tint:1327
Change-Id: I7d2e182f60c42894410500f393a1235d37efe5e1
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71680
Kokoro: Kokoro <noreply+kokoro@google.com >
Commit-Queue: Ben Clayton <bclayton@google.com >
Reviewed-by: James Price <jrprice@google.com >
Reviewed-by: David Neto <dneto@google.com >
2021-12-06 13:02:36 +00:00
Dawn Autoroller
13d6af93fb
Roll ANGLE from 10e5f34d1439 to 60e457b8badc (1 revision)
...
10e5f34d14..60e457b8ba
2021-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9970c397e55e to 5b3be708ab2f (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I838baa3cc9d1f2fe2d8c08031221edc9530ee096
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71740
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-06 12:18:45 +00:00
fujunwei
3a464767a5
Make the prefix of proc table configurable in api.json
...
Add a metadata to configure the prefix of proc table and Make proc table
flexiable with the prefix and declared functions.
BUG=dawn:1201
Change-Id: Id28e5521506fa5dc8efca90a7883fbd3dd548e8d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71526
Commit-Queue: Junwei Fu <junwei.fu@intel.com >
Reviewed-by: Austin Eng <enga@chromium.org >
2021-12-05 05:29:44 +00:00
Dawn Autoroller
1c7d3efcd0
Roll ANGLE from 9408adceaeb9 to 10e5f34d1439 (4 revisions)
...
9408adceae..10e5f34d14
2021-12-04 shrekshao@google.com Revert "Decouple gl_BaseVertex/gl_BaseInstance uniforms"
2021-12-04 abdolrashidi@google.com Reland "Vulkan: Implement GL_EXT_multi_draw_indirect"
2021-12-04 ianelliott@google.com Vulkan: Resize deviceExtensionProps to deviceExtensionCount
2021-12-03 ianelliott@google.com Reland: Vulkan: Use vkResetQueryPoolEXT when available
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: Ie56e028688e0110f0b975da1f050c6c7017b7170
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71666
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-04 14:02:16 +00:00
Kai Ninomiya
5db89fbd38
Fix typo in DmaBuf tests
...
Caused roll failure starting here:
https://chromium-review.googlesource.com/c/chromium/src/+/3314932/
Bug: None
Change-Id: I8f348a4fea243364fefc01f902add33abff66d1d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71700
Auto-Submit: Kai Ninomiya <kainino@chromium.org >
Reviewed-by: Austin Eng <enga@chromium.org >
Commit-Queue: Austin Eng <enga@chromium.org >
2021-12-04 01:51:49 +00:00
Dawn Autoroller
bb8cfb3ab4
Roll ANGLE from f58b8aba0671 to 9408adceaeb9 (7 revisions)
...
f58b8aba06..9408adceae
2021-12-03 bsheedy@chromium.org Add Gold git main method
2021-12-03 cnorthrop@google.com Vulkan: Allow nonconformant EXT_gpu_shader5
2021-12-03 syoussefi@chromium.org Fix changing attached renderbuffer from MSRTT to non-MSRTT
2021-12-03 lfy@google.com Fix flakiness in CpuTimeSleepy
2021-12-03 jmadill@chromium.org FrameCapture: Clean up 'WriteCppReplayFunctionWithParts'.
2021-12-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 933bb8aaaef9 to 9970c397e55e (7 revisions)
2021-12-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f9c39655a610 to a465cca8ec8d (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I194ad24464779255127790dc3b4acdac85d046e2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71665
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-04 00:44:58 +00:00
Dawn Autoroller
80646c10a7
Roll Tint from 2ec1393f31 to 05eedd81b0 (6 revisions)
...
https://dawn.googlesource.com/tint.git/+log/2ec1393f31a4..05eedd81b018
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I0405a59e62da648c5a867e3e5503abc024052ff1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71664
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com >
2021-12-03 23:46:08 +00:00
Ben Clayton
05eedd81b0
writer/msl: Only use [[invariant]] on MSL 2.1+
...
This is not supported on older versions.
This behavior was agreed by the WGSL core group:
https://github.com/gpuweb/gpuweb/issues/893#issuecomment-745537465
Bug: tint:1327
Change-Id: I1a0459068c438e625ae9d99fe4a044a96f2db57e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71684
Reviewed-by: David Neto <dneto@google.com >
Commit-Queue: Ben Clayton <bclayton@google.com >
Kokoro: Kokoro <noreply+kokoro@google.com >
2021-12-03 21:58:53 +00:00
Ben Clayton
cc05d89820
writer/msl: Replace use of 'auto' with actual return type
...
Fixes MSL 1.2 error:
'auto' return without trailing return type; deduced return types are a C++14 extension
Bug: tint:1327
Change-Id: I5956aadf6b28b605b07c9681716ac4b3e31d804a
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71683
Reviewed-by: David Neto <dneto@google.com >
Reviewed-by: James Price <jrprice@google.com >
Commit-Queue: Ben Clayton <bclayton@google.com >
Kokoro: Kokoro <noreply+kokoro@google.com >
2021-12-03 21:50:23 +00:00
Ben Clayton
c830130bb8
resolver: Fixes for bitcasts
...
Fix dependency graph traversal for bitcasts. These were not being traversed, leading to an ICE if the bitcast type was an alias, as the symbol was not resolved for later use by the resolver.
Add missing validation for bitcasts. We were permitting any bitcast that wasn't a being cast to a pointer type, when the spec only allows:
* numeric_scalar to numeric_scalar
* vecN<numeric_scalar> to vecN<numeric_scalar>
Add lots of tests.
Fixed: chromium:1276320
Change-Id: I9e5487ec7649ac543f73fc878e7e282bf932d8cb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71681
Kokoro: Kokoro <noreply+kokoro@google.com >
Commit-Queue: Ben Clayton <bclayton@google.com >
Reviewed-by: Antonio Maiorano <amaiorano@google.com >
2021-12-03 21:29:13 +00:00
Ben Clayton
b9e8a0b87d
writer/spirv: Add tests for automatic OpReturnValue
...
As requested at:
https://dawn-review.googlesource.com/c/tint/+/71604/5/src/writer/spirv/builder_if_test.cc#476
Bug: tint:1302
Change-Id: I661f877beb44f999e17f2769b4aa46b22180bbb9
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71682
Kokoro: Kokoro <noreply+kokoro@google.com >
Commit-Queue: Ben Clayton <bclayton@google.com >
Reviewed-by: David Neto <dneto@google.com >
2021-12-03 19:19:33 +00:00