Commit Graph

10336 Commits

Author SHA1 Message Date
dan sinclair 3a1b799585 Review feeback from 106420
Change-Id: I9c1ec7f26b0fda25bcedc86fec66d174fe81ed5f
Bug: tint:1633, tint:1451
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106843
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
2022-10-24 17:49:20 +00:00
Dawn Autoroller 29f61747bf Roll SwiftShader from 1ab775a9492b to c276d8bf6ff7 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/1ab775a9492b..c276d8bf6ff7

2022-10-24 sugoi@google.com Allow running multiple dEQP tests per process

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I59f93247026206bfe1c89554b7ccb25eb4fea26b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106861
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-24 16:24:27 +00:00
dan sinclair a7014a969e Rename primary_expression.
This CL updates the name of primary_expression to match spec.

Bug: tint:1633
Change-Id: Iba0f681a47f80f80913a5ce3efb6f753201b072c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106581
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
2022-10-24 14:41:44 +00:00
dan sinclair f4baf2713c Revert "Add CopyExternalTextureForBrowser()"
This reverts commit f392c38b67.

Reason for revert: Breaking the roll into Chromium, and breaks the CMake build of Dawn. https://chromium-review.googlesource.com/c/chromium/src/+/3974728

Original change's description:
> Add CopyExternalTextureForBrowser()
>
> This API accept ExternalTexture object as copy source and a dawn 2D texture
> as destination. It has similar functions as CopyTextureForBrowser().
> The API is used to support cases that source images are multi-planar format
> and want to do conversion and uploading to a dawn 2D texture.
>
> Bug: chromium:1361363
> Change-Id: Ie390acfb95b47d417f4a8faa2d1e19163d549154
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/105880
> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
> Reviewed-by: Austin Eng <enga@chromium.org>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>

TBR=cwallez@chromium.org,shaobo.yan@intel.com,enga@chromium.org,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I3f057b1e5fe3bb0e41063eb402d2c269c27aaedf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1361363
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106842
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: dan sinclair <dsinclair@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-10-24 14:24:29 +00:00
dawn-autoroll 5f3fb09405 Roll vulkan-deps from f8a92d3cac38 to e9cf5a1d4589 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/f8a92d3cac38..e9cf5a1d4589

Changed dependencies:
* vulkan-validation-layers: a0cca05e3a..49a480cb91

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I1aef7d24ef7e0b857cde10ccc2aa09748dc7bfce
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106841
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-24 13:05:11 +00:00
Dawn Autoroller e1133a80ee Roll ANGLE from dc62b3eef6ae to 28dd99dccd32 (1 revision)
dc62b3eef6..28dd99dccd

2022-10-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 554ce0027284 to 1ab775a9492b (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I26f4feb057cfeb8ae3f67e427d38501fa5b2ee0a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106860
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-24 12:23:02 +00:00
Yan,Shaobo f392c38b67 Add CopyExternalTextureForBrowser()
This API accept ExternalTexture object as copy source and a dawn 2D texture
as destination. It has similar functions as CopyTextureForBrowser().
The API is used to support cases that source images are multi-planar format
and want to do conversion and uploading to a dawn 2D texture.

Bug: chromium:1361363
Change-Id: Ie390acfb95b47d417f4a8faa2d1e19163d549154
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/105880
Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-10-24 06:03:22 +00:00
Yan,Shaobo 96a0bd5bdf Add visibleRect to ExternalTextureDescriptor
Add visibleRect in ExternalTextureDescriptor to create ExternalTexture.
This helps ExternalTexture present the content correctly if needed.

Bug: chromium:1361363
Change-Id: I54b1912305080943babd7558ef40bca8528c932c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106181
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-24 04:19:43 +00:00
dawn-autoroll 2ec4038483 Roll vulkan-deps from f15463587f34 to f8a92d3cac38 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/f15463587f34..f8a92d3cac38

Changed dependencies:
* vulkan-validation-layers: b24fa204ff..a0cca05e3a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I5515315827b23f9ef614e5206158788f451e1e08
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106820
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-23 08:37:48 +00:00
dawn-autoroll 9d29212fe4 Roll vulkan-deps from 2cdba7f17982 to f15463587f34 (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/2cdba7f17982..f15463587f34

Changed dependencies:
* vulkan-loader: ae54ca0d01..9cd0dc8cd2
* vulkan-validation-layers: 667d7ec02a..b24fa204ff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I8be87b0c434a75f1478a3aeb7e6d1103ffcb971f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106780
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-22 10:42:35 +00:00
Dawn Autoroller aa18830ee8 Roll ANGLE from cc35022f1ee0 to dc62b3eef6ae (8 revisions)
cc35022f1e..dc62b3eef6

2022-10-21 jmadill@chromium.org Capture/Replay: Add trace interpreter.
2022-10-21 jmadill@chromium.org Refine sampling of trace perf tests.
2022-10-21 jmadill@chromium.org Enable flaky retries on SwS ASAN/TSAN.
2022-10-21 solti@google.com disable pixel6 for VertexAttributeTestES31 tests
2022-10-21 solti@google.com Disable test: FramebufferTest_ES3.DrawWithDifferentPreRotations
2022-10-21 jmadill@chromium.org Simplify trace test names.
2022-10-21 jmadill@chromium.org Reduce --use-angle spam in TracePerfTest.
2022-10-21 jmadill@chromium.org Enable capture by default on release non-Android bots.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: Ia5a72d4f043e0a0cf03ebea61e4220aebb98a541
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106702
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-22 05:18:13 +00:00
dawn-autoroll dc4b9ae9d4 Roll vulkan-deps from e6f4d0dfcdb3 to 2cdba7f17982 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/e6f4d0dfcdb3..2cdba7f17982

Changed dependencies:
* vulkan-validation-layers: 5e5391eed5..667d7ec02a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: Ia1e52060c0205801f3f3873535f61b8a518bdd13
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106740
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-21 21:46:16 +00:00
Dawn Autoroller 098193590e Roll SwiftShader from 554ce0027284 to 1ab775a9492b (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/554ce0027284..1ab775a9492b

2022-10-21 capn@google.com Rename EmitState to SpirvEmitter
2022-10-21 sugoi@google.com Fix shell.Exec calls in git.go

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I89806485a78d6c0ce064374c26e1bff26b330c5b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106701
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-21 20:46:21 +00:00
Dawn Autoroller 9524453727 Roll ANGLE from 6193274a528e to cc35022f1ee0 (10 revisions)
6193274a52..cc35022f1e

2022-10-21 romanl@google.com Only allow missing output file when listing tests.
2022-10-21 jmadill@chromium.org Capture/Replay: Optionally emit C sources.
2022-10-21 jmadill@chromium.org Update ANGLE API loaders to avoid C++ syntax.
2022-10-21 jmadill@chromium.org Add a help preamble for trigger.py.
2022-10-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from fa1a1fcf0fd2 to 554ce0027284 (3 revisions)
2022-10-21 jmadill@chromium.org Capture/Replay: Make fixture work with C and C++.
2022-10-21 cnorthrop@google.com FrameCapture: Fix FenceSync for MEC
2022-10-21 syoussefi@chromium.org Vulkan: Separate pipeline cache query and insertion
2022-10-21 syoussefi@chromium.org Vulkan: Clean up rotation spec const update
2022-10-21 m.maiya@samsung.com Expand support in angle_shader_translator

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: Iefcb0d4848e3ae1016c765498c83dd9e1b8ac58c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106700
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-21 15:34:50 +00:00
Dawn Autoroller 8da4a86004 Roll SwiftShader from e1a2fa9b37df to 554ce0027284 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e1a2fa9b37df..554ce0027284

2022-10-20 sugoi@google.com Revert "Temporary patch for OOB read issue"
2022-10-20 capn@google.com Eliminate EmitResult

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I44f1f365ab419ea6e5ba6b82f6a2c06b814aa719
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106640
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-21 07:04:55 +00:00
dawn-autoroll fbf5b9f0a8 Roll vulkan-deps from 5b6b976cb107 to e6f4d0dfcdb3 (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/5b6b976cb107..e6f4d0dfcdb3

Changed dependencies:
* spirv-tools: ecd5b9c167..eb113f0fdf
* vulkan-tools: e52fa1cf2d..0a3b52945c
* vulkan-validation-layers: c3ce72dcb8..5e5391eed5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I83f7c6bde2709ac11f0dc69d05066ce26161c566
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106620
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-21 03:05:44 +00:00
Dawn Autoroller 6ccfe36247 Roll ANGLE from 29624da3f288 to 6193274a528e (12 revisions)
29624da3f2..6193274a52

2022-10-21 jmadill@chromium.org Capture/Replay: Redesign in-memory call capture replay.
2022-10-20 jmadill@chromium.org Enum Utils: Add method to return enum value from string.
2022-10-20 jmadill@chromium.org Entry Points: Move enum helper to registry_xml.
2022-10-20 jmadill@chromium.org run_perf_tests.py: Fix test list unexpected error.
2022-10-20 chris@rive.app Actually use EXT_shader_framebuffer_fetch_non_coherent for PLS
2022-10-20 jmadill@chromium.org Capture/Replay: Move trace fixture into util/
2022-10-20 robert.mader@collabora.com EGL: Implement EGL_EXT_device_drm and EXT_device_drm_render_node
2022-10-20 jmadill@chromium.org Capture/Replay: Move shared trace code into src/common.
2022-10-20 jmadill@chromium.org Capture/Replay: Only inline strings.
2022-10-20 jmadill@chromium.org EGL: Resource IDs for Surface, Context and EGL Image.
2022-10-20 sywow.choi@samsung.com Vulkan: Make compatible with GCC
2022-10-20 cnorthrop@google.com FrameCapture: Fix UniformBlockBinding

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I7f67f2f922967e18cc03c15724e92e8ca9d68005
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106600
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-21 02:16:07 +00:00
dan sinclair b8b0c21918 Add break-if support.
This CL adds support for `break-if` to Tint.

Bug: tint:1633, tint:1451
Change-Id: I30dfd62a3e09255624ff76ebe0cdd3a3c7cf9c5f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106420
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: dan sinclair <dsinclair@google.com>
2022-10-20 22:45:50 +00:00
dan sinclair f8c07d4753 Add test for split of `--`.
An expression like `b--b` needs the `--` split into two symbols in
order to parse correctly. This change was done previously, adding
a test case to show the generated output.

Bug: tint:988
Change-Id: Id389224e33b7702a90e4c157b02031fb605c1b14
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106580
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-20 18:40:53 +00:00
Antonio Maiorano b69c6066c4 tint: Fix uniformity ICE during error reporting wrt non-uniform pointer parameters
Added support for reporting when pointer parameters point to non-uniform
values. Also add support for binary expressions results that may be
non-uniform.

Bug: chromium:1374534
Change-Id: Ia51557e3a984c69a39f2878c964bf07085599809
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106560
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-10-20 17:15:34 +00:00
Dawn Autoroller bcf51bffa8 Roll SwiftShader from fa1a1fcf0fd2 to e1a2fa9b37df (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/fa1a1fcf0fd2..e1a2fa9b37df

2022-10-20 nicolascapens@google.com Revert "Temporarily fix pipelineStageCreationFeedbackCount = 0 issue"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I49f625a267b89c6bec66b4beac8ee3b162eb6307
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106521
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-20 16:19:01 +00:00
dan sinclair 481b2ed959 Fix issue resolving address of numeric.
This CL fixes up a clusterfuzz issue where the address of a
numeric was take in a case selector leading to a nullptr.

Bug: chromium:1376865
Change-Id: I3b78a17e1c47263e18d2d272ff28c2cc8be79a0e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106540
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-20 14:56:45 +00:00
dan sinclair 882b38a2f5 Update fallthrough deprecation notice.
The `default` case selector has been implemented in Tint. This CL
updates the deprecation notice with that fact along with some more
information on replacements.

Bug: tint:1644
Change-Id: I883b4465d11d9696d46523d11e66c9a2dc2777ac
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106460
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-10-20 14:03:04 +00:00
dan sinclair 6e77b47ed9 Update internals to initializer instead of constructor.
This CL catches up the internals (along with a few error messages) to
say `initializer` instead of `constructor.

Bug: tint:1600
Change-Id: I8e56572c310d77da1130380bdd32b334f27c8e46
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106462
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-10-20 13:38:28 +00:00
dawn-autoroll 56ce1a2155 Roll vulkan-deps from 20331a297378 to 5b6b976cb107 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/20331a297378..5b6b976cb107

Changed dependencies:
* vulkan-validation-layers: fa8db0d0bf..c3ce72dcb8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I38f275bc743337839864765e413f747f02435c45
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106501
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-20 13:09:43 +00:00
Dawn Autoroller a4260ade37 Roll ANGLE from d8fe28dddc23 to 29624da3f288 (3 revisions)
d8fe28dddc..29624da3f2

2022-10-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from fdf41479349b to fa1a1fcf0fd2 (3 revisions)
2022-10-20 syoussefi@chromium.org Vulkan: Missing output mask in GraphicsPipelineDesc
2022-10-20 syoussefi@chromium.org Vulkan: Shader component type in GraphicsPipelineDesc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: If74ac3f3b418a10021bac086780fb0e279c7b89b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106520
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-20 12:46:30 +00:00
Dawn Autoroller a48c43cd22 Roll SwiftShader from fdf41479349b to fa1a1fcf0fd2 (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/fdf41479349b..fa1a1fcf0fd2

2022-10-19 sugoi@google.com Fix zlib dependency for Regres
2022-10-19 capn@google.com Store phi variables in a collection of SIMD components
2022-10-19 capn@google.com Limit SPIR-V phi variable lifetimes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I949bd0e5c3c72dfae56d6ab92f3420fd86dbafc4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106417
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-20 01:22:55 +00:00
dawn-autoroll ac03c4031e Roll vulkan-deps from 0562081c088c to 20331a297378 (6 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/0562081c088c..20331a297378

Changed dependencies:
* glslang: a0ad0d7067..980ac50813
* vulkan-validation-layers: ef45fb26a5..fa8db0d0bf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: Ib346258bd8a538fd1ec5c31d054bb8e3b50c1298
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106416
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-19 23:26:17 +00:00
Dawn Autoroller e20c530116 Roll ANGLE from 1a9882dd050c to d8fe28dddc23 (10 revisions)
1a9882dd05..d8fe28dddc

2022-10-19 lexa.knyazev@gmail.com Suppress clip distance tests on iOS
2022-10-19 syoussefi@chromium.org Pass worker pools to image load functions
2022-10-19 syoussefi@chromium.org Move worker pools to Display
2022-10-19 syoussefi@chromium.org Move thread pool classes to common/
2022-10-19 jmadill@chromium.org Redo perf and trace test parameters.
2022-10-19 cnorthrop@google.com Tests: Add reduced crashing shader test
2022-10-19 jmadill@chromium.org run_perf_tests.py: Remove unneeded Android args.
2022-10-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 00b601d8ad24 to fdf41479349b (3 revisions)
2022-10-19 gregschlom@google.com Reland "Make ANGLE's Worker Pool actually pool the threads."
2022-10-19 jmadill@chromium.org Add missing function prototypes to ANGLE ext headers.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: Iacf2fa7b3757b3eb127729a1bcd966927b2f7d98
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106415
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-19 23:23:45 +00:00
dan sinclair fdd2ff1145 Add tests to show correct handling of mixed && and ||.
This CL adds tests to verify the new parser handles the mixing of && and
|| correctly.

Bug: tint:1599
Change-Id: I1a73d041a00118ed649522ae07fc1489021c4b41
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106461
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-10-19 20:28:34 +00:00
Antonio Maiorano 1c94938726 tint: implement updated spec rules for shift left of concrete values
Rules for shift left of concrete values are now split between signed and
unsigned. Shifting unsigned values no longer fails with "sign change"
errors. Furthermore, shifting unsigned values must only shift out 0s.

See https://github.com/gpuweb/gpuweb/pull/3539.

Bug: tint:1701
Bug: tint:1717
Change-Id: Iba2799f4b02cdc77cc58a6c7c104aaa408f0f0f9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106381
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-10-19 17:46:12 +00:00
Antonio Maiorano 3fa6887679 tint: use struct instead of tuple for test cases
googletest doesn't print test parameters properly when they are a tuple
of variants.

Change-Id: I070697bb0118282dd4841df23c936e0171934628
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106380
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-10-19 17:20:58 +00:00
dan sinclair f148f0891b [WGSL] Allow default as a case selector
This CL updates the WGSL parser to parse `default` as a case selector
value.

Bug: tint:1633
Change-Id: I57661d25924e36bec5c03f96399c557fb7bbf760
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106382
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-10-19 15:55:02 +00:00
Yunchao He d27151d333 D3D12 Intel: Improve the workaround for array texture corruption issue
This change adds more tests to exercise the code of the workaround for
array texture corruption issue. Because texture memory layout and tile
alignment vary accordingly if array textures have mipmaps, and/or
different dimensions, etc.

It also does some slight changes in the workaround itself for array
textures with non-32-or-16-bit-wise formats.

Bug: dawn: 949, dawn: 1507
Change-Id: I22e87830ba59f2a2814e6786aa9a1a55a15c95cb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/105241
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Yunchao He <yunchao.he@intel.com>
2022-10-19 15:19:13 +00:00
Jiawei Shao f30e8dbe31 Set colorAttachment.clearColor to NAN in CHelloTriangle.cpp
This patch sets the deprecated member colorAttachment.clearColor to
NAN in CHelloTriangle.cpp to eliminate a warning when running the
demo.

Bug: dawn:1269
Change-Id: I274198d1cafbc2dc15dcf6e59d26b58a62134c5a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106400
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-10-19 13:28:56 +00:00
Dawn Autoroller 89d54308ce Roll SwiftShader from e1b8cbd9702b to fdf41479349b (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e1b8cbd9702b..fdf41479349b

2022-10-18 capn@google.com Move EmitState out of SpirvShader

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: If01cdcee53400e4adbcbf02910d9e1d647164f1b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106408
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-19 10:55:47 +00:00
dawn-autoroll 6947752f18 Roll vulkan-deps from f1a462fd5b9b to 0562081c088c (12 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/f1a462fd5b9b..0562081c088c

Changed dependencies:
* spirv-cross: f09ba27777..5763919669
* vulkan-loader: 61187c4084..ae54ca0d01
* vulkan-validation-layers: cb45bd23c6..ef45fb26a5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I282a96120e385e9bc6a9a14c379c4180e607c7c7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106411
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-19 10:29:31 +00:00
Dawn Autoroller 049ed68728 Roll ANGLE from b521be4c2df7 to 1a9882dd050c (13 revisions)
b521be4c2d..1a9882dd05

2022-10-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2ee62a7f9f78 to c8d10c0b09ab (427 revisions)
2022-10-19 sywow.choi@samsung.com Add cstring header for memcpy and strcmp
2022-10-19 lexa.knyazev@gmail.com GL: Support clip and cull distance extensions
2022-10-18 jmadill@chromium.org Capture/Replay: Improvements to self-test.
2022-10-18 jmadill@chromium.org retrace script: Update trace test suite name.
2022-10-18 romanl@google.com Perf Tests: fail test on GL_CONTEXT_LOST after glFinish().
2022-10-18 jmadill@chromium.org EGL: Add ID types for egl::Surface and egl::Image.
2022-10-18 tvignatti@igalia.com Tests: Enable EGL_ANGLE_iosurface_client_buffer tests on iOS
2022-10-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9ac79e275a41 to 2ee62a7f9f78 (131 revisions)
2022-10-18 robert.mader@collabora.com Reland "Reland "EGL: Implement EGL_EXT_image_dma_buf_import_modifiers""
2022-10-18 jmadill@chromium.org Capture/Replay: Rewrite map buffer calls.
2022-10-18 dullweber@chromium.org Revert "Make ANGLE's Worker Pool actually pool the threads."
2022-10-18 jmadill@chromium.org Capture/Replay: Remove references to uniform block indexes.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: Ib5e4b40f853c6c777041bc34ad42a49b70271dd3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106410
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-19 10:28:26 +00:00
dan sinclair d32fbe07e7 Store expressions in switch case statements.
This CL moves switch case statements to store Expression instead
of an IntLiteralExpression. The SEM is updated to store the
materialized constant instead of accessing the expression value
directly.

Bug: tint:1633
Change-Id: Id79dabb806be1049f775299732bc1c7b1bf0c05f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106300
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
2022-10-19 00:43:41 +00:00
Ben Clayton 00aa7ef462 tint/reader/wgsl: Better diagnostics for missing parentheses
This change required removing the `&&` splitting for `a & b && c` which never valid WGSL (right now).

Fixed: tint:1658
Change-Id: Ideb9f1aa9cf9b9b1054a6fc65860106dc072a9dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/105820
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: David Neto <dneto@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-10-18 23:57:25 +00:00
Antonio Maiorano b6e1bc7d5d tint: Fix C++ UB when shifting abstract 0 left by >= 64
In WGSL, we can shift left abstracts by >= 64, as long as the result is
representable in the data type we choose for it. When shifting 0, we can
shift by any positive u32 value (result is always 0), but in C++, it's
UB to shift by more than the bit width of the data type, so we need to
handle this. This bug was caught by ClusterFuzz.

Bug: chromium:1372963
Change-Id: I638ca190b93538908ca6472f3735627ea8531c5a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106266
Reviewed-by: David Neto <dneto@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-18 20:17:55 +00:00
Dawn Autoroller e4d608a837 Roll SwiftShader from 00b601d8ad24 to e1b8cbd9702b (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/00b601d8ad24..e1b8cbd9702b

2022-10-18 capn@google.com Move Reactor code emission from SpirvShader to EmitState
2022-10-18 capn@google.com Detect OpImageWrite in the analysis pass

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I9688fbf12f7c74ed15e101cc0651dec2cd8a35e0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106361
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-18 17:09:34 +00:00
Dawn Autoroller 987fd29e27 Roll ANGLE from 09b079bbfed6 to b521be4c2df7 (6 revisions)
09b079bbfe..b521be4c2d

2022-10-18 syoussefi@chromium.org Vulkan: Decouple shader-set from pipeline caches
2022-10-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4de33dcbca0e to 00b601d8ad24 (1 revision)
2022-10-18 jiawei.shao@intel.com Remove unused enum CacheResult
2022-10-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 19bc4c33cb49 to 9ac79e275a41 (248 revisions)
2022-10-18 gman@chromium.org Metal: Optimized BufferSubData per device
2022-10-17 jmadill@chromium.org Split trace tests out into angle_trace_tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I60e2469254f00ef49783fc29a34096e299e4f3aa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106360
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-18 17:07:32 +00:00
dawn-autoroll 4b01515418 Roll vulkan-deps from ba840d111dc5 to f1a462fd5b9b (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/ba840d111dc5..f1a462fd5b9b

Changed dependencies:
* spirv-tools: b53d3a6be3..ecd5b9c167
* vulkan-validation-layers: 273665ad0d..cb45bd23c6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I1a9e64b1332503e3a6a7ad46d4e6aa1b09e208f9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106265
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-18 15:53:37 +00:00
Brendon Tiszka f3666c45f3 Add assertions to ServerInlineMemoryTransferService to catch corrupted states while fuzzing with DawnWireServerFuzzer and tests.
Bug: chromium:1340654,chromium:1374495
Change-Id: Icfb008a1cd6dbd8af32f3aedc90ef29e29a0465b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106041
Commit-Queue: Brendon Tiszka <tiszka@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-18 15:15:02 +00:00
Dawn Autoroller 333be21162 Roll ANGLE from 2afb512b90d2 to 09b079bbfed6 (5 revisions)
2afb512b90..09b079bbfe

2022-10-17 syoussefi@chromium.org Vulkan: Move pipeline subset out of pipeline desc
2022-10-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cd88d0e4d12c to 19bc4c33cb49 (264 revisions)
2022-10-17 ynovikov@chromium.org Skip some end2end tests failing on iOS
2022-10-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ab3cb3f5416b to 4de33dcbca0e (2 revisions)
2022-10-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 18608d767af1 to af6c033bca19 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: I8343ccf690ab104585eb84a4397ee04ea0b499d9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106262
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-18 03:29:57 +00:00
dawn-autoroll d7ccff1b48 Roll vulkan-deps from af6c033bca19 to ba840d111dc5 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/af6c033bca19..ba840d111dc5

Changed dependencies:
* glslang: 5755de46b0..a0ad0d7067

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: lokokung@google.com
Change-Id: If98b043b3b678e262256eabdddcb7ee275001323
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106261
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-10-18 02:29:39 +00:00
Antonio Maiorano 79195ca42a tint/uniformity: implement analysis for full and partial assignments
As per https://github.com/gpuweb/gpuweb/pull/3298

Bug: tint:1703
Change-Id: I88eb40764473fdae52962b36df1b4a1c929603f6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/105000
Reviewed-by: Alan Baker <alanbaker@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-10-17 21:47:38 +00:00
dan sinclair 33a090f90f Remove unused SwitchStatement method.
The SwitchStatement has an IsDefault method which checks if the
condition is nullptr. The method is never called, and default
cases are tracked in the CaseStatement class, so it's questionable
what IsDefault even means here.

Change-Id: I96e97fbbf4823df3e92d2440fa6a9541a5ba337f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106280
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-10-17 21:45:34 +00:00
Antonio Maiorano 29fb8f8eef tint: optimize compile time for const_eval_*_test files
The reason for slow compile times is because the very large variants of
builder::Value<T>s combined with the many std::visits over these
variants result in many combinatorial instantiations of the visit
callbacks.

To address this, I added a polymorphic base class ValueBase to Value<T>,
and replaced most of the std::visit-based compile time code with runtime
virtual calls. For the two heaviest users of std::visit over the large
variants, compiles times dropped more than half (clang-10, debug):

const_eval_binary_op_test.cc: 19.079s to 7.736s
const_eval_unary_op_test.cc: 10.021s to 4.789s

Bug: tint:1711
Change-Id: Iba05e6ae1004ef0814250e2a8ea50aa2b26b85f2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/105782
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-10-17 16:11:02 +00:00