ff75ab9a87
d3d11: set object labels
...
Change-Id: I26b7accf973b03cef7ba113b0ee3672b99e41338
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126861
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-04-19 23:26:15 +00:00
5faf59d81d
tools/perfmon: Hook up external shader corpus
...
Allow perfmon to benchmark shaders that are defined outside of the repo
Change-Id: Iee53b64cf357facdaa9941602d8d571611680097
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/128040
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2023-04-19 23:26:01 +00:00
d795f7958e
Roll ANGLE from 3e74b09e8b37 to ef20f19165ab (6 revisions)
...
3e74b09e8b..ef20f19165chris@rive.app Make the PLS allow list more permissive
2023-04-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c8e5e8c4c60b to 9403c35f9956 (31 revisions)
2023-04-19 ynovikov@chromium.org Fix iOS build
2023-04-19 cclao@google.com Reland "Vulkan: Use midRenderPass clear if RP has started but inactive"
2023-04-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e81a1152c10c to dd55e592406d (1 revision)
2023-04-19 kkinnunen@apple.com Metal: Support compiling on iOS without EAGL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: Ied4480daf05dc8015e4c7e3fac7d1821b5c118a5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/128080
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-19 23:19:30 +00:00
e6e5998e2b
Cleanup GLSL writer.
...
This Cl removes the boolean return values from most of the GLSL
writer methods. The diagnostics are used to determine if the generation
was successful. The writer itself just continues until complete.
Change-Id: Ia64968eaa6a0aa39a9713fa78f3e743f2de38b44
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127020
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-19 20:32:13 +00:00
c480632ed6
Setup ArrayLength transform for MSL benchmark
...
Some of the benchmark shaders when run with the MSL backend are
currently failing because the robustness transform is injecting the
arrayLength method but there is no configuration for running the
arrayLength transform.
This Cl adds some default configuration to the MSL bench to make a slot
available for each possible value. It just always makes them available
such that all shaders work correctly.
Change-Id: Ie8a15abc0b7da7d2f46be11274e66302406be019
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/128060
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-19 20:14:50 +00:00
e16ed7ccc2
Make more SymbolTable methods string_view.
...
This CL updates more of the SymbolTable to use string views.
Change-Id: I0d9c7817ba4e3b0d0e73cfc02406481eb796c3c2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127320
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2023-04-19 16:58:12 +00:00
0559005494
Move traits into utils.
...
This CL moves the tint/traits file into tint/utils/traits. Traits is one
of the few items not in utils which is referred to by utils.
Change-Id: Ie955398f24e949b7618fdc868dbcb903fe20b3f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127400
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-19 16:52:46 +00:00
b7285f3c9e
d3d11: implement Buffer
...
Bug: dawn:1705
Change-Id: I4542cc2e0f4f6a7f0d13c5f071bfb25897350008
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126440
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-04-19 15:52:32 +00:00
d21e2d64ec
Convert VariableUser vector over to utils::Vector.
...
This vector was causing a lot of small allocations to happen, this CL
converts over to a utils::Vector to take advantage of the better
allocation strategy
Change-Id: Id740bd2a50a8d0bdd84f4b6e7c7ad4607436c7f4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127500
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-19 15:06:24 +00:00
8fc9b86214
CMake: Add TINT_EXTERNAL_BENCHMARK_CORPUS_DIR
...
If specified, CMake will glob all the .wgsl files in this directory, and add these to the list of benchmarks to run.
Change-Id: I75b2754a6561dcd931c42bd47649c4f625e1c581
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127980
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2023-04-19 15:03:19 +00:00
5f4847c23e
tint/sem: Make BindingPoint optional
...
Reduces hops from sem -> ast, just to know whether the variable has a binding point.
Change-Id: I5620198e6f08b73d5a0171d95874f1a2dae5d93e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127060
Reviewed-by: James Price <jrprice@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: James Price <jrprice@google.com>
2023-04-19 13:24:27 +00:00
d1aa1cb29a
Roll vulkan-deps from 7e14678ab783 to 4fbe7556fc02 (5 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/7e14678ab783..4fbe7556fc02
Changed dependencies:
* vulkan-loader: 55a3cf2651..f035e57c17d1bb20e47f..3b659f3410https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I6000d05bd900031bf4e97f46a14a875e552f6085
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127941
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-19 10:34:14 +00:00
08e93ecfca
Roll ANGLE from 3b57e99923ae to 3e74b09e8b37 (4 revisions)
...
3b57e99923..3e74b09e8bangle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 14f65a9e1f45 to b87b8dd3ae80 (2047 revisions)
2023-04-19 romanl@google.com Remove unused angle_trace_tests from isolate
2023-04-18 yuxinhu@google.com Add Spirv Instruction to explicitly cast mediump float to 16 bit
2023-04-18 cclao@google.com Vulkan: Disallow reactivate of UtilsVk::blitResolve renderPass
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: Ic86c303e66dcdcba41b375e6562ad9e28d139a82
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127961
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-19 10:01:13 +00:00
c47e05ae50
Rolls third_party/gpuweb to 2e75d5e
...
- Needed to remove maxFragmentCombinedOutputResources limit.
Bug: dawn:1756
Change-Id: Ia7c87d845a79fafee45ab7d1e2b7798e3157945f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127940
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2023-04-19 09:08:42 +00:00
f4b9f95b68
dawn/node: Implement GPUBuffer.getMapState()
...
Bug: dawn:1761
Change-Id: Id01789a2df8afd5726f6fc776e7d825153fd0f85
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127722
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2023-04-19 01:47:52 +00:00
ee25184ea4
Triage occlusion query failures in webgpu-cts expectations.txt
...
Bug: dawn:1706
Change-Id: I0c0da246d748489f8b37da5c9512e6066d35ef5a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127521
Commit-Queue: Hao Li <hao.x.li@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-19 01:10:51 +00:00
692846d0a0
tint/resolver: Fix use after move
...
Bug: chromium:1434271
Change-Id: Ib70f9468c60fe00ca7bf9346b6ee8a71a819b59d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127681
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2023-04-18 21:15:44 +00:00
04147fc429
Roll vulkan-deps from f81e1056ccbc to 7e14678ab783 (6 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/f81e1056ccbc..7e14678ab783
Changed dependencies:
* spirv-tools: d5f69dba55..25ad5e19f1797ffe0108..55a3cf265164a454c9c1..d1bb20e47fhttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: Idef5c435ee74c482d5e6903fbb7680e0d2b3db74
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127861
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-18 21:11:37 +00:00
bacf44f964
Workaround dawn_wire_server_and_frontend_fuzzer ASAN false positive
...
When discovering Vulkan adapters, if none is found, the vulkan loader
DLL is loaded and then unloaded, which results in ASAN false positives
when the loader's previously allocated memory is re-used, which happens
in fuzzer::TracePC::ClearInlineCounters.
Bug: chromium:1427723
Bug: chromium:1038952
Change-Id: Idb205607426a0af22daba363e2679afaa33204b9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127840
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2023-04-18 20:10:51 +00:00
b8a3bac98b
Add .gitignore entry for /third_party/google_benchmark/src
...
Change-Id: I41a0a70bbe417f0baaeccc0ff9514d1e20119eb3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127880
Reviewed-by: Loko Kung <lokokung@google.com>
Auto-Submit: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
2023-04-18 19:55:47 +00:00
d018972a88
Roll ANGLE from 2f19bb746c6c to 3b57e99923ae (9 revisions)
...
2f19bb746c..3b57e99923syoussefi@chromium.org Scope global lock in entry points
2023-04-18 sky@chromium.org Adds features to enable loading/saving metallibs to blobcache
2023-04-18 lexa.knyazev@gmail.com GL: Enable OES_shader_multisample_interpolation
2023-04-18 msisov@igalia.com metal: allow unequal size attachments.
2023-04-18 hob@chromium.org Use MESA variant of glFramebufferParameteri if possible
2023-04-18 sky@chromium.org Removes UNREACHABLE in display initialization
2023-04-18 fangzhoug@chromium.org GL: Extend Qualcomm driver workarounds beyond Android
2023-04-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 174e65e85901 to e81a1152c10c (1 revision)
2023-04-18 chris@rive.app Finalize PLS support for non-2D texture types
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I0ac9232539ab6c0c42db2aee7d1af1c03ec1088d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127860
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-18 19:40:58 +00:00
d026e13f48
Remove `SymbolTable::NameFor`
...
This CL removes the `NameFor` method from SymbolTable and accesses the
symbols name directly.
Change-Id: Ic4ad6eecfa78efb946d97aeaecf2d784af2e6f16
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127301
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-18 19:38:25 +00:00
b353ebe752
Add an allocator to store the symbol names.
...
This CL adds an allocator, owned by the SymbolTable, which stores the
names of all the symbols in the table. The Symbols then have a
`string_view` to their name.
Change-Id: I28e5b2aefcf9f67c1877b7ebab52416f780bd8c6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127300
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-18 19:31:21 +00:00
00882100f4
Roll SwiftShader from e81a1152c10c to dd55e592406d (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/e81a1152c10c..dd55e592406d
2023-04-18 bclayton@google.com Add PrintValue specialization for Vector4i
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I8e9821441a98a1bf8a71cb8b6f268aaff57f678c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127820
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-18 17:22:27 +00:00
fa3c08d112
Add a bump allocator.
...
This CL adds a simple allocator which will provide a chunk of memory of
the given size. It allocates out of slabs of memory.
Change-Id: I9acf59fac88cd6bef260b7ebae7d7b77fd939754
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127302
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-18 16:15:44 +00:00
dc071b1098
Roll ANGLE from c9c40896d6f5 to 2f19bb746c6c (4 revisions)
...
c9c40896d6..2f19bb746ccclao@google.com Reland "Vulkan: Reactivate already started render pass when possible"
2023-04-17 romanl@google.com Fix win-trace broken by tracegz.py
2023-04-17 geofflang@chromium.org Avoid calling GetGpuIDFromDisplayID in Mac GPU info collection.
2023-04-17 abdolrashidi@google.com Fix the retrace issue for VMA image suballocation
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I04b0b7ef847ca6e270d1706495f8aa14dbf3f178
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127760
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-18 06:21:41 +00:00
563929f00e
Remove flaky suppression of Mac Intel tests.
...
Bug: dawn:1500
Change-Id: Ie0bd4a06ee42c93180c8267952cb99ccb91900db
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127720
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
2023-04-18 06:17:35 +00:00
af070eb48f
Roll SwiftShader from 174e65e85901 to e81a1152c10c (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/174e65e85901..e81a1152c10c
2023-04-18 ayzhao@google.com Bump git hooks version to 6d91964
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I032a4761459e070f2efc06c52184df9978fe5bc2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127740
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-18 03:23:19 +00:00
8f0607a8c8
Fix D3D12 shader interstage truncating transform
...
Don't skip the TruncateInterstageVariables transform when
user defined interstage attribute input for fragment stage
is empty. Because builtin inputs could also cause register
mismatch for D3D12 HLSL compiler.
Add a boolean flag to Tint hlsl generator option to indicate
whether to run TruncateInterstageVariables or not.
This defaults to false in Tint, while Dawn always set
this to true for vertex stage.
Bug: dawn:1733
Change-Id: Ie4c3648b226513bf15f0e03ae4ce7f3cc09fdef4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127206
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
2023-04-18 01:34:41 +00:00
dbb68623bb
Roll third_party/webgpu-cts/ 8220cf0cf..c7d833bad (7 commits)
...
Regenerated:
- expectations.txt
- ts_sources.txt
- test_list.txt
- cache_list.txt
- resource_files.txt
- webtest .html files
8220cf0cfb..c7d833badc#2486 )
- 3171da bitcast execution: integral 32-bit types and vectors of them (#2428 )
- 0ac5d4 Migrate various Vector -> tests (#2479 )
- 86a1f8 Fix issues in LimitTestsImpl
- 0505ff Migrate unpack* tests to new framework (#2478 )
- 2d608a Migrate Scalar Triple -> Interval tests to use new numeric framework (#2477 )
- 55aaf9 Migrate Scalar Pair -> Interval tests to use new numeric framework (#2475 )
Created with './tools/run cts roll'
Change-Id: Icdd8f92acf2c75da055b00e3874a7210361b5d9c
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127620
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
2023-04-17 22:32:29 +00:00
0791248a26
Roll vulkan-deps from a6e68d7ed2e8 to f81e1056ccbc (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/a6e68d7ed2e8..f81e1056ccbc
Changed dependencies:
* vulkan-validation-layers: ddd3f7ee9d..64a454c9c1https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I8fbd9e32b4b0df4e3407b9dbaf1458d518e00008
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127600
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-17 18:52:33 +00:00
6a7bba54fa
Add basic Dawn microbenchmarks using Google benchmark
...
The initial test tests bind group layout creation of
different sizes, cache / no-cache hit, with and without
multiple threads.
Change-Id: Ic9ed6c6f1c298d35cd1358c7ff492027c83649a7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127346
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-17 18:11:51 +00:00
e27972a575
Roll ANGLE from d0148f12bc12 to c9c40896d6f5 (1 revision)
...
d0148f12bc..c9c40896d6rafael.cintron@microsoft.com Eliminate TexStorage Label Redundancy
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I99a058c32ae53fce355c499fc63ed6c80cc2eced
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127580
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-17 17:06:56 +00:00
559e5a2cde
tint/transform: Fix ICE in HLSL backend
...
When referencing a pointer parameter with a 'let', but not using that
let.
Also fix a bunch of places where we used the old names for the pointer
transforms.
Bug: chromium:1433499
Change-Id: I8decefeacd6150bd6f7637f80e62b9cb62936235
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127540
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2023-04-17 14:24:58 +00:00
63aa15467e
Roll third_party/webgpu-cts/ 15b8caf79..8220cf0cf (9 commits)
...
Regenerated:
- expectations.txt
- ts_sources.txt
- test_list.txt
- cache_list.txt
- resource_files.txt
- webtest .html files
15b8caf79e..8220cf0cfb#2464 )
- f77035 Migrate Scalar -> Interval tests to use new numeric framework (#2474 )
- 65cd11 Migrate `abs` tests over to use FP.f32 directly
- 3ab032 Replace Point/Binary/Ternary with Scalar{Pair/Triple}
- 552fe1 Fix Occlusion Query Op Test
- 3182e8 Fix fragment shader in maxInterStageShaderComponents validation (#2469 )
- 0eacf5 Refactor how floating point intervals are calculated (#2468 )
- fd777c Slightly expand sample_mask tests (#2466 )
- 7e014d Use (number | IntervalBounds) for specifying unittests (#2456 )
Created with './tools/run cts roll'
Change-Id: I48f7afe742004afb6f373c64a16877802f755de1
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126600
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
2023-04-17 02:25:29 +00:00
4bfdd18e7d
Roll ANGLE from 7bc4b7e31f72 to d0148f12bc12 (1 revision)
...
7bc4b7e31f..d0148f12bcynovikov@chromium.org Temporarily restore obsolete VUID suppressions
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Iad5338eb29b0b33676a146181712f166ca50b41e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127480
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-15 22:22:51 +00:00
aee827c460
Roll vulkan-deps from a43d9b56a12c to a6e68d7ed2e8 (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/a43d9b56a12c..a6e68d7ed2e8
Changed dependencies:
* vulkan-validation-layers: f95138a9a2..ddd3f7ee9dhttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ib22aac289a2f0bd9bb7a239a4e7c1c6d51f477ea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127349
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-15 19:21:18 +00:00
7cec9076d5
Remove experimental Mac AMD trybot from CTS rolls
...
Mac AMD testing restored on Dawn CQ in crrev.com/c/4427778
Bug: chromium:1382149
Change-Id: I8a100c68a49ad9de72a0f4a25ec1371241dcc7b8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127421
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-15 11:42:18 +00:00
2f28c5be06
Roll ANGLE from e553b901569d to 7bc4b7e31f72 (6 revisions)
...
e553b90156..7bc4b7e31flexa.knyazev@gmail.com Metal: Implement OES_sample_variables
2023-04-14 romanl@google.com Trace Interpreter: gzip cpp and run gold tests.
2023-04-14 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from ec231c69caa6 to c8e5e8c4c60b (60 revisions)
2023-04-14 msisov@igalia.com [ios] fix sublayer resize
2023-04-14 ynovikov@chromium.org Stop running tests on experimental Mac AMD bot
2023-04-14 romanl@google.com Remove unnecessary and unused --interpreter flag.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I14d7c1da513f8298c72de8f80ec71466587781ab
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127362
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-15 06:35:14 +00:00
402cdedac4
Roll vulkan-deps from 546bc887cb76 to a43d9b56a12c (9 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/546bc887cb76..a43d9b56a12c
Changed dependencies:
* vulkan-tools: 8bb9edd13f..db7475424c801211cb3c..f95138a9a2https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I7cc2b4074db82d95d55cf679a1bf2b8d995f4281
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127348
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-15 05:56:46 +00:00
7532f6665e
Disable OOM tests when TSAN is enabled.
...
Bug: dawn:1725
Change-Id: I83ddaaf0d98d2831f95abbfbf5adfad268ebdba5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127380
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
2023-04-14 22:38:28 +00:00
4489109c86
tools/cts/roll: Preserve RetryOnFailure expectations
...
It's intended for the Unexpected Pass Finder to clean these up.
This should help prevent known flakes from causing retries.
Bug: chromium:1426512
Change-Id: I58c7baf2585dc4ca2e061e4a53c7b7d0f41e0af9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127420
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2023-04-14 18:26:36 +00:00
b7291554c7
Roll ANGLE from aac847223de6 to e553b901569d (2 revisions)
...
aac847223d..e553b90156angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f048076954b4 to 14f65a9e1f45 (538 revisions)
2023-04-14 zzyiwei@chromium.org Vulkan: enable enableCompressingPipelineCacheInThreadPool for venus
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I187833c593f97c9623ab3ee1193af8d0348fb548
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127361
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-14 17:15:57 +00:00
f0da158742
Roll vulkan-deps from c8e5e8c4c60b to 546bc887cb76 (8 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/c8e5e8c4c60b..546bc887cb76
Changed dependencies:
* spirv-tools: f449fb4ad9..d5f69dba558c8619df2d..797ffe01084e17c284d6..8bb9edd13f7b50c36e7a..801211cb3chttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Icb2e1beb9ce84903e4974ab080eebb127011ff4e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127345
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-14 16:39:05 +00:00
a20c1ee82d
Roll ANGLE from 32fa13927f81 to aac847223de6 (3 revisions)
...
32fa13927f..aac847223dromanl@google.com Trace Interpreter: Allow running .cpp traces, not only .c
2023-04-13 romanl@google.com Trace Interpreter: Move to a shared library.
2023-04-13 jmadill@chromium.org Trace Interpreter: Support \\ escape sequences.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I0aeebbb5cd536733b1a7d797bbbe572590a909da
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127360
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-14 03:54:05 +00:00
f5966b09e1
d3d11: enable d3d11 if dawn is not build with chromium
...
This CL enable build d3d11 by default, if dawn is not build with
chromium. d3d11 backend is not full implemented yet, so no tests
will run against d3d11 backend.
Bug: dawn:1705
Change-Id: Id689ab5168511af0f75f0b3537f246713de5ca45
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127260
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-04-14 02:05:17 +00:00
34d52ffa4c
Revert "d3d11: add d3d11 backend in end2end tests"
...
This reverts commit 3fcf96dd8chttps://dawn-review.googlesource.com/c/dawn/+/126260
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Reviewed-by: Austin Eng <enga@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>
Bug: dawn:1705
Change-Id: I95a1cc9a0962b01a6b31ea32b6129f109f4b3e42
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127240
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-04-13 22:45:28 +00:00
c4cc6ec038
Remove the demangler.
...
The demangler is no longer used by the Tint executable, and nothing else
calls it, so delete it.
Change-Id: Ic47238e4a6126e5daacd81dfc6f5986524b648ba
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127280
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-13 21:17:12 +00:00
c0398e4174
Skip logging on Win official builds
...
Skips logging in sandboxed processes on Windows
official builds since the file handles will not
be set properly, causing crashes when we try to
write to stdout/stderr.
Bug: chromium:1429665
Change-Id: Ie70d0cc2e096bd22490dc3538467752b448f213b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127205
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@google.com>
2023-04-13 20:41:23 +00:00
a49353d4cd
Roll vulkan-deps from cc077ed7fd08 to c8e5e8c4c60b (11 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/cc077ed7fd08..c8e5e8c4c60b
Changed dependencies:
* glslang: a270fdae55..68f073b19529ba249312..cfbe4feef2048faf2e53..f449fb4ad963af1cf1ee..95a13d7b71ecb65c98cd..7b50c36e7ahttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I8dad699ca4f2b2bea754c252b58f77f0f3fff79a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127204
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-13 16:29:34 +00:00
Peng Huang
Ben Clayton
Dawn Autoroller
dan sinclair
Ben Clayton
Loko Kung
Jiawei Shao
Li Hao
Antonio Maiorano
Austin Eng
shrekshao
Yuly Novikov
Le Hoang Quyen
Brian Sheedy