541138b11b
Cleanup SyntaxTree writer.
...
This Cl removes the boolean return values from most of the SyntaxTree
writer methods. The diagnostics are used to determine if the generation
was successful. The writer itself just continues until complete.
Change-Id: I87d85e2cbe061306a4598a498ccad4510f62e8c9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/124681
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-13 04:18:55 +00:00
27c7722620
Cleanup WGSL writer.
...
This Cl removes the boolean return values from most of the WGSL writer
methods. The diagnostics are used to determine if the generation was
successful. The writer itself just continues until complete.
Change-Id: Iff33128c1df286cab799f08dab8c3defc5651d76
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/124680
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2023-04-13 02:57:27 +00:00
818865925d
Roll ANGLE from f507fe05cd85 to 9ae918cbd468 (3 revisions)
...
f507fe05cd..9ae918cbd4cclao@google.com Reland "Vulkan: SurfaceVk should only wait for GPU work that uses it"
2023-04-12 zzyiwei@chromium.org Vulkan: remove isVenus from ARM driver version check
2023-04-12 kkinnunen@apple.com Add PLATFORM_IOS again
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I9bc6147b84e47d2d6b15ba2135b1e97e6c32e9fa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127140
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-13 01:24:21 +00:00
3e7a114a6e
Add missing lock to APIBeginRender/ComputePass.
...
Add tests to verify multithreading behaviors of encoding render/compute
passes.
Bug: dawn:1662
Change-Id: I9bc6a0dd5d94b53b59e7e49a4611d4d55cc36e60
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126980
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-12 21:07:31 +00:00
3dba94c1d4
d3d11: implement RenderPipeline
...
Bug: dawn:1705
Change-Id: If6de0d18c4da530ba63637aa095ae2f4a957c2f7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126663
Commit-Queue: Peng Huang <penghuang@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2023-04-12 19:05:00 +00:00
8af0ad53e5
Roll SwiftShader from 8ef6045b0a23 to 770571d91b69 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/8ef6045b0a23..770571d91b69
2023-04-12 jif@google.com Add missing #include in LLVM 16
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC cwallez@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I19eec04679600742af6396e87392fbb4394ada2a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127040
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-12 15:34:36 +00:00
0b3fc055d3
Update samples to process events.
...
This CL updates the `dawn/sample` programs to call the
`dawn::native::InstanceProcessEvents` which allows things like shader
validation errors to be emitted.
Without this change the errors are never displayed.
Change-Id: I054bb4f7177c5d0c110e97409852143b2bef1e02
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126760
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-12 13:19:35 +00:00
b04e622eea
Roll ANGLE from bf11a801abbc to f507fe05cd85 (16 revisions)
...
bf11a801ab..f507fe05cdkkinnunen@apple.com Rename PLATFORM_IOS to PLATFORM_IOS_FAMILY
2023-04-12 kkinnunen@apple.com EAGL: Define ANGLE_ENABLE_EAGL in build system
2023-04-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d579bce09fab to 86be736f34ce (558 revisions)
2023-04-12 cclao@google.com Vulkan: Force submit when switch to system framebuffer draw
2023-04-12 cclao@google.com Vulkan: Wait for surface ANI semaphore only if image is used
2023-04-11 jmadill@chromium.org Trace Interpreter: Support gClientArrays
2023-04-11 cnorthrop@google.com GLES1: Convert ints to uints for mediump values
2023-04-11 romanl@google.com Trace Interpreter: support harry_potter_hogwarts_mystery
2023-04-11 cclao@google.com Vulkan: Let recordWriteBarrier use CommandBufferHelper
2023-04-11 romanl@google.com Avoid "KeyError: 'exit_code'" error in failed shard detection
2023-04-11 cclao@google.com Vulkan: Add commandQueueWaitSemaphoresTotal perf counter
2023-04-11 ynovikov@chromium.org Fix UWP build
2023-04-11 romanl@google.com Set target_sdk_version to 33 instead of system_current
2023-04-11 kkinnunen@apple.com CGL: Remove the impl preprocessor guards
2023-04-11 zzyiwei@chromium.org Vulkan: enable precisionSafeDivision for venus
2023-04-11 romanl@google.com Move targetSdkVersion to Android.bp and set to system_current
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Id9b1866abf59398e901bab34d15666abb3cb1b4b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126962
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-12 12:05:45 +00:00
8a435a2a4b
Remove `error` from TextGenerator.
...
This CL removes the `error()` method from the TextGenerator in favour of
using `Diagnostics().str()`.
Change-Id: If20261ac839d11f6d29890cb17f95f2d4df5db2d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126923
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2023-04-12 11:59:24 +00:00
24e68d9506
Roll vulkan-deps from 007d57ed27cc to cc077ed7fd08 (4 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/007d57ed27cc..cc077ed7fd08
Changed dependencies:
* glslang: 9fe5223370..a270fdae553fa767db74..fc9bee27f4b70aed82a8..ecb65c98cdhttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I338307462c7d47f68ffecd226d0216e9c6fd59bb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126940
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-12 09:16:04 +00:00
585f395e66
Simplify MultiplanarExternalTexture::ShouldRun.
...
Currently the multiplanar `ShouldRun` function is scanning all objects
looking for an external texture. This CL switches to using the type
manager and attempts to find an `ExternalTexture` type in the system. If
found, then the transform should run.
Change-Id: I28b8fa1835a83f2bff5d804e95bcbaa73d3d2124
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126922
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-12 00:44:20 +00:00
c3cc75067e
d3d11: implement ComputePipeline
...
Bug: dawn:1705
Change-Id: I915000a747cc913ed52a423940d20e169b829315
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126664
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-12 00:02:30 +00:00
04d61c85cd
Always run Multiplanar transform.
...
Currently the multiplanar transform is only run if a global variable is
seen with a `texture_external`. There are cases where a function with a
`texture_external` can exist (the fuzzers do this, the tint command line
can do this as well). These will fail when hitting the backend.
This CL makes the running of multiplanar unconditional. This causes the
logic to process the function parameters to run and the external texture
is removed.
Bug: chromium:1431610
Change-Id: I1793142e803e864c744b38cf843931521e6a449f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126921
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-11 23:02:45 +00:00
d146c8a7a2
Enable multiplanar for SPIRV fuzzers.
...
This CL updates the common fuzzer code to enable the multiplanar
extension for the SPIR-V backend.
Bug: chromium:1427801
Change-Id: Ie03d3e10f7831ca851aa11c00cbac0aa474ccabb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126920
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2023-04-11 23:02:38 +00:00
defda09e3c
d3d11: implement Texture
...
Bug: dawn:1705
Change-Id: Iff5e301c04120a86ccf4eba33281233e4d972981
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126662
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-04-11 20:42:23 +00:00
99c5920361
Roll vulkan-deps from f49e9e501f3a to 007d57ed27cc (5 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/f49e9e501f3a..007d57ed27cc
Changed dependencies:
* spirv-cross: 3327924add..3fa767db743521747ed0..b70aed82a8https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Id42f96c2d0b618e0e4635688f7bed62b695f78b7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126900
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-11 19:52:48 +00:00
397546de89
Roll ANGLE from 0059667f5cee to bf11a801abbc (1 revision)
...
0059667f5c..bf11a801abangle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 837a7f0f9df1 to d579bce09fab (439 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I0a948d59001005d997b734c6dfe0f1add5450bdb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126880
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-11 17:42:43 +00:00
c1f6dbd139
Use DAWN_VULKAN_DEPS_DIR consistently.
...
Several of the CMake variables were creating the vulkan-deps folder from
the `THIRD_PARTY_DIR` instead of the provided `VULKAN_DEPS_DIR`.
Change-Id: Id620485b17f833cedbb6403d0f01f0ceba51b660
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126761
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2023-04-11 15:45:18 +00:00
a567d36d0a
Roll vulkan-deps from 141a95bdd1a9 to f49e9e501f3a (9 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/141a95bdd1a9..f49e9e501f3a
Changed dependencies:
* glslang: bdba39bae6..9fe5223370dbcdcc1260..3521747ed0https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Iaa164bd1920b4982f90f4960c11644ba628c2ba4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126820
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-11 06:36:39 +00:00
0fce39c89a
Roll ANGLE from c8b32849b51c to 0059667f5cee (1 revision)
...
c8b32849b5..0059667f5cangle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e621934caf42 to 8ef6045b0a23 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I409d6c9923fd2c6a3f5941ad029eb494c77764bf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126801
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-11 02:52:31 +00:00
8bd2c03ed1
Roll vulkan-deps from cc40b6b58a8d to 141a95bdd1a9 (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/cc40b6b58a8d..141a95bdd1a9
Changed dependencies:
* vulkan-validation-layers: 9b1911a1aa..dbcdcc1260https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I1cb415c7a8ca78d9d491d80d831d015d66caf967
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126743
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-10 17:21:20 +00:00
05625b333a
Roll ANGLE from 23ec06204174 to c8b32849b51c (1 revision)
...
23ec062041..c8b32849b5angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8701b5ed1d64 to 837a7f0f9df1 (574 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I7d7a315f7c02b9f62ba035f0132b0fe7c7ff1a41
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126800
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-10 12:51:06 +00:00
dc626d357d
Add missing lock when creating new pipeline during encoding.
...
This was unsafe when encoding indirect draws with validations on
multiple threads.
Bug: dawn:1662
Change-Id: I479bb35bc98dd314860955b3c30df788d18ed84e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126780
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
2023-04-10 10:09:57 +00:00
3dce55a6fe
MetalBackend: Enable multithread support.
...
Bug: dawn:1662
Change-Id: If2f74b4bbce9d108fcd5906c2105f9ebd95845fe
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/124400
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
2023-04-10 09:33:43 +00:00
6ffc7890fb
Roll vulkan-deps from 76c349cb8e26 to cc40b6b58a8d (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/76c349cb8e26..cc40b6b58a8d
Changed dependencies:
* vulkan-validation-layers: 91a6ad1db0..9b1911a1aahttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: Ic8018b19ece4b2155ccedf12d3f6f24bf1e88091
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126742
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-08 14:37:57 +00:00
132f2536bf
Roll SwiftShader from 08f12cdc2290 to 8ef6045b0a23 (2 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/08f12cdc2290..8ef6045b0a23
2023-04-07 natsu@google.com Undef i386 builtin to avoid collision with LLVM namespace
2023-04-07 natsu@google.com Remove HAVE_MALLINFO2 from Android LLVM16 config
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I294931b3c5fc903df61fdd620977815d77d6c178
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126703
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-08 01:54:03 +00:00
5a7ec21eb0
Roll vulkan-deps from 81c9a845f937 to 76c349cb8e26 (2 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/81c9a845f937..76c349cb8e26
Changed dependencies:
* vulkan-tools: 6b0935cece..4e17c284d6e8815f2d1a..91a6ad1db0https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I3eb8f0479c1bc53e814789e51665b61f776d42bd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126740
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-08 01:23:34 +00:00
12beb4c663
Roll ANGLE from 9896bd2506cf to 23ec06204174 (2 revisions)
...
9896bd2506..23ec062041abdolrashidi@google.com Vulkan: Add more data to blob cache header
2023-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3ecab9c1aa60 to e621934caf42 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I4c41bba71504a24c90954f01d090849d077ff74d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126702
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-08 00:51:04 +00:00
087deedbc8
dawn.json: remove leftovers from implementation-based swapchains.
...
This also removes the need for special casing the swapchain creation
proc in the fuzzers because it is no longer possible to have a valid
CreateSwapChain call since the wire can't create a surface (which is no
longer optional).
Bug: dawn:269
Change-Id: Icc6ed5e82c1d5382628d71d212640d238cfba348
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126425
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
2023-04-07 14:59:55 +00:00
a48ba981ea
Remove dawn_wsi.h
...
Bug: dawn:269
Change-Id: Ie1fb1a8109ff646b880c3e27762300167776d050
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126424
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-07 13:33:26 +00:00
1226684b09
Merge NewSwapChainBase in SwapChainBase
...
Bug: dawn:269
Change-Id: I514c210f88e2bf1f501e2d814f8ab931c5ed724f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126423
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-07 13:30:50 +00:00
4299bd0ac9
Roll SwiftShader from e621934caf42 to 08f12cdc2290 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/e621934caf42..08f12cdc2290
2023-04-07 jif@google.com Reduce the number of files built in LLVM 16
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: Ifa754c617c53e65642d8ce29d296574ee51577cc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126701
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-07 12:40:54 +00:00
2e657602da
Roll vulkan-deps from b71c91d6092d to 81c9a845f937 (5 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/b71c91d6092d..81c9a845f937
Changed dependencies:
* vulkan-loader: 50df6bc578..8c8619df2d37a259a5b2..6b0935cecec709c1d90e..e8815f2d1ahttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: Ib2e6bd4f776cfaee7da430378da8928d7d502f4b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126720
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-07 12:11:37 +00:00
924bb2bd78
Roll ANGLE from 36296928ed7d to 9896bd2506cf (3 revisions)
...
36296928ed..9896bd2506angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7c7c08cd1e65 to 8701b5ed1d64 (1013 revisions)
2023-04-06 kkinnunen@apple.com Fix GetCurrentThreadUniqueId on Release APPLE
2023-04-06 kkinnunen@apple.com EAGL: Remove the impl preprocessor guards
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I5ea69c8bac14e44d35a65ba281e26914994bf4ca
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126700
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-07 11:35:08 +00:00
6b67a90d8b
Allow setting markupsafe directory in CMake.
...
This CL updates the configuration to allow providing the markupsafe
folder in the CMake configuration. The generator is updated in order to
in set the folder into the path so `jinja2` can find markupsafe.
Change-Id: I3b79deba0d8c2af9c751ddb63c4febc542e904df
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126661
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2023-04-07 07:52:36 +00:00
d23059b0bf
Roll vulkan-deps from ff63966203ee to b71c91d6092d (9 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/ff63966203ee..b71c91d6092d
Changed dependencies:
* glslang: 1aefd184a6..bdba39bae6dd03c1fca4..048faf2e534ad4313da0..37a259a5b28b2cdce023..c709c1d90ehttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: If817d2698d909fb93121dad79c8d167f1088b513
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126680
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-06 22:52:50 +00:00
6635b965b9
d3d11: implement ShaderModule
...
Bug: dawn:1705
Change-Id: I621a561e1b61762bb8347a74b24cb18a7c808ba3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126303
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-04-06 22:37:26 +00:00
67571d776d
Roll ANGLE from be3d7e6b6a76 to 36296928ed7d (1 revision)
...
be3d7e6b6a..36296928edgeofflang@chromium.org Mark RGBX and BGRX formats as having 8 unused bits.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: If5301b42437df2498a62fe309d5cecaa1f69fd3c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126681
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-06 22:18:46 +00:00
86e6a13649
d3d11: add BindGroup, BindGroupLayout and PipelineLayout
...
Bug: dawn:1705
Change-Id: I9bc7545328409c7ce8fd8adc26a35b872cda1420
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126302
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-04-06 19:59:05 +00:00
4faf3d31ba
d3d11: add Device, Queue, Sampler, etc
...
Bug: dawn:1705
Change-Id: I0cfc54a3be2c9dc4471d0b5b9cb7d6066519bcf1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126300
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-06 18:02:13 +00:00
ac77863352
d3d: supports more errors in HRESULTAsString()
...
Bug: dawn:1705
Change-Id: I811ed5867399fa417a0a542f3d4e706e989f0a23
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126660
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-04-06 17:12:04 +00:00
b7a3cbe8ca
end2end tests: add --enable-implicit-device-sync option.
...
This option will allow tests to be run with
ImplicitiDeviceSynchronization feature.
Bug: dawn:1662
Change-Id: Ic001b2fa175f63e8d77eeb3b23d4d2cf52bb224e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126580
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
2023-04-06 16:03:13 +00:00
8bfdb661f8
Remove old CMake option.
...
This CL removes the `DAWN_TINT_DIR` option from the main CMakeLists.txt
file as it is no longer used.
Change-Id: I12e6ad29ca7d5d7bf17ae16a197d5a32f2dbc054
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126620
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-06 14:36:53 +00:00
fe87814fd6
Roll SwiftShader from 3ecab9c1aa60 to e621934caf42 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/3ecab9c1aa60..e621934caf42
2023-04-06 jif@google.com Add configs/darwin for LLVM 16
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: Id158e1947c4315ad9d5fa5d85efd1fcab257ae24
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126640
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-06 14:35:19 +00:00
c173a0ea88
Fix TRACE_EVENT wasn't thread safe.
...
TRACE_EVENT uses INTERNAL_TRACE_EVENT_GET_CATEGORY_INFO and
INTERNAL_TRACE_EVENT_GET_CATEGORY_INFO reads and writes to a static
variable on multiple threads.
Fix by using std::atomic for the static variable.
Bug: dawn:1700
Change-Id: I914bb73352e400f0adeafb64518d61099276270d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/123680
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
2023-04-06 08:08:00 +00:00
655c6c9b40
Roll vulkan-deps from 9ed0219175ec to ff63966203ee (6 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/9ed0219175ec..ff63966203ee
Changed dependencies:
* vulkan-loader: c3eb97de22..50df6bc578c50cd18fac..8b2cdce023https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: Iedb4f9c2b0621f9e8f239ac7961f7249012a28b2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126560
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-06 07:13:07 +00:00
53fe6bf384
Roll ANGLE from 9199e77d2650 to be3d7e6b6a76 (5 revisions)
...
9199e77d26..be3d7e6b6ai.nazarov@samsung.com Remove redundant g_SurfaceMutex.
2023-04-05 geofflang@chromium.org Disable staged uploads to packed texture formats on AMD.
2023-04-05 lexa.knyazev@gmail.com Add SampleVariablesTest
2023-04-05 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from 198e6d1c360e to 7c7c08cd1e65 (1326 revisions)
2023-04-05 i.nazarov@samsung.com Vulkan: Minor protected submitCommands() optimization.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com ,kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I96496000c65ce2300d64e2a246c2b2d64fdc963d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126540
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-06 01:45:11 +00:00
7971bfe16f
Add an option to enable implicit device synchronization.
...
1. Auto-generate mutex locking code in DawnNative's ProcTable's
functions. Using a mutex owned by the related Device.
- Unless the function/class has "no autolock" attribute (new) in
dawn.json. In which cases, no locking code will be auto-generated.
- Currently Instance, Adapter, Surface, Encoder classes and
Reference/Release method have "no autolock".
2. Added Feature::ImplicitDeviceSynchronization to enable Device's
mutex.
- If this feature is disabled, lock/unlock Device's mutex is no-op.
Auto-generated locking code will have no effect. This is the default.
- This approach is used instead of generating two sets of ProcTable
because it's cleaner and the internal code doesn't need to care about
whether there is a mutex being locked or not. Furthermore, if there
were two sets of ProcTable, and user used dawnProcSetProcs() to set
global ProcTable, it would affect all other modules using different
Devices. Even though those modules don't need thread safety.
Bug: dawn:1662
Change-Id: I75f0d28959f333318e4159916b259131581f79f5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119940
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-04-05 19:35:07 +00:00
76b73730c5
Roll vulkan-deps from 9c3e3185817f to 9ed0219175ec (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/9c3e3185817f..9ed0219175ec
Changed dependencies:
* spirv-tools: 97a55196d2..dd03c1fca4https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com ,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I50031d5dc68ed28ec3a05e0e87eb5568cb1d09d6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126520
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-04-05 17:59:02 +00:00
78c496395c
Always flush device callbacks when the callbacks are changed
...
With the wire, callbacks reference device-related data which is
freed when the device is unregistered from the wire. However,
the device that the wire refers to can live longer than this
and have its callbacks invoked at a later time, leading to a
use-after-free. Always flush the callbacks so that when the
wire unregisters a device and clears its callbacks, they are
called immediately and no dangling pointers remain.
Bug: chromium:1430221
Change-Id: Ib753b58cee5e7cb4d90ebd703958a0ddd5873573
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/126481
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-04-05 17:10:58 +00:00
dan sinclair
Dawn Autoroller
Le Hoang Quyen
Peng Huang
Corentin Wallez
Austin Eng