AxioDL
/
metaforce
mirror of https://github.com/AxioDL/metaforce.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,417 Commits 26 Branches 15 Tags 52 MiB
Commit Graph

3417 Commits

Author SHA1 Message Date
Phillip Stephens 0db6f96a17
Merge pull request #279 from lioncash/constexpr 
CScannableParameters: Mark CScannableParameters as constexpr
 2020-03-27 23:54:26 -07:00
Lioncash 2558da714e Runtime: Remove unnecessary smart pointer .get() calls 
Same behavior, less code to read.
 2020-03-27 20:50:45 -04:00
Lioncash 194cdf145f Runtime: Use nullptr where applicable 
Same behavior, but no magic 0 value.

While we're in the same area, we can do minor cosmetic changes.
 2020-03-27 20:18:54 -04:00
Lioncash 05988ce31c CScannableParameters: Mark CScannableParameters as constexpr 
This only contains a single member, so this can trivially be marked
constexpr.
 2020-03-27 20:07:33 -04:00
Phillip Stephens e0fe365dfd
Merge pull request #278 from lioncash/explicit 
General: Make use of explicit constructors where applicable
 2020-03-27 14:10:19 -07:00
Lioncash 241a66dc0a General: Make use of explicit constructors where applicable 
Gets rid of potential error prone implicitly constructing constructors.
 2020-03-27 06:00:17 -04:00
Lioncash e46a37e893 MP1: Make use of std::array where applicable 
Same behavior, stronger typing, and allows eliminating hardcoded sizes
in some places.
 2020-03-27 01:07:29 -04:00
Lioncash a77b9cb609 MP1: Join namespaces 
Same behavior, less code.
 2020-03-27 01:02:35 -04:00
Lioncash fcf70aeb2a CGuiWidgetIdDB: Remove redundant std::make_pair funcs 
Same behavior, less code.
 2020-03-26 03:55:28 -04:00
Lioncash 74600588fa Add missing includes pt.2 
Some missing includes that actually need to be present.
 2020-03-26 03:14:03 -04:00
Lioncash be6b5406a9 CPatterned/ScriptLoader: Convert function typedefs to using aliases 
Same thing, but more readable.
 2020-03-26 03:09:56 -04:00
Lioncash d9a9e0f51e CEnvFxManager: Take std::vector by value and std::move 
Same behavior, but allows calling code to move into the parameter,
avoiding copies.
 2020-03-26 02:56:10 -04:00
Lioncash dd76e73e11 ITweak: Default virtual destructor 
Same behavor, but allows the destructor to be trivial.
 2020-03-26 01:14:41 -04:00
Lioncash 51afa94e8c Add missing includes where applicable 
Resolves a few required dependencies
 2020-03-26 01:10:55 -04:00
Lioncash 4169e3d91d CSnakeWeedSwarm: Mark several member functions as const 
These don't alter instance state, so they can be const member functions.
 2020-03-26 01:05:32 -04:00
Lioncash 43e0d16c5d CSnakeWeedSwarm: Use emplace_back in CreateBoid() 
Same behavior, but with in-place construction instead.
 2020-03-26 01:00:29 -04:00
Lioncash 2164854e87 CVisorFlare: Pass flares by value and use std::move 
Same behavior, but allows calling code to move into the parameter and
avoid copies entirely.
 2020-03-26 00:32:49 -04:00
Lioncash 477c5770c6 rstl: Add [[nodiscard]] to interface functions where applicable 
Not using the result of these functions is considered a bug and should
be signified as such by a compiler.
 2020-03-25 23:43:20 -04:00
Lioncash f4b3fb947e CScanDisplay: Make constructor explicit 
Prevents error-prone implicit construction from occurring.
 2020-03-25 20:46:08 -04:00
Lioncash 3c17336fb0 CSaveWorld: Make constructor explicit 
Prevents error-prone implicit constructions from occurring.
 2020-03-25 20:42:21 -04:00
Lioncash 98b9556f3e CProjectileWeapon: Return std::nullopt instead of {} where applicable 
Prevents some implementations from zeroing out their internal buffer
unnecessarily (libstdc++ and libc++).
 2020-03-25 16:03:09 -04:00
Lioncash 6365f2ee1c CPowerBomb: Return std::nullopt in GetTouchBounds() 
Avoids unnecessary zeroing of the internal buffer of std::optional in
some implementations (libstdc++ and libc++).
 2020-03-25 15:56:59 -04:00
Lioncash cda5a48970 CRelayTracker: Add names to function prototypes 
Allows IDE introspections at call sites to function nicer.
 2020-03-25 15:53:49 -04:00
Lioncash c5c888daa6 CRippleManager: Rename Ripples() to GetRipples() 
Allows const overloading to work and prevents compilation errors from
occurring if the constness ever changes.
 2020-03-25 04:22:34 -04:00
Lioncash 4f9e53933e CPathFindArea: Amend bitset size 
The previous commit meant to contain this size.
 2020-03-25 04:15:55 -04:00
Lioncash d0292fdc5d CPathFindArea: Make use of std::bitmap with CPFBitSet 
Same behavior, but without the need to roll the operations ourselves.
 2020-03-25 04:12:55 -04:00
Lioncash 81dcc0604b CParticleElectric: Make use of std::array where applicable 
Prevents array to pointer decay.
 2020-03-25 03:58:37 -04:00
Lioncash c61bee13db CParticleElectric: Add parameters to function prototypes 
Makes the interface more self-documenting.
 2020-03-25 03:58:37 -04:00
Luke Street c08b5a4c98 CFlyingPirate: Fix Aqua Pirates 2020-03-25 03:48:10 -04:00
Luke Street da648b18d8 CSpankWeed: Fix collision manager null deref 2020-03-25 03:47:56 -04:00
Lioncash 90d61ae7ed CAutoMapper: Add names to function prototypes 2020-03-25 03:03:24 -04:00
Luke Street 7ee2a3b912
Merge pull request #254 from AxioDL/flyingpirate 
CFlyingPirate implementation
 2020-03-25 03:01:10 -04:00
Luke Street 815d83d843 CFlyingPirateRagDoll: Fix particles & length constraints 2020-03-25 02:57:57 -04:00
Lioncash 51c1ffecd6 CActorContraption: Add names to parameters in prototypes 
Makes it more self-documenting from the interface alone.
 2020-03-25 02:46:22 -04:00
Lioncash 20548ddeaa CCameraSpline: Make constructor explicit 
Same behavior, but prevents error-prone implicit constructions from
occurring.
 2020-03-25 02:41:07 -04:00
Lioncash f1fce0f631 CCameraSpline: Add names to prototypes 
More self-documenting from the interface alone.
 2020-03-25 02:40:03 -04:00
Lioncash 7bced5308b CCameraManager: Add names to parameters in prototypes 
More self documenting and allows IDE inspections to be better.
 2020-03-25 02:33:34 -04:00
Lioncash a862b792de CBoneTracking: Make use of parameter in SetActive() 
GM8E v0 makes use of the parameter and doesn't always set the value to
true.
 2020-03-25 02:12:56 -04:00
Luke Street 556f870dc8 Merge branch 'pr-277' 2020-03-25 02:09:09 -04:00
Luke Street f91536ebee Merge branch 'pr-276' 2020-03-25 02:09:05 -04:00
Luke Street 8314d5b6ef Merge branch 'pr-255' 2020-03-25 02:09:02 -04:00
Luke Street 3734a09ed3 CGuiWidget: Make GetIsFinishedLoading non-const 2020-03-25 02:01:47 -04:00
Lioncash 40fc3f9dd8 CModelBoo: Remove usages of const_cast 
Many functions are modifying internals of CBooModel and const-casting
is performed in order to work around functions being const when they
really shouldn't be.

This amends the function signatures in order to allow these functions to
exist without const_cast, making code much nicer to read.
 2020-03-25 02:01:46 -04:00
Lioncash e38d86fe59 CPhysicsActor: Amend constructor names for CPhysicsState 
These were previously undescriptive names despite the member variables
being fully named. We can amend the parameters here.
 2020-03-25 01:56:58 -04:00
Lioncash 81ae6bdda2 CPhysicsActor: Add names to parameters in prototypes 
Allows better introspection in IDEs and makes the interface itself more
self-documenting.
 2020-03-25 01:54:17 -04:00
Lioncash 22036859db CPASDatabase: Add names to parameters in prototypes 
Makes IDE introspection better.
 2020-03-25 01:43:27 -04:00
Lioncash fad980dc19 CBodyController: Make HasBodyInfo() accept a const reference 
This only queries state and doesn't actually modify it.
 2020-03-25 01:39:08 -04:00
Lioncash f875bdf024 CBodyController: Add names to parameters in interface 
Makes the interface more self-documenting and allows IDEs to perform
better introspection at call sites.
 2020-03-25 01:36:54 -04:00
Lioncash ab6c45c7a8 CWorld: Provide parameter names for prototypes 
More self-documenting from the interface alone and allows IDE
inspections at callsites to be better.
 2020-03-25 01:27:56 -04:00
Lioncash 985b85d9db CAudioGroupSet: Eliminate undefined behavior within LoadData() 
Eliminates aliasing violations.
 2020-03-25 01:14:27 -04:00