Lioncash
|
47555c725b
|
CAutoMapper: Eliminate usages of const_cast
Same behavior, but makes it explicit from the interface that
modifications are clearly going on from within the class.
|
2020-03-31 06:57:07 -04:00 |
Lioncash
|
12e42ba58a
|
CMapWorld: Make use of std::array where applicable
Same behavior, stronger typing.
|
2020-03-31 06:18:58 -04:00 |
Lioncash
|
92833b185a
|
CMapWorld: Move internally linked entities into an anonymous namespace
Same behavior, but prevents any potential ODR violations from occurring.
|
2020-03-31 06:16:07 -04:00 |
Lioncash
|
91f75a4c60
|
IAnimReader: Add missing override specifiers
|
2020-03-31 06:11:08 -04:00 |
Lioncash
|
2f0d774ed8
|
General: Make use of emplace_back where applicable
|
2020-03-31 05:33:10 -04:00 |
Lioncash
|
7b9018dbf0
|
CModelData: Initialize m_drawInstCount to zero
Allows for deterministic initial state to make debugging nicer.
|
2020-03-31 04:53:04 -04:00 |
Lioncash
|
1415265ef2
|
Runtime: Default destructors where applicable
Same behavior, but allows the destructors to be trivial, etc.
|
2020-03-31 04:50:26 -04:00 |
Phillip Stephens
|
d167293552
|
Merge pull request #291 from lioncash/name
IAnimReader: Make use of std::string_view where applicable
|
2020-03-31 01:20:20 -07:00 |
Phillip Stephens
|
7b0c043721
|
Merge pull request #288 from lioncash/explicit
Runtime: Add more usages of explicit
|
2020-03-31 01:19:40 -07:00 |
Lioncash
|
67f6666ea1
|
Runtime: Add more usages of explicit
Prevents error-prone implicit conversions where applicable.
This targets the regular RuntimeCommon target this time around.
|
2020-03-31 03:53:49 -04:00 |
Luke Street
|
b43d4eaddc
|
CElitePirate: Implement SpecialAttack, CShockWave
|
2020-03-31 03:29:00 -04:00 |
Lioncash
|
2c36b0bb83
|
IAnimReader: Make use of std::string_view where applicable
Same behavior, but allows interoperating with different string types in
a more straightforward manner.
|
2020-03-31 03:13:02 -04:00 |
Luke Street
|
13ce419554
|
Merge pull request #290 from lioncash/call
CAnimTreeDoubleChild: Correct call to VGetBoolPOIState() in VGetInt32POIState()
|
2020-03-31 02:53:13 -04:00 |
Lioncash
|
aa8d147350
|
CAnimTreeDoubleChild: Correct call to VGetBoolPOIState() in VGetInt32POIState()
Like the previous change, it's awfully suspect to be interpreting all
integer values as bools.
|
2020-03-31 02:43:48 -04:00 |
Luke Street
|
5161bc2988
|
Merge pull request #289 from lioncash/call
CAnimTreeAnimReaderContainer: Correct call to VGetBoolPOIState() within VGetInt32POIState()
|
2020-03-31 02:20:01 -04:00 |
Lioncash
|
03c0a8a5f6
|
CAnimTreeAnimReaderContainer: Correct call to VGetBoolPOIState() within VGetInt32POIState()
It seems quite suspect to read all integral values as bools.
|
2020-03-31 02:06:56 -04:00 |
Lioncash
|
260dbaca7d
|
CAnimData: Rename IceModel() to GetIceModel()
Allows const overloading to work and prevents compilation errors from
occuring if the const qualifier on an instance changes over refactoring.
|
2020-03-31 01:26:00 -04:00 |
Luke Street
|
f0927d937a
|
CGrenadeLauncher: Remove redundant CColor
|
2020-03-30 23:39:41 -04:00 |
Luke Street
|
782a13c0a4
|
CGrenadeLauncher: Fix CModelFlags assignment
|
2020-03-30 23:31:46 -04:00 |
Luke Street
|
2e3d1c980b
|
CElitePirate: Implement AttractProjectiles; fix CGameProjectile material list
|
2020-03-30 23:10:51 -04:00 |
Luke Street
|
684bbd5903
|
CElitePirate: Bug fixes, make member variables private, cleanup
|
2020-03-30 20:40:38 -04:00 |
Luke Street
|
ed254b460e
|
Revert some clang-tidy changes
|
2020-03-30 19:42:11 -04:00 |
Luke Street
|
571050245d
|
Add .clang-tidy and apply fixes
|
2020-03-30 19:31:14 -04:00 |
Lioncash
|
3e4731bf7f
|
CWallCrawlerSwarm: Minor tidying changes
- Amends formatting according to clang-format.
- Makes use of const where applicable
- More consistent bracing
|
2020-03-30 19:05:48 -04:00 |
Lioncash
|
e5a0959ef0
|
CWallCrawlerSwarm: Make use of size_t where applicable
Avoids unnecessary upper register clearing.
|
2020-03-30 19:05:48 -04:00 |
Lioncash
|
e1273faa68
|
CWallCrawlerSwarm: Eliminate some sign conversion warnings
Same behavior, less warnings.
|
2020-03-30 19:05:48 -04:00 |
Luke Street
|
cc8603fbec
|
Merge pull request #286 from lioncash/const-cast
CIOWin: Make Draw() non-const
|
2020-03-30 18:40:40 -04:00 |
Jack Andersen
|
76fc829c6b
|
Merge branch 'new-particle-metaclass'
|
2020-03-30 11:38:01 -10:00 |
Lioncash
|
7ff3d29794
|
CWallCrawlerSwarm: Mark static const data as constexpr
Same behavior, but allows elision of initializers. While we're at it, we
can convert an array over to std::array.
|
2020-03-30 05:44:35 -04:00 |
Luke Street
|
bc1135f0cf
|
CBouncyGrenade: Use explicit SMoverData constructor
|
2020-03-30 03:14:33 -04:00 |
Luke Street
|
bc08792523
|
CBouncyGrenade implementation
|
2020-03-30 03:05:16 -04:00 |
Lioncash
|
312b8f219a
|
CWorld: Dehardcode magic number in CheckWorldComplete()
Same behavior, no magic number.
|
2020-03-30 00:58:03 -04:00 |
Lioncash
|
802ac13812
|
CWorld: Make use of std::array where applicable
|
2020-03-30 00:54:38 -04:00 |
Lioncash
|
79b1e26052
|
IGameArea: Amend formatting of EChain
Makes for nicer visual scanning.
|
2020-03-30 00:47:29 -04:00 |
Lioncash
|
6ae935924b
|
IRenderer/CBooRenderer: Add parameter names to function prototypes
Makes the interface more self-documenting and allows IDEs to perform
better parameter introspection
|
2020-03-30 00:34:38 -04:00 |
Lioncash
|
111f0c3d3a
|
IRenderer: Convert typedef to using alias
Same behavior, but nicer to read.
|
2020-03-30 00:18:38 -04:00 |
Luke Street
|
fbbd73db48
|
CGrenadeLauncher implementation
|
2020-03-29 23:45:55 -04:00 |
Lioncash
|
6dce70895c
|
CIOWin: Make Draw() non-const
Allows removing several const_cast usages within the codebase.
|
2020-03-29 21:56:49 -04:00 |
Lioncash
|
0d3bab4c14
|
CScanDisplay: Remove use of const_cast
The draw function is essentially not fully const in behavior, so we can
remove the const qualifiers where necessary.
|
2020-03-29 21:44:10 -04:00 |
Lioncash
|
2d8e94911a
|
CGuiTextSupport: Eliminate the use of const_cast
We can supply a const and non-const variant to eliminate the need to
const_cast here.
|
2020-03-29 21:37:11 -04:00 |
Lioncash
|
f3afcf7299
|
CGuiTextPane: Remove stray unnecessary const_cast in Draw()
Draw() isn't const qualified, so there's no need to cast away const
here.
|
2020-03-29 21:25:47 -04:00 |
Lioncash
|
1d725587e5
|
CSortedLists: Remove const_cast in all BuildNearList() implementations
Same behavior, but nicer to read.
|
2020-03-29 21:22:52 -04:00 |
Lioncash
|
0a366855bc
|
CSortedLists: Add names to all function prototypes
More self-documenting and allows parameter inspection in IDEs to
function nicer.
|
2020-03-29 21:18:18 -04:00 |
Lioncash
|
eecd03428d
|
CSortedLists: Remove use of const_cast in AddToLinkedList()
Same behavior, but nicer to read.
|
2020-03-29 21:17:59 -04:00 |
Lioncash
|
6d2ef0360f
|
CGameState: Resolve sign conversion warnings in PutTo()
Same behavior, but makes conversions explicit.
|
2020-03-29 21:03:24 -04:00 |
Lioncash
|
45ea19040d
|
CGameState: Make use of std::array where applicable
|
2020-03-29 20:58:31 -04:00 |
Lioncash
|
24fe7ec499
|
CGameState: Remove use of const_cast
Same behavior, but nicer to read.
|
2020-03-29 20:52:34 -04:00 |
Lioncash
|
603942daaf
|
CTextRenderBuffer: Remove use of const_cast in Render()
Makes for much less casting.
|
2020-03-29 20:27:04 -04:00 |
Phillip Stephens
|
387e6a5733
|
Merge pull request #285 from lioncash/text
Revert "Revert "CTextRenderBuffer: Forward declare structs where applicable"
|
2020-03-29 17:19:11 -07:00 |
Lioncash
|
04a42980ab
|
Revert "Revert "CTextRenderBuffer: Forward declare structs where applicable""
This reverts commit 16745f3a7b .
We can simply default the move constructor and move assignment operator
to make this work.
|
2020-03-29 20:09:16 -04:00 |