AxioDL
/
metaforce
mirror of https://github.com/AxioDL/metaforce.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,237 Commits 26 Branches 15 Tags 52 MiB
Commit Graph

192 Commits

Author SHA1 Message Date
Lioncash 258409bc7d CGrappleArm: Remove const_cast within RenderXRayModel() 
Same behavior, but without a cast.
 2020-03-16 19:53:04 -04:00
Lioncash 9063b16d36 CGrappleArm: Convert reinterpret_cast to static_cast in PointGenerator() 
It's permissible to use static_cast when converting from void* to
another type.
 2020-03-16 19:16:46 -04:00
Lioncash 0cbfc6d169 CGrappleArm: Move skDependencyNames into BuildSuitDependencyList() 
Same behavior, but narrows the visible scope of the array.
 2020-03-16 19:12:55 -04:00
Lioncash d0d6210ccd CGrappleArm: Resolve sign mismatch warnings in loops 2020-03-16 19:11:16 -04:00
Lioncash 097d4a4422 Runtime: Collapse emplace_back() calls where applicable 
Same behavior, but with less code.
 2020-03-13 17:14:44 -04:00
Phillip Stephens eb38d96d9a
Merge pull request #214 from lioncash/virtual 
CGunWeapon: Make destructor virtual
 2020-03-12 15:11:02 -07:00
Phillip Stephens 7601888e34
Merge pull request #212 from lioncash/power-color 
CPowerBomb: Make kFadeColor internally linked
 2020-03-12 15:10:40 -07:00
Phillip Stephens ce5ce35743
Merge pull request #210 from lioncash/bob 
CPlayerCameraBob: Minor cleanup
 2020-03-12 15:10:19 -07:00
Phillip Stephens 2a2b471671
Merge pull request #209 from lioncash/cast 
CPlayerGun: Minor cleanup
 2020-03-12 15:10:07 -07:00
Phillip Stephens ac46b898bc
Merge pull request #208 from lioncash/wave 
CWaveBuster: Implement GetTouchBounds()
 2020-03-12 15:09:57 -07:00
Phillip Stephens 196a545f9a
Merge pull request #207 from lioncash/get 
CElectricBeamProjectile: Remove unnecessary get() calls in PreRender()
 2020-03-12 15:09:47 -07:00
Lioncash 2c091ac124 CGunWeapon: Make destructor virtual 
This class is used as polymorphic type, so the destructor should be
marked as virtual to prevent any potential undefined behavior.

This also more closely matches the GM8E v0 binary itself.
 2020-03-12 17:20:45 -04:00
Lioncash ee952b9c99 CPowerBomb: Make kFadeColor internally linked 
Hides the name from external view entirely and allows the color instance
to be constexpr.
 2020-03-12 10:13:37 -04:00
Lioncash 179d19412b CPlayerCameraBob: Make static non-const member variables private 
Prevents accidental modification of the values from occurring in code
that makes use of them. Many of these constants aren't even used outside
of the class itself in the first place.
 2020-03-09 20:55:12 -04:00
Lioncash 73f11a6132 CPlayerGun: Make use of std::array where applicable 2020-03-09 16:33:10 -04:00
Lioncash 1838e43078 CPlayerGun: Relocate file-static variables and constants into a single anonymous namespace 
Keeps all file-static variables organized together.
 2020-03-09 16:15:55 -04:00
Lioncash 3abaccb238 CPlayerGun: Resolve trivial implicit sign conversion warnings 2020-03-09 16:04:13 -04:00
Lioncash 9e5dc627ea CWaveBuster: Implement GetTouchBounds() 
Implements GetTouchBounds() according to the implementation within the
GM8E v0 binary.

Fills out the implementation of CWaveBuster a little bit.
 2020-03-09 14:51:04 -04:00
Lioncash 06dfc3406e CElectricBeamProjectile: Remove unnecessary get() calls in PreRender() 
Same behavior, less code.
 2020-03-09 13:55:26 -04:00
Luke Street 830db8772d Merge remote-tracking branch 'origin/master' into chozoghosts 2020-03-09 10:12:40 -04:00
Phillip Stephens 3011a839eb
Merge pull request #194 from lioncash/init 
CProjectileInfo: Initialize result variable to false within PredictInterceptPos
 2020-03-08 18:02:41 -07:00
Phillip Stephens f06c26e7d6
Fix infinite loop in CObjectList, and add an assert to detect invalid assignments 2020-03-07 09:14:07 -08:00
Lioncash 27fb2008dc CProjectileInfo: Initialize result variable to false within PredictInterceptPos() 
GM8E v0 sets this to false before performing any further calculations.
This also prevents accidental uninitialized usages from occurring if
this is ever changed in the future.

While we're in the same area we can make bracing consistent.
 2020-03-06 21:57:39 -05:00
Phillip Stephens 1cccaac115
Final CChozoGhost imps 2020-03-06 07:16:55 -08:00
Lioncash 88cb5acdca CFlameThrower: Amend virtual interface discrepancies 
GM8E v0 overrides Render(), GetTouchBounds() and Touch() and does
nothing within them. This updates the interface to match it.
 2020-03-04 06:52:50 -05:00
Lioncash f4fc17bee0 CScriptGunTurret: Move static const data into the cpp file 
Makes the data fully internally linked and also allows making said data
constexpr.
 2020-03-03 03:05:02 -05:00
Luke S 08604d770a
Merge pull request #163 from lioncash/data 
ITweakGunRes: Minor cleanup
 2020-02-25 22:32:25 -05:00
Lioncash e80d9c7192 ITweakGunRes: Make use of std::array where applicable 
Deduplicates a few array sizes and makes the member variables more
strongly typed.
 2020-02-25 15:50:37 -05:00
Lioncash 450bcd019e CAuxWeapon: Replace always false condition with false in Fire() 
Given we already check if chargeState is Normal previously, there's no
way that this can also be Charged at the same time.
 2020-02-25 04:36:10 -05:00
Lioncash 3d5ed90d1a CWeaponMode: Make constexpr capable 
Given this is such a simple type, this can be made usable with
constexpr. This allows the type to be usable at file-scope without
potentially incurring a runtime constructor.
 2020-01-23 23:12:18 -05:00
Lioncash 221cc5c6b8 RuntimeCommonB: Normalize cpp file includes 
Like the prior changes normalizing the inclusions within headers, this
tackles the cpp files of the RuntimeCommonB target, making these source
files consistent with their headers.
 2019-12-22 18:12:04 -05:00
Phillip Stephens 34e78a2dd0
Move CParticleGlobals from the executable and onto the heap, minor fixes, update wiki link 2019-12-03 00:47:05 -08:00
Phillip Stephens 697a100bca
Implement CScriptSpecialFunction::ThinkAreaDamage, and more CThardus 2019-11-24 07:32:45 -08:00
Phillip Stephens a1c7692d36
More CRidley imps 2019-11-12 12:25:21 -08:00
Phillip Stephens 3b101267f8
Merge pull request #88 from lioncash/radar 
Graphics/Shaders: Minor changes
 2019-11-10 08:03:42 -08:00
Lioncash 902f4fb5c5 Graphics/Shaders: Use forward declarations where applicable 
Now, with all of the headers normalized, we can safely convert some
headers into forward declarations without needing to worry about
potentially breaking code in other headers or source files.
 2019-11-09 20:22:09 -05:00
Lioncash 26a9ceab60 CGunWeapon: Eliminate const_cast usages in DrawMuzzleFx() 
We can just make the temporary variable non-const to eliminate the need
for const_casts.
 2019-10-19 01:11:19 -04:00
Lioncash 271ee6d8c3 CGunWeapon: Make use of algorithms where applicable 
We can leverage these to also eliminate some hardcoded sizes.
 2019-10-19 01:11:05 -04:00
Lioncash c228baf5f7 CGunWeapon: Make use of std::array where applicable 
Makes the arrays strongly typed and also allows us to dehardcode some
loop boundary constants.
 2019-10-19 01:07:01 -04:00
Lioncash c36e6a85b9 CGunWeapon: Organize cpp includes 
Makes the source file consistent with the header.
 2019-10-19 00:03:38 -04:00
Lioncash 36d04456dd General: Normalize RuntimeCommonB include paths 
Finishes the normalizing of all of includes within the RuntimeCommonB target's headers.
 2019-09-23 17:22:37 -04:00
Lioncash 06789d1860 General: Normalize several headers' include paths 
Normalizes the include paths and makes them consistent. Also adds any
missing includes relevant to the interface.
 2019-09-22 20:36:33 -04:00
Lioncash 8dcffbb67f CBurstFire: Use std::array where applicable 
Makes the array type strongly typed and prevents implicit array to
pointer decay.
 2019-09-22 09:48:07 -04:00
Lioncash adf9610138 CBurstFire: Tidy up includes 
Includes all necessary headers and uses a forward declaration where
applicable. Ensures inclusion changes in other headers don't break the compilation
of these headers and source files.
 2019-09-22 09:45:01 -04:00
Phillip Stephens 68e2fad74f
Fix TCastTo.hpp inclusions, add comment to warn against modifying include path 2019-09-21 06:07:13 -07:00
Lioncash f9079f0215 Runtime: Make use of std::make_unique where applicable 
Makes use of the C++14 make_unique allocation function to allocate class
instances where applicable instead of a reset with a new operator within
it.

This doesn't touch cases where buffers are allocated, given make_unique
would zero-initialize them.
 2019-09-12 04:09:48 -04:00
Lioncash afab3e0327 Runtime: Make const/non-const getters have the same name 
Makes for a more consistent interface, as getters won't have different
names to remember based off whether or not they're const qualified.
 2019-08-14 12:45:57 -04:00
Lioncash d3d629d405 RuntimeCommon: Use const on member functions where applicable 
Adds missing const qualifiers on class member functions that don't
modify instance state.
 2019-08-14 09:25:39 -04:00
Lioncash 09f917a9aa Runtime/Weapon/CGameProjectile: Fix misnamed virtual function 
This has a vaguely equivalent name to FluidFXThink (which has an
uppercase X). Given this function isn't explicitly called anywhere
directly, this is assumed to be a typo.
 2019-08-14 02:00:09 -04:00
Phillip Stephens ebdcfb6b51 Initial CMetroidBeta imps 2019-08-11 08:14:52 -07:00