Luke Street
de2996a941
CMetroid: Implement UpdateVolume, IsPlayerUnderwater, IsHunterAttacking
2020-05-22 03:34:48 -04:00
Luke Street
e0866ebdd4
CMetroid: More implementation & fixes
2020-05-21 12:50:17 -04:00
Luke Street
56d31254cd
CKnockBackController: Fix EKnockBackType
2020-05-21 11:32:48 -04:00
Lioncash
1158a171e7
CFontImageDef: Collapse IsLoaded() into a std::all_of call
...
Same behavior, less code. C++20 ranges will allow shortening this in the
future.
2020-05-21 01:40:31 -04:00
Lioncash
6063ec2540
CFontRenderState: Eliminate sign conversion in SetColor()
...
Same behavior, minus a sign conversion warning.
2020-05-21 01:33:39 -04:00
Luke Street
8f56219900
CChozoGhost: Add missing call to SetAnimationStateRange
2020-05-20 23:45:44 -04:00
Lioncash
32a4087f69
CScriptAiJumpPoint: Mark reference as const in AcceptScriptMsg
...
None of the data members of the referenced connections are modified.
2020-05-20 14:32:24 -04:00
Lioncash
5536417474
CScannableObjectInfo: Resolve unused parameter warning
...
This is unused, so we can just not specify it.
2020-05-20 14:03:20 -04:00
Lioncash
47cfaf17bd
CScriptActor: Remove unused printf code
...
Given it's not actively used or tied into the logging system, we can get
rid of this to prevent it from ever bitrotting.
2020-05-20 13:59:21 -04:00
Lioncash
1049a1a590
CScriptActorRotate: Make use of insert_or_assign in UpdateActors()
...
Same behavior, minus potentially avoidable default constructions that
immediately get overwritten.
2020-05-20 13:50:01 -04:00
Lioncash
677ed1ce9a
CScriptSpawnPoint: Resolve sign conversion warnings
...
operator[] takes a size_t, not an int.
2020-05-20 12:19:03 -04:00
Lioncash
38213bae99
CTeamAiMgr: Convert type into an enum class
...
Makes the sorting type explicit at the call site, rather than using
magic values.
2020-05-19 23:50:02 -04:00
Lioncash
96129264a3
CTeamAiMgr: Make use of TCastToConstPtr where applicable
...
Makes mutability explicit.
2020-05-19 23:47:05 -04:00
Lioncash
e1ddabaff8
CTeamAiMgr: Make use of std::any_of in ShouldUpdateRoles()
...
Same behavior, less code.
2020-05-19 23:41:58 -04:00
Lioncash
e73e704d20
CPlayerState: Make GetPickupTotal() a const member function
...
This doesn't modify internal member state.
2020-05-19 22:25:27 -04:00
Lioncash
9ce7c72a1c
CStaticInterference: Shorten some find_if calls
...
While we're at it, we can also const qualify a reference
2020-05-19 22:17:25 -04:00
Lioncash
463e9e9f60
CStaticInterference: Eliminate sign conversion warnings in constructor
...
We can just accept a size_t to prevent warnings from occurring.
2020-05-19 22:14:21 -04:00
Lioncash
f204d43333
rstl: Make iterator tag use std::contiguous_iterator_tag
...
Given we're iterating over a contiguous sequence with iterators like
these, we can use the contiguous_iterator_tag introduced within C++20 to
signify this.
2020-05-19 16:01:02 -04:00
Luke Street
eddaa24b1e
CDamageVulnerability: Fix WeaponHits
2020-05-17 12:25:04 -04:00
Luke Street
74d9bf4abc
CMetroid: More AI impl & fixes
2020-05-17 11:21:52 -04:00
Luke Street
3cafee2abd
CMetroid: Implement SuckEnergyFromTarget
2020-05-17 02:46:23 -04:00
Luke Street
6ad1aa79ab
Merge branch 'master' into metroid
2020-05-16 23:12:00 -04:00
Lioncash
871d3dc6ec
CPatterned: Make skDamageColor fully constexpr
2020-05-15 16:51:20 -04:00
Lioncash
7d3b43712d
CElitePirate: Make IsArmClawCollider internally linked
...
We can fully collapse this into a helper function and simplify the
parameters on it.
2020-05-14 22:21:55 -04:00
Lioncash
d9540c31ce
CElitePirate: Simplify IsArmClawCollider()
...
We can collapse this down into a std::any_of call.
2020-05-14 21:59:14 -04:00
Luke Street
c1f7358d96
CWideScreenFilter: Implement DrawFilter
2020-05-14 19:23:43 -04:00
Luke Street
72880f6286
CScriptDebris: Assign dieOnProjectile
2020-05-14 11:59:34 -04:00
Luke Street
ff62fddc89
CMetaree: Fix Halt delay
2020-05-14 11:27:23 -04:00
Phillip Stephens
47d767c441
CRidley: Various fixes, now you can kick the dragon's ass
2020-05-14 06:06:21 -07:00
Phillip Stephens
6e3370d90f
Merge pull request #320 from lioncash/reverse
...
rstl: Remove need for manual reverse iterators
2020-05-14 04:42:19 -07:00
Phillip Stephens
9c217c9115
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde
2020-05-13 06:20:52 -07:00
Phillip Stephens
a432a79cd4
Various Ridley fixes
2020-05-13 06:20:40 -07:00
Luke Street
514fc33fd8
CElitePirate: Add missing ShakeCamera function
2020-05-12 23:51:03 -04:00
Lioncash
f2d0939a15
CParticleSwooshShaders: Remove unused file-scope variable
...
Same behavior, one less runtime static constructor.
2020-05-12 20:50:35 -04:00
Lioncash
4e718a805f
CFluidPlaneShader: Replace explicit operator bool calls with the analogous named function
...
Same behavior, more informative to the reader about what is being
checked for.
2020-05-12 20:45:32 -04:00
Lioncash
942b972398
CTweaks: Collapse namespace specifiers into nested namespaces
...
Same behavior, less code.
2020-05-12 20:39:18 -04:00
Lioncash
a17ff08662
CPhazonHealingNodule: It helps to commit your editor changes before pushing
...
Intended to be part of 4b5074b298
2020-05-12 20:33:59 -04:00
Lioncash
4b5074b298
RuntimeCommon: Const qualify auto references where source is const
...
Marks references that would be deduced as const automatically with const
to be explicit to the reader.
2020-05-12 20:32:51 -04:00
Lioncash
8e77d6175c
CTextureBoo: Make use of std::array where applicable
...
Allows dehardcoding some array sizes.
2020-05-12 20:23:27 -04:00
Lioncash
e0a44bdf45
CTextureBoo: Prevent signed conversion warnings from occurring in Convert* helper functions
2020-05-12 20:03:58 -04:00
Lioncash
fee8d91dca
CTextureBoo: Make use of anonymous namespace
...
Makes some helper functions have internal linkage, silencing some
-Wmissing-declarations warnings, and also allows preventing ODR
violations from ever occurring with the RGBA8 and DXT1Block structs.
2020-05-12 20:01:58 -04:00
Lioncash
bfbb027117
CSlideShow: Collapse loop into std::all_of
...
Same behavior, less code. We can also make this function fully
internally linked, given it doesn't depend on instance state.
2020-05-12 19:53:19 -04:00
Lioncash
fd2f2e146c
CFluidPlaneCPU: Convert define into a typed constant
...
Same behavior, less preprocessor.
2020-05-12 17:00:00 -04:00
Lioncash
75494a501a
CFluidPlaneCPU: Early exit in CTurbulence constructor
...
Allows unindenting code.
2020-05-12 16:58:30 -04:00
Lioncash
dc32bee499
CFluidPlaneCPU: Eliminate sign conversions in CTurbulence constructor
2020-05-12 16:57:42 -04:00
Lioncash
c60290819e
CMorphBall: Collapse common code within ApplyGravity()
...
All that differs between the conditionals is the gravity value used, so
we can collapse all of this down to simply conditionally retrieve that.
2020-05-11 18:42:39 -04:00
Lioncash
0af9b16b92
CMorphBall: Take torque by const reference in SpinToSpeed()
...
Same behavior, minus unnecessary copies and consistency with the rest of
the API.
2020-05-11 18:23:54 -04:00
Lioncash
37138fb584
CMorphBall: Convert TCastToPtr to TCastToConstPtr
...
Same behavior, but makes the read-only intent explicit.
2020-05-11 14:23:15 -04:00
Lioncash
a73a7b22e7
CMorphBall: Brace statements where applicable
...
Makes the code consistent and also makes mutability explicit in large
calculations.
2020-05-10 22:18:33 -04:00
Lioncash
e9ea73ec98
CRidley: Amend formatting of skFloats
...
Makes the formatting less wonky.
2020-05-10 19:47:28 -04:00