Luke Street
|
fcf7044bf2
|
Merge remote-tracking branch 'github/recovery'
|
2020-03-18 00:45:49 -04:00 |
Luke Street
|
6ddbd15cfc
|
Merge pull request #237 from lioncash/state
CStateManager: Casting-related cleanups
|
2020-03-16 20:19:31 -04:00 |
Luke Street
|
488614563e
|
Merge pull request #236 from lioncash/sign
CGrappleArm: Minor changes
|
2020-03-16 20:18:31 -04:00 |
Lioncash
|
179f0b5f08
|
CStateManager: Remove instances of const_cast where applicable
Eliminates trivial casts that don't require much modifications to other
existing interfaces.
|
2020-03-16 20:16:15 -04:00 |
Luke Street
|
87eeafe0b0
|
CSnakeWeedSwarm: Renaming & cleanup
|
2020-03-16 20:15:22 -04:00 |
Lioncash
|
58b112dbe6
|
CStateManager: Convert reinterpret_cast instances over to static_cast
Conversions from void* can be done with static_cast.
|
2020-03-16 20:05:41 -04:00 |
Lioncash
|
0ae2364b24
|
CStateManager: Remove unnecessary casts
|
2020-03-16 20:01:57 -04:00 |
Lioncash
|
258409bc7d
|
CGrappleArm: Remove const_cast within RenderXRayModel()
Same behavior, but without a cast.
|
2020-03-16 19:53:04 -04:00 |
Lioncash
|
9063b16d36
|
CGrappleArm: Convert reinterpret_cast to static_cast in PointGenerator()
It's permissible to use static_cast when converting from void* to
another type.
|
2020-03-16 19:16:46 -04:00 |
Lioncash
|
0cbfc6d169
|
CGrappleArm: Move skDependencyNames into BuildSuitDependencyList()
Same behavior, but narrows the visible scope of the array.
|
2020-03-16 19:12:55 -04:00 |
Lioncash
|
d0d6210ccd
|
CGrappleArm: Resolve sign mismatch warnings in loops
|
2020-03-16 19:11:16 -04:00 |
Luke Street
|
dc77fb0c41
|
Merge pull request #234 from lioncash/puddle
CPuddleSpore: Make static const class data internally linked
|
2020-03-16 19:11:04 -04:00 |
Lioncash
|
ff8e4c18a1
|
CPuffer: Make use of std::array where applicable
Allows direct size querying, which allows removing the use of direct
hardcoded array sizes.
|
2020-03-16 16:37:40 -04:00 |
Lioncash
|
2ae02eefb0
|
CPuddleSpore: Make static const class data internally linked
Makes the data an implementation detail and also allows for the
string_view array to be declared constexpr.
|
2020-03-16 16:26:19 -04:00 |
Luke Street
|
7039232a95
|
Merge pull request #233 from lioncash/pos
CPoseAsTransforms: Make use of std::array where applicable
|
2020-03-16 16:14:40 -04:00 |
Luke Street
|
4a64d92433
|
Merge pull request #232 from lioncash/blur2
CPhazonSuitFilter: Convert define into local variable
|
2020-03-16 16:14:25 -04:00 |
Luke Street
|
2f7e2dd85e
|
Merge pull request #231 from lioncash/blur
CPauseScreenBlur: Remove const_cast in Draw()
|
2020-03-16 16:14:03 -04:00 |
Luke Street
|
6ea64becb4
|
Merge pull request #230 from lioncash/pause2
CPauseScreenBase: Minor cleanup
|
2020-03-16 16:13:42 -04:00 |
Lioncash
|
f45e2362c5
|
CPoseAsTransforms: Make use of std::array where applicable
|
2020-03-16 16:08:25 -04:00 |
Lioncash
|
cc6d50a1aa
|
CPoseAsTransforms: Mark constructor as explicit
Prevents potentially error-prone implicit constructions.
|
2020-03-16 16:05:52 -04:00 |
Lioncash
|
b9be092635
|
CPauseScreenBlur: Remove const_cast in Draw()
Draw() clearly modifies the internals of the class in a non-caching
manner, so this member function should really not have a const qualifier
on it.
|
2020-03-16 16:00:12 -04:00 |
Lioncash
|
bb075d51ed
|
CPhazonSuitFilter: Convert define into local variable
Same behavior, but with a more localized scope.
|
2020-03-16 15:57:21 -04:00 |
Phillip Stephens
|
574fc9b840
|
CJellyZap fixes
|
2020-03-15 19:00:52 -07:00 |
Lioncash
|
1a7ad1a7f6
|
CPauseScreenBase: Make use of std::array in GetImagePaneName()
We can make use of std::array here and also make the array constexpr.
This can also be moved into the function in order to hide its scope.
|
2020-03-15 21:26:59 -04:00 |
Lioncash
|
6e921e3258
|
CPauseScreenBase: Mark colors as constexpr within UpdateSideTable()
Same behavior, but allows eliding construction at runtime.
|
2020-03-15 21:26:47 -04:00 |
Lioncash
|
a9082bc445
|
CCollisionActor: Mark gkDefaultCollisionActorMaterials as constexpr
While we're at it, change the g to s, since it's internally linked.
|
2020-03-15 20:04:15 -04:00 |
Luke Street
|
eeb09f512d
|
Merge pull request #220 from lioncash/array
CHud*: Make use of std::array where applicable
|
2020-03-15 19:56:33 -04:00 |
Luke Street
|
79f6dbac73
|
Merge pull request #228 from lioncash/time
CCharAnimTime: Make constructors constexpr where applicable
|
2020-03-15 19:46:39 -04:00 |
Luke Street
|
76f12c5c38
|
Merge pull request #227 from lioncash/pair
CAnimSourceReader: Minor cleanup
|
2020-03-15 19:46:21 -04:00 |
Luke Street
|
797c583ed7
|
Merge pull request #226 from lioncash/clamp
CAnimSource: Simplify ClampZeroToOne()
|
2020-03-15 19:45:37 -04:00 |
Luke Street
|
70c60ecf2f
|
Merge pull request #225 from lioncash/bool
CArchitectureQueue: Make operator bool explicit
|
2020-03-15 19:45:22 -04:00 |
Luke Street
|
04c226e645
|
Merge pull request #224 from lioncash/explicit2
CMemoryCardSys: Make CardResult's conversion operator explicit
|
2020-03-15 19:45:13 -04:00 |
Luke Street
|
5804032fb4
|
Merge pull request #223 from lioncash/ref
CGameHintInfo: Take CVParamTransfer parameter by const reference
|
2020-03-15 19:45:02 -04:00 |
Luke Street
|
4eaed95c11
|
Merge pull request #222 from lioncash/view
CGameOptions: Make use of std::string_view where applicable
|
2020-03-15 19:44:47 -04:00 |
Luke Street
|
e1d622d47b
|
Merge pull request #221 from lioncash/emplace
CFontImageDef: Make use of emplace_back where applicable
|
2020-03-15 19:44:23 -04:00 |
Lioncash
|
1926966d21
|
CCharAnimTime: Make constructors constexpr where applicable
These can be made constexpr to allow use at compile-time, given these
only hold an enum and a floating point value.
|
2020-03-15 19:41:54 -04:00 |
Lioncash
|
15db1b2647
|
CAnimSourceReader: Make use of std::find_if where applicable
|
2020-03-15 18:55:30 -04:00 |
Lioncash
|
9541ed1919
|
CAnimSourceReader: Make use of emplace() where applicable
Same behavior, but with less code.
|
2020-03-15 18:42:19 -04:00 |
Lioncash
|
7c1528688b
|
CAnimSource: Simplify ClampZeroToOne()
We can make use of std::clamp instead of std::min and std::max
|
2020-03-15 18:30:58 -04:00 |
Lioncash
|
ff92b72f91
|
CMemoryCardSys: Make CardResult's conversion operator explicit
Prevents implicit error-prone conversions to bool
|
2020-03-14 22:18:42 -04:00 |
Lioncash
|
e6812a7cd9
|
CArchitectureQueue: Make operator bool explicit
Prevents potentially error-prone implicit conversion contexts.
|
2020-03-14 21:42:38 -04:00 |
Lioncash
|
f5cc056a9e
|
CGameHintInfo: Take CVParamTransfer parameter by const reference
Avoids trivial unnecessary copies.
|
2020-03-14 21:28:46 -04:00 |
Lioncash
|
659b8a43d3
|
CGameOptions: Make use of std::string_view where applicable
Enforces the use of valid strings in the interface. Also reduces c_str()
noise a little bit.
|
2020-03-14 20:09:23 -04:00 |
Lioncash
|
e64dfe76b2
|
CFontImageDef: Make use of emplace_back where applicable
Same behavior, but constructs the instances directly within the
container.
|
2020-03-14 18:45:37 -04:00 |
Lioncash
|
e0392d69c4
|
CHudEnergyInterface: Make use of std::array where applicable
|
2020-03-14 17:59:39 -04:00 |
Lioncash
|
c4796ed090
|
CHudMissileInterface: Make use of std::array where applicable
|
2020-03-14 17:57:05 -04:00 |
Lioncash
|
9fafb24fb9
|
CHudVisorBeamMenu: Make use of std::array where applicable
|
2020-03-14 17:52:30 -04:00 |
Lioncash
|
07542ff335
|
CHudThreatInterface: Make use of std::array where applicable
Same behavior, but with stronger typing.
|
2020-03-14 17:38:57 -04:00 |
Phillip Stephens
|
f7fdbc07ba
|
Merge pull request #219 from lioncash/false
CPathCamera: Change 0 to false in CPathCamera constructor
|
2020-03-13 15:30:59 -07:00 |
Phillip Stephens
|
6567ae8d42
|
Merge pull request #218 from lioncash/emplace
Runtime: Collapse emplace_back() calls where applicable
|
2020-03-13 15:30:43 -07:00 |