04c18267bc
Roll ANGLE from ca3b7d35fef0 to 152616eedcfd (8 revisions)
...
ca3b7d35fe..152616eedccnorthrop@google.com Tests: Add Aztec Ruins High trace
2022-04-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1b159f6cdecb to d3cc7d7ac0c3 (1 revision)
2022-04-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3c01a5c3bc2f to 6f6eb80eab19 (52 revisions)
2022-04-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c32f123be7eb to 3c01a5c3bc2f (107 revisions)
2022-04-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f39b4372b8a8 to c32f123be7eb (777 revisions)
2022-04-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6d732e01d9ea to 345e2a278e69 (3 revisions)
2022-04-06 abdolrashidi@google.com Vulkan: Optimize resolve of multisample swapchains
2022-04-06 syoussefi@chromium.org Vulkan: Perf counters test for glInvalidateSubFramebuffer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: I84774e3740d4428b1a947f122cad58d2c9b14483
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85905
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-06 19:21:23 +00:00
720d6d2de3
Roll vulkan-deps from a7760fb18903 to 746dd371204b (17 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/a7760fb18903..746dd371204b
Changed dependencies:
* spirv-headers: 4995a2f272..9c3fd01c8a628eaec640..76f00ef6cb7f84b1c2fa..ae24c6e7910265f2e00b..fc0b3f063f196438804b..b06084972ahttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: If5dd27531eb44046ca717245ed30da385b5a6942
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85872
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-06 18:29:24 +00:00
a696d08c51
CommandBufferVk: Update an ASSERT with copy format compatibility.
...
Fixed: dawn:1354
Change-Id: Id5b8169113436debf7a8af71df9737d1e0d2dec5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85920
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-06 17:42:54 +00:00
380a262ad0
Roll SwiftShader from d3cc7d7ac0c3 to 9c16e141823e (3 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/d3cc7d7ac0c3..9c16e141823e
2022-04-06 capn@google.com Only build WSI support for XCB surfaces when xcb.h is found
2022-04-06 capn@google.com Use 'discard' to denote terminated or demoted invocations
2022-04-06 swiftshader.regress@gmail.com Regres: Update test lists @ d3cc7d7a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: I55111b565c74bc9f7a5ba159ca1c9ff362a1d10d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85904
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-06 17:19:43 +00:00
b2e4a961f6
Roll Tint from 12f2f9b1bc to a730eb738e (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/12f2f9b1bc9a..a730eb738e9f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: I971924a0d8a4b1972ea0e3edac11474c836839d4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85903
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-06 15:28:16 +00:00
8e6c4bb59a
Roll Tint from b7e560dea0 to 12f2f9b1bc (2 revisions)
...
https://dawn.googlesource.com/tint.git/+log/b7e560dea055..12f2f9b1bc9a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: Id570eeefcda9b9c1b16e448a1e4e4710740a9bc8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85901
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-06 06:25:34 +00:00
13d2eb2702
Roll ANGLE from 83d3a98cde77 to ca3b7d35fef0 (15 revisions)
...
83d3a98cde..ca3b7d35feyuxinhu@google.com Vulkan: Roll volk
2022-04-05 cnorthrop@google.com Skip car_chase on all Intel Windows platforms
2022-04-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7d100c556081 to 1b159f6cdecb (2 revisions)
2022-04-05 antonio.caggiano@collabora.com Vulkan: Wayland include directories
2022-04-05 cnorthrop@google.com Tests: Add GFXBench Car Chase trace
2022-04-05 syoussefi@chromium.org Vulkan: Don't invalidate resolve attachment except with MSRTT
2022-04-05 lubosz.sarnecki@collabora.com retrace_restricted_traces: Check for json file.
2022-04-05 yuxinhu@google.com Fix Max Atomic Counter Conformance Test Failure on Pixel6
2022-04-05 cnorthrop@google.com Tests: Add Scary Teacher 3D trace
2022-04-05 lubosz.sarnecki@collabora.com retrace_restricted_traces: Remove unused code.
2022-04-05 cnorthrop@google.com Capture/Replay: Use glFramebufferTexture2D for cubes
2022-04-05 romanl@google.com Set SKIPPED status on skipped tests, rely on it in Gold tests.
2022-04-05 jmadill@chromium.org Vulkan: Skip failing intel blend test.
2022-04-05 nicolascapens@google.com Remove swiftshader_spirv_tools_dir
2022-04-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a190ceed7293 to 7d100c556081 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: I4fe818d2fc4dbd322bb7dc2147a49e1efa20b22d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85900
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-06 05:26:13 +00:00
94978da1d0
Roll SwiftShader from 7d100c556081 to d3cc7d7ac0c3 (3 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/7d100c556081..d3cc7d7ac0c3
2022-04-05 capn@google.com Remove unsupported extension feature enums
2022-04-05 capn@google.com Update SPIR-V Tools to eed5c76a5
2022-04-05 swiftshader.regress@gmail.com Regres: Update test lists @ 7d100c55
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: Ic9c8aae0c5f6407d1bfcc1242f4cb042f8eb3327
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85902
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-06 03:46:23 +00:00
aae6bce1fb
Add regression test for crbug.com/1313172
...
This adds a test, and a toggle disable_resource_suballocation.
This enables testing the behavior discovered in the bug without
creating enormous resources.
Bug: chromium:1313172
Change-Id: I779aad50c051e5022a9c85ebfbf33c18173a748f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85861
Reviewed-by: Loko Kung <lokokung@google.com>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-04-06 01:21:43 +00:00
e8d5678b70
Fix use-after-free of committed resource heaps
...
Heaps were destroyed immediately instead of deferring destruction
until after all work using the buffer was complete. This is only
a problem on D3D12. Vulkan allocations already have deferred
deletion, and Metal allocations are managed by the driver.
Bug: chromium:1313172
Change-Id: I0ef43709949c9e86c40e766f7f2029b14c8a2e97
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85840
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-04-06 01:14:33 +00:00
8d9d132f7c
Revert "Enable Queue, Device labels to be set."
...
This reverts commit 0126761de8https://dawn-review.googlesource.com/c/dawn/+/85540
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Commit-Queue: Brandon Jones <bajones@chromium.org>
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: dawn:1323
Change-Id: I62e4b508d2c55fd89f2f4c5cbe5d04d22681aeef
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85700
Reviewed-by: Brandon Jones <bajones@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-04-05 22:09:43 +00:00
7bcf9d8fa3
Roll Tint from 91357329ff to b7e560dea0 (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/91357329ff18..b7e560dea055
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: Id10e41963eeea390da8e7eb98d6702c848d89c15
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85880
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-05 21:24:43 +00:00
24ae176d91
Fix commit build rule to use empty hash (and not throw error) if git is not available.
...
Bug: dawn:549
Change-Id: I75ab6eb0273ddcb2dc571d5c91d35422793fdffc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85745
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
2022-04-05 20:11:43 +00:00
29b72c87e9
Updated the syntax for WGSL structs in all tests.
...
Change-Id: Ia80b1bed84aa7d16421d432d5da861e55175b335
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85841
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Brandon Jones <bajones@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
2022-04-05 18:41:23 +00:00
40b4ece211
Add more information on renderBundle<->pass attachment state mismatch
...
Bug: dawn:563
Change-Id: I8f68f27bf0f4864018ec8c58eae6754671031db8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85761
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
2022-04-05 17:19:53 +00:00
3a279a84e7
tools: Remove error return value from query.Parse()
...
It was always nil
Bug: dawn:1342
Change-Id: I7bc623bba1cbc65e6b91dee7af9bc6b096174605
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85803
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-05 17:08:25 +00:00
7ee6bf3dda
Disable a flaky T2T copy test on Intel Windows D3D12
...
Bug: chromium:1312066
Change-Id: Ia31496cdf9178a860e44503d81eda5be10c3d4e3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85681
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-04-05 16:48:33 +00:00
91c25df838
dawn.node: Add TODOs for implementing unhandlederror.
...
Bug: dawn:1348
Change-Id: I3b3d10a1ff1828f602087f8b17610749c60b6e49
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85801
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-05 16:27:43 +00:00
4d68bcbd9d
dawn.node: Implement bundle encoder depth/stencilReadOnly
...
Bug: dawn:1325
Change-Id: Iffe8b316038d639d68fa57dfb448e7242fd1f087
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85802
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-05 16:25:23 +00:00
c2bcdd6ec1
Roll SwiftShader from 0b2a76847b1f to 7d100c556081 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/0b2a76847b1f..7d100c556081
2022-04-05 sugoi@google.com Added missing feature structure for VK_KHR_maintenance4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: Idbd9b8c398b601982e1f660240de0c0751746803
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85781
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-05 14:20:23 +00:00
bb6997214d
dawn.node: Update for attachment "value" renames.
...
This silences some deprecations warnings.
Bug: dawn:1123
Change-Id: Ic6c12c6ad7606a85be8a17177b55a53f61d1136d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85760
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-05 12:50:13 +00:00
9b5ee7a526
Roll ANGLE from 74eac5e5a506 to 83d3a98cde77 (1 revision)
...
74eac5e5a5..83d3a98cderomanl@google.com Remove commented out mSkipTest.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: I368983e22d5d32a962e95d3ca3ac94e004f8fe19
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85780
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-05 12:23:03 +00:00
664cb1535b
Roll SwiftShader from a190ceed7293 to 0b2a76847b1f (8 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/a190ceed7293..0b2a76847b1f
2022-04-04 capn@google.com Validate SPIR-V instruction word array accesses
2022-04-04 dvet@google.com Add documentation for the configuration file mechanism
2022-04-04 capn@google.com Support VK_IMAGE_CREATE_EXTENDED_USAGE_BIT
2022-04-04 rebecca.chang@starfivetech.com Reactor: riscv64 is not supported in subzero
2022-04-04 rebecca.chang@starfivetech.com llvm-10.0: add configs/common and configs/linux for riscv64
2022-04-04 rebecca.chang@starfivetech.com llvm-10.0: update script to include riscv64 target
2022-04-04 rebecca.chang@starfivetech.com marl: add new source file for riscv64
2022-04-04 sugoi@google.com Add missing imageView compatible formats for YCbCr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: Ic2c62f57ba4d7bf57c9a36a072732c56b74df28a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85721
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-05 00:53:32 +00:00
0f5e4fe064
Roll ANGLE from 4b232a9a8261 to 74eac5e5a506 (6 revisions)
...
4b232a9a82..74eac5e5a5angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from fbc38865227d to 6f8a7182bd26 (14 revisions)
2022-04-04 romanl@google.com Use GTEST_SKIP to set gTest status of skipped tests to SKIPPED.
2022-04-04 jmadill@chromium.org Revert "Vulkan: Fix texture-after-framebuffer sync issues"
2022-04-04 penghuang@chromium.org Use provided format as intended format for EGLImage from VkImage
2022-04-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 649d6e46aeae to a190ceed7293 (1 revision)
2022-04-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 804d5a91d49d to f39b4372b8a8 (124 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: I47ace216dd60f3ef60348e91057c80658a34becf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85720
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-04 22:51:42 +00:00
bb0793fda2
Roll vulkan-deps from 73ae3e821932 to a7760fb18903 (5 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/73ae3e821932..a7760fb18903
Changed dependencies:
* spirv-tools: b0ce31fd2d..eed5c76a57c48c34f297..196438804bhttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: I2f8de59da623994a9f48b14780b5160378acb368
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85682
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-04 22:30:12 +00:00
8191f846cc
Remove swiftshader_spirv_tools_dir
...
SwiftShader now uses an independent build of SPIRV-Tools dependencies,
like in other environments.
Bug: b/158002593
Change-Id: I2149b99fc4b4f615c77c589ae9e5eb880f37feb6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85660
Auto-Submit: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2022-04-04 21:00:52 +00:00
e8498e7f04
Validate texture view format is supported
...
Fixed: chromium:1312780
Change-Id: I29f13a2df3ef1db6961a5760a6c1bb05ab3fa89b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85680
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
2022-04-04 20:28:37 +00:00
2787a4c64c
Rely on Tint to validate shader IO and bindings have decorations.
...
This removes a little bit of noise from the reflection of shader
metadata in Dawn. Tests are added to make sure that Tint does the
correct validation (it does).
Bug: None
Change-Id: I334e7c23b723cf5b5985c9914cc9f8d79a7c0568
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85502
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-04 18:57:52 +00:00
2f2977b728
dawn.node: Handle \0 in entryPoint names.
...
Bug: chromium:1215024
Change-Id: I88fd8b513fbda9b6c55575616afaa0c65882fc1a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85505
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-04 16:21:32 +00:00
a2f7d02c5e
Validate ShaderModule limits at pipeline creation time.
...
A list of errors, `infringingLimits`, is added to EntryPointMetadata.
During shader reflection, instead of directly bubbling limit errors up,
they are stored in this list and check only later during pipeline
creation.
Several ShaderModule tests are reworked to create a pipeline to check
for the validation of these limits. For the IO variable limits the tests
needed to be reworked to check for strings in the error messages because
since IO structs have to match between VS and FS, if one failed the
other failed too. (so it's no possible to target the validation of one
of these in particular)
Bug: dawn:986
Change-Id: I689e16454488d4a3c746ece53828555ed72ed561
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85501
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-04 16:11:42 +00:00
8033af0947
dawn.node: Implement the [Clamp] and [EnforceRange] WebIDL attributes.
...
These are implemented by wrapping the integer types in transparent
ClampedInteger<> and EnforceRangeInteger<> structures.
Some parts of the core needed to be updated after this, either to
disambiguate conversions, or because of bugs (u32 vs u64).
To make the CTS tests checking for this pass, the errors returned when
conversion FromJS failed needed to be updated to TypeError and not just
the generic Napi::Error.
Bug: dawn:1123
Change-Id: Ife1d0baa7687e43d735a1814ec41883c49ae74a6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85640
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-04 14:46:12 +00:00
e56b5f1097
dawn.node: Check for OOB in setBindGroup's typed array variant.
...
Bug: dawn:1123
Change-Id: I9ded6c76d50183ff14158e573b2c1a36a1becb3a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85641
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-04-04 12:22:52 +00:00
2d2ddc3f06
Roll SwiftShader from afcbbd0ad3b5 to a190ceed7293 (2 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/afcbbd0ad3b5..a190ceed7293
2022-04-04 capn@google.com Correct border clamp and depth comparison order
2022-04-01 swiftshader.regress@gmail.com Regres: Update test lists @ afcbbd0a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I27478bef7f8c07d0a9311cea5cfaed7e21f68aea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85600
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-04 09:28:31 +00:00
069fc14269
Roll ANGLE from 57a081c76f15 to 4b232a9a8261 (14 revisions)
...
57a081c76f..4b232a9a82angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 384f873e0970 to 804d5a91d49d (4365 revisions)
2022-04-03 ynovikov@chromium.org Skip end2end tests timing out on TSAN and ASAN
2022-04-02 syoussefi@chromium.org Vulkan: Fix texture-after-framebuffer sync issues
2022-04-02 syoussefi@chromium.org Skip failing tests on Pixel 6
2022-04-02 jmadill@chromium.org Vulkan: Lift SwS suppressions.
2022-04-02 abdolrashidi@google.com Remove the TODOs regarding multisample buffer age
2022-04-02 abdolrashidi@google.com Vulkan: Add multisample buffer age tests
2022-04-01 cclao@google.com Vulkan: Move memory allocation initialization code into function
2022-04-01 syoussefi@chromium.org Vulkan: Fix no location decoration vs framebuffer fetch
2022-04-01 cnorthrop@google.com Android: Track peak GPU memory in restricted_trace_perf
2022-04-01 jmadill@chromium.org infra: Use logarithmic batching in LUCI config.
2022-04-01 cnorthrop@google.com Compiler: Allow deferred array sizing in geometry shaders
2022-04-01 jmadill@chromium.org Cache outer array offset in linked uniforms.
2022-04-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bc5bec05c369 to 649d6e46aeae (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I267683771e779fa33e5466ee1682e6d8c3da4fe5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85601
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-04 09:22:21 +00:00
e6359d6058
dawn.node: Implement writeBuffer up to spec.
...
Bug: dawn:1132
Change-Id: I5b088283c85305f8c8b662478a5a46169a0217fa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85503
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-04 09:09:51 +00:00
7b6609f19b
Roll vulkan-deps from f8cb281b77d2 to 73ae3e821932 (4 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/f8cb281b77d2..73ae3e821932
Changed dependencies:
* vulkan-tools: e494de740e..0265f2e00b4ed67b11da..c48c34f297https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I566864404d5e17b11740ecb3cb29bb2c9caf9cec
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85620
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-04 08:28:52 +00:00
0126761de8
Enable Queue, Device labels to be set.
...
Queue labels can be set by the defaultQueue.label member of the device
descriptor or the setQueue method.
Device labels can be set label member of the device
descriptor or the setQueue method.
D3D12 and VK backend label support included.
Change-Id: Id12dd6e1fc8f1519c55e4efb35e1ead67c085e46
Bug: dawn:1323
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85540
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
2022-04-02 04:45:41 +00:00
c96ef43684
Updates remainder of references to old vulkan headers and removes them.
...
Change-Id: I7b0563a9bd3a98c08b81569be04a9c45dbb61f0d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85420
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
2022-04-02 03:02:40 +00:00
2a87c84c56
Add end2end tests to expose buffer size error on D3D12
...
When we do B2T or T2B copy from/to a buffer with paddings,
D3D12 may wrongly calculate the required buffer size.
For example, if copySize = {1, 1, 2}, offset = 0, bytesPerRow =
256, and rowsPerImage = 2 (there is 1-row padding for every image),
and we are copying a non-compressed format like rgba8unorm,
the required minimum buffer size should be:
offset + bytesPerRow * rowsPerImage * (copySize.depthOrArrayLayers - 1)
+ bytesPerRow * (copySize.height - 1) + bytesPerBlock * copySize.width.
It is 0 + 256 * 2 * (2 - 1) + 256 * (1 - 1) + 4 * 1 = 516.
The required minimum buffer on D3D12 (including WARP) size is:
offset + bytesPerRow * rowsPerImage * (copySize.depthOrArrayLayers - 1)
+ bytesPerRow * (rowsPerImage - 1) + bytesPerBlock * copySize.width.
Or offset + bytesPerRow * rowsPerImage * copySize.depthOrArrayLayers
+ bytesPerBlock * copySize.width - bytesPerRow.
It is 0 + 256 * 2 * (2 - 1) + 256 * (2 - 1) + 4 * 1 = 772.
It looks like D3D12 requires unnecessary buffer storage for
rowsPerImagePadding in the last image. It does respect
bytesPerRowPadding in the last row and doesn't require storage for
that part, though.
You can verify the buffer size requirement on D3D12 backend with the
new tests via --enable-backend-validation. The validation layer
says that D3D12 requires 772 bytes but we only provide a 516-bytes
buffer, and leads to E_INVALIDARG (Error code 0x80070057) when run
mD3d12CommandList->Close() in CommandRecordingContext::ExecuteCommandList
and causes device lost.
Bug: dawn:1278, dawn:1288, dawn:1289
Change-Id: Icfb792dec60ff7444cb20b3c283709cdb165f80a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85341
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Yunchao He <yunchao.he@intel.com>
2022-04-02 00:18:00 +00:00
42e76ba82a
TextureView defaults and validation updates
...
Spec PR: https://github.com/gpuweb/gpuweb/pull/2687
Fixed: dawn:682
Bug: dawn:1276
Change-Id: Ifa8f94fa4c1a27fb40d0ccfb9f032ca4a28ed24e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/84520
Reviewed-by: Loko Kung <lokokung@google.com>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-04-01 23:04:50 +00:00
595e20085d
Separate entry point reflection in its own function.
...
This allows adding as an error context the name of the entry point, and
dedents the code a little bit.
Bug: dawn:563
Change-Id: I1ea9760fc1aca506826ca7ef5a65d40f8370136d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85500
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
2022-04-01 22:04:30 +00:00
705b6e3d08
Roll vulkan-deps from 6d732e01d9ea to f8cb281b77d2 (6 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/6d732e01d9ea..f8cb281b77d2
Changed dependencies:
* spirv-tools: bd325d2984..b0ce31fd2d0c5928795a..628eaec640f8c97eea2f..7f84b1c2fafbc48cff34..4ed67b11dahttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: If45a7c42465be480fd089c69b7b72aa8f7fa10af
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85541
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-01 19:22:20 +00:00
d1cdb61aa1
dawn.node: make popErrorScope reject on validation errors.
...
The semantic of popErrorScope was changed from raising an exception on
validation errors to instead reject the promise.
Bug: dawn:1123
Bug: dawn:1324
Change-Id: I34322d8293e112eb2d1bfea784e2b2d6be33b604
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85506
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-04-01 18:18:22 +00:00
d78ca49bdb
Roll ANGLE from d2a7db9d0804 to 57a081c76f15 (3 revisions)
...
d2a7db9d08..57a081c76fangle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e37ba68c0fde to 6d732e01d9ea (4 revisions)
2022-04-01 m.maiya@samsung.com Vulkan: Handle border color for stencil component
2022-03-31 cclao@google.com Vulkan: Create buffer for vertex array if robust enabled
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I48ee8ba87e6b8cf867ef75ebba2ce767b5f53af0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85444
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-01 17:53:16 +00:00
359b82da43
dawn.node: Make run-cts disable disallow_unsafe_apis
...
Bug: dawn:1123
Change-Id: I2696dedf8249f5cfd8fe0138b7ee43e567a4ddf5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85504
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-01 17:14:56 +00:00
75cc17f2d1
tools: Add src/cts/query
...
Provides a type to represent the CTS query strings.
100% test coverage.
Bug: dawn:1342
Change-Id: I3769b094ba64221a7b79dd38f76daf0125ee9e28
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85221
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-04-01 16:31:15 +00:00
9c53d8a02c
Roll Tint from 79db32aff2 to 91357329ff (2 revisions)
...
https://dawn.googlesource.com/tint.git/+log/79db32aff201..91357329ff18
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I69289cf1ab51ba09af39863768622462264e23b0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85445
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-01 16:26:36 +00:00
60e5ab281c
dawn.node: Do not expose non-WebGPU interfaces at global scope.
...
This remove some interfaces like OffscreenCanvas from the global scope
because dawn.node is not capable to usefully create them. The CTS
uses the absence of these interfaces to skip tests when needed.
Bug: dawn:1123
Change-Id: I6d57600ba6b41be58c541d1f8091e7e88781f04f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85364
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-01 13:11:58 +00:00
63fe6e11cd
dawn.node: Make GPUDevice.lost [SameObject]
...
Previously a new promise was created and new promises were never
resolved on creation, only on loss/destruction of the device. This made
the following code wait forever:
device.destroy();
await device.lost();
Bug: dawn:1123
Change-Id: I1e31cf9ccd466672eed4cad464c38cb9f8b3d724
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85362
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-01 12:22:36 +00:00
ecc3fe6f0f
dawn_node: Implement the [SameObject] IDL attribute
...
This is done by moving the set up of these attributes to the place where
the wrapper objects are created, by doing:
jsObject.DefineProperty("foo", impl->getOnceFoo());
Three alternatives that weren't chosen are:
- Caching a weak reference to the member's Napi::Value on the wrapper
struct, and recreate it only as needed. This is good because it
doesn't risk using the value after it is GCed, but it can result in
multiple calls to the getters, which could be unexpected (for example
for GPUDevice.lost in a follow-up CL).
- Caching a persistent reference to the member's Napi::Value on the
wrapper struct. This calls the getter once and doesn't risk using the
value after it is GCed. However if Javascript does something like
`myGPUDevice.limits.device = myGPUDevice`, a cycle is created that
the GC doesn't have visibility into, and that can't be collected.
(the origin of the edge of the reference graph that persistent
references make is unknown to the GC).
- Caching the member on a hidden variable of the JS object. I didn't
find a way to do this. The closest would have been to do
jsObject[Symbol(...)] = cachedValue but even symbols can be retrieved
with Object.getOwnPropertySymbols.
Bug: dawn:1123
Fixed: dawn:1144
Change-Id: I1bc82dd9d10be95bf2bdca73bdfb843bc556d2df
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85361
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-04-01 11:39:26 +00:00
Dawn Autoroller
Corentin Wallez
Austin Eng
Ryan Harrison
Loko Kung
Brandon Jones
Ben Clayton
Yunchao He
Nicolas Capens