Lioncash
|
b439e4bba1
|
CLight: Make use of in-class initializers where applicable
Same behavior, less code.
|
2020-06-14 19:03:32 -04:00 |
Lioncash
|
f942ad6551
|
CGameTemplate: Mark getter functions as const
These don't modify internal class state, so we can mark them as const.
|
2020-06-14 18:58:05 -04:00 |
Lioncash
|
15708b8624
|
CGameTemplate: Collapse loops into ranged for where applicable
|
2020-06-14 18:49:37 -04:00 |
Lioncash
|
d9bb255518
|
CGameTemplate: Use in-class initializers where applicable
Same behavior, less code.
|
2020-06-14 18:35:10 -04:00 |
Lioncash
|
332be356de
|
CIndexBuffer: Make use of size_t where applicable
Provides a nicer interface for operating with standard types, etc.
|
2020-06-14 18:29:39 -04:00 |
Lioncash
|
d4564434c3
|
FShowFlags: Remove use of cpp file
Now that these constructs are constexpr capable, we can make use of
constexpr here to contain it fully within the header.
|
2020-06-14 17:12:37 -04:00 |
Lioncash
|
b2db6a21fa
|
CFlagsProperty: Mark HasValidValue() as const
This doesn't modify internal state.
|
2020-06-14 17:07:47 -04:00 |
Lioncash
|
d5a33b631a
|
CFlagsProperty: Make use of a ranged for loop
|
2020-06-14 17:06:46 -04:00 |
Lioncash
|
84184da66d
|
CFont: Prevent Wmaybe-uninitialized warning
|
2020-06-14 17:04:35 -04:00 |
Lioncash
|
4861f118fb
|
CFont: Make PtsToFloat() internally linked
This is only ever used within the cpp file
|
2020-06-14 17:04:35 -04:00 |
Lioncash
|
1c292f5e2d
|
CFont: Make use of std::array
Same behavior, stronger typing.
|
2020-06-14 17:04:32 -04:00 |
Lioncash
|
b6b7bcace1
|
CFont: In-class initialize members where applicable
Provides a consistent initial state.
|
2020-06-14 16:54:16 -04:00 |
Lioncash
|
01e68ec5d8
|
CFontLoader: Default constructor
|
2020-06-14 16:51:13 -04:00 |
Lioncash
|
e49315a645
|
CSkeleton: Make use of unique_ptr where applicable
Makes ownership semantics explicit.
|
2020-06-14 16:49:51 -04:00 |
Lioncash
|
4dcb539763
|
CSkeletonLoader: Make use of ranged for where applicable
Same behavior, less code.
|
2020-06-14 16:13:28 -04:00 |
Lioncash
|
6909c75d64
|
CTextureDecoder: Misc cleanup
Const correctness, unimplemented prototypes, reducing copies, etc.
|
2020-06-14 16:07:43 -04:00 |
Lioncash
|
68455c54e8
|
CTextureDecoder: Make utility functions internally linked
Same behavior, but keeps implementation details internal.
|
2020-06-14 15:41:32 -04:00 |
Lioncash
|
f0cd6ee99b
|
CStructProperty: Make use of ranged for
|
2020-06-12 17:25:06 -04:00 |
Lioncash
|
7b40eec19c
|
CScriptObject: Collapse for loops into ranged for loops
While we're at it, eliminate sign conversion warnings.
|
2020-06-12 17:12:37 -04:00 |
Lioncash
|
5c42bcc580
|
CLink: Resolve sign conversion warnings
|
2020-06-12 16:46:49 -04:00 |
Lioncash
|
38d245b460
|
CLink: Make constructor explicit
|
2020-06-12 16:45:33 -04:00 |
Lioncash
|
f5e9254c9a
|
CIndexBuffer: Make use of in-class initializers where applicable
|
2020-06-12 16:43:54 -04:00 |
Lioncash
|
721c4d8121
|
CIndexBuffer: Make constructor explicit
Prevents implicit constructions.
|
2020-06-12 16:41:47 -04:00 |
Lioncash
|
ece0aec27a
|
CGraphics: Make use of std::array
|
2020-06-12 16:36:34 -04:00 |
Lioncash
|
bf9233779a
|
CGraphics: Make skDefaultAmbientColor constexpr
Same behavior, no runtime initializer.
|
2020-06-12 16:19:59 -04:00 |
Lioncash
|
e8a20933de
|
CVirtualDirectory: Resolve -Wreorder warnings
|
2020-06-12 16:09:20 -04:00 |
Lioncash
|
1ae5462cd7
|
CGameProject: Make use of unique_ptr where applicable
Makes the ownership semantics explicit.
|
2020-06-12 16:07:04 -04:00 |
Lioncash
|
1bdcdb85de
|
CResourceStore: Use unique_ptr where applicable
Makes the ownership semantics explicit and prevents leaks from occurring
a little better.
|
2020-06-12 14:43:39 -04:00 |
Lioncash
|
137b2395c9
|
CResourceStore: Use in-class initializers where applicable
|
2020-06-12 14:11:57 -04:00 |
Lioncash
|
7da16efe9d
|
CDependencyTree: Make use of unique_ptr
Makes the ownership semantics explicit in the interface.
|
2020-06-12 14:09:08 -04:00 |
Lioncash
|
e2190793fd
|
CDependencyTree: Tidying up
- Convert for loops to ranged for loops.
- Collapse loop into an any_of.
|
2020-06-12 13:37:54 -04:00 |
Lioncash
|
7d4ce7e909
|
CDependencyGroupLoader: Default constructor
|
2020-06-12 13:26:39 -04:00 |
LC
|
10cbcd4024
|
Merge pull request #31 from lioncash/properties
Property: Make use of override where applicable
|
2020-06-12 13:17:05 -04:00 |
Lioncash
|
c020084587
|
CCollisionMaterial: Make use of std::array
Allows simplifying some size calculations.
|
2020-06-12 13:14:39 -04:00 |
Lioncash
|
a51604ca91
|
CCollisionMeshGroup: Make use of unique_ptr
|
2020-06-12 13:08:48 -04:00 |
Lioncash
|
48d8d361b6
|
CCollisionLoader: Collapse for loop into ranged for pt. 2
|
2020-06-12 12:57:18 -04:00 |
Lioncash
|
3b3b2cc80f
|
CCollisionLoader: Collapse for loop into ranged for
Also removes a delete left behind in an error case.
|
2020-06-12 12:52:28 -04:00 |
Lioncash
|
3449f60317
|
CCollisionLoader: Make use of unique_ptr more
Same behavior, but makes the allocation ownership explicit
|
2020-06-12 12:50:19 -04:00 |
Lioncash
|
d43f2dab31
|
CAudioGroupLoader: Default constructor
|
2020-06-12 12:44:27 -04:00 |
Lioncash
|
9e2a8bd693
|
CAnimationLoader: Make use of std::array
Prevents implicit array to pointer decay.
|
2020-06-12 12:43:09 -04:00 |
Lioncash
|
12ccb2fbd4
|
CGameArea: Simplify allocation handling
Eliminates manual new/delete and also makes the lifecycle of allocations
enforced within the interface.
|
2020-06-12 12:38:54 -04:00 |
Lioncash
|
674ae65e56
|
CAnimSetLoader: Collapse for loops into ranged for loops
|
2020-06-12 11:28:05 -04:00 |
Lioncash
|
9921ccfe25
|
IMetaTransition: Always initialize CMetaTransTrans members
Always provides a deterministic initial state.
|
2020-06-12 10:47:22 -04:00 |
Lioncash
|
eabc789910
|
CAnimSet: Simplify allocation code
We can make use of std::unique_ptr to prevent any potential memory leaks
from occurring and simplifying the destruction code.
|
2020-06-12 10:43:29 -04:00 |
Lioncash
|
4eb1027362
|
CAnimSet: Collapse loops into ranged for where applicable
|
2020-06-12 10:03:02 -04:00 |
Lioncash
|
2a5ab1ed32
|
CAnimEventLoader: Use unique_ptr more
Makes memory handling a little more robust.
|
2020-06-11 21:10:02 -04:00 |
Lioncash
|
ecbd3eb83d
|
CAnimEventLoader: Default destructor
Allows the constructor to be considered trivial.
|
2020-06-11 21:00:08 -04:00 |
Lioncash
|
114742fc37
|
CCamera: Resolve -Wreorder warnings
|
2020-06-11 20:58:59 -04:00 |
Lioncash
|
6f0c8669de
|
CCollisionLoader: Formatting
|
2020-06-11 20:53:11 -04:00 |
Lioncash
|
d0bd7eb292
|
CCollisionLoader: Make LoadAreaCollision() return a unique_ptr
Same behavior, less boilerplate
|
2020-06-11 20:46:39 -04:00 |
Lioncash
|
907f1270bd
|
CResourceFactory: Make use of unique_ptr
Makes the API more memory safe
|
2020-06-11 20:22:21 -04:00 |
Lioncash
|
ce315280c3
|
CResource: Make BuildDependencyTree() return a unique_ptr
Makes the functions more memory safe in terms of freeing memory in
exceptional paths .
|
2020-06-11 18:39:07 -04:00 |
Lioncash
|
eb8ca98a8a
|
CAnimEventData: Collapse for loop into a ranged for loop
|
2020-06-11 18:02:52 -04:00 |
Lioncash
|
044efcf59d
|
CAnimEventData: Remove unnecessary inline specifiers
|
2020-06-11 18:01:18 -04:00 |
Lioncash
|
aeea0f8052
|
CMaterialPass: Make use of std::array
|
2020-06-11 17:50:40 -04:00 |
Lioncash
|
7b81aa5268
|
CMaterialPass: Simplify initialization code
|
2020-06-11 17:41:54 -04:00 |
Lioncash
|
92811a9309
|
CShader: Simplify initialization
|
2020-06-11 17:34:52 -04:00 |
Lioncash
|
b8078e7419
|
CShaderGenerator: Fix compiler warning
MSVC desires the namespace version
|
2020-06-11 15:55:06 -04:00 |
Lioncash
|
012da6fb6d
|
General: Remove unnecessary inline specifiers and add overrides
|
2020-06-11 15:49:42 -04:00 |
Lioncash
|
2d76c5865a
|
CCharacterNode: Add missing override specifiers
|
2020-06-11 13:44:20 -04:00 |
Lioncash
|
060101c718
|
CCharacterNode: Remove unnecessary inline specifiers
Functions defined in class declarations are implicitly inline
|
2020-06-11 13:43:19 -04:00 |
Lioncash
|
100453b356
|
CCamera: Remove unnecessary inline specifiers
Functions defined within a class declaration are inline by default.
|
2020-06-11 13:41:33 -04:00 |
Lioncash
|
53b257fb8a
|
CBoneTransformData: Remove unnecessary inline keywords
Functions defined within the class declaration are inline by default.
|
2020-06-11 13:40:00 -04:00 |
Lioncash
|
9ec61de2ca
|
CAudioManager: Make LogSoundInfo() a const member function
This function doesn't modify internal state.
|
2020-06-11 13:38:00 -04:00 |
Lioncash
|
872c38b384
|
CAudioManager: Make GetSoundInfo() a const member function
This doesn't modify internal member state.
|
2020-06-11 13:35:38 -04:00 |
Lioncash
|
9692a064cd
|
CAudioManager: Make constructor explicit
Prevents potentially error-prone constructions from occurring
|
2020-06-11 13:34:17 -04:00 |
Lioncash
|
7f881b1b10
|
CAudioMacro: Make use of ranged for where applicable
Same behavior, less moving parts.
|
2020-06-11 13:32:29 -04:00 |
Lioncash
|
f9031283d0
|
CAudioMacro: Add missing override specifier
|
2020-06-11 13:31:40 -04:00 |
Lioncash
|
416608a76a
|
CAudioMacro: Remove unnecessary inline specifiers
Functions defined within a class declaration are already inline by
default.
|
2020-06-11 13:31:00 -04:00 |
Lioncash
|
edaafd4bcf
|
CAudioMacro: Make constructor explicit
Prevents implicit error-prone constructions from occurring.
|
2020-06-11 13:30:07 -04:00 |
Lioncash
|
e95cb1117a
|
CAudioLookupTable: Include used headers
|
2020-06-11 13:28:11 -04:00 |
Lioncash
|
1b4ebd5f7b
|
CAudioLookupTable: Make FindSoundDefineID() const
This doesn't mutate any contained state, so it can be const.
|
2020-06-11 13:26:32 -04:00 |
Lioncash
|
a82f9c197b
|
CAudioLookupTable: Make use of explicit constructors
Prevents implicit constructions
|
2020-06-11 13:25:19 -04:00 |
Lioncash
|
d223bac56a
|
CAudioGroup: Make use of in-class initializers
|
2020-06-11 13:23:50 -04:00 |
Lioncash
|
7ce0e14e29
|
CAssetNameMap: Eliminate file-scope string allocations
|
2020-06-11 13:21:33 -04:00 |
Lioncash
|
9925925b6f
|
TResPtr: Use in-class initializers where applicable
|
2020-06-11 13:14:33 -04:00 |
Lioncash
|
11f156352a
|
CAnimSetLoader: Default constructor
|
2020-06-11 13:11:38 -04:00 |
Lioncash
|
61a6151afe
|
externals: Update LibCommon
|
2020-06-11 11:10:04 -04:00 |
LC
|
b5ddc20771
|
Merge pull request #26 from lioncash/scene
CSceneNode: Minor cleanup
|
2020-06-11 10:53:51 -04:00 |
LC
|
1fb554fa4c
|
Merge pull request #24 from lioncash/cook
CAreaCooker: Minor cleanup
|
2020-06-11 10:53:17 -04:00 |
LC
|
8babcc13bb
|
Merge pull request #22 from lioncash/anim2
CAnimation: Minor clean up
|
2020-06-11 10:52:59 -04:00 |
LC
|
9c2b7e4c95
|
Merge pull request #23 from lioncash/iter
CResourceIterator: Cleanup and undefined behavior prevention
|
2020-06-11 10:52:41 -04:00 |
LC
|
d7b6ab81ea
|
Merge pull request #27 from lioncash/gen
CShaderGenerator: Make file-scope arrays non-allocating
|
2020-06-11 10:52:19 -04:00 |
LC
|
80ccc32e68
|
Merge pull request #29 from lioncash/viewport
CBasicViewport: Make member functions const where applicable
|
2020-06-11 10:51:53 -04:00 |
LC
|
919dcfd8d9
|
Merge pull request #28 from lioncash/table
CStringTable: Eliminate file-scope allocations
|
2020-06-11 10:51:34 -04:00 |
LC
|
4f289193bb
|
Merge pull request #32 from lioncash/str
CGameInfo: Make file-scope strings non-allocating
|
2020-06-11 10:51:20 -04:00 |
LC
|
156c92909e
|
Merge pull request #33 from lioncash/index
CIndexBuffer: Mark member functions as const where applicable
|
2020-06-11 10:50:52 -04:00 |
Lioncash
|
76ec0df8a2
|
externals: Update LibCommon
|
2020-06-11 10:49:37 -04:00 |
Lioncash
|
c929293789
|
CIndexBuffer: Mark member functions as const where applicable
These member functions don't alter internal state, so we can mark them
as const.
|
2020-06-10 19:33:50 -04:00 |
Lioncash
|
7da0cdb8a3
|
CGameInfo: Make file-scope strings non-allocating
Same behavior, minus any potential heap allocations and static
constructors.
|
2020-06-10 18:04:40 -04:00 |
Lioncash
|
96876b70e0
|
Property: Make use of override where applicable
Makes the API strongly enforced. This also fixes a bug in CBoolProperty,
where ValueAsString() had an incorrect signature (was missing a const).
|
2020-06-10 09:19:12 -04:00 |
Lioncash
|
01372f7049
|
CBasicViewport: Make member functions const where applicable
These don't modify member state. While we're at it, we can mark
functions as override where applicable.
|
2020-06-10 01:47:51 -04:00 |
Lioncash
|
583472f2f9
|
CStringTable: Eliminate file-scope allocations
Eliminates all runtime static initializers, reducing the heap usage of
the application lifetime just a little bit.
|
2020-06-10 01:06:46 -04:00 |
Lioncash
|
ef0030872a
|
CShaderGenerator: default constructor and destructor
|
2020-06-10 00:55:12 -04:00 |
Lioncash
|
e75c077bda
|
CShaderGenerator: Make file-scope arrays non-allocating
We can make these plain views to eliminate any potential static runtime
constructors.
|
2020-06-10 00:55:08 -04:00 |
Lioncash
|
c285207f24
|
CSceneNode: Collapse loops into ranged for loops
Where applicable, we can simplify some loops a little bit, migrating off
the slightly more verbose iterator means of traversing standard
containers.
|
2020-06-09 23:07:47 -04:00 |
Lioncash
|
3d4f2d60eb
|
CSceneNode: Make use of std::array
Same behavior, stronger typing.
|
2020-06-09 22:57:44 -04:00 |
Lioncash
|
7065005c30
|
CSceneNode: Make use of override
Same behavior, stronger enforcement of API.
|
2020-06-09 22:56:38 -04:00 |
Lioncash
|
d3315bf84f
|
CSceneNode: Make use of in-class initializers
Same behavior, less code.
|
2020-06-09 22:55:25 -04:00 |
Lioncash
|
03f1aba7e8
|
CAreaCooker: Collapse for loops into ranged for where applicable
Same behavior, less code.
|
2020-06-09 07:56:56 -04:00 |