AxioDL
/
metaforce
mirror of https://github.com/AxioDL/metaforce.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,459 Commits 26 Branches 15 Tags 52 MiB
Commit Graph

2173 Commits

Author SHA1 Message Date
Lioncash 260dbaca7d CAnimData: Rename IceModel() to GetIceModel() 
Allows const overloading to work and prevents compilation errors from
occuring if the const qualifier on an instance changes over refactoring.
 2020-03-31 01:26:00 -04:00
Lioncash 3e4731bf7f CWallCrawlerSwarm: Minor tidying changes 
- Amends formatting according to clang-format.
- Makes use of const where applicable
- More consistent bracing
 2020-03-30 19:05:48 -04:00
Lioncash e5a0959ef0 CWallCrawlerSwarm: Make use of size_t where applicable 
Avoids unnecessary upper register clearing.
 2020-03-30 19:05:48 -04:00
Lioncash e1273faa68 CWallCrawlerSwarm: Eliminate some sign conversion warnings 
Same behavior, less warnings.
 2020-03-30 19:05:48 -04:00
Luke Street cc8603fbec
Merge pull request #286 from lioncash/const-cast 
CIOWin: Make Draw() non-const
 2020-03-30 18:40:40 -04:00
Lioncash 7ff3d29794 CWallCrawlerSwarm: Mark static const data as constexpr 
Same behavior, but allows elision of initializers. While we're at it, we
can convert an array over to std::array.
 2020-03-30 05:44:35 -04:00
Lioncash 312b8f219a CWorld: Dehardcode magic number in CheckWorldComplete() 
Same behavior, no magic number.
 2020-03-30 00:58:03 -04:00
Lioncash 802ac13812 CWorld: Make use of std::array where applicable 2020-03-30 00:54:38 -04:00
Lioncash 79b1e26052 IGameArea: Amend formatting of EChain 
Makes for nicer visual scanning.
 2020-03-30 00:47:29 -04:00
Lioncash 6ae935924b IRenderer/CBooRenderer: Add parameter names to function prototypes 
Makes the interface more self-documenting and allows IDEs to perform
better parameter introspection
 2020-03-30 00:34:38 -04:00
Lioncash 111f0c3d3a IRenderer: Convert typedef to using alias 
Same behavior, but nicer to read.
 2020-03-30 00:18:38 -04:00
Lioncash 6dce70895c CIOWin: Make Draw() non-const 
Allows removing several const_cast usages within the codebase.
 2020-03-29 21:56:49 -04:00
Lioncash 0d3bab4c14 CScanDisplay: Remove use of const_cast 
The draw function is essentially not fully const in behavior, so we can
remove the const qualifiers where necessary.
 2020-03-29 21:44:10 -04:00
Lioncash 2d8e94911a CGuiTextSupport: Eliminate the use of const_cast 
We can supply a const and non-const variant to eliminate the need to
const_cast here.
 2020-03-29 21:37:11 -04:00
Lioncash f3afcf7299 CGuiTextPane: Remove stray unnecessary const_cast in Draw() 
Draw() isn't const qualified, so there's no need to cast away const
here.
 2020-03-29 21:25:47 -04:00
Lioncash 1d725587e5 CSortedLists: Remove const_cast in all BuildNearList() implementations 
Same behavior, but nicer to read.
 2020-03-29 21:22:52 -04:00
Lioncash 0a366855bc CSortedLists: Add names to all function prototypes 
More self-documenting and allows parameter inspection in IDEs to
function nicer.
 2020-03-29 21:18:18 -04:00
Lioncash eecd03428d CSortedLists: Remove use of const_cast in AddToLinkedList() 
Same behavior, but nicer to read.
 2020-03-29 21:17:59 -04:00
Lioncash 6d2ef0360f CGameState: Resolve sign conversion warnings in PutTo() 
Same behavior, but makes conversions explicit.
 2020-03-29 21:03:24 -04:00
Lioncash 45ea19040d CGameState: Make use of std::array where applicable 2020-03-29 20:58:31 -04:00
Lioncash 24fe7ec499 CGameState: Remove use of const_cast 
Same behavior, but nicer to read.
 2020-03-29 20:52:34 -04:00
Lioncash 603942daaf CTextRenderBuffer: Remove use of const_cast in Render() 
Makes for much less casting.
 2020-03-29 20:27:04 -04:00
Lioncash 04a42980ab Revert "Revert "CTextRenderBuffer: Forward declare structs where applicable"" 
This reverts commit 16745f3a7b.

We can simply default the move constructor and move assignment operator
to make this work.
 2020-03-29 20:09:16 -04:00
Phillip Stephens 16745f3a7b
Revert "CTextRenderBuffer: Forward declare structs where applicable" 2020-03-29 16:35:02 -07:00
Phillip Stephens f3721844b9
Merge pull request #282 from lioncash/struct 
CTextRenderBuffer: Forward declare structs where applicable
 2020-03-29 16:04:32 -07:00
Lioncash 232ae12802 CGuiTextPane: Make use of std::array where applicable 
Same behavior, but with stronger typing and allows removing of a
hardcoded array size.
 2020-03-29 08:00:40 -04:00
Lioncash 0aff4dc21e CTextRenderBuffer: Remove use of const_cast within Render() 
Same behavior but way less casting.
 2020-03-29 04:42:58 -04:00
Lioncash 20b74c4818 CTextRenderBuffer: Forward declare structs where applicable 
These are only used internally, so we can completely hide these structs
from external view.

This allows their implementation to be changed without needing to
recompile all the headers that include it.
 2020-03-29 03:54:29 -04:00
Jack Andersen 3e07a06355 Merge branch 'master' of ssh://git.axiodl.com:6431/AxioDL/urde 2020-03-28 21:21:53 -10:00
Jack Andersen d1c2ae71c2 Ensure consistent override usage in TCachedToken 2020-03-28 21:20:44 -10:00
Jack Andersen eefb975f23 Merge branch 'noexcept' of https://github.com/lioncash/urde 2020-03-28 21:08:43 -10:00
Lioncash fda08db9b1 CHudVisorBeamMenu: Dehardcode array sizes 
Same behavior, but queries the container for the size rather than
hardcoding it in loop bounds.
 2020-03-29 03:08:41 -04:00
Lioncash 413483a996 CHudFreeLookInterfaceXRay: Assign free look and control held flags in SetFreeLookState() 
GM8Ev0 does this.
 2020-03-29 02:08:51 -04:00
Lioncash ad07b993c8 CHudFreeLookInterface: Collapse conditional within SetFreeLookState() 
Same behavior, less code.
 2020-03-29 02:03:20 -04:00
Lioncash 59fbefbd58 CGuiWidget: Provide names for all function prototypes 
Makes parameter introspection nicer with IDEs and also renames ambiguous
"v" names to something more self-descriptive.
 2020-03-29 01:52:23 -04:00
Lioncash 764dac0adc CToken: Add missing override specifiers 2020-03-28 05:55:17 -04:00
Phillip Stephens 0db6f96a17
Merge pull request #279 from lioncash/constexpr 
CScannableParameters: Mark CScannableParameters as constexpr
 2020-03-27 23:54:26 -07:00
Lioncash 54c6122cbd CToken: Mark move assignment operator as noexcept 
Allows containers and anything using std::move_if_noexcept to perform a
move instead of a copy.
 2020-03-27 20:56:04 -04:00
Lioncash 2558da714e Runtime: Remove unnecessary smart pointer .get() calls 
Same behavior, less code to read.
 2020-03-27 20:50:45 -04:00
Lioncash 194cdf145f Runtime: Use nullptr where applicable 
Same behavior, but no magic 0 value.

While we're in the same area, we can do minor cosmetic changes.
 2020-03-27 20:18:54 -04:00
Lioncash 05988ce31c CScannableParameters: Mark CScannableParameters as constexpr 
This only contains a single member, so this can trivially be marked
constexpr.
 2020-03-27 20:07:33 -04:00
Phillip Stephens e0fe365dfd
Merge pull request #278 from lioncash/explicit 
General: Make use of explicit constructors where applicable
 2020-03-27 14:10:19 -07:00
Lioncash 241a66dc0a General: Make use of explicit constructors where applicable 
Gets rid of potential error prone implicitly constructing constructors.
 2020-03-27 06:00:17 -04:00
Lioncash e46a37e893 MP1: Make use of std::array where applicable 
Same behavior, stronger typing, and allows eliminating hardcoded sizes
in some places.
 2020-03-27 01:07:29 -04:00
Lioncash a77b9cb609 MP1: Join namespaces 
Same behavior, less code.
 2020-03-27 01:02:35 -04:00
Lioncash fcf70aeb2a CGuiWidgetIdDB: Remove redundant std::make_pair funcs 
Same behavior, less code.
 2020-03-26 03:55:28 -04:00
Lioncash 74600588fa Add missing includes pt.2 
Some missing includes that actually need to be present.
 2020-03-26 03:14:03 -04:00
Lioncash be6b5406a9 CPatterned/ScriptLoader: Convert function typedefs to using aliases 
Same thing, but more readable.
 2020-03-26 03:09:56 -04:00
Lioncash d9a9e0f51e CEnvFxManager: Take std::vector by value and std::move 
Same behavior, but allows calling code to move into the parameter,
avoiding copies.
 2020-03-26 02:56:10 -04:00
Lioncash dd76e73e11 ITweak: Default virtual destructor 
Same behavor, but allows the destructor to be trivial.
 2020-03-26 01:14:41 -04:00