AxioDL
/
metaforce
mirror of https://github.com/AxioDL/metaforce.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,645 Commits 26 Branches 15 Tags 52 MiB
Commit Graph

798 Commits

Author SHA1 Message Date
Lioncash 51afa94e8c Add missing includes where applicable 
Resolves a few required dependencies
 2020-03-26 01:10:55 -04:00
Lioncash 4169e3d91d CSnakeWeedSwarm: Mark several member functions as const 
These don't alter instance state, so they can be const member functions.
 2020-03-26 01:05:32 -04:00
Lioncash 43e0d16c5d CSnakeWeedSwarm: Use emplace_back in CreateBoid() 
Same behavior, but with in-place construction instead.
 2020-03-26 01:00:29 -04:00
Lioncash 2164854e87 CVisorFlare: Pass flares by value and use std::move 
Same behavior, but allows calling code to move into the parameter and
avoid copies entirely.
 2020-03-26 00:32:49 -04:00
Lioncash c5c888daa6 CRippleManager: Rename Ripples() to GetRipples() 
Allows const overloading to work and prevents compilation errors from
occurring if the constness ever changes.
 2020-03-25 04:22:34 -04:00
Lioncash 4f9e53933e CPathFindArea: Amend bitset size 
The previous commit meant to contain this size.
 2020-03-25 04:15:55 -04:00
Lioncash d0292fdc5d CPathFindArea: Make use of std::bitmap with CPFBitSet 
Same behavior, but without the need to roll the operations ourselves.
 2020-03-25 04:12:55 -04:00
Luke Street 7ee2a3b912
Merge pull request #254 from AxioDL/flyingpirate 
CFlyingPirate implementation
 2020-03-25 03:01:10 -04:00
Luke Street 556f870dc8 Merge branch 'pr-277' 2020-03-25 02:09:09 -04:00
Luke Street 8314d5b6ef Merge branch 'pr-255' 2020-03-25 02:09:02 -04:00
Lioncash 40fc3f9dd8 CModelBoo: Remove usages of const_cast 
Many functions are modifying internals of CBooModel and const-casting
is performed in order to work around functions being const when they
really shouldn't be.

This amends the function signatures in order to allow these functions to
exist without const_cast, making code much nicer to read.
 2020-03-25 02:01:46 -04:00
Lioncash e38d86fe59 CPhysicsActor: Amend constructor names for CPhysicsState 
These were previously undescriptive names despite the member variables
being fully named. We can amend the parameters here.
 2020-03-25 01:56:58 -04:00
Lioncash 81ae6bdda2 CPhysicsActor: Add names to parameters in prototypes 
Allows better introspection in IDEs and makes the interface itself more
self-documenting.
 2020-03-25 01:54:17 -04:00
Lioncash ab6c45c7a8 CWorld: Provide parameter names for prototypes 
More self-documenting from the interface alone and allows IDE
inspections at callsites to be better.
 2020-03-25 01:27:56 -04:00
Lioncash f2b1e44ee1 CEntity: Rename ConnectionList() to GetConnectionList() 
Allows const overloading to function, preventing compilation errors from
occuring across constness changes.
 2020-03-24 21:29:44 -04:00
Lioncash 8644b8393b CEntity: Add parameter names to interface 
Allows IDEs to perform better parameter inspection.
 2020-03-24 21:28:15 -04:00
Phillip Stephens e8f0d29a3b
Merge pull request #275 from lioncash/const-over 
CPlayerState: Rename HealthInfo() to GetHealthInfo()
 2020-03-24 17:45:59 -07:00
Phillip Stephens c72f388929
Merge pull request #273 from lioncash/team-uninit 
CTeamAiMgr: Initialize x90_timeSinceMelee and x90_timeSinceRanged to 0.0f in constructor
 2020-03-24 17:45:29 -07:00
Phillip Stephens 9aece39445
Merge pull request #272 from lioncash/uninit 
CFluidPlane: Always initialize mul to 0.0f in CalculateRippleIntensity()
 2020-03-24 17:45:15 -07:00
Lioncash ef93a601eb CPlayerState: Rename HealthInfo() to GetHealthInfo() 
Allows const overloading to function and prevents compilation errors
from occurring if constness changes through future changes of any sort.
 2020-03-24 06:20:37 -04:00
Lioncash 64d0563872 CTeamAiMgr: Initialize x90_timeSinceMelee and x90_timeSinceRanged to 0.0f in constructor 
Makes all class members have a deterministic initial state.
 2020-03-24 05:19:05 -04:00
Lioncash f416a814a1 CFluidPlane: Always initialize mul to 0.0f in CalculateRippleIntensity() 
Avoids a -Wmaybe-uninitialized warning.
 2020-03-24 05:14:01 -04:00
Lioncash 35ea097028 CPlayer: Add parameter names to prototypes 
Makes them more self-documenting from the interface alone and also
allows IDEs to perform better parameter and argument inspection.
 2020-03-24 04:33:54 -04:00
Phillip Stephens fc87bd8022
Merge pull request #270 from lioncash/brace 
CPlayer: Un-nest code within FinishNewScan()
 2020-03-23 23:29:59 -07:00
Phillip Stephens 2e43266714
Merge pull request #258 from lioncash/emplaced 
General: Make use of emplace_back where applicable
 2020-03-23 23:26:51 -07:00
Lioncash 70c51c3a86 CPlayer: Un-nest code within FinishNewScan() 
Makes this function much nicer to read.
 2020-03-23 02:44:44 -04:00
Lioncash fc4df76afc General: Make use of emplace_back where applicable 
Allows for in-place construction. Also results in less code to read in
certain usages.
 2020-03-21 00:30:12 -04:00
Lioncash 8a9e76a345 CWorld: Rename IMapWorld to IGetMapWorld() 
Allows const overloading to function properly and prevents potential
compilation errors from occurring if constness on functions is ever
changed.
 2020-03-20 23:27:07 -04:00
Luke Street 13d8c3fdd1 CFlyingPirate: First draft almost done 2020-03-18 01:18:48 -04:00
Luke Street 5765fd8951 CFlyingPirate: Method definitions & CFlyingPirateRagDoll constructor 2020-03-18 01:18:48 -04:00
Luke Street fcf7044bf2 Merge remote-tracking branch 'github/recovery' 2020-03-18 00:45:49 -04:00
Luke Street 87eeafe0b0 CSnakeWeedSwarm: Renaming & cleanup 2020-03-16 20:15:22 -04:00
Luke Street 4eaed95c11
Merge pull request #222 from lioncash/view 
CGameOptions: Make use of std::string_view where applicable
 2020-03-15 19:44:47 -04:00
Lioncash 659b8a43d3 CGameOptions: Make use of std::string_view where applicable 
Enforces the use of valid strings in the interface. Also reduces c_str()
noise a little bit.
 2020-03-14 20:09:23 -04:00
Lioncash 097d4a4422 Runtime: Collapse emplace_back() calls where applicable 
Same behavior, but with less code.
 2020-03-13 17:14:44 -04:00
Phillip Stephens 8badbd3f35
Merge pull request #211 from lioncash/init 
CPlayerEnergyDrain: Initialize x10_energyDrainTime on construction
 2020-03-12 15:10:28 -07:00
Phillip Stephens ce5ce35743
Merge pull request #210 from lioncash/bob 
CPlayerCameraBob: Minor cleanup
 2020-03-12 15:10:19 -07:00
Lioncash d51518dc57 CPlayerEnergyDrain: Make constructor explicit 
Prevents error-prone implicit constructions from occurring.
 2020-03-12 10:01:31 -04:00
Lioncash e628cbf1be CPlayerEnergyDrain: Initialize x10_energyDrainTime on construction 
GM8E v0 initializes this to zero when constructing the class. This also
makes the entire class have a consistent initial state.
 2020-03-12 09:57:43 -04:00
Luke Street cfd568bb39 Merge branch 'chozoghosts' 2020-03-11 17:17:00 -04:00
Phillip Stephens 190c369aeb
Fix crashes with FusionSuit active 2020-03-11 06:48:30 -07:00
Lioncash 179d19412b CPlayerCameraBob: Make static non-const member variables private 
Prevents accidental modification of the values from occurring in code
that makes use of them. Many of these constants aren't even used outside
of the class itself in the first place.
 2020-03-09 20:55:12 -04:00
Lioncash f622ed364d CPlayerCameraBob: Make use of std::array where applicable 2020-03-09 20:33:37 -04:00
Luke Street 830db8772d Merge remote-tracking branch 'origin/master' into chozoghosts 2020-03-09 10:12:40 -04:00
Phillip Stephens d93df18a37
Fix `CScriptDistanceFog::AcceptScriptMessage` 2020-03-08 23:18:57 -07:00
Luke Street 6e9a80de5d CVisorFlare: Rename "near" to avoid MSVC conflict 2020-03-08 23:44:44 -04:00
Phillip Stephens dd54f93da4
Merge pull request #195 from lioncash/unused 
CPlayer: Make use of unused CCollidableAABox in ProcessInput()
 2020-03-08 18:02:52 -07:00
Phillip Stephens f06c26e7d6
Fix infinite loop in CObjectList, and add an assert to detect invalid assignments 2020-03-07 09:14:07 -08:00
Lioncash 830e1c59d2 CPlayer: Make nearby variables const 
Makes nearby variables from the previous change const to make their
immutability explicit.
 2020-03-06 22:08:56 -05:00
Lioncash a2b6b4515d CPlayer: Make use of unused CCollidableAABox in ProcessInput() 
GM8E v0 makes use of the temporary collidable AA box. This amends the
code to make use of it.
 2020-03-06 22:06:44 -05:00
Phillip Stephens 17f25457c5
CGameArea::CAreaObjectList fix 2020-03-06 16:20:52 -08:00
Phillip Stephens 1cccaac115
Final CChozoGhost imps 2020-03-06 07:16:55 -08:00
Lioncash 6917132a94 CThardus: std::move vector instances in constructor 
Previously the std::move calls wouldn't do anything, as the parameters
were constant references, so we can take them by value and move into the
constructor and then move the parameters into the member variables.

While we're at it, we can initialize the vectors in place instead of
constructing and then assigning to them.
 2020-03-05 21:19:32 -05:00
Phillip Stephens 9d77d7313c
More ChozoGhost imps 2020-03-04 18:41:10 -08:00
Phillip Stephens 2f9dd38bbe
Silence discard errors 2020-03-04 18:40:03 -08:00
Phillip Stephens 80dbc1920c
Update submodules 2020-03-03 16:49:13 -08:00
Phillip Stephens 366d6b96ee
Merge pull request #178 from lioncash/data 
CScriptGunTurret: Remove unnecessary data() call in AcceptScriptMsg()
 2020-03-03 16:43:43 -08:00
Phillip Stephens abfd77c3ba
Merge pull request #177 from lioncash/burst 
CScriptGunTurret: Move static const data into the cpp file
 2020-03-03 16:43:34 -08:00
Lioncash 70c3a7ddf5 CScriptGunTurret: Remove unnecessary data() call in AcceptScriptMsg() 
We can use append() instead of data(). This allows the size of the
string view instance to be used directly instead of redundantly doing a
string size lookup.
 2020-03-03 06:30:20 -05:00
Luke Street 9e0e053906 CScriptSpecialFunction: Further ThinkSpinnerController implementation 2020-03-03 03:31:58 -05:00
Lioncash 245a8145c7 CScriptGunTurret: Make use of std::array with file-static data 2020-03-03 03:12:35 -05:00
Lioncash f4fc17bee0 CScriptGunTurret: Move static const data into the cpp file 
Makes the data fully internally linked and also allows making said data
constexpr.
 2020-03-03 03:05:02 -05:00
Luke Street 12393d4c4d CSnakeWeedSwarm: Fix lighting 2020-03-01 03:05:16 -05:00
Luke Street 17b9813b3e CSnakeWeedSwarm: Rendering & state fixes 2020-03-01 02:52:17 -05:00
Luke Street f064bc2f7b CSnakeWeedSwarm: Initialize bitfields; some more cleanup 2020-03-01 01:59:12 -05:00
Luke Street 046fbe7760 CSnakeWeedSwarm: Cleanup, renaming & fixes 2020-03-01 01:59:12 -05:00
Luke Street 34a80aab81 CSnakeWeedSwarm: Implement ApplyRadiusDamage 2020-03-01 01:59:12 -05:00
Luke Street f50f5cedef CSnakeWeedSwarm: Implement remaining methods 2020-03-01 01:59:12 -05:00
Phillip Stephens 9f5f0abab4
More CThardus imps, add reference CTevPass imps 2020-02-29 17:11:41 -08:00
Lioncash f1256faeb7 Runtime: Remove unnecessary c_str() calls 
Makes for less noisy code and also gets rid of unnecessary std::strlen
calls in the case things are passed to a std::string_view parameter.
 2020-02-28 05:26:41 -05:00
Lioncash 79c409c5e0 CPlayer: Add missing return within UpdateOrbitModeTimer() 
Previously, any call to this function would always reset the timer to
0.0, rather than potentially decrement it.

GM8E v0 always returns within the conditional.
 2020-02-25 02:17:22 -05:00
Luke S 97ab8a56d9
Merge pull request #157 from lioncash/optional-goo 
CScriptVisorGoo: Use std::make_optional where applicable
 2020-02-24 03:12:17 -05:00
Lioncash b3b71a2e76 CScriptVisorGoo: Use std::make_optional where applicable 
Same behavior, but without a verbose type name.
 2020-02-24 02:57:47 -05:00
Luke Street f1dd82066a Start implementing CSnakeWeedSwarm 2020-02-20 23:27:12 -05:00
Luke Street a978b030c3 Fix infra model for CWallCrawlerSwarm 2020-02-20 21:50:54 -05:00
Phillip Stephens 61f9adfa70
Merge branch 'pr-148' 2020-02-07 14:25:31 -08:00
Phillip Stephens 60f8dfb9d1
Final CCollisionInfoList imps 2020-02-07 14:20:04 -08:00
Lioncash 16f7925652 CFireFlea: Set CPathFindSearch's padding to 50.0f within AcceptScriptMsg() 
v0-00 sets the padding member of CPathFindSearch here to 50.0, not a
member variable that's part of the CFireFlea class.
 2020-02-07 16:27:56 -05:00
Phillip Stephens 569886de6a
Merge pull request #142 from lioncash/decay 
CScriptPlatform: Amend delta time value in AcceptScriptMsg for deletion
 2020-02-03 14:44:21 -08:00
Phillip Stephens 48570cd956
Merge pull request #141 from lioncash/dock-aa 
CScript*: Return std::nullopt in GetTouchBounds()
 2020-02-03 14:43:58 -08:00
Phillip Stephens 06d7a3e00a
Merge pull request #140 from lioncash/enum-class 
CScriptDock: Make EDockState an enum class
 2020-02-03 14:43:28 -08:00
Lioncash 3147d39cd9 CScript*: Return std::nullopt in GetTouchBounds() 
In some implementations, returning via default construction for
std::optional can cause the entire inner buffer to be zeroed out.

Returning with std::nullopt causes only the internal validity flag to be
set and nothing more.
 2020-02-01 01:06:43 -05:00
Lioncash c944d04614 CScriptPlatform: Amend delta time value in AcceptScriptMsg for deletion 
Game code makes use of 1.66666675f here, not 0.0f.
 2020-01-31 23:53:39 -05:00
Lioncash 9a8f99faa5 CScriptDock: Make EDockState an enum class 
Makes the enum type strongly typed. All usages currently allow for this
anyways.
 2020-01-31 21:34:10 -05:00
Lioncash 458ff8949a IGameArea: Make Dock's reference count variable signed 
In all usage cases, this variable is used with functions that expect a
signed value. This eliminates quite a few signed mismatch warnings.
 2020-01-31 21:29:53 -05:00
Lioncash a3ebe8727f CScriptSound: Remove active check within AcceptScriptMsg() deactivate path 
Game code doesn't check for active status within this branch, and
there's no comment indicating whether or not this difference was intentional.
 2020-01-31 17:37:46 -05:00
Lioncash 495ff19aad CDamageInfo: Make certain constructors constexpr 
Allows eliminating potential runtime static constructors by allowing
file-scope instances to be declared constexpr.
 2020-01-31 02:06:14 -05:00
Phillip Stephens 968c3394c6
Merge pull request #135 from lioncash/dash-elements 
CPlayer: Add missing element to skDashStrafeDistances
 2020-01-30 20:12:00 -08:00
Phillip Stephens d7f475166f
Merge pull request #134 from lioncash/function-error 
CPlayer: Fix function call mismatch within SidewaysDashAllowed()
 2020-01-30 20:11:49 -08:00
Phillip Stephens 11352ef042
Merge pull request #131 from lioncash/top-const 
CActor: Remove top-level const from GetScaledLocatorTransform() and GetLocatorTransform()
 2020-01-30 20:11:12 -08:00
Lioncash 29ca2b6062 CPlayer: Add missing element to skDashStrafeDistances 
This was previously missing the initial element within the array,
causing all the elements in the table to be shifted to the left by one.
This corrects that.
 2020-01-29 03:51:50 -05:00
Lioncash 264c897bb5 CPlayer: Fix function call mismatch within SidewaysDashAllowed() 
This function actually calls GetPressInput() here, not
GetDigitalInput().
 2020-01-29 03:18:36 -05:00
Lioncash edf5511af4 CActor: Remove top-level const from GetScaledLocatorTransform() and GetLocatorTransform() 
Same behavior, less code.
 2020-01-29 01:50:31 -05:00
Lioncash 3d5ed90d1a CWeaponMode: Make constexpr capable 
Given this is such a simple type, this can be made usable with
constexpr. This allows the type to be usable at file-scope without
potentially incurring a runtime constructor.
 2020-01-23 23:12:18 -05:00
Phillip Stephens 8d90edd55f
Initial CChozoGhost imp 2020-01-20 20:00:40 -08:00
Lioncash ab2ad38220 CPatterned: Mark CMaterialList instance in CollidedWith as constexpr 
This isn't ever modified, so we can mark it constexpr to eliminate
potential runtime initializers.
 2020-01-15 14:48:21 -05:00
Phillip Stephens 841996a872
More work on CThardus 2020-01-05 20:24:54 -08:00
Lioncash 221cc5c6b8 RuntimeCommonB: Normalize cpp file includes 
Like the prior changes normalizing the inclusions within headers, this
tackles the cpp files of the RuntimeCommonB target, making these source
files consistent with their headers.
 2019-12-22 18:12:04 -05:00
Phillip Stephens 21159e604e
More CThardus 2019-12-14 15:50:29 -08:00
Phillip Stephens 8689d599c5
GCC Fixes 2019-12-14 01:14:58 -08:00