Lioncash
8698cc3cd5
CScriptPlayerActor: Brace conditionals where applicable
2020-05-07 12:41:00 -04:00
Lioncash
c308b2e3c5
CScriptPlayerHint: Brace conditionals where applicable
2020-05-07 12:36:06 -04:00
Lioncash
e47d0446b1
CScriptPointOfInterest: Brace conditionals where applicable
2020-05-07 12:35:31 -04:00
Lioncash
192cbd5e14
CScriptRandomRelay: Brace conditionals where applicable
2020-05-07 12:34:57 -04:00
Lioncash
7145917e30
CScriptRelay: Brace conditionals where applicable
2020-05-07 12:33:25 -04:00
Lioncash
1315189990
CScriptRipple: Brace conditionals where applicable
2020-05-07 12:29:43 -04:00
Lioncash
2bf190048d
CScriptRoomAcoustics: Brace conditionals where applicable
2020-05-07 12:28:45 -04:00
Lioncash
e691628289
CScriptShadowProjector: Brace conditionals where applicable
2020-05-07 12:27:49 -04:00
Lioncash
7186e57a9d
CScriptSound: Brace conditionals where applicable
2020-05-07 12:26:05 -04:00
Lioncash
ecbcb86bc5
CScriptSpawnPoint: Brace conditionals where applicable
2020-05-07 12:18:57 -04:00
Lioncash
750e0a8643
CScriptSpecialFunction: Brace conditionals where applicable
2020-05-07 12:16:53 -04:00
Lioncash
568e8c0d88
CScriptSpiderBallWaypoint: Brace conditionals where applicable
2020-05-07 12:03:44 -04:00
Lioncash
90e67898e4
CScriptSpindleCamera: Brace conditionals where applicable
2020-05-07 11:59:29 -04:00
Lioncash
5cc1cd799a
CScriptSteam: Brace conditionals where applicable
2020-05-07 11:50:21 -04:00
Lioncash
52cc84374d
CScriptStreamedMusic: Brace conditionals where applicable
2020-05-07 11:49:31 -04:00
Lioncash
79a25cab5e
CScriptSwitch: Brace conditionals where applicable
2020-05-07 11:48:34 -04:00
Lioncash
0fa7e0a73b
CScriptTargetingPoint: Brace conditionals where applicable
2020-05-07 11:47:59 -04:00
Lioncash
bb578468f4
CScriptTimer: Brace conditionals where applicable
2020-05-07 11:47:05 -04:00
Lioncash
ca718f938e
CScriptTrigger: Brace conditionals where applicable
2020-05-07 11:45:53 -04:00
Lioncash
29f6ef0f76
CScriptVisorFlare: Brace conditionals where applicable
2020-05-07 11:41:56 -04:00
Lioncash
d517db5c5d
CScriptVisorGoo: Brace conditionals where applicable
...
Makes the code consistent.
2020-05-07 11:41:14 -04:00
Lioncash
f78c85f37c
CScriptWaypoint: Brace conditionals where applicable
...
Makes the code consistent.
2020-05-07 11:39:11 -04:00
Lioncash
717d422fc4
CScriptWater: Brace conditionals where applicable
2020-05-07 11:36:17 -04:00
Lioncash
c81d6632bb
CScriptActor: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 08:19:14 -04:00
Lioncash
63fda8f1c7
CScriptActorRotate: Brace statements where applicable
...
Makes code consistent.
2020-05-07 08:11:09 -04:00
Lioncash
e8dc27bfaa
CScriptAiJumpPoint: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 08:01:38 -04:00
Lioncash
bdcf6dee66
CScriptAreaAttributes: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 07:59:20 -04:00
Lioncash
0bb3fcae3b
CScriptBallTrigger: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 07:58:15 -04:00
Lioncash
ec6416e387
CScriptBeam: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 07:55:24 -04:00
Lioncash
23b14232be
CScriptCamera*Keyframe: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 07:54:19 -04:00
Lioncash
d6ad152a97
CScriptCameraHint: Brace statements where applicable
...
Makes code consistent.
2020-05-07 07:51:50 -04:00
Lioncash
a8fd2a1992
CScriptCameraHintTrigger: Brace statements where applicable
...
Same behavior, more consistent code.
2020-05-07 07:45:08 -04:00
Lioncash
ed231b85e9
CScriptCameraPitchVolume: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 07:43:35 -04:00
Lioncash
dab1784302
CScriptDamageableTrigger: Brace conditions where applicable
...
Makes code consistent.
2020-05-07 07:40:26 -04:00
Lioncash
ff0d14b52d
CScriptDamageableTrigger: Mark helper functions as static where applicable
...
Makes them internally linked.
2020-05-07 07:37:04 -04:00
Lioncash
af61cba8db
CScriptDebris: Brace statements where applicable
...
Makes code fully consistent style-wise.
2020-05-07 07:29:21 -04:00
Lioncash
d3ad8e104b
CScriptDebris: Remove redundant constructor initializers
...
These are initialized within the class definition.
2020-05-07 07:18:09 -04:00
Luke Street
d30ce2b218
CScriptPlatform: Fix breakable behavior; CScriptColorModulate fixes
2020-05-07 02:19:58 -04:00
Lioncash
40ede53949
CScriptWorldTeleporter: Unindent code in StartTransition()
...
We can make use of an early-return to unindent code by one level.
2020-05-03 10:28:28 -04:00
Lioncash
d0233b7767
CTeamAiMgr: Make reference parameters to GetTeamAiMgr() const
...
No modifications to these parameters are being made, so we can make that
explicit in the interface.
2020-05-02 22:39:51 -04:00
Lioncash
21a33b01ad
CTeamAiMgr: Collapse two loops into count_if
...
Same behavior, less code.
Ranges in C++20 will allow us to further simplify this in the future.
2020-05-02 22:09:52 -04:00
Luke Street
1578a9481b
CScriptAiJumpPoint: Fix GetInUse
2020-04-29 03:03:14 -04:00
Lioncash
1948ec3274
CWallWalker: Remove unused variables in PreThink
...
We can leave a comment documenting this to make the code itself a little
nicer to read.
2020-04-26 03:28:48 -04:00
Lioncash
d4264b6469
CWallWalker: Eliminate signed->unsigned implicit conversion in header
...
Prevents compiler warnings.
2020-04-26 03:22:03 -04:00
Lioncash
4f56bf8eb6
CWallWalker: Simplify CCollisionSurface initializer
...
Allows it to sit on one line.
2020-04-26 03:20:47 -04:00
Lioncash
07ebdd364c
CDamageVulnerability: Make constructors constexpr
...
Eliminates any potential runtime initializers related to file-scope
constant instances of this class.
2020-04-26 01:06:26 -04:00
Lioncash
0ad1f8ba42
CDamageVulnerability: Amend typo in parameter name
2020-04-26 00:56:45 -04:00
Lioncash
f1ff48c38b
CDamageVulnerability: Remove unnecessary inline specifiers
...
These functions are already marked static, so they're already a
candidate for inlining.
We can mark them as constexpr though, given how trivial they are.
2020-04-26 00:54:36 -04:00
Lioncash
4a6c3cde3c
CWorldLight: Eliminate variable shadowing
...
While we're at it, we can make use of structured bindings.
2020-04-23 07:25:07 -04:00
Lioncash
4e3363a98b
CScriptActorKeyframe: Eliminate variable shadowing
2020-04-23 07:22:10 -04:00
Lioncash
9ec9f42457
CPathFindSearch: Eliminate variable shadowing
2020-04-23 07:19:41 -04:00
Lioncash
078acce378
CMorphBall: Eliminate variable shadowing
2020-04-23 07:18:43 -04:00
Lioncash
eefeb5cd0b
CGameArea: Remove undefined behavior type-punning in a few functions
...
We can make use of std::memcpy here to get around this.
2020-04-23 03:06:04 -04:00
Lioncash
df3aed75fe
CGameArea: Eliminate implicit sign conversions in Validate()
2020-04-23 02:53:24 -04:00
Phillip Stephens
59f979db67
Actually implement AssetNameMap in DNAMP1
2020-04-22 03:38:48 -07:00
Lioncash
535717fbd8
CGameArea: Make use of std::array where applicable
2020-04-22 02:19:14 -04:00
Lioncash
664d08469c
CEnvFxManager: Make use of std::array where applicable
...
Same behavior, less code.
2020-04-22 02:16:37 -04:00
Lioncash
52f51c111a
CAmbientAI: Return std::nullopt in GetTouchBounds()
...
Allows implementations to avoid zeroing out the internal buffer of the
std::optional.
2020-04-22 02:10:55 -04:00
Luke Street
8488dca336
CPlayer: Long fall anim/dmg fix
2020-04-21 20:43:34 -04:00
Luke Street
82aa99f858
CScriptCameraWaypoint: Fix Arrived
2020-04-21 20:35:37 -04:00
Luke Street
449d8409d8
CMagdolite: Fix lock-on, retreat & loader
2020-04-21 04:46:07 -04:00
Luke Street
5f66ab2219
CMagdolite: Minor cleanup
2020-04-21 01:32:16 -04:00
Phillip Stephens
d1c796f2a9
Initial CMagdolite imps
2020-04-21 01:06:52 -04:00
Luke Street
d3a44259c3
Merge pull request #315 from lioncash/init
...
RuntimeCommonB: Make use of bitfield initializers where applicable
2020-04-21 00:56:39 -04:00
Lioncash
554893ef85
RuntimeCommonB: Make use of bitfield initializers where applicable
...
Given that we now target C++20, we can make use of bitfield initializers
where applicable.
2020-04-20 15:57:25 -04:00
Luke Street
32c44cbf05
Merge branch 'master' into omegapirate
...
# Conflicts:
# Runtime/GuiSys/CAuiImagePane.cpp
2020-04-19 22:12:18 -04:00
Luke Street
1fd28d3fc3
CStateMachine: Use logvisor report for state logging
2020-04-19 22:11:09 -04:00
Lioncash
ecdedb5d8f
CActorModelParticles: Make IsMediumOrLarge() parameter a const reference
...
Nothing about the parameter is modified.
2020-04-19 21:44:31 -04:00
Luke Street
24acb585f8
MSVC & zeus fixes; update hecl-gui
2020-04-19 21:09:30 -04:00
Luke Street
a3e0c42794
Merge pull request #312 from lioncash/explicit
...
MkCastTo: Make operator bool instances explicit
2020-04-19 00:24:15 -04:00
Lioncash
2c3e5e205f
MkCastTo: Make operator bool instances explicit
...
Prevents error prone implicit conversions.
2020-04-18 23:02:11 -04:00
Luke Street
30f2ac3f26
Merge branch 'master' into omegapirate
2020-04-18 18:14:51 -04:00
Phillip Stephens
df75c00203
Fix WideScreenFilter crash
2020-04-17 15:32:26 -07:00
Lioncash
76f0b57340
General: Use bool literals where applicable
...
More indicative of the passed in type compared to raw values.
2020-04-17 17:43:56 -04:00
Lioncash
0b05c906df
CScriptEffect: Eliminate variable shadowing
...
Avoids clashing names.
2020-04-17 16:31:02 -04:00
Lioncash
5491f3ff23
CKnockBackController: Simplify initialization of x24_ in constructor
...
Same behavior, less code.
2020-04-17 13:17:27 -04:00
Lioncash
26ac3b166d
CKnockBackController: Make use of braces where applicable
...
Makes code more consistent.
Where applicable we can also unindent code.
2020-04-17 13:17:27 -04:00
Lioncash
58040eb53d
CKnockBackController: Make CalculateExtraHurlVelocity() a const member function
...
This doesn't modify internal member state, so it can be marked const
While we're at it we can also invert the conditional to unindent the
main calculation.
2020-04-17 01:07:41 -04:00
Lioncash
b55d1e4c77
CKnockBackController: Make use of const references where applicable
...
In many cases the CPatterned& parameter is only used for read-only
querying. We can make this explicit in the interface.
2020-04-17 01:03:12 -04:00
Lioncash
49cc019699
CKnockBackController: Make GetKnockBackCharacterState() a const member function
...
This doesn't modify internal instance state, so this can be made const.
2020-04-17 00:58:29 -04:00
Lioncash
529d7e58bd
CFishCloud: Initialize x230_whichModel on construction
...
Provides a deterministic initial state.
2020-04-17 00:49:06 -04:00
Lioncash
fa9f0fdc61
CFishCloud: Brace statements where applicable
...
Makes the code more uniform and consistent.
While we're in the same area, we can make use of const where applicable.
2020-04-17 00:47:25 -04:00
Lioncash
ed125031f3
CFluidUVMotion: Collapse separate resize and assignment into a constructor call
...
We can pre-size and insert the elements all at the same time.
2020-04-16 21:11:31 -04:00
Phillip Stephens
582d8a6999
Initial PAL/JP/Trilogy imps, various cleanup
2020-04-15 22:26:14 -07:00
Phillip Stephens
e553a9022f
Fix CMemoryCardSys
2020-04-15 04:27:06 -07:00
Luke Street
b020904e84
Comment out printfs entirely
2020-04-14 22:14:27 -04:00
Luke Street
eb89a17817
CDummyWorld: Fix IGetAreaId
2020-04-14 21:15:38 -04:00
Lioncash
6436184a3f
CWorld: Make use of find_if in GetAreaIdForSaveId()
...
Same behavior minus any explicit mutable state.
2020-04-14 16:40:13 -04:00
Lioncash
86b94ad915
CWorld: Make use of std::find_if in IGetAreaId
...
Removes explicit mutable state. This can be further simplified in the
future with ranges.
2020-04-14 16:31:17 -04:00
Lioncash
655805ffcb
CWorld: Add missing override specifier
2020-04-14 16:17:26 -04:00
Luke Street
594fe2fcbd
Merge pull request #310 from lioncash/table
...
CFluidPlane: Make use of std::array where applicable
2020-04-14 02:09:19 -04:00
Lioncash
2850b7e7fb
CWallCrawlerSwarm: Initialize all CBoid members
...
Provides a deterministic initial state.
2020-04-13 16:36:24 -04:00
Lioncash
7fcd6f41cf
CStateMachine: Initialize data members where applicable
...
Provides a deterministic initial state.
2020-04-13 16:34:18 -04:00
Lioncash
0d97104cf2
CScriptSpindleCamera: Initialize x33c_24_inResetThink in constructor
...
Provides a deterministic initial state.
2020-04-13 16:32:41 -04:00
Lioncash
4341dfae50
CScriptPickup: Initialize x274_tractorTime in constructor
...
Provides a deterministic initial state upon construction.
2020-04-13 16:31:28 -04:00
Lioncash
a554e5d4a6
CPathFindSearch: Initialize xcc_result in constructor
...
Provides a deterministic initial state upon construction.
2020-04-13 16:29:12 -04:00
Lioncash
9f21f8ef55
CFluidPlaneCPU: Initialize m_cachedDoubleLightmapBlend and m_cachedAdditive
...
Provides a deterministic initial state upon construction.
2020-04-13 16:27:21 -04:00
Lioncash
498c940479
CFluidPlane: Initialize all members of SRippleInfo
...
Provides a deterministic initial state, which is useful for debugging.
2020-04-13 16:25:36 -04:00
Lioncash
29cd228d03
CMorphBall: Eliminate hardcoded sizes
...
We can query the container capacity directly instead of hardcoding it
in.
2020-04-13 14:10:52 -04:00
Lioncash
414c06b33e
CScriptDebris: Make use of std::array
...
Same behavior, stronger typing.
2020-04-12 21:07:17 -04:00