encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/BUILD.gn

1150 lines
38 KiB
Plaintext
Raw Normal View History

Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
# Copyright 2018 The Dawn Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
Build with a different gtest harness when in Chromium Running test in a Chromium build requires using their gtest and gmock targets as well as a harness that is in //base. Since we want to run Dawn tests on the Chromium GPU bots, we need to support two configurations both building tests standalone and in Chromium. BUG=chromium:870747 Change-Id: I862e62a607e193a27562ece0f1f6d46d8728e446 Reviewed-on: https://dawn-review.googlesource.com/c/2080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-10-31 10:49:21 +00:00
import("//build_overrides/build.gni")
dawn_native: handle NaN lod values in samplers For samplers with NaN mLodMinClamp or mLodMaxClamp, the equality operator returned false. Adds checks for finite values, and also early returns if two pointers are equal. Bug: dawn:143, chromium:965633 Change-Id: Id5998d6eec275af0fbe30e3b4fcb3eed4fe64c6a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7401 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-05-22 17:18:52 +00:00
import("generator/dawn_generator.gni")
BUILD.gn: Split dawn_component/generator in their own files This will allow follow up commits to use them from the different parts of the split-off BUILD.gn file. BUG=dawn:61 Change-Id: I767f6c97c06ee73290d3df482880d1a2df92e187 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5301 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-06 23:17:39 +00:00
import("scripts/dawn_component.gni")
[dawn] small fix for BUILD.gn BackendBinding.h includes dawn/dawncpp.h, so dawn_headers_gen needs to be in public_deps. See below reference for more details. https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps Applied `gn format` too. Bug: chromium:931596 Change-Id: I8572ba54b56c96950a58ec068ba797b3031f3c01 Reviewed-on: https://dawn-review.googlesource.com/c/4640 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-02-13 18:42:38 +00:00
import("scripts/dawn_features.gni")
import("scripts/dawn_overrides_with_defaults.gni")
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
import("//testing/test.gni")
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
Add dawn_platform::Platform for handling tracing events in Dawn This patch provides Chromium TRACE_EVENT macros and hooks for implementing the TRACE_EVENT api. Bug: chromium:958013 Change-Id: I033b1c7ca57c550504a1bea1898a1a152831922b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7060 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-13 19:00:34 +00:00
###############################################################################
# dawn_platform
###############################################################################
source_set("dawn_platform") {
configs += [ "${dawn_root}/src/common:dawn_internal" ]
sources = [
"${dawn_root}/src/include/dawn_platform/DawnPlatform.h",
"src/dawn_platform/tracing/EventTracer.cpp",
"src/dawn_platform/tracing/EventTracer.h",
"src/dawn_platform/tracing/TraceEvent.h",
]
deps = [
"${dawn_root}/src/common",
]
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
###############################################################################
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
# libdawn_native
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
###############################################################################
config("libdawn_native_internal") {
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
configs = [ "${dawn_root}/src/common:dawn_internal" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
Clarify disabled warning for Metal in BUILD.gn BUG= Change-Id: I7f0715bbaaae433d2f1a93c5a2496f28d466e150 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11220 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-09-18 04:40:32 +00:00
# Suppress warnings that Metal isn't in the deployment target of Chrome:
# initialization of the Metal backend is behind a IsMetalSupported check so
# Dawn won't call Metal functions on macOS 10.10.
# TODO(cwallez@chromium.org): Consider using API_AVAILABLE annotations on all
# metal code in dawn once crbug.com/1004024 is sorted out.
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
if (is_mac) {
cflags_objcc = [ "-Wno-unguarded-availability" ]
}
}
Generators: main.py is now dawn_json_generator.py This merges all the files for main.py together again except generator_lib.py because there doesn't seeem to be a good way to separate the pure dawn.json generators and the dawn wire generator. Also updates the GN templates to make it easier to define new generators based on generator_lib, and move the Jinja2 template "stdlib" to generator_lib.py BUG=dawn:165 Change-Id: I1b5b2ef0a59cb142e214f3af9a58048a88ae949a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7880 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-06-11 18:03:05 +00:00
dawn_json_generator("libdawn_native_utils_gen") {
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
target = "dawn_native_utils"
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
outputs = [
Normalize generated file paths to match main tree. Previously dawn_native files were in src/dawn_native/ while generated files were in dawn_native/. This makes some things complicated when integrating in other source trees so normalize all generated files to be in paths that match the main tree. BUG=dawn:225 Change-Id: I5b3e04d37a16251143578dfb7a31445b229fe4ac Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11300 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-09-18 04:33:12 +00:00
"src/dawn_native/ProcTable.cpp",
"src/dawn_native/dawn_structs_autogen.h",
"src/dawn_native/dawn_structs_autogen.cpp",
"src/dawn_native/ValidationUtils_autogen.h",
"src/dawn_native/ValidationUtils_autogen.cpp",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
if (dawn_enable_opengl) {
dawn_generator("libdawn_native_opengl_loader_gen") {
script = "generator/opengl_loader_generator.py"
args = [
"--gl-xml",
Remove glad and replace it with our own GL header This completely removes the dependency on glad by generating the GL headers from gl.xml directly. This requires adding khrplatform.h so all Khronos dependencies are gathered in third_party/khronos. Also removes a stray CMakeLists.txt that was still hanging out. BUG=dawn:165 Change-Id: Ia64bc51bc8b18c6b48613918e2f309f7405ecb3b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8163 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-17 09:17:29 +00:00
rebase_path("third_party/khronos/gl.xml", root_build_dir),
OpenGL: Support B2T and T2T copies with BC formats This patch implements the creation, buffer-to-texture copies and texture-to-texture copies with BC formats on OpenGL backend. Note that OpenGL SPEC also has the same issue about texture-to-texture copies with compressed textures as Vulkan SPEC, so we have to skip the related case. The texture-to-buffer copies with BC formats and related end2end tests will be supported in the following patches. BUG=dawn:42 TEST=dawn_end2end_tests Change-Id: I76b16862259cb2df77f202ed7ed433d41aa3cd47 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10220 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-08-22 08:19:13 +00:00
"--supported-extensions",
rebase_path("src/dawn_native/opengl/supported_extensions.json",
root_build_dir),
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
]
outputs = [
Normalize generated file paths to match main tree. Previously dawn_native files were in src/dawn_native/ while generated files were in dawn_native/. This makes some things complicated when integrating in other source trees so normalize all generated files to be in paths that match the main tree. BUG=dawn:225 Change-Id: I5b3e04d37a16251143578dfb7a31445b229fe4ac Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11300 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-09-18 04:33:12 +00:00
"src/dawn_native/opengl/OpenGLFunctionsBase_autogen.cpp",
"src/dawn_native/opengl/OpenGLFunctionsBase_autogen.h",
"src/dawn_native/opengl/opengl_platform_autogen.h",
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
]
}
}
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
# Public libdawn_native headers so they can be publically visible for
# dependencies of libdawn_native
source_set("libdawn_native_headers") {
public_deps = [
Split generation of dawncpp headers from libdawncpp libdawn_native also requires the dawncpp headers. When we separated libdawn_cpp from the dawn_headers, libdawn_native lost the cpp headers and caused a compile failure. This patch separates the dawncpp headers as a separate target so both libdawncpp and libdawn_native can depend on them. Bug: dawn:22 Change-Id: I4172f1654377afac8c4314123ee8b5b81dc7c928 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12300 Reviewed-by: David Turner <digit@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-10-16 10:26:01 +00:00
"${dawn_root}/src/dawn:dawncpp_headers",
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
]
BUILD.gn: put public include dirs in all_dependent_configs The public include dirs for Dawn were in the dawn_public config but it would only be added to targets as a part of public_configs. This meant that second-level dependencies that ended up needing to include dawn/dawn.h wouldn't know where to find it. Fixed this by adding include dirs in all_dependent_configs and renamed the config to be very explicit that it is for include dirs only. BUG=chromium:938895 Change-Id: Iad70f3ce1f8a02b96bf341e7dd7d6068ce645af7 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5920 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-26 17:16:28 +00:00
all_dependent_configs = [ "${dawn_root}/src/common:dawn_public_include_dirs" ]
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
sources = [
"src/include/dawn_native/DawnNative.h",
"src/include/dawn_native/dawn_native_export.h",
# Include all backend's public headers so that dependencies can include
# them even when the backends are disabled.
"src/include/dawn_native/D3D12Backend.h",
"src/include/dawn_native/MetalBackend.h",
"src/include/dawn_native/NullBackend.h",
"src/include/dawn_native/OpenGLBackend.h",
"src/include/dawn_native/VulkanBackend.h",
]
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
# The meat of the compilation for libdawn_native so that we can cheaply have
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
# shared_library / static_library versions of it. It compiles all the files
# except those that define exported symbols.
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
source_set("libdawn_native_sources") {
deps = [
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
":libdawn_native_headers",
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
":libdawn_native_utils_gen",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
Validate SPIR-V code when creating ShaderModules This integrates spirv-val in dawn_native so that regular and WebGPU-specific validation of shaders is done. Also adds tests to check OpUndef is correctly rejected so we know WebGPU-specific validation is working. Change-Id: If49d276c98bca8cd3c6c1a420903fe34923a2942
2018-09-06 15:25:46 +00:00
"${dawn_spirv_tools_dir}:spvtools_val",
BUILD.gn: Move last third_party deps to third_party/BUILD.gn
2018-08-13 06:31:17 +00:00
"third_party:spirv_cross",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
configs += [ ":libdawn_native_internal" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
libs = []
Fix compilation of the OpenGL backend on Mac OpenGLBackend.cpp would end up including KHR/khrplatform.h when the libdawn_native target that contains it doesn't have a dependency on the khr_platform target. Fix this by making libdawn_native_sources expose some of its dependencies as public_deps. BUG= Change-Id: I45c05a064e4b73ab7ac6f5f6258e7983e5fc085d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9205 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2019-07-22 23:32:29 +00:00
# Dependencies that are needed to compile libdawn_native entry points in
# FooBackend.cpp need to be public deps so they are propagated to the
# libdawn_native target
Add dawn_platform::Platform for handling tracing events in Dawn This patch provides Chromium TRACE_EVENT macros and hooks for implementing the TRACE_EVENT api. Bug: chromium:958013 Change-Id: I033b1c7ca57c550504a1bea1898a1a152831922b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7060 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-13 19:00:34 +00:00
public_deps = [
":dawn_platform",
]
Fix compilation of the OpenGL backend on Mac OpenGLBackend.cpp would end up including KHR/khrplatform.h when the libdawn_native target that contains it doesn't have a dependency on the khr_platform target. Fix this by making libdawn_native_sources expose some of its dependencies as public_deps. BUG= Change-Id: I45c05a064e4b73ab7ac6f5f6258e7983e5fc085d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9205 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2019-07-22 23:32:29 +00:00
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
sources = get_target_outputs(":libdawn_native_utils_gen")
sources += [
dawn_native: Add Instance and Adapters New objects are introduced to control what happens before device creation in dawn_native: - Instance: a connection from the application to dawn_native that is used for dependency injection and to discover adapters. - Adapters: represents the possibility of device creation for a specific (GPU, backend) pair. - BackendConnection: an internal object that standardizes the interface between the frontend and backends. The BackendConnection interface is implemented for the Null backend and stubbed out in other backends. This allows this change to port the ValidationTests to use the new Instance and Adapters concept and deal with other backends later. BUG=dawn:29 Change-Id: I19719a9342b4af091accc0c02fb6b9697eadde7b Reviewed-on: https://dawn-review.googlesource.com/c/3500 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-04 10:30:40 +00:00
"src/dawn_native/Adapter.cpp",
"src/dawn_native/Adapter.h",
Deduplicate AttachmentState shared by RenderPipeline and RenderPasses This both deduplicates shared state by multiple passes or pipelines and makes checking pipeline compatibility a single pointer check. It will be useful for also checking RenderBundle compatibility. Bug: dawn:154 Change-Id: I0fb289fab5ac76a7fbd500f64b8a6409a246ab32 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9461 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-07-26 19:08:18 +00:00
"src/dawn_native/AttachmentState.cpp",
"src/dawn_native/AttachmentState.h",
dawn_native: Add Instance and Adapters New objects are introduced to control what happens before device creation in dawn_native: - Instance: a connection from the application to dawn_native that is used for dependency injection and to discover adapters. - Adapters: represents the possibility of device creation for a specific (GPU, backend) pair. - BackendConnection: an internal object that standardizes the interface between the frontend and backends. The BackendConnection interface is implemented for the Null backend and stubbed out in other backends. This allows this change to port the ValidationTests to use the new Instance and Adapters concept and deal with other backends later. BUG=dawn:29 Change-Id: I19719a9342b4af091accc0c02fb6b9697eadde7b Reviewed-on: https://dawn-review.googlesource.com/c/3500 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-04 10:30:40 +00:00
"src/dawn_native/BackendConnection.cpp",
"src/dawn_native/BackendConnection.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/BindGroup.cpp",
"src/dawn_native/BindGroup.h",
"src/dawn_native/BindGroupLayout.cpp",
"src/dawn_native/BindGroupLayout.h",
Support setting bind groups before pipeline for all backends This is to match WebGPU semantics. Bug: dawn:201 Change-Id: I2aab671fc389edf1d2765395814a9c831afc653e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11080 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-09-17 19:25:27 +00:00
"src/dawn_native/BindGroupTracker.h",
Resource Management 3: Buddy allocator Introduces the buddy system for fast power-of-two sub-allocation. BUG=dawn:27 Change-Id: I56836ae317ecc5a91d8341c843fc37d4f91fb5af Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9260 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-07-30 16:46:10 +00:00
"src/dawn_native/BuddyAllocator.cpp",
"src/dawn_native/BuddyAllocator.h",
Resource Management 7: Device memory sub-allocation using buddy allocator. Uses a large buddy system to allocate binary sized heaps on-demand. BUG=dawn:27 Change-Id: I72e425c23e601da6ee53827423bef7ff13be049c Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10880 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2019-10-03 18:17:31 +00:00
"src/dawn_native/BuddyMemoryAllocator.cpp",
"src/dawn_native/BuddyMemoryAllocator.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Buffer.cpp",
"src/dawn_native/Buffer.h",
"src/dawn_native/CommandAllocator.cpp",
"src/dawn_native/CommandAllocator.h",
"src/dawn_native/CommandBuffer.cpp",
"src/dawn_native/CommandBuffer.h",
"src/dawn_native/CommandBufferStateTracker.cpp",
"src/dawn_native/CommandBufferStateTracker.h",
WebGPU error handling 2: CommandEncoder for samples and end2end tests CommandEncoder is the replacement for CommandBufferBuilder. This commit adds the dawn.json definition for it and an initial implementation that wraps CommandBufferBuilder. This is done so that the code can be ported to CommandEncoder gradually, otherwise the commit would be too big and would risk many merge conflicts. This converts all samples and end2end tests to use CommandEncoder. BUG=dawn:8 Change-Id: If4ce86e6fb39ba4e0c2af6328d40e63be17d18c1 Reviewed-on: https://dawn-review.googlesource.com/c/4741 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-15 12:54:08 +00:00
"src/dawn_native/CommandEncoder.cpp",
"src/dawn_native/CommandEncoder.h",
Factor RenderPass command validation Validation of GPURenderBundle will share code with RenderPass validation. Factor validation of commands for GPURenderBundle into a separate function. Bug: dawn:154 Change-Id: I79a229592ead27d462da0dd2d12fbdb95443ff19 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9980 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-13 00:22:28 +00:00
"src/dawn_native/CommandValidation.cpp",
"src/dawn_native/CommandValidation.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Commands.cpp",
"src/dawn_native/Commands.h",
Introduce [Render|Compute]PassEncoder. This splits off part of CommandBufferBuilder in separate RenderPassEncoder and ComputePassEncoder objects. To match the WebGPU IDL and factor some code, both these encoders inherit from ProgrammablePassEncoder. These encoders are pure frontend objects and record into the CommandBufferBuilder command allocator objects, so no changes to the backends were needed. Error handling is still ew, because the "builder" mechanism we had doesn't allow for "split builders". Nicer error handling will have to wait on Dawn matching WebGPU. All the tests and samples were updated to the new structure. BUG=dawn:5 Change-Id: I5f5d4ad866e2c07fedd1ba7a122258c6610941f1 Reviewed-on: https://dawn-review.googlesource.com/1543 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-09-21 00:24:37 +00:00
"src/dawn_native/ComputePassEncoder.cpp",
"src/dawn_native/ComputePassEncoder.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/ComputePipeline.cpp",
"src/dawn_native/ComputePipeline.h",
"src/dawn_native/Device.cpp",
"src/dawn_native/Device.h",
Memory manager: buffer uploads (D3D) - Part 1 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: Ifc5a1b06baf8633f1e133245ac1ee76275431cc5 Reviewed-on: https://dawn-review.googlesource.com/c/3160 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-29 00:10:07 +00:00
"src/dawn_native/DynamicUploader.cpp",
"src/dawn_native/DynamicUploader.h",
Factor EncodingContext out of CommandEncoderBase. This patch factors the CommandAllocator, CommandIterator, and error handling out of CommandEncoderBase so it can later be used by the RenderBundleEncoder. Bug: dawn:154 Change-Id: Ia4f8c3ce7f432f0887b619bd8090aa9bec7330fc Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9181 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-07-24 18:15:24 +00:00
"src/dawn_native/EncodingContext.cpp",
"src/dawn_native/EncodingContext.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Error.cpp",
"src/dawn_native/Error.h",
"src/dawn_native/ErrorData.cpp",
"src/dawn_native/ErrorData.h",
Implement ErrorScopes for synchronous errors This patch implements Push/PopErrorScope except for asynchronous or GPU commands. These commands, such as Queue::Submit will need to hold onto the ErrorScope until GPU execution is complete. Bug: dawn:153 Change-Id: I2d340b8b391d117a59497f35690993a9cd7503e6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10700 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-09-10 23:19:11 +00:00
"src/dawn_native/ErrorScope.cpp",
"src/dawn_native/ErrorScope.h",
Support ErrorScopes for asynchronous GPU execution This changes updates ErrorScopes so that scopes enclosing a Queue::Submit or Queue::Signal resolve their callbacks asynchronously after GPU execution is complete. Bug: dawn:153 Change-Id: I0e0b8a9f19f3f29d1b6a3683938154b87f190a07 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10701 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-09-17 18:24:07 +00:00
"src/dawn_native/ErrorScopeTracker.cpp",
"src/dawn_native/ErrorScopeTracker.h",
Support BC formats as the first extension in Dawn This patch refactors the current implementation of BC formats to treat it as the first extension in Dawn and adds all the related tests. Note that in Dawn all the extensions are disabled unless we enable them when we create the device, which means the BC formats can only be used when we enable the related extension on the creation of the device, and the creation of the device will fail if the adapter does not support the extension BUG=dawn:42 TEST=dawn_end2end_tests TEST=dawn_unittests Change-Id: I04d818b0218ebb3b1b7a70a4fea71779f308f85f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9520 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-08-02 00:06:38 +00:00
"src/dawn_native/Extensions.cpp",
"src/dawn_native/Extensions.h",
Implement timeline fences in Dawn This change implements timeline fences in Dawn. It includes methods and descriptor members to eventually support multi-queue, but does not implement them. Bug: dawn:26 Change-Id: I81d5fee6acef402fe099227a034d9669a89ab6c3 Reviewed-on: https://dawn-review.googlesource.com/c/2460 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2018-12-03 16:57:34 +00:00
"src/dawn_native/Fence.cpp",
"src/dawn_native/Fence.h",
"src/dawn_native/FenceSignalTracker.cpp",
"src/dawn_native/FenceSignalTracker.h",
Precompute all the Formats at Device creation in the FormatTable This is needed for two reasons: - TextureBase and TextureViewBase stored Formats by value which isn't too much overhead at this time but will get bigger in the future. - The OpenGL backends needs its own GLFormat structure to store data about each format which will eventually contain complicated logic to detect support in the GL driver so it shouldn't be duplicated in Textures. The computations of the information about Format is moved from being done whenever they are needed to being precomputed at DeviceBase initialization. This makes each format have a constant "index" in that can be used in the backends to address their own structure, for example a GLFormat table. Also some DeviceBase pointers were made const for validation. BUG=dawn:128 Change-Id: I37d1e9c739b87cddcea09cb1759e175704d90f9e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9101 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-07-18 09:25:04 +00:00
"src/dawn_native/Format.cpp",
"src/dawn_native/Format.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Forward.h",
dawn_native: Add Instance and Adapters New objects are introduced to control what happens before device creation in dawn_native: - Instance: a connection from the application to dawn_native that is used for dependency injection and to discover adapters. - Adapters: represents the possibility of device creation for a specific (GPU, backend) pair. - BackendConnection: an internal object that standardizes the interface between the frontend and backends. The BackendConnection interface is implemented for the Null backend and stubbed out in other backends. This allows this change to port the ValidationTests to use the new Instance and Adapters concept and deal with other backends later. BUG=dawn:29 Change-Id: I19719a9342b4af091accc0c02fb6b9697eadde7b Reviewed-on: https://dawn-review.googlesource.com/c/3500 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-04 10:30:40 +00:00
"src/dawn_native/Instance.cpp",
"src/dawn_native/Instance.h",
Resource Management 7: Device memory sub-allocation using buddy allocator. Uses a large buddy system to allocate binary sized heaps on-demand. BUG=dawn:27 Change-Id: I72e425c23e601da6ee53827423bef7ff13be049c Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10880 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2019-10-03 18:17:31 +00:00
"src/dawn_native/MemoryAllocator.h",
Put the reference to DeviceBase in a new ObjectBase ObjectBase will contain data that all WebGPU objects have such as a pointer back to the device, a refcount (via inheriting from RefCounted), a name, an error status etc. BUG=dawn:24 Change-Id: I919e1a6d4a68811ceb6e503b2a793815c92f2528 Reviewed-on: https://dawn-review.googlesource.com/c/1620 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2018-10-15 12:54:30 +00:00
"src/dawn_native/ObjectBase.cpp",
"src/dawn_native/ObjectBase.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/PassResourceUsage.h",
Factor PassResourceUsageTracker to its own file GPURenderBundleEncoder and GPUCommandEncoder will need to share code for tracking resource usages. Bug: dawn:154 Change-Id: I0286f71c4c0638f89be2754c8e9691e67e5db335 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9700 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-08 17:21:39 +00:00
"src/dawn_native/PassResourceUsageTracker.cpp",
"src/dawn_native/PassResourceUsageTracker.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/PerStage.cpp",
"src/dawn_native/PerStage.h",
"src/dawn_native/Pipeline.cpp",
"src/dawn_native/Pipeline.h",
"src/dawn_native/PipelineLayout.cpp",
"src/dawn_native/PipelineLayout.h",
Introduce [Render|Compute]PassEncoder. This splits off part of CommandBufferBuilder in separate RenderPassEncoder and ComputePassEncoder objects. To match the WebGPU IDL and factor some code, both these encoders inherit from ProgrammablePassEncoder. These encoders are pure frontend objects and record into the CommandBufferBuilder command allocator objects, so no changes to the backends were needed. Error handling is still ew, because the "builder" mechanism we had doesn't allow for "split builders". Nicer error handling will have to wait on Dawn matching WebGPU. All the tests and samples were updated to the new structure. BUG=dawn:5 Change-Id: I5f5d4ad866e2c07fedd1ba7a122258c6610941f1 Reviewed-on: https://dawn-review.googlesource.com/1543 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-09-21 00:24:37 +00:00
"src/dawn_native/ProgrammablePassEncoder.cpp",
"src/dawn_native/ProgrammablePassEncoder.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Queue.cpp",
"src/dawn_native/Queue.h",
"src/dawn_native/RefCounted.cpp",
"src/dawn_native/RefCounted.h",
Implement RenderBundle in the frontend This CL implements RenderBundle and RenderBundleEncoder in the frontend and adds unittests for validation. Bug: dawn:154 Change-Id: Ice5ecd384cd627ad270b73052408f8139d1ea5f4 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9221 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-13 22:12:54 +00:00
"src/dawn_native/RenderBundle.cpp",
"src/dawn_native/RenderBundle.h",
"src/dawn_native/RenderBundleEncoder.cpp",
"src/dawn_native/RenderBundleEncoder.h",
Add RenderEncoderBase to match WebGPU class hierarchy. This is needed so that RenderBundleEncoder and RenderPassEncoder can share code. This patch also moves EndPass out of ProgrammablePassEncoder and into both RenderPassEncoder and ComputePassEncoder. Render bundles do not have EndPass. Bug: dawn:154 Change-Id: Ib7126b2ba718b0b93e3d6f15c429ac910c0d5d31 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9180 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-07-20 01:34:56 +00:00
"src/dawn_native/RenderEncoderBase.cpp",
"src/dawn_native/RenderEncoderBase.h",
Introduce [Render|Compute]PassEncoder. This splits off part of CommandBufferBuilder in separate RenderPassEncoder and ComputePassEncoder objects. To match the WebGPU IDL and factor some code, both these encoders inherit from ProgrammablePassEncoder. These encoders are pure frontend objects and record into the CommandBufferBuilder command allocator objects, so no changes to the backends were needed. Error handling is still ew, because the "builder" mechanism we had doesn't allow for "split builders". Nicer error handling will have to wait on Dawn matching WebGPU. All the tests and samples were updated to the new structure. BUG=dawn:5 Change-Id: I5f5d4ad866e2c07fedd1ba7a122258c6610941f1 Reviewed-on: https://dawn-review.googlesource.com/1543 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-09-21 00:24:37 +00:00
"src/dawn_native/RenderPassEncoder.cpp",
"src/dawn_native/RenderPassEncoder.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/RenderPipeline.cpp",
"src/dawn_native/RenderPipeline.h",
Resource Management 5: D3D support for resource allocation. Refactor existing resource allocators by adding a memory type and memory handle. BUG=dawn:27, dawn:153 Change-Id: I090b6ab40e7eaa0d7ea5ce1e8b760e961be9b559 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9420 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-27 23:36:26 +00:00
"src/dawn_native/ResourceHeap.h",
"src/dawn_native/ResourceMemoryAllocation.cpp",
"src/dawn_native/ResourceMemoryAllocation.h",
Remove device dependencies from ringbuffer. Allows ringbuffer sub-allocator to be used for non-staging memory. BUG=dawn:155 Change-Id: Id0021907f520909aaebaf79e992124a47797d38d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9760 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2019-09-18 22:06:41 +00:00
"src/dawn_native/RingBufferAllocator.cpp",
"src/dawn_native/RingBufferAllocator.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Sampler.cpp",
"src/dawn_native/Sampler.h",
"src/dawn_native/ShaderModule.cpp",
"src/dawn_native/ShaderModule.h",
Memory manager: buffer uploads (D3D) - Part 1 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: Ifc5a1b06baf8633f1e133245ac1ee76275431cc5 Reviewed-on: https://dawn-review.googlesource.com/c/3160 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-29 00:10:07 +00:00
"src/dawn_native/StagingBuffer.cpp",
"src/dawn_native/StagingBuffer.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/SwapChain.cpp",
"src/dawn_native/SwapChain.h",
"src/dawn_native/Texture.cpp",
"src/dawn_native/Texture.h",
"src/dawn_native/ToBackend.h",
Move all the implementations of Toggle to Toggles.cpp This patch moves all the code related to Toggle from Instance.cpp to Toggles.cpp to make the code in Instance.cpp cleaner. BUG=dawn:56 Change-Id: Ica2a779569478a58ddf21e632a211c0c5b889b00 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9580 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2019-07-30 23:58:52 +00:00
"src/dawn_native/Toggles.cpp",
Emulate store and multisample resolve on Metal This patch implements "store and MSAA resolve" store operation on Metal drivers that don't support MTLStoreActionStoreAndMultisampleResolve with a workaround that does MSAA resolve in another render pass. Driver workaround is one type of Dawn Toggles. Dawn Toggles will include other optional optimizations and features that can be configured to use or not when we create Dawn Devices. As all Metal try bots don't need this toggle, to better test this patch on the try bots: 1. We add the support of forcing enabling a workaround when starting an Dawn end2end test so that we can test the workaround on the platforms where the workaround is disabled. 2. We add an optional parameter DeviceDescriptor to CreateDevice() so that we can custom the toggles the Dawn device should use. This patch also adds the support of querying toggle details from Instance and the names of the toggles in use from Device. These APIs are tested in the Dawn unittests added in this patch. BUG=dawn:56 TEST=dawn_end2end_tests TEST=dawn_unittests Change-Id: Iae31d2ded6057eee638b6099d3061e9d78b04d55 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6620 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2019-04-26 07:52:57 +00:00
"src/dawn_native/Toggles.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/dawn_platform.h",
]
if (dawn_enable_d3d12) {
D3D12: Dynamically load D3D12, DXGI and D3DCompiler Linking against their .lib makes loading Dawn fail on systems that don't have the DLLs. This happens for example on Windows7 that doesn't have d3d12.dll. Instead we dynamically load functions pointers from these DLLs at d3d12::Device startup. Change-Id: I4d01a12d0f91bec45bf125450d2c08aaa9ff9fac
2018-08-30 12:20:28 +00:00
libs += [ "dxguid.lib" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
sources += [
D3D12: Implement the backend connection and adapter. BUG=dawn:29 Change-Id: Id4497b4a91ba58b79d1cd976a52df5a0fa5d60a8 Reviewed-on: https://dawn-review.googlesource.com/c/3844 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-30 16:07:48 +00:00
"src/dawn_native/d3d12/AdapterD3D12.cpp",
"src/dawn_native/d3d12/AdapterD3D12.h",
"src/dawn_native/d3d12/BackendD3D12.cpp",
"src/dawn_native/d3d12/BackendD3D12.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/BindGroupD3D12.cpp",
"src/dawn_native/d3d12/BindGroupD3D12.h",
"src/dawn_native/d3d12/BindGroupLayoutD3D12.cpp",
"src/dawn_native/d3d12/BindGroupLayoutD3D12.h",
"src/dawn_native/d3d12/BufferD3D12.cpp",
"src/dawn_native/d3d12/BufferD3D12.h",
"src/dawn_native/d3d12/CommandAllocatorManager.cpp",
"src/dawn_native/d3d12/CommandAllocatorManager.h",
"src/dawn_native/d3d12/CommandBufferD3D12.cpp",
"src/dawn_native/d3d12/CommandBufferD3D12.h",
Add CommandRecordingContext to D3D12 This change refactors D3D12 backend to have CommandRecordingContext CommandRecordingContext allows us to, in a future, add additional data to the context such as textures that need to be acquired and released before command lists are executed. The Device's pending command list and the command list which resides in the Queue object were converted to use CommandRecordingContext. Bug=dawn:234 Change-Id: Ic13a229fc1f15895ef71117ce638c942de224743 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11940 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-10 18:06:58 +00:00
"src/dawn_native/d3d12/CommandRecordingContext.cpp",
"src/dawn_native/d3d12/CommandRecordingContext.h",
Resource Management 5: D3D support for resource allocation. Refactor existing resource allocators by adding a memory type and memory handle. BUG=dawn:27, dawn:153 Change-Id: I090b6ab40e7eaa0d7ea5ce1e8b760e961be9b559 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9420 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-27 23:36:26 +00:00
"src/dawn_native/d3d12/CommittedResourceAllocatorD3D12.cpp",
"src/dawn_native/d3d12/CommittedResourceAllocatorD3D12.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/ComputePipelineD3D12.cpp",
"src/dawn_native/d3d12/ComputePipelineD3D12.h",
D3D12 replace ASSERT_SUCCESS with better error handling Added D3D12Error to check HRESULTS and return error messages with the correct error names. Remove ASSERT_SUCCESS from D3D12 backend and use MaybeError and ResultError instead to handle errors. Bug: dawn:19 Change-Id: Idf2f1987725e7e658bd29a9b13653125ab43c564 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12000 Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-10-16 09:26:54 +00:00
"src/dawn_native/d3d12/D3D12Error.cpp",
"src/dawn_native/d3d12/D3D12Error.h",
Improve D3D12 adapter initialization. Gather device info at device initialization rather than adapter initialization. BUG=dawn:144 Change-Id: I07e114731a37f3738daa585afa99675f2fd36289 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7700 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-06-12 18:54:57 +00:00
"src/dawn_native/d3d12/D3D12Info.cpp",
"src/dawn_native/d3d12/D3D12Info.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/DescriptorHeapAllocator.cpp",
"src/dawn_native/d3d12/DescriptorHeapAllocator.h",
"src/dawn_native/d3d12/DeviceD3D12.cpp",
"src/dawn_native/d3d12/DeviceD3D12.h",
"src/dawn_native/d3d12/Forward.h",
"src/dawn_native/d3d12/NativeSwapChainImplD3D12.cpp",
"src/dawn_native/d3d12/NativeSwapChainImplD3D12.h",
"src/dawn_native/d3d12/PipelineLayoutD3D12.cpp",
"src/dawn_native/d3d12/PipelineLayoutD3D12.h",
D3D12: Dynamically load D3D12, DXGI and D3DCompiler Linking against their .lib makes loading Dawn fail on systems that don't have the DLLs. This happens for example on Windows7 that doesn't have d3d12.dll. Instead we dynamically load functions pointers from these DLLs at d3d12::Device startup. Change-Id: I4d01a12d0f91bec45bf125450d2c08aaa9ff9fac
2018-08-30 12:20:28 +00:00
"src/dawn_native/d3d12/PlatformFunctions.cpp",
"src/dawn_native/d3d12/PlatformFunctions.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/QueueD3D12.cpp",
"src/dawn_native/d3d12/QueueD3D12.h",
"src/dawn_native/d3d12/RenderPipelineD3D12.cpp",
"src/dawn_native/d3d12/RenderPipelineD3D12.h",
"src/dawn_native/d3d12/ResourceAllocator.cpp",
"src/dawn_native/d3d12/ResourceAllocator.h",
D3D12: Move resource allocators from device into manager. Encapsulates resource allocation using a manager class. BUG=dawn:27 Change-Id: I7a496261dcede647d32e44d96ed27237bf418fb2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11742 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2019-10-02 21:45:09 +00:00
"src/dawn_native/d3d12/ResourceAllocatorManagerD3D12.cpp",
"src/dawn_native/d3d12/ResourceAllocatorManagerD3D12.h",
D3D12: Move resource into allocation handle. Allows buffer/texture direct access to underlying resource rather than indirectly with a opaque memory type. BUG=dawn:27 Change-Id: I2eb69f4e30c96c431dbc96094d671be1e0a29869 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11800 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2019-10-09 16:50:42 +00:00
"src/dawn_native/d3d12/ResourceHeapAllocationD3D12.cpp",
"src/dawn_native/d3d12/ResourceHeapAllocationD3D12.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/SamplerD3D12.cpp",
"src/dawn_native/d3d12/SamplerD3D12.h",
"src/dawn_native/d3d12/ShaderModuleD3D12.cpp",
"src/dawn_native/d3d12/ShaderModuleD3D12.h",
Memory manager: buffer uploads (D3D) - Part 1 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: Ifc5a1b06baf8633f1e133245ac1ee76275431cc5 Reviewed-on: https://dawn-review.googlesource.com/c/3160 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-29 00:10:07 +00:00
"src/dawn_native/d3d12/StagingBufferD3D12.cpp",
"src/dawn_native/d3d12/StagingBufferD3D12.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/SwapChainD3D12.cpp",
"src/dawn_native/d3d12/SwapChainD3D12.h",
"src/dawn_native/d3d12/TextureCopySplitter.cpp",
"src/dawn_native/d3d12/TextureCopySplitter.h",
"src/dawn_native/d3d12/TextureD3D12.cpp",
"src/dawn_native/d3d12/TextureD3D12.h",
Complete the sampler object to match WebGPU WebGPUSampler is much more complete than Dawn's Sampler. This patch implement the missing part. BUG=dawn:47 Change-Id: Ief45cb9710493e9d79ddab60fe3be5a123b76ebd Reviewed-on: https://dawn-review.googlesource.com/c/3540 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-04 04:56:08 +00:00
"src/dawn_native/d3d12/UtilsD3D12.cpp",
"src/dawn_native/d3d12/UtilsD3D12.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/d3d12_platform.h",
]
}
if (dawn_enable_metal) {
libs += [
"Metal.framework",
"Cocoa.framework",
Collect device information on Metal Becuase CGDisplayIOServicePort is deprecated in OSX >= 10.9, we create an alternative function which manually finding a service port with matching vendor and product IDs. BUG=dawn:10 TEST=dawn_end2end_tests Change-Id: I94ff65911e159c2b7075209d8902c1551560ed47 Reviewed-on: https://dawn-review.googlesource.com/c/2541 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2018-11-29 10:54:03 +00:00
"IOKit.framework",
Implement wrapping IOSurfaces in dawn::Texture. This allows wrapping IOSurfaces in a dawn::Texture so a Dawn application can sample from, or render to an IOSurface. It uses Metal's functionality for wrapping textures in MTLTexture. Support for single-plane BGRA8, RG8 and R8 IOSurfaces is added as well as tests for sampling and using BeginRenderPass to clear them. BUG=dawn:112 Change-Id: I367dbd1a75a0c7b81901fb0aae05f1cd46af3f3a Reviewed-on: https://dawn-review.googlesource.com/c/5101 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-03-01 12:01:18 +00:00
"IOSurface.framework",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
sources += [
Metal: Implement the backend connection and adapter. BUG=dawn:29 Change-Id: Idaca7d2f8ac52d5f46d8030571b5e2da3a573a97 Reviewed-on: https://dawn-review.googlesource.com/c/3940 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-05 13:02:30 +00:00
"src/dawn_native/metal/BackendMTL.h",
"src/dawn_native/metal/BackendMTL.mm",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/metal/BufferMTL.h",
"src/dawn_native/metal/BufferMTL.mm",
"src/dawn_native/metal/CommandBufferMTL.h",
"src/dawn_native/metal/CommandBufferMTL.mm",
"src/dawn_native/metal/ComputePipelineMTL.h",
"src/dawn_native/metal/ComputePipelineMTL.mm",
"src/dawn_native/metal/DeviceMTL.h",
"src/dawn_native/metal/DeviceMTL.mm",
"src/dawn_native/metal/Forward.h",
"src/dawn_native/metal/PipelineLayoutMTL.h",
"src/dawn_native/metal/PipelineLayoutMTL.mm",
"src/dawn_native/metal/QueueMTL.h",
"src/dawn_native/metal/QueueMTL.mm",
"src/dawn_native/metal/RenderPipelineMTL.h",
"src/dawn_native/metal/RenderPipelineMTL.mm",
"src/dawn_native/metal/SamplerMTL.h",
"src/dawn_native/metal/SamplerMTL.mm",
"src/dawn_native/metal/ShaderModuleMTL.h",
"src/dawn_native/metal/ShaderModuleMTL.mm",
Memory manager: buffer uploads (Metal+refactor) - Part 3 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: If4d3e717186895b1409502c1dea5ab751a4776b2 Reviewed-on: https://dawn-review.googlesource.com/c/4440 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2019-02-15 21:18:40 +00:00
"src/dawn_native/metal/StagingBufferMTL.h",
"src/dawn_native/metal/StagingBufferMTL.mm",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/metal/SwapChainMTL.h",
"src/dawn_native/metal/SwapChainMTL.mm",
"src/dawn_native/metal/TextureMTL.h",
"src/dawn_native/metal/TextureMTL.mm",
Complete the sampler object to match WebGPU WebGPUSampler is much more complete than Dawn's Sampler. This patch implement the missing part. BUG=dawn:47 Change-Id: Ief45cb9710493e9d79ddab60fe3be5a123b76ebd Reviewed-on: https://dawn-review.googlesource.com/c/3540 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-04 04:56:08 +00:00
"src/dawn_native/metal/UtilsMetal.h",
"src/dawn_native/metal/UtilsMetal.mm",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
if (dawn_enable_null) {
sources += [
dawn_native: define exported functions in their own files. This adds a new FooBackend.cpp file for each backend that defines exactly the symbols that are exported by libdawn_native's headers. THis will allow factoring most of the compilation of dawn_native between the shared and static library variants. BUG=dawn:85 Change-Id: I69c808dac2fe5e8bb08356117e3997677787b08a Reviewed-on: https://dawn-review.googlesource.com/c/3760 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 08:35:16 +00:00
"src/dawn_native/null/DeviceNull.cpp",
"src/dawn_native/null/DeviceNull.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
if (dawn_enable_opengl) {
Fix compilation of the OpenGL backend on Mac OpenGLBackend.cpp would end up including KHR/khrplatform.h when the libdawn_native target that contains it doesn't have a dependency on the khr_platform target. Fix this by making libdawn_native_sources expose some of its dependencies as public_deps. BUG= Change-Id: I45c05a064e4b73ab7ac6f5f6258e7983e5fc085d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9205 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2019-07-22 23:32:29 +00:00
public_deps += [
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
":libdawn_native_opengl_loader_gen",
Remove glad and replace it with our own GL header This completely removes the dependency on glad by generating the GL headers from gl.xml directly. This requires adding khrplatform.h so all Khronos dependencies are gathered in third_party/khronos. Also removes a stray CMakeLists.txt that was still hanging out. BUG=dawn:165 Change-Id: Ia64bc51bc8b18c6b48613918e2f309f7405ecb3b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8163 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-17 09:17:29 +00:00
"third_party:khronos_platform",
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
]
sources += get_target_outputs(":libdawn_native_opengl_loader_gen")
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
sources += [
OpenGL: Implement the backend connection and adapter. The OpenGL backend can't gather discover default adapters because it needs getProc to do anything so we add DiscoverAdapters method to Instance that takes backend-specific options. dawn_native::opengl::CreateDevice is removed in favor of the adapter path so OpenGLBinding is modified to create an instance locally. This is only temporary until all backends support adapters, at which point a lot of *Binding code will be factored. Also contains a small fix for Result<T, E> with movable types. BUG=dawn:29 Change-Id: I4eb3d4a14a871af73e1872132aff72b45e5fe566 Reviewed-on: https://dawn-review.googlesource.com/c/3663 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-07 09:48:03 +00:00
"src/dawn_native/opengl/BackendGL.cpp",
"src/dawn_native/opengl/BackendGL.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/opengl/BufferGL.cpp",
"src/dawn_native/opengl/BufferGL.h",
"src/dawn_native/opengl/CommandBufferGL.cpp",
"src/dawn_native/opengl/CommandBufferGL.h",
"src/dawn_native/opengl/ComputePipelineGL.cpp",
"src/dawn_native/opengl/ComputePipelineGL.h",
"src/dawn_native/opengl/DeviceGL.cpp",
"src/dawn_native/opengl/DeviceGL.h",
"src/dawn_native/opengl/Forward.h",
Introduce a format table in the OpenGL The information about formats in OpenGL will grow to include more information than just (internalFormat, format, type) and will gain more logic to depend on GL version and available extensions over time. BUG=dawn:128 Change-Id: I63a6ac7d48797fb4a9f97a65871306e640cf41d6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9201 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-07-23 06:40:54 +00:00
"src/dawn_native/opengl/GLFormat.cpp",
"src/dawn_native/opengl/GLFormat.h",
Remove OpenGLBinding's dependency on glad This move all the OpenGL-specific code for swapchain handling in a new NativeSwapChainImpl in the OpenGL backend so no code outside of dawn_native needs OpenGL. BUG=dawn:165 Change-Id: I3c0c1055e3215a59fdc8e9550baf30762a7014b5 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8161 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-06-17 09:01:09 +00:00
"src/dawn_native/opengl/NativeSwapChainImplGL.cpp",
"src/dawn_native/opengl/NativeSwapChainImplGL.h",
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
"src/dawn_native/opengl/OpenGLFunctions.cpp",
"src/dawn_native/opengl/OpenGLFunctions.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/opengl/PersistentPipelineStateGL.cpp",
"src/dawn_native/opengl/PersistentPipelineStateGL.h",
"src/dawn_native/opengl/PipelineGL.cpp",
"src/dawn_native/opengl/PipelineGL.h",
"src/dawn_native/opengl/PipelineLayoutGL.cpp",
"src/dawn_native/opengl/PipelineLayoutGL.h",
"src/dawn_native/opengl/QueueGL.cpp",
"src/dawn_native/opengl/QueueGL.h",
"src/dawn_native/opengl/RenderPipelineGL.cpp",
"src/dawn_native/opengl/RenderPipelineGL.h",
"src/dawn_native/opengl/SamplerGL.cpp",
"src/dawn_native/opengl/SamplerGL.h",
"src/dawn_native/opengl/ShaderModuleGL.cpp",
"src/dawn_native/opengl/ShaderModuleGL.h",
"src/dawn_native/opengl/SwapChainGL.cpp",
"src/dawn_native/opengl/SwapChainGL.h",
"src/dawn_native/opengl/TextureGL.cpp",
"src/dawn_native/opengl/TextureGL.h",
Complete the sampler object to match WebGPU WebGPUSampler is much more complete than Dawn's Sampler. This patch implement the missing part. BUG=dawn:47 Change-Id: Ief45cb9710493e9d79ddab60fe3be5a123b76ebd Reviewed-on: https://dawn-review.googlesource.com/c/3540 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-04 04:56:08 +00:00
"src/dawn_native/opengl/UtilsGL.cpp",
"src/dawn_native/opengl/UtilsGL.h",
Remove glad and replace it with our own GL header This completely removes the dependency on glad by generating the GL headers from gl.xml directly. This requires adding khrplatform.h so all Khronos dependencies are gathered in third_party/khronos. Also removes a stray CMakeLists.txt that was still hanging out. BUG=dawn:165 Change-Id: Ia64bc51bc8b18c6b48613918e2f309f7405ecb3b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8163 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-17 09:17:29 +00:00
"src/dawn_native/opengl/opengl_platform.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
if (dawn_enable_vulkan) {
Fix compilation of the OpenGL backend on Mac OpenGLBackend.cpp would end up including KHR/khrplatform.h when the libdawn_native target that contains it doesn't have a dependency on the khr_platform target. Fix this by making libdawn_native_sources expose some of its dependencies as public_deps. BUG= Change-Id: I45c05a064e4b73ab7ac6f5f6258e7983e5fc085d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9205 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2019-07-22 23:32:29 +00:00
public_deps += [ "third_party:vulkan_headers" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
sources += [
Vulkan: Implement the backend connection and adapter. This also changes VulkanInfo to gather info on backends / adapters instead of the device, because all the info gathering can happen before the device is created. BUG=dawn:29 Change-Id: I9dc4412f494428f1ae589544d3adf76fe8b9a3a3 Reviewed-on: https://dawn-review.googlesource.com/c/3941 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-04 09:31:09 +00:00
"src/dawn_native/vulkan/AdapterVk.cpp",
"src/dawn_native/vulkan/AdapterVk.h",
"src/dawn_native/vulkan/BackendVk.cpp",
"src/dawn_native/vulkan/BackendVk.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/vulkan/BindGroupLayoutVk.cpp",
"src/dawn_native/vulkan/BindGroupLayoutVk.h",
"src/dawn_native/vulkan/BindGroupVk.cpp",
"src/dawn_native/vulkan/BindGroupVk.h",
"src/dawn_native/vulkan/BufferVk.cpp",
"src/dawn_native/vulkan/BufferVk.h",
"src/dawn_native/vulkan/CommandBufferVk.cpp",
"src/dawn_native/vulkan/CommandBufferVk.h",
Normalize generated file paths to match main tree. Previously dawn_native files were in src/dawn_native/ while generated files were in dawn_native/. This makes some things complicated when integrating in other source trees so normalize all generated files to be in paths that match the main tree. BUG=dawn:225 Change-Id: I5b3e04d37a16251143578dfb7a31445b229fe4ac Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11300 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-09-18 04:33:12 +00:00
"src/dawn_native/vulkan/CommandRecordingContext.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/vulkan/ComputePipelineVk.cpp",
"src/dawn_native/vulkan/ComputePipelineVk.h",
"src/dawn_native/vulkan/DeviceVk.cpp",
"src/dawn_native/vulkan/DeviceVk.h",
Add wrapping for using external vulkan images as textures This change adds platform-dependent services that handle creating semaphores and importing image memory. Then, we use them to wrap a texture from an outside source, and release a signal semaphore back when we're done with it. This will be used to allow chrome to render dawn on Vulkan platforms. Bug: chromium:976495 Change-Id: I9f07eaf436e10aa6bd88cffdc74fd23834d62ee0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8340 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-10 03:17:52 +00:00
"src/dawn_native/vulkan/ExternalHandle.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/vulkan/FencedDeleter.cpp",
"src/dawn_native/vulkan/FencedDeleter.h",
"src/dawn_native/vulkan/Forward.h",
"src/dawn_native/vulkan/MemoryAllocator.cpp",
"src/dawn_native/vulkan/MemoryAllocator.h",
Resource Management 6: VK support for resource allocation. Refactor existing memory allocators by using a common memory type and handle. BUG=dawn:27 Change-Id: Ieed4fa30a0bd8fedfb3a3c580920805f40b56fae Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10680 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2019-09-05 17:36:47 +00:00
"src/dawn_native/vulkan/MemoryResourceAllocatorVk.cpp",
"src/dawn_native/vulkan/MemoryResourceAllocatorVk.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/vulkan/NativeSwapChainImplVk.cpp",
"src/dawn_native/vulkan/NativeSwapChainImplVk.h",
"src/dawn_native/vulkan/PipelineLayoutVk.cpp",
"src/dawn_native/vulkan/PipelineLayoutVk.h",
"src/dawn_native/vulkan/QueueVk.cpp",
"src/dawn_native/vulkan/QueueVk.h",
"src/dawn_native/vulkan/RenderPassCache.cpp",
"src/dawn_native/vulkan/RenderPassCache.h",
"src/dawn_native/vulkan/RenderPipelineVk.cpp",
"src/dawn_native/vulkan/RenderPipelineVk.h",
Resource Management 6: VK support for resource allocation. Refactor existing memory allocators by using a common memory type and handle. BUG=dawn:27 Change-Id: Ieed4fa30a0bd8fedfb3a3c580920805f40b56fae Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10680 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2019-09-05 17:36:47 +00:00
"src/dawn_native/vulkan/ResourceMemoryVk.cpp",
"src/dawn_native/vulkan/ResourceMemoryVk.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/vulkan/SamplerVk.cpp",
"src/dawn_native/vulkan/SamplerVk.h",
"src/dawn_native/vulkan/ShaderModuleVk.cpp",
"src/dawn_native/vulkan/ShaderModuleVk.h",
Memory manager: buffer uploads (Vulkan) - Part 2 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: Ic2a5df3142fc24fa772b9a85b38248eea8c7e003 Reviewed-on: https://dawn-review.googlesource.com/c/4260 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-02-06 18:10:12 +00:00
"src/dawn_native/vulkan/StagingBufferVk.cpp",
"src/dawn_native/vulkan/StagingBufferVk.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/vulkan/SwapChainVk.cpp",
"src/dawn_native/vulkan/SwapChainVk.h",
"src/dawn_native/vulkan/TextureVk.cpp",
"src/dawn_native/vulkan/TextureVk.h",
Complete the sampler object to match WebGPU WebGPUSampler is much more complete than Dawn's Sampler. This patch implement the missing part. BUG=dawn:47 Change-Id: Ief45cb9710493e9d79ddab60fe3be5a123b76ebd Reviewed-on: https://dawn-review.googlesource.com/c/3540 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-04 04:56:08 +00:00
"src/dawn_native/vulkan/UtilsVulkan.cpp",
"src/dawn_native/vulkan/UtilsVulkan.h",
Vulkan: Print the VkResult value on device creation failure. This adds a CheckVkSuccess utility function that adds the VkResult value to the context lost error message. Also adds a small fix to dawn_native/Error.h interoperability between MaybeError and ResultOrError<NonPointer> with tests. BUG=chromium:917555 BUG=dawn:79 Change-Id: Icc01122d62d83693fc0ea3f26b272f2372fd3087 Reviewed-on: https://dawn-review.googlesource.com/c/3623 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-04 10:18:40 +00:00
"src/dawn_native/vulkan/VulkanError.cpp",
"src/dawn_native/vulkan/VulkanError.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/vulkan/VulkanFunctions.cpp",
"src/dawn_native/vulkan/VulkanFunctions.h",
"src/dawn_native/vulkan/VulkanInfo.cpp",
"src/dawn_native/vulkan/VulkanInfo.h",
Add wrapping for using external vulkan images as textures This change adds platform-dependent services that handle creating semaphores and importing image memory. Then, we use them to wrap a texture from an outside source, and release a signal semaphore back when we're done with it. This will be used to allow chrome to render dawn on Vulkan platforms. Bug: chromium:976495 Change-Id: I9f07eaf436e10aa6bd88cffdc74fd23834d62ee0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8340 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-10 03:17:52 +00:00
"src/dawn_native/vulkan/external_memory/MemoryService.h",
"src/dawn_native/vulkan/external_semaphore/SemaphoreService.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
Add wrapping for using external vulkan images as textures This change adds platform-dependent services that handle creating semaphores and importing image memory. Then, we use them to wrap a texture from an outside source, and release a signal semaphore back when we're done with it. This will be used to allow chrome to render dawn on Vulkan platforms. Bug: chromium:976495 Change-Id: I9f07eaf436e10aa6bd88cffdc74fd23834d62ee0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8340 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-10 03:17:52 +00:00
if (is_linux) {
sources += [
"src/dawn_native/vulkan/external_memory/MemoryServiceOpaqueFD.cpp",
"src/dawn_native/vulkan/external_semaphore/SemaphoreServiceOpaqueFD.cpp",
]
[fuchsia] Implement external semaphore and memory support. This CL adds Fuchsia-specific implementations to the following classes: dawn_native::vulkan::external_memory::Service dawn_native::vulkan::external_semaphore::Service The implementation is based on two Fuchsia Vulkan extensions that are provides by the vulkan_fuchsia_extras.h header (i.e. are not upstreamed to Khronos yet, but used/provided by the Fuchsia platform): VK_FUCHSIA_external_memory VK_FUCHSIA_external_semaphore Their details are similar to VK_KHR_external_XXXX_fd, but uses Zircon handles instead of file decriptors. BUG=dawn:221 Change-Id: I48238bcf3193433970cbe200a84b86a67103a2f2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10963 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: David Turner <digit@google.com>
2019-09-10 10:07:28 +00:00
} else if (is_fuchsia) {
sources += [
"src/dawn_native/vulkan/external_memory/MemoryServiceZirconHandle.cpp",
"src/dawn_native/vulkan/external_semaphore/SemaphoreServiceZirconHandle.cpp",
]
Add wrapping for using external vulkan images as textures This change adds platform-dependent services that handle creating semaphores and importing image memory. Then, we use them to wrap a texture from an outside source, and release a signal semaphore back when we're done with it. This will be used to allow chrome to render dawn on Vulkan platforms. Bug: chromium:976495 Change-Id: I9f07eaf436e10aa6bd88cffdc74fd23834d62ee0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8340 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-10 03:17:52 +00:00
} else {
sources += [
"src/dawn_native/vulkan/external_memory/MemoryServiceNull.cpp",
"src/dawn_native/vulkan/external_semaphore/SemaphoreServiceNull.cpp",
]
}
Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
if (build_with_chromium && is_fuchsia) {
# Necessary to ensure that the Vulkan libraries will be in the
# final Fuchsia package.
data_deps = [
# NOTE: The line below is a work around for http://crbug.com/1001081
"//third_party/fuchsia-sdk/sdk:trace_engine",
"//third_party/fuchsia-sdk:vulkan_base",
"//third_party/fuchsia-sdk:vulkan_validation",
]
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
}
}
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
# The static and shared libraries for libdawn_native. Most of the files are
# already compiled in libdawn_native_sources, but we still need to compile
# files defining exported symbols.
BUILD.gn: Change the static/shared library template to component This changes the dawn_static_and_shared_library template to be a dawn_component template that mimics the behavior of Chromium's components. This helps avoid issues where on non-component builds on Windows the CRT would get linked statically in both the Dawn shared libraries and the test executables, causing alloc/deallocs across library boundaries to crash. BUG=dawn:29 Change-Id: I69287a523cc0bf5f2e921982ea9c26dcfed82f11 Reviewed-on: https://dawn-review.googlesource.com/c/4040 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-25 03:20:20 +00:00
dawn_component("libdawn_native") {
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
DEFINE_PREFIX = "DAWN_NATIVE"
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
#Make headers publically visible
public_deps = [
":libdawn_native_headers",
]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
deps = [
Add wire_cmd.py and dawn_wire.json to autogenerate all wire commands. Unify code generation for Client->Server and Server->Client commands. Methods in dawn.json are converted into command records and additional commands are specified in dawn_wire.json. This can then be used to completely generate the command handlers and command struct definitions. Bug: dawn:88 Change-Id: Ic796796ede0aafe02e14f1f96790324dad92f4c0 Reviewed-on: https://dawn-review.googlesource.com/c/3800 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-15 20:49:53 +00:00
":libdawn_native_sources",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
]
sources = [
"src/dawn_native/DawnNative.cpp",
]
configs = [ ":libdawn_native_internal" ]
if (dawn_enable_d3d12) {
sources += [ "src/dawn_native/d3d12/D3D12Backend.cpp" ]
}
if (dawn_enable_metal) {
sources += [ "src/dawn_native/metal/MetalBackend.mm" ]
}
if (dawn_enable_null) {
sources += [ "src/dawn_native/null/NullBackend.cpp" ]
}
if (dawn_enable_opengl) {
sources += [ "src/dawn_native/opengl/OpenGLBackend.cpp" ]
}
if (dawn_enable_vulkan) {
sources += [ "src/dawn_native/vulkan/VulkanBackend.cpp" ]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
}
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
###############################################################################
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
# libdawn_wire
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
###############################################################################
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
Generators: main.py is now dawn_json_generator.py This merges all the files for main.py together again except generator_lib.py because there doesn't seeem to be a good way to separate the pure dawn.json generators and the dawn wire generator. Also updates the GN templates to make it easier to define new generators based on generator_lib, and move the Jinja2 template "stdlib" to generator_lib.py BUG=dawn:165 Change-Id: I1b5b2ef0a59cb142e214f3af9a58048a88ae949a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7880 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-06-11 18:03:05 +00:00
dawn_json_generator("libdawn_wire_gen") {
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
target = "dawn_wire"
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
outputs = [
Normalize generated file paths to match main tree. Previously dawn_native files were in src/dawn_native/ while generated files were in dawn_native/. This makes some things complicated when integrating in other source trees so normalize all generated files to be in paths that match the main tree. BUG=dawn:225 Change-Id: I5b3e04d37a16251143578dfb7a31445b229fe4ac Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11300 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-09-18 04:33:12 +00:00
"src/dawn_wire/WireCmd_autogen.h",
"src/dawn_wire/WireCmd_autogen.cpp",
"src/dawn_wire/client/ApiObjects_autogen.h",
"src/dawn_wire/client/ApiProcs_autogen.cpp",
"src/dawn_wire/client/ApiProcs_autogen.h",
"src/dawn_wire/client/ClientBase_autogen.h",
"src/dawn_wire/client/ClientHandlers_autogen.cpp",
"src/dawn_wire/client/ClientPrototypes_autogen.inc",
"src/dawn_wire/server/ServerBase_autogen.h",
"src/dawn_wire/server/ServerDoers_autogen.cpp",
"src/dawn_wire/server/ServerHandlers_autogen.cpp",
"src/dawn_wire/server/ServerPrototypes_autogen.inc",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
BUILD.gn: Change the static/shared library template to component This changes the dawn_static_and_shared_library template to be a dawn_component template that mimics the behavior of Chromium's components. This helps avoid issues where on non-component builds on Windows the CRT would get linked statically in both the Dawn shared libraries and the test executables, causing alloc/deallocs across library boundaries to crash. BUG=dawn:29 Change-Id: I69287a523cc0bf5f2e921982ea9c26dcfed82f11 Reviewed-on: https://dawn-review.googlesource.com/c/4040 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-25 03:20:20 +00:00
dawn_component("libdawn_wire") {
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
DEFINE_PREFIX = "DAWN_WIRE"
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
deps = [
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
":libdawn_wire_gen",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
Split off libdawn_wire_headers from BUILD.gn These need to be separated from the main BUILD.gn as well. They cannot be easily guarded behind build flags in Chromium because the WebGPUImplementation will extend dawn_wire::CommandSerializer. Bug: dawn:61 Change-Id: Ic7d6bb13cc535ecddb99c832407ba1f37019ed93 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5401 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-03-08 00:51:27 +00:00
"${dawn_root}/src/dawn_wire:libdawn_wire_headers",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
configs = [ "${dawn_root}/src/common:dawn_internal" ]
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
sources = get_target_outputs(":libdawn_wire_gen")
Add wire_cmd.py and dawn_wire.json to autogenerate all wire commands. Unify code generation for Client->Server and Server->Client commands. Methods in dawn.json are converted into command records and additional commands are specified in dawn_wire.json. This can then be used to completely generate the command handlers and command struct definitions. Bug: dawn:88 Change-Id: Ic796796ede0aafe02e14f1f96790324dad92f4c0 Reviewed-on: https://dawn-review.googlesource.com/c/3800 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-15 20:49:53 +00:00
sources += [
Create wire Client and Server classes with private impl This creates proper Client and Server interfaces which will be necessary for adding additional features to the Wire for chrome integration Bug: dawn:103 Change-Id: I181e95079b0bac85c2c6152ad8066a94b80c8d28 Reviewed-on: https://dawn-review.googlesource.com/c/4002 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-11 21:50:16 +00:00
"src/dawn_wire/WireClient.cpp",
Add wire_cmd.py and dawn_wire.json to autogenerate all wire commands. Unify code generation for Client->Server and Server->Client commands. Methods in dawn.json are converted into command records and additional commands are specified in dawn_wire.json. This can then be used to completely generate the command handlers and command struct definitions. Bug: dawn:88 Change-Id: Ic796796ede0aafe02e14f1f96790324dad92f4c0 Reviewed-on: https://dawn-review.googlesource.com/c/3800 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-15 20:49:53 +00:00
"src/dawn_wire/WireDeserializeAllocator.cpp",
"src/dawn_wire/WireDeserializeAllocator.h",
Create wire Client and Server classes with private impl This creates proper Client and Server interfaces which will be necessary for adding additional features to the Wire for chrome integration Bug: dawn:103 Change-Id: I181e95079b0bac85c2c6152ad8066a94b80c8d28 Reviewed-on: https://dawn-review.googlesource.com/c/4002 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-11 21:50:16 +00:00
"src/dawn_wire/WireServer.cpp",
Separate WireClient.cpp into multiple files. This patch copies methods and classes from WireClient.cpp and distributes them over multiple files. Headers and forward declarations are added as necessary, but no logical changes are made. Bug: dawn:88 Change-Id: I9d0fcaeb67e789c3ad0597eaa3839adefc3ac5f9 Reviewed-on: https://dawn-review.googlesource.com/c/3980 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-01-16 02:18:06 +00:00
"src/dawn_wire/client/ApiObjects.h",
"src/dawn_wire/client/ApiProcs.cpp",
"src/dawn_wire/client/Buffer.cpp",
"src/dawn_wire/client/Buffer.h",
"src/dawn_wire/client/Client.cpp",
"src/dawn_wire/client/Client.h",
Factor wire client handlers into proper command handlers and doers Bug: dawn:88 Change-Id: I3ab28efad7edc7d06f11aa5abae07a1bb3d7e59e Reviewed-on: https://dawn-review.googlesource.com/c/4003 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-30 03:00:17 +00:00
"src/dawn_wire/client/ClientDoers.cpp",
Add MemoryTransfer interfaces to the wire This patch adds MemoryTransfer client/server interfaces and uses it to implement data transfers for buffer mapping. This patch also provides a default "inline" implementation of the MemoryTransfer which is used if the embedder does not provide one on initialization. Because implementations of MemoryTransfer perform their own serialization, a skip_serialize option is added to WireCmd records. Bug: dawn:156 Change-Id: I2fa035517628a3ad465b0bc18a6ffc477e2bd67f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8642 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-07-19 16:01:48 +00:00
"src/dawn_wire/client/ClientInlineMemoryTransferService.cpp",
Make the wire Client own ObjectAllocators and CommandSerializer This moves ownership of ObjectAllocators and CommandSerializers from the Device to the Client. There may be also be multiple Devices, so New() now takes the Device the object belongs to. Device allocation specializes New() to take the owning Client so that we can get a pointer to the Client from any Dawn API object. Bug: dawn:88 Change-Id: Ie4274d46313884c44a857159e95d236dc1141c0c Reviewed-on: https://dawn-review.googlesource.com/c/4001 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-30 02:31:37 +00:00
"src/dawn_wire/client/Device.cpp",
"src/dawn_wire/client/Device.h",
Separate WireClient.cpp into multiple files. This patch copies methods and classes from WireClient.cpp and distributes them over multiple files. Headers and forward declarations are added as necessary, but no logical changes are made. Bug: dawn:88 Change-Id: I9d0fcaeb67e789c3ad0597eaa3839adefc3ac5f9 Reviewed-on: https://dawn-review.googlesource.com/c/3980 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-01-16 02:18:06 +00:00
"src/dawn_wire/client/Fence.cpp",
"src/dawn_wire/client/Fence.h",
"src/dawn_wire/client/ObjectAllocator.h",
Separate WireServer.cpp into multiple files. This patch copies methods and classes from WireServer.cpp and distributes them over multiple files. Headers and forward declarations are added as necessary, but no functional changes are made. Bug: dawn:88 Change-Id: I471b8c27804916257eff266a51d087ba1ddbfeb6 Reviewed-on: https://dawn-review.googlesource.com/c/4000 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-01-30 02:20:58 +00:00
"src/dawn_wire/server/ObjectStorage.h",
"src/dawn_wire/server/Server.cpp",
"src/dawn_wire/server/Server.h",
"src/dawn_wire/server/ServerBuffer.cpp",
"src/dawn_wire/server/ServerDevice.cpp",
"src/dawn_wire/server/ServerFence.cpp",
Add MemoryTransfer interfaces to the wire This patch adds MemoryTransfer client/server interfaces and uses it to implement data transfers for buffer mapping. This patch also provides a default "inline" implementation of the MemoryTransfer which is used if the embedder does not provide one on initialization. Because implementations of MemoryTransfer perform their own serialization, a skip_serialize option is added to WireCmd records. Bug: dawn:156 Change-Id: I2fa035517628a3ad465b0bc18a6ffc477e2bd67f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8642 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-07-19 16:01:48 +00:00
"src/dawn_wire/server/ServerInlineMemoryTransferService.cpp",
Separate WireServer.cpp into multiple files. This patch copies methods and classes from WireServer.cpp and distributes them over multiple files. Headers and forward declarations are added as necessary, but no functional changes are made. Bug: dawn:88 Change-Id: I471b8c27804916257eff266a51d087ba1ddbfeb6 Reviewed-on: https://dawn-review.googlesource.com/c/4000 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-01-30 02:20:58 +00:00
"src/dawn_wire/server/ServerQueue.cpp",
Add wire_cmd.py and dawn_wire.json to autogenerate all wire commands. Unify code generation for Client->Server and Server->Client commands. Methods in dawn.json are converted into command records and additional commands are specified in dawn_wire.json. This can then be used to completely generate the command handlers and command struct definitions. Bug: dawn:88 Change-Id: Ic796796ede0aafe02e14f1f96790324dad92f4c0 Reviewed-on: https://dawn-review.googlesource.com/c/3800 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-15 20:49:53 +00:00
]
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
# Make headers publically visible
public_deps = [
Split off libdawn_wire_headers from BUILD.gn These need to be separated from the main BUILD.gn as well. They cannot be easily guarded behind build flags in Chromium because the WebGPUImplementation will extend dawn_wire::CommandSerializer. Bug: dawn:61 Change-Id: Ic7d6bb13cc535ecddb99c832407ba1f37019ed93 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5401 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-03-08 00:51:27 +00:00
"${dawn_root}/src/dawn_wire:libdawn_wire_headers",
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
}
Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
###############################################################################
# GLFW wrapping target
###############################################################################
BUILD.gn: Only expose the GLFW target on platforms that support it Due to the way GN target discovery works, glfw would get discovered in Fuchsia / Android / ChromeOS builds when it isn't supported causing compilation failures. This changes third_party/BUILD.gn so that glfw targets are only created on supported platforms. It also changes dawn_glfw in BUILD.gn to be more robust to building on all platforms. Bug=dawn:221 BUG=chromium:1002895 Change-Id: I8f40b06f680094406d24e9a6dea44b128e59b854 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11160 Reviewed-by: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-09-11 16:53:46 +00:00
# GLFW does not support ChromeOS, Android or Fuchsia, so provide a small mock
# library that can be linked into the Dawn tests on these platforms. Otherwise,
# use the real library from third_party/.
BUILD.gn: Correctly skip GLFW on ChromeOS ChromeOS has is_linux = true so the code to skip compiling GLFW on ChromeOS didn't work correctly. BUG=dawn:221 BUG=chromium:1002895 Change-Id: Ifbf8527407ad20b4368531da1d7653ce620d37be Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11200 Reviewed-by: Mitsuru Oshima <oshima@google.com> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@google.com> Commit-Queue: Austin Eng <enga@chromium.org>
2019-09-12 16:33:31 +00:00
if (is_win || (is_linux && !is_chromeos) || is_mac) {
BUILD.gn: Only expose the GLFW target on platforms that support it Due to the way GN target discovery works, glfw would get discovered in Fuchsia / Android / ChromeOS builds when it isn't supported causing compilation failures. This changes third_party/BUILD.gn so that glfw targets are only created on supported platforms. It also changes dawn_glfw in BUILD.gn to be more robust to building on all platforms. Bug=dawn:221 BUG=chromium:1002895 Change-Id: I8f40b06f680094406d24e9a6dea44b128e59b854 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11160 Reviewed-by: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-09-11 16:53:46 +00:00
group("dawn_glfw") {
public_deps = [
"third_party:glfw",
]
}
} else if (is_fuchsia) {
# The mock implementation of GLFW on Fuchsia
Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
config("dawn_glfw_public_config") {
# Allow inclusion of <GLFW/glfw3.h>
[fuchsia]: Fix Fuchsia build. A previous CL broke the build because a GLFW-related config is no longer exposed. This fixes the issue. Bug=dawn:221 Change-Id: I83d43b55d58d18e04ea20f732c76830a798f2487 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11181 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: David Turner <digit@google.com>
2019-09-12 12:50:31 +00:00
include_dirs = [ "${dawn_glfw_dir}/include" ]
Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
# The GLFW/glfw3.h header includes <GL/gl.h> by default, but the latter
# does not exist on Fuchsia. Defining GLFW_INCLUDE_NONE helps work around
# the issue, but it needs to be defined for any file that includes the
# header.
defines = [
"GLFW_INCLUDE_NONE",
"GLFW_INCLUDE_VULKAN",
]
}
static_library("dawn_glfw") {
sources = [
# NOTE: The header below is required to pass "gn check".
"${dawn_glfw_dir}/include/GLFW/glfw3.h",
"src/utils/Glfw3Fuchsia.cpp",
]
public_configs = [ ":dawn_glfw_public_config" ]
deps = [
"${dawn_root}/src/common",
]
}
} else {
BUILD.gn: Only expose the GLFW target on platforms that support it Due to the way GN target discovery works, glfw would get discovered in Fuchsia / Android / ChromeOS builds when it isn't supported causing compilation failures. This changes third_party/BUILD.gn so that glfw targets are only created on supported platforms. It also changes dawn_glfw in BUILD.gn to be more robust to building on all platforms. Bug=dawn:221 BUG=chromium:1002895 Change-Id: I8f40b06f680094406d24e9a6dea44b128e59b854 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11160 Reviewed-by: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-09-11 16:53:46 +00:00
# Just skip GLFW on other systems
Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
group("dawn_glfw") {
}
}
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
###############################################################################
# Utils for tests and samples
###############################################################################
static_library("dawn_utils") {
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
configs += [ "${dawn_root}/src/common:dawn_internal" ]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
sources = [
Implement RenderBundle in the frontend This CL implements RenderBundle and RenderBundleEncoder in the frontend and adds unittests for validation. Bug: dawn:154 Change-Id: Ice5ecd384cd627ad270b73052408f8139d1ea5f4 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9221 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-13 22:12:54 +00:00
"src/utils/ComboRenderBundleEncoderDescriptor.cpp",
"src/utils/ComboRenderBundleEncoderDescriptor.h",
Render Pipeline Descriptorization -- Part I This patch remove render pipeline builder and use descriptor to create render pipeline. Sub-objects in descriptor will be removed in future. Bug: dawn:4 Change-Id: I58dd569c7be42c2648311847b939c681189c2854 Reviewed-on: https://dawn-review.googlesource.com/c/2180 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2018-12-10 19:47:22 +00:00
"src/utils/ComboRenderPipelineDescriptor.cpp",
"src/utils/ComboRenderPipelineDescriptor.h",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
"src/utils/DawnHelpers.cpp",
"src/utils/DawnHelpers.h",
"src/utils/SystemUtils.cpp",
"src/utils/SystemUtils.h",
"src/utils/TerribleCommandBuffer.cpp",
"src/utils/TerribleCommandBuffer.h",
Add Dawn perf test harness This patch adds a perf test harness for Dawn and a simple test of buffer upload performance. The test harness is based off of ANGLE's perf tests. Because perf tests are parameterized to support multiple test variants, this patch also adds DawnTestWithParams and ParamGenerator to support instantiating tests with additional parameters. Bug: dawn:208 Change-Id: I60df730e9f9f21a4c29fc21ea1a8315e4fff1aa6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10340 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-08-28 23:18:10 +00:00
"src/utils/Timer.h",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
]
[dawn] small fix for BUILD.gn BackendBinding.h includes dawn/dawncpp.h, so dawn_headers_gen needs to be in public_deps. See below reference for more details. https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps Applied `gn format` too. Bug: chromium:931596 Change-Id: I8572ba54b56c96950a58ec068ba797b3031f3c01 Reviewed-on: https://dawn-review.googlesource.com/c/4640 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-02-13 18:42:38 +00:00
Add Dawn perf test harness This patch adds a perf test harness for Dawn and a simple test of buffer upload performance. The test harness is based off of ANGLE's perf tests. Because perf tests are parameterized to support multiple test variants, this patch also adds DawnTestWithParams and ParamGenerator to support instantiating tests with additional parameters. Bug: dawn:208 Change-Id: I60df730e9f9f21a4c29fc21ea1a8315e4fff1aa6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10340 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-08-28 23:18:10 +00:00
if (is_win) {
sources += [ "src/utils/WindowsTimer.cpp" ]
} else if (is_mac) {
sources += [ "src/utils/OSXTimer.cpp" ]
} else {
sources += [ "src/utils/PosixTimer.cpp" ]
}
[dawn] small fix for BUILD.gn BackendBinding.h includes dawn/dawncpp.h, so dawn_headers_gen needs to be in public_deps. See below reference for more details. https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps Applied `gn format` too. Bug: chromium:931596 Change-Id: I8572ba54b56c96950a58ec068ba797b3031f3c01 Reviewed-on: https://dawn-review.googlesource.com/c/4640 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-02-13 18:42:38 +00:00
public_deps = [
Split generation of dawncpp headers from libdawncpp libdawn_native also requires the dawncpp headers. When we separated libdawn_cpp from the dawn_headers, libdawn_native lost the cpp headers and caused a compile failure. This patch separates the dawncpp headers as a separate target so both libdawncpp and libdawn_native can depend on them. Bug: dawn:22 Change-Id: I4172f1654377afac8c4314123ee8b5b81dc7c928 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12300 Reviewed-by: David Turner <digit@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-10-16 10:26:01 +00:00
"${dawn_root}/src/dawn:dawncpp_headers",
[dawn] small fix for BUILD.gn BackendBinding.h includes dawn/dawncpp.h, so dawn_headers_gen needs to be in public_deps. See below reference for more details. https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps Applied `gn format` too. Bug: chromium:931596 Change-Id: I8572ba54b56c96950a58ec068ba797b3031f3c01 Reviewed-on: https://dawn-review.googlesource.com/c/4640 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-02-13 18:42:38 +00:00
]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
deps = [
":libdawn_native",
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
":libdawn_wire",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
Roll shaderc and glslang and use their BUILD.gn This rolls glslang and shaderc to be able to use their BUILD.gn files, and also rolls SPIRV-Tools and spirv-headers to have compatible versions. BUG=chromium:870747 Change-Id: I13c615f6f3d148c9b69f06547992bf5910e04e62 Reviewed-on: https://dawn-review.googlesource.com/c/1680 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-10-04 17:17:57 +00:00
"${dawn_shaderc_dir}:libshaderc",
Remove GLFW dependency for non-GL tests As part of enabling WebGPU on Chrome OS, we would like to run the Dawn unit and e2e tests as part of the Chrome OS test suite. This CL removes the GLFW dependency because Chrome OS does not support GLFW. The GLFWwindow is only used to create swap chains for the various backends, but these swap chains are not actually used in the tests (the e2e tests render to textures instead). The swap chains are only referenced as part of an unused debugging function: SwapBuffersForCapture which we can safely remove as per my discussions with kainino@ and enga@. We still need GLFW for OpenGL, so we conditionally include it on platforms that enable the OpenGL backend (which Chrome OS is not). Note: enga@ suggested to create a VulkanWindowlessBinding that has an empty GetSwapChainImplementation, but after exploring the option, it seems like a bit too many ifdefs. In the end, I think it's cleaner to just remove the *Binding classes entirely. BUG=chromium:993457 TEST=tests compile and pass for all values of dawn_enable_opengl Change-Id: I067b12a23f2c236f5506252cd7727b847e79a667 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
2019-08-13 21:45:44 +00:00
]
}
static_library("dawn_bindings") {
configs += [ "${dawn_root}/src/common:dawn_internal" ]
sources = [
"src/utils/BackendBinding.cpp",
"src/utils/BackendBinding.h",
]
public_deps = [
"${dawn_root}/src/dawn:dawn_headers",
]
deps = [
Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
":dawn_glfw",
Remove GLFW dependency for non-GL tests As part of enabling WebGPU on Chrome OS, we would like to run the Dawn unit and e2e tests as part of the Chrome OS test suite. This CL removes the GLFW dependency because Chrome OS does not support GLFW. The GLFWwindow is only used to create swap chains for the various backends, but these swap chains are not actually used in the tests (the e2e tests render to textures instead). The swap chains are only referenced as part of an unused debugging function: SwapBuffersForCapture which we can safely remove as per my discussions with kainino@ and enga@. We still need GLFW for OpenGL, so we conditionally include it on platforms that enable the OpenGL backend (which Chrome OS is not). Note: enga@ suggested to create a VulkanWindowlessBinding that has an empty GetSwapChainImplementation, but after exploring the option, it seems like a bit too many ifdefs. In the end, I think it's cleaner to just remove the *Binding classes entirely. BUG=chromium:993457 TEST=tests compile and pass for all values of dawn_enable_opengl Change-Id: I067b12a23f2c236f5506252cd7727b847e79a667 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
2019-08-13 21:45:44 +00:00
":libdawn_native",
"${dawn_root}/src/common",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
]
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
libs = []
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
if (dawn_enable_d3d12) {
sources += [ "src/utils/D3D12Binding.cpp" ]
}
if (dawn_enable_metal) {
sources += [ "src/utils/MetalBinding.mm" ]
libs += [
"Metal.framework",
"QuartzCore.framework",
]
# Suppress warnings that Metal isn't in the deployment target of Chrome
if (is_mac) {
cflags_objcc = [ "-Wno-unguarded-availability" ]
}
}
if (dawn_enable_null) {
sources += [ "src/utils/NullBinding.cpp" ]
}
if (dawn_enable_opengl) {
sources += [ "src/utils/OpenGLBinding.cpp" ]
}
if (dawn_enable_vulkan) {
sources += [ "src/utils/VulkanBinding.cpp" ]
}
}
###############################################################################
# Dawn test targets
###############################################################################
Generators: main.py is now dawn_json_generator.py This merges all the files for main.py together again except generator_lib.py because there doesn't seeem to be a good way to separate the pure dawn.json generators and the dawn wire generator. Also updates the GN templates to make it easier to define new generators based on generator_lib, and move the Jinja2 template "stdlib" to generator_lib.py BUG=dawn:165 Change-Id: I1b5b2ef0a59cb142e214f3af9a58048a88ae949a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7880 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-06-11 18:03:05 +00:00
dawn_json_generator("mock_dawn_gen") {
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
target = "mock_dawn"
outputs = [
Normalize generated file paths to match main tree. Previously dawn_native files were in src/dawn_native/ while generated files were in dawn_native/. This makes some things complicated when integrating in other source trees so normalize all generated files to be in paths that match the main tree. BUG=dawn:225 Change-Id: I5b3e04d37a16251143578dfb7a31445b229fe4ac Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11300 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-09-18 04:33:12 +00:00
"src/dawn/mock_dawn.h",
"src/dawn/mock_dawn.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
]
}
test("dawn_unittests") {
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
configs += [ "${dawn_root}/src/common:dawn_internal" ]
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
deps = [
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
":dawn_utils",
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
":libdawn_native",
Add wire_cmd.py and dawn_wire.json to autogenerate all wire commands. Unify code generation for Client->Server and Server->Client commands. Methods in dawn.json are converted into command records and additional commands are specified in dawn_wire.json. This can then be used to completely generate the command handlers and command struct definitions. Bug: dawn:88 Change-Id: Ic796796ede0aafe02e14f1f96790324dad92f4c0 Reviewed-on: https://dawn-review.googlesource.com/c/3800 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-15 20:49:53 +00:00
":libdawn_native_sources",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
":libdawn_wire",
":mock_dawn_gen",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
Split the libdawn target in components with a single purpose. The functionality of the dawn_headers and libdawn targets are split into the following targets: - dawn_headers: the new version only exposes the "dawn.h" C API and no longer includes the C++ API. - dawncpp: the header and implementation of the C++ API that wraps the C API. This is unbundled from the rest so the C++ API can be used with libdawn_proc or other libraries implementing the C API. - libdawn_proc: A DawnProcTable-backend implementation of the C API. This is needed because in follow-up commit there will be three libraries implementing the C API: libdawn_proc that trampolines where we want, and libdawn_native/wire that don't have trampolines for better perf. BUG=dawn:22 Change-Id: I5d941f0d98e5a4b633e14d67eb5269f7924f0647 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12160 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-10-15 11:44:38 +00:00
"${dawn_root}/src/dawn:dawncpp",
"${dawn_root}/src/dawn:libdawn_proc",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"third_party:gmock_and_gtest",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
]
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
# Add internal Dawn Native headers and config for internal unittests.
deps += [ ":libdawn_native_headers" ]
configs += [ ":libdawn_native_internal" ]
sources = get_target_outputs(":mock_dawn_gen")
Add wire tests and mocks for the MemoryTransferService This CL tests integration of the MemoryTransferService with buffer mapping. It tests the basic success and error cases for buffer mapping, and it tests mocked failures of each fallible MemoryTransferService method that an embedder could implement. Change-Id: Iece660fb49664cc6a09a0b0b8dbe59e2882a6017 Bug: dawn:156 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8841 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-07-19 16:16:58 +00:00
sources += [
"src/dawn_wire/client/ClientMemoryTransferService_mock.cpp",
"src/dawn_wire/client/ClientMemoryTransferService_mock.h",
"src/dawn_wire/server/ServerMemoryTransferService_mock.cpp",
"src/dawn_wire/server/ServerMemoryTransferService_mock.h",
]
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
sources += [
"src/tests/unittests/BitSetIteratorTests.cpp",
Resource Management 3: Buddy allocator Introduces the buddy system for fast power-of-two sub-allocation. BUG=dawn:27 Change-Id: I56836ae317ecc5a91d8341c843fc37d4f91fb5af Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9260 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-07-30 16:46:10 +00:00
"src/tests/unittests/BuddyAllocatorTests.cpp",
Resource Management 7: Device memory sub-allocation using buddy allocator. Uses a large buddy system to allocate binary sized heaps on-demand. BUG=dawn:27 Change-Id: I72e425c23e601da6ee53827423bef7ff13be049c Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10880 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2019-10-03 18:17:31 +00:00
"src/tests/unittests/BuddyMemoryAllocatorTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/CommandAllocatorTests.cpp",
"src/tests/unittests/EnumClassBitmasksTests.cpp",
"src/tests/unittests/ErrorTests.cpp",
Support BC formats as the first extension in Dawn This patch refactors the current implementation of BC formats to treat it as the first extension in Dawn and adds all the related tests. Note that in Dawn all the extensions are disabled unless we enable them when we create the device, which means the BC formats can only be used when we enable the related extension on the creation of the device, and the creation of the device will fail if the adapter does not support the extension BUG=dawn:42 TEST=dawn_end2end_tests TEST=dawn_unittests Change-Id: I04d818b0218ebb3b1b7a70a4fea71779f308f85f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9520 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-08-02 00:06:38 +00:00
"src/tests/unittests/ExtensionTests.cpp",
Add dawnGetProcAddress. This will become wgpuGetProcAddress that is part of the webgpu.h and the last gap in functionality for dawn.h to match webgpu.h. BUG=dawn:22 Change-Id: I0dcb3b5e6bd99cb10db273fc101d3ec0161b7da0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12120 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-10-15 12:08:48 +00:00
"src/tests/unittests/GetProcAddressTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/MathTests.cpp",
"src/tests/unittests/ObjectBaseTests.cpp",
"src/tests/unittests/PerStageTests.cpp",
"src/tests/unittests/RefCountedTests.cpp",
"src/tests/unittests/ResultTests.cpp",
Remove device dependencies from ringbuffer. Allows ringbuffer sub-allocator to be used for non-staging memory. BUG=dawn:155 Change-Id: Id0021907f520909aaebaf79e992124a47797d38d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9760 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2019-09-18 22:06:41 +00:00
"src/tests/unittests/RingBufferAllocatorTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/SerialMapTests.cpp",
"src/tests/unittests/SerialQueueTests.cpp",
"src/tests/unittests/ToBackendTests.cpp",
"src/tests/unittests/validation/BindGroupValidationTests.cpp",
"src/tests/unittests/validation/BufferValidationTests.cpp",
"src/tests/unittests/validation/CommandBufferValidationTests.cpp",
Reland "dawn_native: Indirect draw/dispatch" This is a reland of 7eb6be186be60a536a9f529b514bb5c5fd79293d Fixes casting issue on 32 bit machines Original change's description: > dawn_native: Indirect draw/dispatch > > Adds indirect draw and dispatch for all backends (without validation). > > Tests for opengl negative offset are skipped since there is no easy > way to add the index buffer offset. Current idea is to use a compute > shader to modify the indirect draw buffer. > > Change-Id: I1d3eec7c699b211423f4b911769cca17bfbcd045 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7481 > Commit-Queue: Idan Raiter <idanr@google.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> Change-Id: Id28c5658ee18ec5c030f721fb44d9f11ebe21ff9 Bug:dawn:54,chromium:972358 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7961 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-06-10 20:56:27 +00:00
"src/tests/unittests/validation/ComputeIndirectValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/ComputeValidationTests.cpp",
"src/tests/unittests/validation/CopyCommandsValidationTests.cpp",
Implementation of Debug Marker APIs Introduces pushDebugGroup, popDebugGroup, and insertDebugMarker implementations for Vulkan and Metal using VK_EXT_debug_marker and XCode, respectively. Bug: dawn:44 Change-Id: I0ae56c4d67aa832123f27a1fcdddf65746261e57 Reviewed-on: https://dawn-review.googlesource.com/c/4241 Commit-Queue: Brandon Jones <brandon1.jones@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-20 20:21:00 +00:00
"src/tests/unittests/validation/DebugMarkerValidationTests.cpp",
Reland "dawn_native: Indirect draw/dispatch" This is a reland of 7eb6be186be60a536a9f529b514bb5c5fd79293d Fixes casting issue on 32 bit machines Original change's description: > dawn_native: Indirect draw/dispatch > > Adds indirect draw and dispatch for all backends (without validation). > > Tests for opengl negative offset are skipped since there is no easy > way to add the index buffer offset. Current idea is to use a compute > shader to modify the indirect draw buffer. > > Change-Id: I1d3eec7c699b211423f4b911769cca17bfbcd045 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7481 > Commit-Queue: Idan Raiter <idanr@google.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> Change-Id: Id28c5658ee18ec5c030f721fb44d9f11ebe21ff9 Bug:dawn:54,chromium:972358 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7961 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-06-10 20:56:27 +00:00
"src/tests/unittests/validation/DrawIndirectValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/DynamicStateCommandValidationTests.cpp",
Implement ErrorScopes for synchronous errors This patch implements Push/PopErrorScope except for asynchronous or GPU commands. These commands, such as Queue::Submit will need to hold onto the ErrorScope until GPU execution is complete. Bug: dawn:153 Change-Id: I2d340b8b391d117a59497f35690993a9cd7503e6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10700 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-09-10 23:19:11 +00:00
"src/tests/unittests/validation/ErrorScopeValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/FenceValidationTests.cpp",
"src/tests/unittests/validation/QueueSubmitValidationTests.cpp",
Implement RenderBundle in the frontend This CL implements RenderBundle and RenderBundleEncoder in the frontend and adds unittests for validation. Bug: dawn:154 Change-Id: Ice5ecd384cd627ad270b73052408f8139d1ea5f4 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9221 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-13 22:12:54 +00:00
"src/tests/unittests/validation/RenderBundleValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/RenderPassDescriptorValidationTests.cpp",
Fix null pointer dereference in CommandBufferStateTracker The CommandBufferStateTracker dereferences a null pointer if there is no bind group set for an index of the layout Change-Id: Id247f9876340d189088e8bbe8cb4d68a4d517c6e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6100 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-03-28 15:28:01 +00:00
"src/tests/unittests/validation/RenderPassValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/RenderPipelineValidationTests.cpp",
dawn_native: handle NaN lod values in samplers For samplers with NaN mLodMinClamp or mLodMaxClamp, the equality operator returned false. Adds checks for finite values, and also early returns if two pointers are equal. Bug: dawn:143, chromium:965633 Change-Id: Id5998d6eec275af0fbe30e3b4fcb3eed4fe64c6a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7401 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-05-22 17:18:52 +00:00
"src/tests/unittests/validation/SamplerValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/ShaderModuleValidationTests.cpp",
Make TextureDescriptor match WebGPU IDL This patch updates the definition of TextureDescriptor to make it match WebGPU IDL: 1. Rename 'arrayLayer' to 'arraySize' 2. Add the missing member "sampleCount" and check that currently sampleCount can only be 1. BUG=dawn:56 TEST=dawn_unittests Change-Id: I642186529f045865ae344cb5545ac80e14445c59 Reviewed-on: https://dawn-review.googlesource.com/c/3180 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-12 09:27:16 +00:00
"src/tests/unittests/validation/TextureValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/TextureViewValidationTests.cpp",
Emulate store and multisample resolve on Metal This patch implements "store and MSAA resolve" store operation on Metal drivers that don't support MTLStoreActionStoreAndMultisampleResolve with a workaround that does MSAA resolve in another render pass. Driver workaround is one type of Dawn Toggles. Dawn Toggles will include other optional optimizations and features that can be configured to use or not when we create Dawn Devices. As all Metal try bots don't need this toggle, to better test this patch on the try bots: 1. We add the support of forcing enabling a workaround when starting an Dawn end2end test so that we can test the workaround on the platforms where the workaround is disabled. 2. We add an optional parameter DeviceDescriptor to CreateDevice() so that we can custom the toggles the Dawn device should use. This patch also adds the support of querying toggle details from Instance and the names of the toggles in use from Device. These APIs are tested in the Dawn unittests added in this patch. BUG=dawn:56 TEST=dawn_end2end_tests TEST=dawn_unittests Change-Id: Iae31d2ded6057eee638b6099d3061e9d78b04d55 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6620 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2019-04-26 07:52:57 +00:00
"src/tests/unittests/validation/ToggleValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/ValidationTest.cpp",
"src/tests/unittests/validation/ValidationTest.h",
"src/tests/unittests/validation/VertexBufferValidationTests.cpp",
Update VertexInput (InputState) to match spec - Part 1 This is only a renaming: change VertexInput to VertexBuffer, and change InputState to VertexInput. The next two patches will do as follows: 1) change the structure of vertex input descriptor related stuff. 2) change num to count. BUG=dawn:80, dawn:107 Change-Id: Ie76aa653a527759a9c3b4a4792e3254689f053b8 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7420 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Yunchao He <yunchao.he@intel.com>
2019-05-22 22:46:32 +00:00
"src/tests/unittests/validation/VertexInputValidationTests.cpp",
Split wire tests into multiple test files Bug: dawn:104 Change-Id: I0dc46dabc92c98df13dbf596dea63aeaaea85d3d Reviewed-on: https://dawn-review.googlesource.com/c/4562 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-02-14 18:47:07 +00:00
"src/tests/unittests/wire/WireArgumentTests.cpp",
"src/tests/unittests/wire/WireBasicTests.cpp",
"src/tests/unittests/wire/WireBufferMappingTests.cpp",
Nuke Builders Part 1: remove the testing BufferBuilder. This requires deleting wire tests for builders that were using it, and leads to small simplifications in the WireTest harness. Also allows removing the BuilderBase class from dawn_native. BUG=dawn:125 Change-Id: I3cbac609207aa652cdc9d37e0b700cce3ac6e093 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6120 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-28 17:12:47 +00:00
"src/tests/unittests/wire/WireErrorCallbackTests.cpp",
Split wire tests into multiple test files Bug: dawn:104 Change-Id: I0dc46dabc92c98df13dbf596dea63aeaaea85d3d Reviewed-on: https://dawn-review.googlesource.com/c/4562 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-02-14 18:47:07 +00:00
"src/tests/unittests/wire/WireFenceTests.cpp",
Add dawn_wire entrypoints to inject texture in the wire This allows reserving a texture ID in the client and injecting textures in the wire, so that the WebGPU control channel can create WebGPU textures backed by SharedImages in Chromium. BUG=941543 Change-Id: I1efcfe3dce024bb2d3592f22225407a97b641c1f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5820 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-03-28 12:57:11 +00:00
"src/tests/unittests/wire/WireInjectTextureTests.cpp",
Add wire tests and mocks for the MemoryTransferService This CL tests integration of the MemoryTransferService with buffer mapping. It tests the basic success and error cases for buffer mapping, and it tests mocked failures of each fallible MemoryTransferService method that an embedder could implement. Change-Id: Iece660fb49664cc6a09a0b0b8dbe59e2882a6017 Bug: dawn:156 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8841 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-07-19 16:16:58 +00:00
"src/tests/unittests/wire/WireMemoryTransferServiceTests.cpp",
Split wire tests into multiple test files Bug: dawn:104 Change-Id: I0dc46dabc92c98df13dbf596dea63aeaaea85d3d Reviewed-on: https://dawn-review.googlesource.com/c/4562 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-02-14 18:47:07 +00:00
"src/tests/unittests/wire/WireOptionalTests.cpp",
"src/tests/unittests/wire/WireTest.cpp",
"src/tests/unittests/wire/WireTest.h",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
]
if (dawn_enable_d3d12) {
sources += [ "src/tests/unittests/d3d12/CopySplitTests.cpp" ]
}
# When building inside Chromium, use their gtest main function because it is
# needed to run in swarming correctly.
if (build_with_chromium) {
sources += [ "//gpu/dawn_unittests_main.cc" ]
} else {
sources += [ "src/tests/UnittestsMain.cpp" ]
}
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
}
Add wrapping for using external vulkan images as textures This change adds platform-dependent services that handle creating semaphores and importing image memory. Then, we use them to wrap a texture from an outside source, and release a signal semaphore back when we're done with it. This will be used to allow chrome to render dawn on Vulkan platforms. Bug: chromium:976495 Change-Id: I9f07eaf436e10aa6bd88cffdc74fd23834d62ee0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8340 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-10 03:17:52 +00:00
source_set("dawn_end2end_tests_sources") {
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
configs += [ "${dawn_root}/src/common:dawn_internal" ]
Add wrapping for using external vulkan images as textures This change adds platform-dependent services that handle creating semaphores and importing image memory. Then, we use them to wrap a texture from an outside source, and release a signal semaphore back when we're done with it. This will be used to allow chrome to render dawn on Vulkan platforms. Bug: chromium:976495 Change-Id: I9f07eaf436e10aa6bd88cffdc74fd23834d62ee0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8340 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-10 03:17:52 +00:00
testonly = true
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
deps = [
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
":dawn_utils",
":libdawn_native",
":libdawn_wire",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
Split the libdawn target in components with a single purpose. The functionality of the dawn_headers and libdawn targets are split into the following targets: - dawn_headers: the new version only exposes the "dawn.h" C API and no longer includes the C++ API. - dawncpp: the header and implementation of the C++ API that wraps the C API. This is unbundled from the rest so the C++ API can be used with libdawn_proc or other libraries implementing the C API. - libdawn_proc: A DawnProcTable-backend implementation of the C API. This is needed because in follow-up commit there will be three libraries implementing the C API: libdawn_proc that trampolines where we want, and libdawn_native/wire that don't have trampolines for better perf. BUG=dawn:22 Change-Id: I5d941f0d98e5a4b633e14d67eb5269f7924f0647 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12160 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-10-15 11:44:38 +00:00
"${dawn_root}/src/dawn:dawncpp",
"${dawn_root}/src/dawn:libdawn_proc",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"third_party:gmock_and_gtest",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
]
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
sources = [
"src/tests/DawnTest.h",
"src/tests/end2end/BasicTests.cpp",
"src/tests/end2end/BindGroupTests.cpp",
"src/tests/end2end/BufferTests.cpp",
Fix clip space on D3D12 and OpenGL The range of the Z-coordinate in clipping volume is [-w, w] on OpenGL, while it is [0, w] on D3D12, Metal and Vulkan. In this patch, the "fixup_clipspace" flag of SPIRV-Cross is enabled on OpenGL backend and disabled on D3D12 backend to unify the behaviour of clip space on all Dawn backends. An end2end test is also added for this fix. This patch also fix a bug when clearing depth stencil attachments on OpenGL backend. Before clearing depth stencil attachments, we should enable depth stencil writing by properly setting depth and stencil masks. We do not need to set the depth and stencil masks back because they will be set again when applying the render pipeline. The newly added test will fail without this fix when running the test together with all the end2ends. BUG=dawn:122 TEST=dawn_end2end_tests Change-Id: I4f50ce3eb1f16d731ee4cffc12a56e17844b4675 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5860 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2019-03-27 00:01:33 +00:00
"src/tests/end2end/ClipSpaceTests.cpp",
Rename BlendState to ColorState, in order to match web idl BUG=dawn:106 Change-Id: Id2cb1788becfacd09bd7f420d6525d22f96d1fe2 Reviewed-on: https://dawn-review.googlesource.com/c/4781 Commit-Queue: Yunchao He <yunchao.he@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-02-16 02:27:30 +00:00
"src/tests/end2end/ColorStateTests.cpp",
Support BC5 formats on Vulkan This patch supports BC5 formats on Vulkan backends and adds related Dawn end2end tests. For the textures with BC formats, they could have non-multiple-of-4 sizes on the non-zero mipmap levels in sampling, but we are still required to provide texture data in complete 4x4 blocks in texture copies because that is the size of which they are stored in GPU memory. In this patch, we refer the term "physical memory size" as the memory size of the texture subresource in GPU memory, and the term "virtual memory size" as the size used in texture sampling. As Dawn requires the Extent3D in texture copies must fit in the physical memory size, while Vulkan requires it must fit in the virtual memory size, this patch recalculates the imageExtent to ensure it always follow this Vulkan validation rules. For Dawn end2end tests, note that we use pure green and pure red for the textures because BC5 does not support SRGB formats. Furthermore, "CopyPartofTextureSubResourceIntoNonZeroMipmapLevel" is skipped in this patch because there is an issue on the T2T copies from a region within the virtual size of one texture to another one that exceeds the virtual size of another texture in Vulkan SPEC. BUG=dawn:42 TEST=dawn_end2end_tests Change-Id: I17518cd335fb13125cb753bbf879bc06eb20e426 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8260 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2019-07-02 23:55:55 +00:00
"src/tests/end2end/CompressedTextureFormatTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/ComputeCopyStorageBufferTests.cpp",
Reland "dawn_native: Indirect draw/dispatch" This is a reland of 7eb6be186be60a536a9f529b514bb5c5fd79293d Fixes casting issue on 32 bit machines Original change's description: > dawn_native: Indirect draw/dispatch > > Adds indirect draw and dispatch for all backends (without validation). > > Tests for opengl negative offset are skipped since there is no easy > way to add the index buffer offset. Current idea is to use a compute > shader to modify the indirect draw buffer. > > Change-Id: I1d3eec7c699b211423f4b911769cca17bfbcd045 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7481 > Commit-Queue: Idan Raiter <idanr@google.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> Change-Id: Id28c5658ee18ec5c030f721fb44d9f11ebe21ff9 Bug:dawn:54,chromium:972358 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7961 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-06-10 20:56:27 +00:00
"src/tests/end2end/ComputeIndirectTests.cpp",
Add a basic compute shared memory test Change-Id: I6fab17d59d58434d10def29923e71106605c4f32 Bug: None Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6580 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2019-04-26 02:08:12 +00:00
"src/tests/end2end/ComputeSharedMemoryTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/CopyTests.cpp",
Implement Culling and FrontFace This patch implements Culling and FrontFace on backends, and add tests too. This test also verified that we couldn't invert FrontFace on Metal backend. Otherwise, the tests would fail on all HWs. But we do need to invert CCW/CW on OpenGL backend. Because Y axis is up in OpenGL while Y axis is down in WebGPU. Bug=dawn:43 Change-Id: I7dd0922477397a13c5f7208e104ff352a673a556 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8420 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Yunchao He <yunchao.he@intel.com>
2019-07-06 00:11:10 +00:00
"src/tests/end2end/CullingTests.cpp",
Implementation of Debug Marker APIs Introduces pushDebugGroup, popDebugGroup, and insertDebugMarker implementations for Vulkan and Metal using VK_EXT_debug_marker and XCode, respectively. Bug: dawn:44 Change-Id: I0ae56c4d67aa832123f27a1fcdddf65746261e57 Reviewed-on: https://dawn-review.googlesource.com/c/4241 Commit-Queue: Brandon Jones <brandon1.jones@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-20 20:21:00 +00:00
"src/tests/end2end/DebugMarkerTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/DepthStencilStateTests.cpp",
Destroy frontend and backend for Textures Same idea as for buffers, Destroy can be used to free GPU memory associated with resources without waiting for javascript garbage collection to occur. Bug: dawn:46 Change-Id: Ia796b06b5228cbec4cfe8d78a500f967181d8c1f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5540 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Natasha Lee <natlee@microsoft.com>
2019-03-27 22:04:10 +00:00
"src/tests/end2end/DestroyTests.cpp",
Reland "dawn_native: Indirect draw/dispatch" This is a reland of 7eb6be186be60a536a9f529b514bb5c5fd79293d Fixes casting issue on 32 bit machines Original change's description: > dawn_native: Indirect draw/dispatch > > Adds indirect draw and dispatch for all backends (without validation). > > Tests for opengl negative offset are skipped since there is no easy > way to add the index buffer offset. Current idea is to use a compute > shader to modify the indirect draw buffer. > > Change-Id: I1d3eec7c699b211423f4b911769cca17bfbcd045 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7481 > Commit-Queue: Idan Raiter <idanr@google.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> Change-Id: Id28c5658ee18ec5c030f721fb44d9f11ebe21ff9 Bug:dawn:54,chromium:972358 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7961 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-06-10 20:56:27 +00:00
"src/tests/end2end/DrawIndexedIndirectTests.cpp",
Implement 'baseVertex' in drawIndexed() on D3D12, Metal and Vulkan This patch adds the support of the parameter 'baseVertex' of drawIndexed on D3D12, Metal and Vulkan back-ends. BUG=dawn:51 TEST=dawn_end2end_tests Change-Id: Ibd25884ad2abceaaed744d74c4ee6b0ae6b3fa1b Reviewed-on: https://dawn-review.googlesource.com/c/3221 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2018-12-13 01:05:26 +00:00
"src/tests/end2end/DrawIndexedTests.cpp",
Reland "dawn_native: Indirect draw/dispatch" This is a reland of 7eb6be186be60a536a9f529b514bb5c5fd79293d Fixes casting issue on 32 bit machines Original change's description: > dawn_native: Indirect draw/dispatch > > Adds indirect draw and dispatch for all backends (without validation). > > Tests for opengl negative offset are skipped since there is no easy > way to add the index buffer offset. Current idea is to use a compute > shader to modify the indirect draw buffer. > > Change-Id: I1d3eec7c699b211423f4b911769cca17bfbcd045 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7481 > Commit-Queue: Idan Raiter <idanr@google.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> Change-Id: Id28c5658ee18ec5c030f721fb44d9f11ebe21ff9 Bug:dawn:54,chromium:972358 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7961 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-06-10 20:56:27 +00:00
"src/tests/end2end/DrawIndirectTests.cpp",
Fix non-zero validation in Draw and DrawIndexed Metal validation layer does not allow indexCount or instanceCount to be 0 in drawIndexedPrimitives and drawPrimitives, otherwise we should draw nothing with these operations. BUG=dawn:76 TEST=dawn_end2end_tests Change-Id: Ic22be73ac992289d4bc8d7b3d4d30d20c4488776 Reviewed-on: https://dawn-review.googlesource.com/c/3900 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-30 09:01:08 +00:00
"src/tests/end2end/DrawTests.cpp",
Dynamic Buffer Offset : Metal Backend In a typical application, most draws will use different uniforms values for things like the world position and orientation. In the current state of WebGPU this means that a new bind group needs to be created for each draw to set the right uniforms. Bind group creation is expected to be more expensive than recording draws because they incur an allocation. This feature is to reduce the number of bind groups that need to be created. The patch implemented dynamic buffer offset on metal backend. Bug=dawn:55 Change-Id: I34f397ec9ec10fa5b8e8a1c029d2d6a19e8dc0ee Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7320 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
2019-05-23 00:45:12 +00:00
"src/tests/end2end/DynamicBufferOffsetTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/FenceTests.cpp",
"src/tests/end2end/IndexFormatTests.cpp",
Support multisampled rendering on OpenGL This patch adds the support of multisampled rendering on OpenGL backends and the related end2end tests to test all new features implemented in this patch. BUG=dawn:56 TEST=dawn_end2end_tests Change-Id: I91e462178ee39041ef591503c33c70db511775e9 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5880 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2019-03-28 14:18:11 +00:00
"src/tests/end2end/MultisampledRenderingTests.cpp",
Create nonzero_clear_resources_on_creation_for_testing toggle Created toggle to force texture clearing to 1 bits in order to test the logic of lazy clearing. Bug: dawn:145 Change-Id: I83bc32f046159c709c426b77458fbdf115f7bfd0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7120 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Natasha Lee <natlee@microsoft.com>
2019-05-11 00:21:50 +00:00
"src/tests/end2end/NonzeroTextureCreationTests.cpp",
dawn_native: deduplicate pipeline layouts This is the first step to do pipeline deduplication. It also introduces tests for deduplication. BUG=dawn:143 Change-Id: Ib22496f543f8d1f9cfde04f725612504132c7d72 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6861 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-05-01 12:57:27 +00:00
"src/tests/end2end/ObjectCachingTests.cpp",
Implement OpArrayLength on Metal Metal uses a physical addressing mode and buffers are just pointers in GPU memory that don't have a size. This prevents implementing OpArrayLength without any additional information. When a shader uses OpArrayLength on unsized arrays, SPIRV-Cross requires an extra buffer argument that gets the length of the buffers. Use that workaround mechanism in the Metal backend by keeping track of the storage buffer sizes and applying the extra "buffer length buffer" when a pipeline requires it. Also adds tests that OpArraySize works in all shader stages. BUG=dawn:195 Change-Id: I6aa6089aaea85d0589ccad1756e55dd0befefcb5 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9386 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-02 18:15:08 +00:00
"src/tests/end2end/OpArrayLengthTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/PrimitiveTopologyTests.cpp",
Implement RenderBundle in the backend Bug: dawn:154 Change-Id: I45496fb2103150dabe32fbc7cb5856dc40c9339f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9222 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-08-14 02:01:14 +00:00
"src/tests/end2end/RenderBundleTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/RenderPassLoadOpTests.cpp",
D3D12: Remove RenderPassDescriptorD3D12 This patch removes RenderPassDescriptorD3D12 completely and moves the creation of RTVs and DSVs to CommandBufferD3D12::RecordCommands(), where we allocate all RTVs and DSVs used in the current command buffer in one RTV heap and one DSV heap. Note that the method to allocate RTVs and DSVs are too simple in this patch, and we will optimize it later. This patch also adds a test to make sure Dawn works correctly when we use two different render passes in one command buffer. This patch is one of the preparations on completely removing RenderPassDescriptorBuilder from Dawn. BUG=dawn:6 Change-Id: I02e30c007fb8668a7474a3caf7a858782d0c92df Reviewed-on: https://dawn-review.googlesource.com/c/4520 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-15 10:55:08 +00:00
"src/tests/end2end/RenderPassTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/SamplerTests.cpp",
"src/tests/end2end/ScissorTests.cpp",
Add most WebGPU texture formats on Vulkan This adds the formats to dawn.json, implements support in the Vulkan backend and adds tests performing basic sampling checks for all formats. The R8UnormSrgb and RG8UnormSrgb formats skipped because they are not required in Vulkan (and RG8UnormSrgb is in fact not supported on the machine used for developing this CL). A PR will be sent to the WebGPU repo to remove the from the initial list of formats. The RG11B10Float and RGB10A2Unorm formats of WebGPU are replaced with B10GR11Float and A2RGB10Unorm that are the formats exposed by Vulkan. It is likely that all APIs implement them with components stored in that order. Each format except depth-stencil ones is tested by uploading some interesting texel data and checking that sampling from the texture produces correct results. The goal is to make sure that backends don't make a mistake in the giant switch statements. There was no effort made to check the hardware implementation of the formats. Tests will later be extended to cover rendering and clearing operations as well as multisample resolve. It isn't clear if depth-stencil format will support TRANSFER operations in WebGPU so these are left untested for now. BUG=dawn:128 Change-Id: I78ac5bf77b57398155551e6db3de50b478d69452 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8363 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-07-01 09:58:07 +00:00
"src/tests/end2end/TextureFormatTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/TextureViewTests.cpp",
Clear Vulkan Textures at first usage This prevents dirty textures to be used when memory is recycled while destroying/creating textures. If a texture is not cleared at load, it will be cleared to 0 before it is used. Bug: dawn:145 Change-Id: Ia3f02427478fb48649089829186ccb377caa1912 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6960 Commit-Queue: Natasha Lee <natlee@microsoft.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-06-11 18:11:05 +00:00
"src/tests/end2end/TextureZeroInitTests.cpp",
Add end2end test for all vertex formats BUG=dawn:41 Change-Id: I37bde37843522a8d7c8b3bea1cb24c0971efd8e2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6340 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
2019-04-26 15:25:18 +00:00
"src/tests/end2end/VertexFormatTests.cpp",
Update VertexInput (InputState) to match spec - Part 1 This is only a renaming: change VertexInput to VertexBuffer, and change InputState to VertexInput. The next two patches will do as follows: 1) change the structure of vertex input descriptor related stuff. 2) change num to count. BUG=dawn:80, dawn:107 Change-Id: Ie76aa653a527759a9c3b4a4792e3254689f053b8 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7420 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Yunchao He <yunchao.he@intel.com>
2019-05-22 22:46:32 +00:00
"src/tests/end2end/VertexInputTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/ViewportOrientationTests.cpp",
Implement RenderPassEncoder::SetViewport: add end2end tests The main aim of this CL is to add tests for SetViewport. But it also implements the feature on Vulkan backend to verify the tests. BUG=dawn:53 TEST=dawn_end2end_tests Change-Id: I9578b2d9650cb952ce67cf91f79e9682c9932ee3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8820 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Yunchao He <yunchao.he@intel.com>
2019-07-16 19:27:09 +00:00
"src/tests/end2end/ViewportTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
]
Implement wrapping IOSurfaces in dawn::Texture. This allows wrapping IOSurfaces in a dawn::Texture so a Dawn application can sample from, or render to an IOSurface. It uses Metal's functionality for wrapping textures in MTLTexture. Support for single-plane BGRA8, RG8 and R8 IOSurfaces is added as well as tests for sampling and using BeginRenderPass to clear them. BUG=dawn:112 Change-Id: I367dbd1a75a0c7b81901fb0aae05f1cd46af3f3a Reviewed-on: https://dawn-review.googlesource.com/c/5101 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-03-01 12:01:18 +00:00
libs = []
if (dawn_enable_metal) {
sources += [ "src/tests/end2end/IOSurfaceWrappingTests.cpp" ]
libs += [ "IOSurface.framework" ]
}
Remove GLFW dependency for non-GL tests As part of enabling WebGPU on Chrome OS, we would like to run the Dawn unit and e2e tests as part of the Chrome OS test suite. This CL removes the GLFW dependency because Chrome OS does not support GLFW. The GLFWwindow is only used to create swap chains for the various backends, but these swap chains are not actually used in the tests (the e2e tests render to textures instead). The swap chains are only referenced as part of an unused debugging function: SwapBuffersForCapture which we can safely remove as per my discussions with kainino@ and enga@. We still need GLFW for OpenGL, so we conditionally include it on platforms that enable the OpenGL backend (which Chrome OS is not). Note: enga@ suggested to create a VulkanWindowlessBinding that has an empty GetSwapChainImplementation, but after exploring the option, it seems like a bit too many ifdefs. In the end, I think it's cleaner to just remove the *Binding classes entirely. BUG=chromium:993457 TEST=tests compile and pass for all values of dawn_enable_opengl Change-Id: I067b12a23f2c236f5506252cd7727b847e79a667 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
2019-08-13 21:45:44 +00:00
Add WrapSharedHandle to D3D12 backend WrapSharedHandle uses a HANDLE and an acquire key to create a Dawn texture object. A future change will use the acquire key to manage a keyed shared mutex with Chromium code. Bug: dawn:27 Change-Id: I1c0ef8d022158abf3f1c6731a37ee3f51632fcf9 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10540 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-09-02 19:19:34 +00:00
if (dawn_enable_d3d12) {
sources += [ "src/tests/end2end/D3D12ResourceWrappingTests.cpp" ]
libs += [
"d3d11.lib",
"dxgi.lib",
]
}
Remove GLFW dependency for non-GL tests As part of enabling WebGPU on Chrome OS, we would like to run the Dawn unit and e2e tests as part of the Chrome OS test suite. This CL removes the GLFW dependency because Chrome OS does not support GLFW. The GLFWwindow is only used to create swap chains for the various backends, but these swap chains are not actually used in the tests (the e2e tests render to textures instead). The swap chains are only referenced as part of an unused debugging function: SwapBuffersForCapture which we can safely remove as per my discussions with kainino@ and enga@. We still need GLFW for OpenGL, so we conditionally include it on platforms that enable the OpenGL backend (which Chrome OS is not). Note: enga@ suggested to create a VulkanWindowlessBinding that has an empty GetSwapChainImplementation, but after exploring the option, it seems like a bit too many ifdefs. In the end, I think it's cleaner to just remove the *Binding classes entirely. BUG=chromium:993457 TEST=tests compile and pass for all values of dawn_enable_opengl Change-Id: I067b12a23f2c236f5506252cd7727b847e79a667 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
2019-08-13 21:45:44 +00:00
if (dawn_enable_opengl) {
Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
deps += [ ":dawn_glfw" ]
Remove GLFW dependency for non-GL tests As part of enabling WebGPU on Chrome OS, we would like to run the Dawn unit and e2e tests as part of the Chrome OS test suite. This CL removes the GLFW dependency because Chrome OS does not support GLFW. The GLFWwindow is only used to create swap chains for the various backends, but these swap chains are not actually used in the tests (the e2e tests render to textures instead). The swap chains are only referenced as part of an unused debugging function: SwapBuffersForCapture which we can safely remove as per my discussions with kainino@ and enga@. We still need GLFW for OpenGL, so we conditionally include it on platforms that enable the OpenGL backend (which Chrome OS is not). Note: enga@ suggested to create a VulkanWindowlessBinding that has an empty GetSwapChainImplementation, but after exploring the option, it seems like a bit too many ifdefs. In the end, I think it's cleaner to just remove the *Binding classes entirely. BUG=chromium:993457 TEST=tests compile and pass for all values of dawn_enable_opengl Change-Id: I067b12a23f2c236f5506252cd7727b847e79a667 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
2019-08-13 21:45:44 +00:00
}
Add wrapping for using external vulkan images as textures This change adds platform-dependent services that handle creating semaphores and importing image memory. Then, we use them to wrap a texture from an outside source, and release a signal semaphore back when we're done with it. This will be used to allow chrome to render dawn on Vulkan platforms. Bug: chromium:976495 Change-Id: I9f07eaf436e10aa6bd88cffdc74fd23834d62ee0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8340 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-10 03:17:52 +00:00
}
source_set("dawn_white_box_tests_sources") {
configs += [ "${dawn_root}/src/common:dawn_internal" ]
testonly = true
deps = [
":dawn_utils",
":libdawn_native",
":libdawn_native_sources",
":libdawn_wire",
"${dawn_root}/src/common",
Split the libdawn target in components with a single purpose. The functionality of the dawn_headers and libdawn targets are split into the following targets: - dawn_headers: the new version only exposes the "dawn.h" C API and no longer includes the C++ API. - dawncpp: the header and implementation of the C++ API that wraps the C API. This is unbundled from the rest so the C++ API can be used with libdawn_proc or other libraries implementing the C API. - libdawn_proc: A DawnProcTable-backend implementation of the C API. This is needed because in follow-up commit there will be three libraries implementing the C API: libdawn_proc that trampolines where we want, and libdawn_native/wire that don't have trampolines for better perf. BUG=dawn:22 Change-Id: I5d941f0d98e5a4b633e14d67eb5269f7924f0647 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12160 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-10-15 11:44:38 +00:00
"${dawn_root}/src/dawn:dawncpp",
"${dawn_root}/src/dawn:libdawn_proc",
Add wrapping for using external vulkan images as textures This change adds platform-dependent services that handle creating semaphores and importing image memory. Then, we use them to wrap a texture from an outside source, and release a signal semaphore back when we're done with it. This will be used to allow chrome to render dawn on Vulkan platforms. Bug: chromium:976495 Change-Id: I9f07eaf436e10aa6bd88cffdc74fd23834d62ee0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8340 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-10 03:17:52 +00:00
"third_party:gmock_and_gtest",
]
sources = [
"src/tests/DawnTest.h",
]
if (dawn_enable_vulkan) {
deps += [ "third_party:vulkan_headers" ]
if (is_linux) {
sources += [ "src/tests/white_box/VulkanImageWrappingTests.cpp" ]
}
}
Remove GLFW dependency for non-GL tests As part of enabling WebGPU on Chrome OS, we would like to run the Dawn unit and e2e tests as part of the Chrome OS test suite. This CL removes the GLFW dependency because Chrome OS does not support GLFW. The GLFWwindow is only used to create swap chains for the various backends, but these swap chains are not actually used in the tests (the e2e tests render to textures instead). The swap chains are only referenced as part of an unused debugging function: SwapBuffersForCapture which we can safely remove as per my discussions with kainino@ and enga@. We still need GLFW for OpenGL, so we conditionally include it on platforms that enable the OpenGL backend (which Chrome OS is not). Note: enga@ suggested to create a VulkanWindowlessBinding that has an empty GetSwapChainImplementation, but after exploring the option, it seems like a bit too many ifdefs. In the end, I think it's cleaner to just remove the *Binding classes entirely. BUG=chromium:993457 TEST=tests compile and pass for all values of dawn_enable_opengl Change-Id: I067b12a23f2c236f5506252cd7727b847e79a667 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
2019-08-13 21:45:44 +00:00
if (dawn_enable_opengl) {
Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
deps += [ ":dawn_glfw" ]
Remove GLFW dependency for non-GL tests As part of enabling WebGPU on Chrome OS, we would like to run the Dawn unit and e2e tests as part of the Chrome OS test suite. This CL removes the GLFW dependency because Chrome OS does not support GLFW. The GLFWwindow is only used to create swap chains for the various backends, but these swap chains are not actually used in the tests (the e2e tests render to textures instead). The swap chains are only referenced as part of an unused debugging function: SwapBuffersForCapture which we can safely remove as per my discussions with kainino@ and enga@. We still need GLFW for OpenGL, so we conditionally include it on platforms that enable the OpenGL backend (which Chrome OS is not). Note: enga@ suggested to create a VulkanWindowlessBinding that has an empty GetSwapChainImplementation, but after exploring the option, it seems like a bit too many ifdefs. In the end, I think it's cleaner to just remove the *Binding classes entirely. BUG=chromium:993457 TEST=tests compile and pass for all values of dawn_enable_opengl Change-Id: I067b12a23f2c236f5506252cd7727b847e79a667 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
2019-08-13 21:45:44 +00:00
}
Add wrapping for using external vulkan images as textures This change adds platform-dependent services that handle creating semaphores and importing image memory. Then, we use them to wrap a texture from an outside source, and release a signal semaphore back when we're done with it. This will be used to allow chrome to render dawn on Vulkan platforms. Bug: chromium:976495 Change-Id: I9f07eaf436e10aa6bd88cffdc74fd23834d62ee0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8340 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-10 03:17:52 +00:00
libs = []
}
test("dawn_end2end_tests") {
configs += [ "${dawn_root}/src/common:dawn_internal" ]
deps = [
":dawn_end2end_tests_sources",
":dawn_utils",
":dawn_white_box_tests_sources",
":libdawn_native",
":libdawn_wire",
"${dawn_root}/src/common",
Split the libdawn target in components with a single purpose. The functionality of the dawn_headers and libdawn targets are split into the following targets: - dawn_headers: the new version only exposes the "dawn.h" C API and no longer includes the C++ API. - dawncpp: the header and implementation of the C++ API that wraps the C API. This is unbundled from the rest so the C++ API can be used with libdawn_proc or other libraries implementing the C API. - libdawn_proc: A DawnProcTable-backend implementation of the C API. This is needed because in follow-up commit there will be three libraries implementing the C API: libdawn_proc that trampolines where we want, and libdawn_native/wire that don't have trampolines for better perf. BUG=dawn:22 Change-Id: I5d941f0d98e5a4b633e14d67eb5269f7924f0647 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12160 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-10-15 11:44:38 +00:00
"${dawn_root}/src/dawn:dawncpp",
"${dawn_root}/src/dawn:libdawn_proc",
Add wrapping for using external vulkan images as textures This change adds platform-dependent services that handle creating semaphores and importing image memory. Then, we use them to wrap a texture from an outside source, and release a signal semaphore back when we're done with it. This will be used to allow chrome to render dawn on Vulkan platforms. Bug: chromium:976495 Change-Id: I9f07eaf436e10aa6bd88cffdc74fd23834d62ee0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8340 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-08-10 03:17:52 +00:00
"third_party:gmock_and_gtest",
]
sources = [
"src/tests/DawnTest.cpp",
"src/tests/DawnTest.h",
]
libs = []
Implement wrapping IOSurfaces in dawn::Texture. This allows wrapping IOSurfaces in a dawn::Texture so a Dawn application can sample from, or render to an IOSurface. It uses Metal's functionality for wrapping textures in MTLTexture. Support for single-plane BGRA8, RG8 and R8 IOSurfaces is added as well as tests for sampling and using BeginRenderPass to clear them. BUG=dawn:112 Change-Id: I367dbd1a75a0c7b81901fb0aae05f1cd46af3f3a Reviewed-on: https://dawn-review.googlesource.com/c/5101 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-03-01 12:01:18 +00:00
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
# When building inside Chromium, use their gtest main function because it is
# needed to run in swarming correctly.
if (build_with_chromium) {
sources += [ "//gpu/dawn_end2end_tests_main.cc" ]
} else {
sources += [ "src/tests/End2EndTestsMain.cpp" ]
}
Remove GLFW dependency for non-GL tests As part of enabling WebGPU on Chrome OS, we would like to run the Dawn unit and e2e tests as part of the Chrome OS test suite. This CL removes the GLFW dependency because Chrome OS does not support GLFW. The GLFWwindow is only used to create swap chains for the various backends, but these swap chains are not actually used in the tests (the e2e tests render to textures instead). The swap chains are only referenced as part of an unused debugging function: SwapBuffersForCapture which we can safely remove as per my discussions with kainino@ and enga@. We still need GLFW for OpenGL, so we conditionally include it on platforms that enable the OpenGL backend (which Chrome OS is not). Note: enga@ suggested to create a VulkanWindowlessBinding that has an empty GetSwapChainImplementation, but after exploring the option, it seems like a bit too many ifdefs. In the end, I think it's cleaner to just remove the *Binding classes entirely. BUG=chromium:993457 TEST=tests compile and pass for all values of dawn_enable_opengl Change-Id: I067b12a23f2c236f5506252cd7727b847e79a667 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
2019-08-13 21:45:44 +00:00
if (dawn_enable_opengl) {
Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
deps += [ ":dawn_glfw" ]
Remove GLFW dependency for non-GL tests As part of enabling WebGPU on Chrome OS, we would like to run the Dawn unit and e2e tests as part of the Chrome OS test suite. This CL removes the GLFW dependency because Chrome OS does not support GLFW. The GLFWwindow is only used to create swap chains for the various backends, but these swap chains are not actually used in the tests (the e2e tests render to textures instead). The swap chains are only referenced as part of an unused debugging function: SwapBuffersForCapture which we can safely remove as per my discussions with kainino@ and enga@. We still need GLFW for OpenGL, so we conditionally include it on platforms that enable the OpenGL backend (which Chrome OS is not). Note: enga@ suggested to create a VulkanWindowlessBinding that has an empty GetSwapChainImplementation, but after exploring the option, it seems like a bit too many ifdefs. In the end, I think it's cleaner to just remove the *Binding classes entirely. BUG=chromium:993457 TEST=tests compile and pass for all values of dawn_enable_opengl Change-Id: I067b12a23f2c236f5506252cd7727b847e79a667 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
2019-08-13 21:45:44 +00:00
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
}
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
Add Dawn perf test harness This patch adds a perf test harness for Dawn and a simple test of buffer upload performance. The test harness is based off of ANGLE's perf tests. Because perf tests are parameterized to support multiple test variants, this patch also adds DawnTestWithParams and ParamGenerator to support instantiating tests with additional parameters. Bug: dawn:208 Change-Id: I60df730e9f9f21a4c29fc21ea1a8315e4fff1aa6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10340 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-08-28 23:18:10 +00:00
test("dawn_perf_tests") {
configs += [ "${dawn_root}/src/common:dawn_internal" ]
deps = [
":dawn_utils",
":libdawn_native",
":libdawn_wire",
"${dawn_root}/src/common",
Split the libdawn target in components with a single purpose. The functionality of the dawn_headers and libdawn targets are split into the following targets: - dawn_headers: the new version only exposes the "dawn.h" C API and no longer includes the C++ API. - dawncpp: the header and implementation of the C++ API that wraps the C API. This is unbundled from the rest so the C++ API can be used with libdawn_proc or other libraries implementing the C API. - libdawn_proc: A DawnProcTable-backend implementation of the C API. This is needed because in follow-up commit there will be three libraries implementing the C API: libdawn_proc that trampolines where we want, and libdawn_native/wire that don't have trampolines for better perf. BUG=dawn:22 Change-Id: I5d941f0d98e5a4b633e14d67eb5269f7924f0647 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12160 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-10-15 11:44:38 +00:00
"${dawn_root}/src/dawn:dawncpp",
"${dawn_root}/src/dawn:libdawn_proc",
Add Dawn perf test harness This patch adds a perf test harness for Dawn and a simple test of buffer upload performance. The test harness is based off of ANGLE's perf tests. Because perf tests are parameterized to support multiple test variants, this patch also adds DawnTestWithParams and ParamGenerator to support instantiating tests with additional parameters. Bug: dawn:208 Change-Id: I60df730e9f9f21a4c29fc21ea1a8315e4fff1aa6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10340 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-08-28 23:18:10 +00:00
"third_party:gmock_and_gtest",
]
sources = [
"src/tests/DawnTest.cpp",
"src/tests/DawnTest.h",
"src/tests/ParamGenerator.h",
"src/tests/perf_tests/BufferUploadPerf.cpp",
"src/tests/perf_tests/DawnPerfTest.cpp",
"src/tests/perf_tests/DawnPerfTest.h",
]
libs = []
# When building inside Chromium, use their gtest main function because it is
# needed to run in swarming correctly.
if (build_with_chromium) {
sources += [ "//gpu/dawn_perf_tests_main.cc" ]
} else {
sources += [ "src/tests/PerfTestsMain.cpp" ]
}
if (dawn_enable_metal) {
libs += [ "IOSurface.framework" ]
}
if (dawn_enable_opengl) {
Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
deps += [ ":dawn_glfw" ]
Add Dawn perf test harness This patch adds a perf test harness for Dawn and a simple test of buffer upload performance. The test harness is based off of ANGLE's perf tests. Because perf tests are parameterized to support multiple test variants, this patch also adds DawnTestWithParams and ParamGenerator to support instantiating tests with additional parameters. Bug: dawn:208 Change-Id: I60df730e9f9f21a4c29fc21ea1a8315e4fff1aa6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10340 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-08-28 23:18:10 +00:00
}
}
BUILD.gn: Add temporary proxy groups for test targets This will allow use to update gn_isolate_map_pyl to point to the groups instead of the targets, while we move the actual targets in a different file. BUG=chromium:913171 Change-Id: Ic681fb12d9cbc99557b742784f5b1bf779b76ed1 Reviewed-on: https://dawn-review.googlesource.com/c/3100 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-10 16:45:24 +00:00
# Temporary groups to make a 5-way patch to fix crbug.com/913171
group("dawn_unittests_temp_group") {
testonly = true
Make TextureDescriptor match WebGPU IDL This patch updates the definition of TextureDescriptor to make it match WebGPU IDL: 1. Rename 'arrayLayer' to 'arraySize' 2. Add the missing member "sampleCount" and check that currently sampleCount can only be 1. BUG=dawn:56 TEST=dawn_unittests Change-Id: I642186529f045865ae344cb5545ac80e14445c59 Reviewed-on: https://dawn-review.googlesource.com/c/3180 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-12 09:27:16 +00:00
deps = [
":dawn_unittests",
]
BUILD.gn: Add temporary proxy groups for test targets This will allow use to update gn_isolate_map_pyl to point to the groups instead of the targets, while we move the actual targets in a different file. BUG=chromium:913171 Change-Id: Ic681fb12d9cbc99557b742784f5b1bf779b76ed1 Reviewed-on: https://dawn-review.googlesource.com/c/3100 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-10 16:45:24 +00:00
}
group("dawn_end2end_tests_temp_group") {
testonly = true
Make TextureDescriptor match WebGPU IDL This patch updates the definition of TextureDescriptor to make it match WebGPU IDL: 1. Rename 'arrayLayer' to 'arraySize' 2. Add the missing member "sampleCount" and check that currently sampleCount can only be 1. BUG=dawn:56 TEST=dawn_unittests Change-Id: I642186529f045865ae344cb5545ac80e14445c59 Reviewed-on: https://dawn-review.googlesource.com/c/3180 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-12 09:27:16 +00:00
deps = [
":dawn_end2end_tests",
]
BUILD.gn: Add temporary proxy groups for test targets This will allow use to update gn_isolate_map_pyl to point to the groups instead of the targets, while we move the actual targets in a different file. BUG=chromium:913171 Change-Id: Ic681fb12d9cbc99557b742784f5b1bf779b76ed1 Reviewed-on: https://dawn-review.googlesource.com/c/3100 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-10 16:45:24 +00:00
}
Add Dawn perf test harness This patch adds a perf test harness for Dawn and a simple test of buffer upload performance. The test harness is based off of ANGLE's perf tests. Because perf tests are parameterized to support multiple test variants, this patch also adds DawnTestWithParams and ParamGenerator to support instantiating tests with additional parameters. Bug: dawn:208 Change-Id: I60df730e9f9f21a4c29fc21ea1a8315e4fff1aa6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10340 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-08-28 23:18:10 +00:00
group("dawn_perf_tests_temp_group") {
testonly = true
deps = [
":dawn_perf_tests",
]
Add dawn_perf_tests as a data_dep of dawn_perf_tests_temp_group This is needed so that the script to produce the isolate can correctly detect the binary. Bug: dawn:208 TBR: cwallez@chromium.org Change-Id: I62fc4c40edfe9320d55a587d2176bbd9c93bb540 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10761 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-08-30 19:16:46 +00:00
data_deps = [
":dawn_perf_tests",
]
Add Dawn perf test harness This patch adds a perf test harness for Dawn and a simple test of buffer upload performance. The test harness is based off of ANGLE's perf tests. Because perf tests are parameterized to support multiple test variants, this patch also adds DawnTestWithParams and ParamGenerator to support instantiating tests with additional parameters. Bug: dawn:208 Change-Id: I60df730e9f9f21a4c29fc21ea1a8315e4fff1aa6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10340 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-08-28 23:18:10 +00:00
}
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
###############################################################################
# Dawn samples, only in standalone builds
###############################################################################
if (dawn_standalone) {
# Static library to contain code and dependencies common to all samples
static_library("dawn_sample_utils") {
sources = [
"examples/SampleUtils.cpp",
"examples/SampleUtils.h",
]
# Export all of these as public deps so that `gn check` allows includes
public_deps = [
Remove GLFW dependency for non-GL tests As part of enabling WebGPU on Chrome OS, we would like to run the Dawn unit and e2e tests as part of the Chrome OS test suite. This CL removes the GLFW dependency because Chrome OS does not support GLFW. The GLFWwindow is only used to create swap chains for the various backends, but these swap chains are not actually used in the tests (the e2e tests render to textures instead). The swap chains are only referenced as part of an unused debugging function: SwapBuffersForCapture which we can safely remove as per my discussions with kainino@ and enga@. We still need GLFW for OpenGL, so we conditionally include it on platforms that enable the OpenGL backend (which Chrome OS is not). Note: enga@ suggested to create a VulkanWindowlessBinding that has an empty GetSwapChainImplementation, but after exploring the option, it seems like a bit too many ifdefs. In the end, I think it's cleaner to just remove the *Binding classes entirely. BUG=chromium:993457 TEST=tests compile and pass for all values of dawn_enable_opengl Change-Id: I067b12a23f2c236f5506252cd7727b847e79a667 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
2019-08-13 21:45:44 +00:00
":dawn_bindings",
Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
":dawn_glfw",
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
":dawn_utils",
":libdawn_native",
":libdawn_wire",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
Split the libdawn target in components with a single purpose. The functionality of the dawn_headers and libdawn targets are split into the following targets: - dawn_headers: the new version only exposes the "dawn.h" C API and no longer includes the C++ API. - dawncpp: the header and implementation of the C++ API that wraps the C API. This is unbundled from the rest so the C++ API can be used with libdawn_proc or other libraries implementing the C API. - libdawn_proc: A DawnProcTable-backend implementation of the C API. This is needed because in follow-up commit there will be three libraries implementing the C API: libdawn_proc that trampolines where we want, and libdawn_native/wire that don't have trampolines for better perf. BUG=dawn:22 Change-Id: I5d941f0d98e5a4b633e14d67eb5269f7924f0647 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12160 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-10-15 11:44:38 +00:00
"${dawn_root}/src/dawn:dawncpp",
"${dawn_root}/src/dawn:libdawn_proc",
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
]
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
public_configs = [ "${dawn_root}/src/common:dawn_internal" ]
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
}
# Template for samples to avoid listing dawn_sample_utils as a dep every time
template("dawn_sample") {
executable(target_name) {
deps = [
":dawn_sample_utils",
]
forward_variables_from(invoker, "*", [ "deps" ])
if (defined(invoker.deps)) {
deps += invoker.deps
}
}
}
dawn_sample("CppHelloTriangle") {
sources = [
"examples/CppHelloTriangle.cpp",
]
}
dawn_sample("CHelloTriangle") {
sources = [
"examples/CHelloTriangle.cpp",
]
}
dawn_sample("ComputeBoids") {
sources = [
"examples/ComputeBoids.cpp",
]
deps = [
"third_party:glm",
]
}
dawn_sample("Animometer") {
sources = [
"examples/Animometer.cpp",
]
}
dawn_sample("CubeReflection") {
sources = [
"examples/CubeReflection.cpp",
]
deps = [
"third_party:glm",
]
}
BUILD.gn: Add a dawn_samples group BUG= Change-Id: I328bdc960bfc28a1ea16ca0c6705cb60b929109f Reviewed-on: https://dawn-review.googlesource.com/1542 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-09-20 21:17:14 +00:00
group("dawn_samples") {
deps = [
Fix for D3D12 re-used bindgroup bug. If a bindgroup was re-used in multiple command buffers in a single call to queue.Submit(), it was skipping the creation of the corresponding descriptor heap for that bind group in the second command buffer. The fix is to use the command buffer's index into the submit command as part of the key for the bind group's descriptor heap. Change-Id: Ie66a0e772b10cc72bf040f090dac4c4a10f24266 Reviewed-on: https://dawn-review.googlesource.com/c/1740 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
2018-10-04 16:59:05 +00:00
":Animometer",
BUILD.gn: Add a dawn_samples group BUG= Change-Id: I328bdc960bfc28a1ea16ca0c6705cb60b929109f Reviewed-on: https://dawn-review.googlesource.com/1542 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-09-20 21:17:14 +00:00
":CHelloTriangle",
":ComputeBoids",
Fix for D3D12 re-used bindgroup bug. If a bindgroup was re-used in multiple command buffers in a single call to queue.Submit(), it was skipping the creation of the corresponding descriptor heap for that bind group in the second command buffer. The fix is to use the command buffer's index into the submit command as part of the key for the bind group's descriptor heap. Change-Id: Ie66a0e772b10cc72bf040f090dac4c4a10f24266 Reviewed-on: https://dawn-review.googlesource.com/c/1740 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
2018-10-04 16:59:05 +00:00
":CppHelloTriangle",
BUILD.gn: Add a dawn_samples group BUG= Change-Id: I328bdc960bfc28a1ea16ca0c6705cb60b929109f Reviewed-on: https://dawn-review.googlesource.com/1542 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-09-20 21:17:14 +00:00
":CubeReflection",
]
}
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
}
Add fuzzers for SPIRV-Cross This CL adds in fuzzers for SPIRV-Cross for HLSL, GLSL, and MSL outputs. These fuzzers live in Dawn because there is not appropriate location in the Chromium source repo for them and it is unlikely they would be land-able in the SPIRV-Cross repo, because it is not coupled with Chromium's build system and thus Clusterfuzz so would be effectively dead code. Dawn depends on this code, but it is also integrated into the Chromium build system, so this was the best place I could find for them The code under fuzz unfortunately uses exceptions/aborting as its error reporting mechanism. This is an acknowledge short coming and there are efforts to remove this behaviour. To work around this and reduce the number of false positives found by the fuzzers, a signal trap has been implemented which will be removed once the code under fuzz has been updated. The trap replaces the existing signal handler and silencing signals while running the code under test. This allows the code under test to call abort() and not crash the fuzzing process. Theoretically, only SIGABRT should need to be trapped, but something is causing the signal from abort() to be converted to SIGSEGV when running under ASAN. This signal trap has been tested with the fuzzing/sanitizers by intentionally inserting bad calls that will occur after a few thousand test cases. It was confirmed that the fuzzer detected the issue and stops fuzzing. The alternate to implementing this signal trap would be to turn on exceptions for the fuzzer. This was attempted, but proved to be fruitless due to what was reported as an ODR issue, but couldn't couldn't be silenced. The likely underlying issue was a pre-built library or other object being built without exceptions was causing different versions of symbols or the exception version of the standard library not being instrumented by ASAN. Given the majority of Chromium eco-system turns off exceptions, fixing this issue would not be helpful to the larger community and was looking like it would require significant effort. BUG=chromium:903380 Change-Id: I63a5595383f99b7a0e150d72bb04c89b8d722631 Reviewed-on: https://dawn-review.googlesource.com/c/2260 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-11-12 12:20:21 +00:00
###############################################################################
# Fuzzers
###############################################################################
Build fuzzer tests in standalone builds too. This will avoid compilation to break, and adds standalone reproducers for the fuzzer_tests. BUG=chromium:903380 BUG=dawn:34 Change-Id: I9995a852076d9f6d1ebdee5b999989c2d74d4709 Reviewed-on: https://dawn-review.googlesource.com/c/2321 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Dan Sinclair <dsinclair@google.com>
2018-11-12 18:09:56 +00:00
group("dawn_fuzzers") {
testonly = true
deps = [
"src/fuzzers:dawn_spirv_cross_glsl_fast_fuzzer",
"src/fuzzers:dawn_spirv_cross_hlsl_fast_fuzzer",
"src/fuzzers:dawn_spirv_cross_msl_fast_fuzzer",
"src/fuzzers:dawn_wire_server_and_frontend_fuzzer",
]
Add fuzzers for SPIRV-Cross This CL adds in fuzzers for SPIRV-Cross for HLSL, GLSL, and MSL outputs. These fuzzers live in Dawn because there is not appropriate location in the Chromium source repo for them and it is unlikely they would be land-able in the SPIRV-Cross repo, because it is not coupled with Chromium's build system and thus Clusterfuzz so would be effectively dead code. Dawn depends on this code, but it is also integrated into the Chromium build system, so this was the best place I could find for them The code under fuzz unfortunately uses exceptions/aborting as its error reporting mechanism. This is an acknowledge short coming and there are efforts to remove this behaviour. To work around this and reduce the number of false positives found by the fuzzers, a signal trap has been implemented which will be removed once the code under fuzz has been updated. The trap replaces the existing signal handler and silencing signals while running the code under test. This allows the code under test to call abort() and not crash the fuzzing process. Theoretically, only SIGABRT should need to be trapped, but something is causing the signal from abort() to be converted to SIGSEGV when running under ASAN. This signal trap has been tested with the fuzzing/sanitizers by intentionally inserting bad calls that will occur after a few thousand test cases. It was confirmed that the fuzzer detected the issue and stops fuzzing. The alternate to implementing this signal trap would be to turn on exceptions for the fuzzer. This was attempted, but proved to be fruitless due to what was reported as an ODR issue, but couldn't couldn't be silenced. The likely underlying issue was a pre-built library or other object being built without exceptions was causing different versions of symbols or the exception version of the standard library not being instrumented by ASAN. Given the majority of Chromium eco-system turns off exceptions, fixing this issue would not be helpful to the larger community and was looking like it would require significant effort. BUG=chromium:903380 Change-Id: I63a5595383f99b7a0e150d72bb04c89b8d722631 Reviewed-on: https://dawn-review.googlesource.com/c/2260 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-11-12 12:20:21 +00:00
}