11018 Commits

Author SHA1 Message Date
Bryan Bernhart
988f19e208 Pool sub-allocated resource heaps.
Allow resource heaps to be recycled when
no longer used.

BUG=dawn:496

Change-Id: I36518f8b0c0b26d2cceecc4e7b05e00a5fd5bd25
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26126
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2020-08-17 17:47:15 +00:00
Sarah Mashayekhi
b08e253886 [validation] Validates if return statement type matches function return type
This CL checks if the return statement type matches the function return type

Bug: tint 6
Change-Id: I621d67086291c392b68261673a25c0e6caca71ae
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26860
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-17 15:46:07 +00:00
Sarah Mashayekhi
eec1a6e628 [validation] Validates function name uniqueness
This CL implements and add a test for the following validation rule:
v-0016: Function names must be unique

Bug: tint: 6
Change-Id: I9f135dd577863e41f03a2d02adebe4347a9922eb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26782
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-17 15:32:38 +00:00
Austin Eng
5e9b29fab9 Fix ASSERT in WindowsDebugLogger
SetEvent returns non-zero on success, not zero.

Tbr=cwallez@chromium.org
Bug: none
Change-Id: Ib6ea74b19799bc3211136a5788b2bce8880f3b17
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26841
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2020-08-14 22:44:02 +00:00
Austin Eng
f580096468 end2end_tests: Forward Windows debug messages to stderr
When validation layers are enabled, D3D12 warnings and error
messages are logged to the shared DBWIN_BUFFER segment of memory.
This CL has makes the test environment watch for new events and
logs them to stderr so they show up in the test bot logs. This helps
debug problems in the D3D12 backend which previously just crashed
with a general Device Lost message.

Bug: none
Change-Id: I0eaddf9e16303bd65579e85fe6693bd8cdfbd8da
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26640
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Bryan Bernhart <bryan.bernhart@intel.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2020-08-14 21:02:12 +00:00
Corentin Wallez
24b5971b84 Remove deprecated wgpu::BufferCopyView members
Bug: dawn:22

Change-Id: Iec26e9945443411a8f322a80d7e63c96c74f3508
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26702
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2020-08-14 09:31:00 +00:00
Idan Raiter
d315022be5 Add Metal vertex pulling behind a flag
Implements vertex pulling on the Metal backend, hidden behind a flag
until ready for use (we are missing support for more complicated vertex
input types).

Bug: dawn:480
Change-Id: I38028b80673693ebf21309ad5336561fb99f40dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26522
Commit-Queue: Idan Raiter <idanr@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2020-08-13 23:53:59 +00:00
Idan Raiter
e1604b9a64 Enable robust buffer access pass if robustness on
Turns on SPVC buffer access pass if robustness is also enabled.

Bug: dawn:480
Change-Id: Ib4d74e177f4f65139219f3ce8662566370f4a108
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26741
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2020-08-13 20:53:59 +00:00
Enrico Galli
76d9e34bbc Eagerly destroy CommandBuffer commands after submission
Command buffers hold references to all encoded objects. Freeing them
eagerly significantly reduces the amount memory held before the JS GC
clears the command buffers.

Bug: dawn:262, dawn:372
Change-Id: I68dfa973f980fba8d94611ed1de3c593bdb91a63
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26562
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2020-08-13 20:25:39 +00:00
Austin Eng
f7905c3cb5 Roll 5 dependencies
Roll third_party/glslang/ b60e067b4..d253278f9 (2 commits)

b60e067b43..d253278f98

$ git log b60e067b4..d253278f9 --date=short --no-merges --format='%ad %ae %s'
2020-08-12 alanbaker Update test expectations
2020-08-12 alanbaker Update SPIRV-Tools and SPIRV-Headers known good

Created with:
  roll-dep third_party/glslang

Change-Id: I1aea9a8360edcbc16c46fdcf36c2d0d18b544540

Roll third_party/shaderc/ c626b912d..ffd805115 (2 commits)

c626b912dc..ffd805115e

$ git log c626b912d..ffd805115 --date=short --no-merges --format='%ad %ae %s'
2020-08-13 rharrison Add support for Dawn using deprecated Options constructor (#1130)
2020-08-10 rharrison Roll 5 dependencies and update expectations (#1129)

Created with:
  roll-dep third_party/shaderc

Change-Id: I2c4482711a1951d10d5592308f5a378bfe2114f3

Roll third_party/spirv-cross/ 82d1c43e4..4c7944bb4 (1 commit)

82d1c43e40..4c7944bb42

$ git log 82d1c43e4..4c7944bb4 --date=short --no-merges --format='%ad %ae %s'
2020-08-13 lehoangq Fix #1445: MSL: Enclose args when convert distance(a,b) to abs(a-b)

Created with:
  roll-dep third_party/spirv-cross

Change-Id: I69886c8b47ebc66fd98228a97203bc8835dfb314

Roll third_party/SPIRV-Tools/ 2990a2192..b4c4da3e7 (15 commits)

2990a21926..b4c4da3e76

$ git log 2990a2192..b4c4da3e7 --date=short --no-merges --format='%ad %ae %s'
2020-08-13 alanbaker Improve non-semantic instruction handling in the optimizer (#3693)
2020-08-13 vasniktel Fix the bug (#3680)
2020-08-12 andreperezmaselco.developer spirv-fuzz: Check integer and float width capabilities (#3670)
2020-08-12 andreperezmaselco.developer spirv-fuzz: consider additional access chain instructions (#3672)
2020-08-12 andreperezmaselco.developer spirv-fuzz: Ignore specialization constants (#3664)
2020-08-12 vasniktel Fix the bug (#3683)
2020-08-12 vasniktel spirv-fuzz: Fix width in FuzzerPassAddEquationInstructions (#3685)
2020-08-12 jaebaek Preserve debug info in dead-insert-elim pass (#3652)
2020-08-12 jaebaek Validate more OpenCL.DebugInfo.100 instructions (#3684)
2020-08-11 alanbaker Only validation locations for appropriate execution models (#3656)
2020-08-11 andreperezmaselco.developer spirv-fuzz: Fix in operand type assertion (#3666)
2020-08-11 andreperezmaselco.developer spirv-opt: Add spvOpcodeIsAccessChain (#3682)
2020-08-11 vasniktel spirv-fuzz: FuzzerPassPropagateInstructionsUp (#3478)
2020-08-10 stevenperron Handle no index access chain in local access chain convert (#3678)
2020-08-10 rharrison Roll 2 dependencies (#3677)

Created with:
  roll-dep third_party/SPIRV-Tools

Change-Id: I1a07ba8931ec0b3ec8d70234f8aa871793df6fa0

Roll third_party/tint/ 5e7ef27ca..23c3fee35 (3 commits)

https://dawn.googlesource.com/tint/+log/5e7ef27ca7b1..23c3fee35436

$ git log 5e7ef27ca..23c3fee35 --date=short --no-merges --format='%ad %ae %s'
2020-08-13 sarahmashay [validation]: Add disabled test for validating return statement type matches function types
2020-08-13 sarahmashay [validation] Validates return statement
2020-08-13 rharrison Fix handling of .spvasm inputs

Created with:
  roll-dep third_party/tint

Change-Id: I70f8e484d12df835efce98db28b22d0cfa848a0b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26800
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2020-08-13 20:18:39 +00:00
Sarah Mashayekhi
23c3fee354 [validation]: Add disabled test for validating return statement type matches function types
Bug: tint: 6
Change-Id: I573cd4fb5759f1d72dd2e0f04a1dd183879745d6
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26723
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-13 19:17:49 +00:00
Sarah Mashayekhi
d73f812c84 [validation] Validates return statement
This CL checks if functions end with a return statement (v-0002)
reworks previously added tests to pass
enables related tests

Bug: tint: 6
Change-Id: Iafe46581ccc50e146b33d33f9577d995a7f80d77
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26722
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-13 18:09:59 +00:00
Ryan Harrison
a532ac55d9 Fix handling of .spvasm inputs
BUG=tint:207

Change-Id: Ic429a909d092423908409678b7256bd88de10a99
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26760
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-13 17:33:59 +00:00
Corentin Wallez
13f3340173 Remove wgpu::Buffer::SetSubData
Bug: dawn:22

Change-Id: Id2bb79e84064c0d81d4dec5e85340d015806f9bc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26701
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2020-08-13 16:01:08 +00:00
Corentin Wallez
e236f7df27 Remove deprecated array layer descriptor members
- wgpu::TextureDescriptor::arrayLayerCount
 - wgpu::TextureCopyView::arrayLayer

Bug: dawn:22

Change-Id: I41a8b50c667f28c2496e0ad2e1d4ca655bf6c154
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26700
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2020-08-13 14:38:48 +00:00
Jiawei Shao
2b1c0b0e92 Clean up BufferZeroInitTests
BUG=dawn:414
TEST=dawn_end2end_tests

Change-Id: I8a9a4d45fe93e1071b8508ba7ddd2bf9545a3c63
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26641
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-08-13 12:03:28 +00:00
Austin Eng
4a486be696 Roll third_party/tint/ bc80805c4..5e7ef27ca (9 commits)
https://dawn.googlesource.com/tint/+log/bc80805c4b04..5e7ef27ca7b1

$ git log bc80805c4..5e7ef27ca --date=short --no-merges --format='%ad %ae %s'
2020-08-12 sarahmashay [ast] Adds get last statement to ast::Function
2020-08-12 sarahmashay [validation] Validates functions return statement
2020-08-12 dsinclair Minor updates to fix compilation.
2020-08-12 dsinclair Change output of string based data from sample app.
2020-08-12 idanr Find un-named entry points, change set number
2020-08-12 idanr Add instance step mode to vertex pulling transform
2020-08-12 idanr Add vertex pulling transform
2020-08-11 sarahmashay [validation] Validates declaration name uniqueness
2020-08-11 dsinclair Disable failing tests

Created with:
  roll-dep third_party/tint

Change-Id: I95394bd42e2a02bad36896188c7a1def2d140e78
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26740
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2020-08-12 23:13:08 +00:00
Sarah Mashayekhi
5e7ef27ca7 [ast] Adds get last statement to ast::Function
This CL adds a function which returns the last statement of a ast::Function

Change-Id: I1dc68b7f4669c17a24a62c03a87dcc95866a428d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26720
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-12 20:06:29 +00:00
Corentin Wallez
2088cdec66 Update tests to use new mapping APIs
This CL updates all tests not specific to the old mapping API to use the
new mapping APIs. (a couple old tests that caused difficult diffs were
removed early).

Also fix an issue where the mapAsync callback wasn't fired with Unknown
when the buffer was destroyed.

Bug: dawn:445

Change-Id: I0101f533ecb1fd995066742b60a833dc2ad522aa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26300
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-08-12 19:32:25 +00:00
Sarah Mashayekhi
f16250b8ac [validation] Validates functions return statement
This CL adds a disabled test for validation rule v-0002: functions must
end with a return statement

Bug: Tint: 6
Change-Id: I127aa1bd7d236ff353fd89024b274c9f9b463f15
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26680
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-12 19:31:42 +00:00
dan sinclair
633b1a7463 Minor updates to fix compilation.
This CL adds the needed `memory` include for clang on windows and fixes
up some issues to make doxygen happy again.

Change-Id: I2c3f21aa086b079d3b861786834bcf4370123a7d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26703
Reviewed-by: Idan Raiter <idanr@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-12 19:28:59 +00:00
dan sinclair
06176633ec Change output of string based data from sample app.
This CL updates the sample app to use the text writer in the case we are
neither SPIRV-Asm or SPIRV. This fixes up an issue where HLSL was
missing from the original if and caused it to not emit anything.

Bug: tint:7
Change-Id: Iee493e9cec6c62df7c57a2584e61f623d5151029
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26721
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2020-08-12 17:49:09 +00:00
Idan Raiter
eca0eaa006 Find un-named entry points, change set number
Finds entry points, and uses set 4 intentionally as it is bigger than
the maximum set for users.

Bug: dawn:480
Change-Id: I24f01d770ba43796233aeb40b3b6b2ae9b3c3663
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26520
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-12 17:44:01 +00:00
Idan Raiter
ef6a4af7b5 Add instance step mode to vertex pulling transform
Bug: dawn:480
Change-Id: Icf650b7f340528e6a49d68d155fd9becc212e623
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26440
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-12 17:30:08 +00:00
Idan Raiter
63551e3b2f Add vertex pulling transform
Adds a first-pass version of vertex pulling. This is missing several important things such as buffer offsets, support for more types, and clamping.

Bug: dawn:480, tint:206
Change-Id: Ia8a3abc446bca4c5a40e064f85fb59de1c3f5af9
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26260
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-12 17:23:58 +00:00
Corentin Wallez
1aff02d444 Small nits for the implementation of WriteTexture in D3D12
Bug: None

Change-Id: Id44ff878ac3fc9762008a7f8b95ee65072aa1fcd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26600
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-08-12 08:43:24 +00:00
Austin Eng
37f547456c Support depth-only/stencil-only copies on D3D12
Bug: dawn:439
Change-Id: I919a5e7bcb46f1817f9b15aaf49a1a72680aa47a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24960
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2020-08-12 01:57:54 +00:00
Sarah Mashayekhi
d3107bdbaa [validation] Validates declaration name uniqueness
This CL adds implementations and tests for these validation rules:
v-0011: Global variable names must be unique
v-0013: Variables declared in a function must be unique between that function and any global variables.
v-0014: Variables declared in a function must have unique names

Bug: tint 6
Change-Id: I793485c981f67abc6a3dc81d35be743ccc18db5b
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26480
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-11 20:44:06 +00:00
dan sinclair
a5e7ead0c6 Disable failing tests
A few of the tests depend on floating point string output which is
slightly different on MSVC. Disable for now.

Bug: tint:201
Change-Id: I51510a1192488f4e391dfb3560b5b6a2915ebcd1
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26220
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2020-08-11 20:23:40 +00:00
Tomek Ponitka
11c0f579b1 Adding validation for requiredBytesInCopy overflow
Also some uint32_t computations are now done on uint64_t.

Bug: dawn:482
Change-Id: Ia0094e16999ec3a9fec193f27760e73cd14d289c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26540
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Commit-Queue: Tomek Ponitka <tommek@google.com>
2020-08-11 12:04:52 +00:00
Natasha Lee
cbec3179ef Implement Queue::WriteTexture in D3D12
Bug: dawn:483
Change-Id: I9e5f54abc6675acbb11a021a3d38aea7195017c5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26320
Commit-Queue: Natasha Lee <natlee@microsoft.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2020-08-10 22:29:49 +00:00
Ryan Harrison
8fe202eccb Roll 3 dependencies
Roll third_party/glslang/ 2de6d657d..b60e067b4 (2 commits)

2de6d657dd..b60e067b43

$ git log 2de6d657d..b60e067b4 --date=short --no-merges --format='%ad %ae %s'
2020-08-06 john SPV: Fix #1829: don't emit OpModuleProcessed use-storage-buffer
2020-08-05 john Build/Test: Dropping 2013 allows using the latest googletests.

Created with:
  roll-dep third_party/glslang

Roll third_party/SPIRV-Tools/ 8bc27a1cf..2990a2192 (10 commits)

8bc27a1cfb..2990a21926

$ git log 8bc27a1cf..2990a2192 --date=short --no-merges --format='%ad %ae %s'
2020-08-10 stevenperron Avoid using /MP4 for clang on windows. (#3662)
2020-08-06 antonikarp spirv-fuzz: TransformationReplaceAddSubMulWithCarryingExtended (#3598)
2020-08-06 andreperezmaselco.developer spirv-fuzz: Add TransformationMakeVectorOperationDynamic (#3597)
2020-08-06 andreperezmaselco.developer spirv-fuzz: iterate over blocks in replace linear algebra pass (#3654)
2020-08-06 stefanomil spirv-fuzz: make outliner pass use additional transformations (#3604)
2020-08-05 jaebaek OpenCL.DebugInfo.100 DebugTypeArray with variable size (#3549)
2020-08-05 andreperezmaselco.developer spirv-opt: Improve the code of the Instruction class (#3610)
2020-08-05 vasniktel spirv-fuzz: Handle OpPhis in livesafe functions (#3642)
2020-08-05 vasniktel spirv-fuzz: Handle OpPhi during constant obfuscation (#3640)
2020-08-05 vasniktel spirv-fuzz: Fix FuzzerPassCopyObjects (#3638)

Created with:
  roll-dep third_party/SPIRV-Tools

Roll third_party/tint/ f18d737b4..bc80805c4 (5 commits)

https://dawn.googlesource.com/tint/+log/f18d737b4e93..bc80805c4b04

$ git log f18d737b4..bc80805c4 --date=short --no-merges --format='%ad %ae %s'
2020-08-09 dneto [spirv-writer] Infer and emit matrix layout
2020-08-07 sarahmashay [validation] v-0021: cannot re-assign constants
2020-08-06 sarahmashay [Validation] v-0006: variables must be defined before use
2020-08-05 dneto [spirv-reader] Remove support for NumWorkgroups builtin variable
2020-08-05 sarahmashay [validator] implement variable_stack_

Created with:
  roll-dep third_party/tint

Change-Id: Ieec678acb5113f7a9da92a44dbdd53b9f65b6286
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26561
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2020-08-10 19:12:29 +00:00
Brandon Jones
ccf01e74ec Re-add heap usage tracking for textures in a pass
Heap usage tracking for textures in a pass was mistakenly removed when
texture subresource transitions was implemented. This must be re-added
for residency management to work (and not crash the application).

Bug: dawn:193
Change-Id: Ie5e9622f88a70d153232d5d72bb11846f4164e87
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26461
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Brandon Jones <brandon1.jones@intel.com>
2020-08-10 16:58:29 +00:00
Jiawei Shao
1662e97f32 Add tests for lazily initializing indirect buffers
This patch adds the end2end tests on the buffer lazy-initialization on
indirect buffers. In the last patch we have already supported buffer
lazy initialization on all the buffers used in a render pass and compute
pass, so in this patch we just need to add tests to ensure buffer lazy
initializations run as we expect on indirect buffers.

This patch also enables all the tests with write-only storage textures
on Metal, Vulkan and OpenGL with SPVC parser as these tests only fail
on D3D12 backends.

BUG=dawn:414
TEST=dawn_end2end_tests

Change-Id: If40b0129d6766e854cf1efdaea539a740a86ae66
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26340
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2020-08-10 00:48:58 +00:00
David Neto
bc80805c4b [spirv-writer] Infer and emit matrix layout
WGSL matrices are always column major, with tightly packed columns.
We need to infer that layout and decorate the containing structure
members, if those members require a layout.

Bug: tint:200
Change-Id: Ieceb460ed6c7eeb1244beecbf4e0eee0b8b8e373
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26180
Reviewed-by: Sarah Mashayekhi <sarahmashay@google.com>
2020-08-09 15:45:37 +00:00
Enrico Galli
101a5829d5 DawnTest: Prevent infinite loops in DawnTest.
WaitABit waits forever should a device loss occurs, which
happens when a bug is introduced. This can lock up the console
preventing debugging when needed the most.

Bug: dawn:495
Change-Id: I0b13ddfa75abbb9c43f7dd545fa9c41be79a697c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25960
Reviewed-by: Bryan Bernhart <bryan.bernhart@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2020-08-08 01:05:59 +00:00
Sarah Mashayekhi
e88f1c388c [validation] v-0021: cannot re-assign constants
Bug: tint: 6
Change-Id: Ib5cd57478b35c8dbf04136eb4167a3c3bce1c954
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26420
Reviewed-by: David Neto <dneto@google.com>
2020-08-07 14:34:34 +00:00
Sarah Mashayekhi
65f88d6f1d [Validation] v-0006: variables must be defined before use
Bug:tint 6
Change-Id: I22f3117a8d59eaba97166de1f188156a9e3cd7a0
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26381
Reviewed-by: David Neto <dneto@google.com>
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
2020-08-06 21:24:14 +00:00
Austin Eng
2cf5a08cfc Track depth/stencil aspects independently
This enables depth-stencil textures to track per aspect state
independently. It lifts the restriction that depth and stencil
store ops must be the same as they now have independent clear
states. It will also enable correct barriers on Vulkan and D3D12.

Bug: dawn:439
Change-Id: I8a73187df57a1d7eee6790cb4395bdecf42b63aa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26127
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2020-08-06 17:00:29 +00:00
David Neto
6eb2a85adf [spirv-reader] Remove support for NumWorkgroups builtin variable
It was removed from WGSL MVP
https://github.com/gpuweb/gpuweb/issues/920

Bug: tint:3
Change-Id: I94a584feec88dda7e310ee5d7fa01e93e26cd31d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/25526
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2020-08-05 21:16:59 +00:00
Ryan Harrison
fa4b74d479 Remove temporary disabling of validation check
Change-Id: I8bf7f4850689c240152a7a87ed42d7637c69ed45
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26380
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2020-08-05 18:18:04 +00:00
Tomek Ponitka
7ce4924a35 Fixing linear texture data validation on bytesPerRow
This makes the validation match the spec more.
Since the change makes the validation throw less errors
than it used to, most of the tests should still be fine,
except for those I fixed.

Bug: dawn:482
Change-Id: I1d01356df66c897191a2305df419f088b45c8467
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26302
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Tomek Ponitka <tommek@google.com>
2020-08-05 16:43:24 +00:00
Sarah Mashayekhi
b77399cbad [validator] implement variable_stack_
Change-Id: I388847770de8dc703e92030f0fab8f9001643f95
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26006
Reviewed-by: David Neto <dneto@google.com>
2020-08-05 15:23:47 +00:00
Ryan Harrison
076a4e5820 Roll 6 dependencies and bypass changed API usage
Roll third_party/glslang/ 3ee5f2f1d..2de6d657d (6 commits)

3ee5f2f1d3..2de6d657dd

$ git log 3ee5f2f1d..2de6d657d --date=short --no-merges --format='%ad %ae %s'
2020-08-04 john SPV: Standalone; sanity check the client GLSL input semantics option value.
2020-08-04 john SPV: Use more correct SPV-Tools environment, partially addressing #2290
2020-08-04 john SPV: Fix #2363: include trailing newline named text SPV output.
2020-07-03 ShabbyX Use GLSLANG_ANGLE to strip features to what ANGLE requires
2020-07-31 bclayton Revert changes that migrate to `thread_local`.
2020-07-27 dneto Avoid spurious warning about uninit var

Created with:
  roll-dep third_party/glslang

Roll third_party/shaderc/ cfacaaffd..c626b912d (1 commit)

cfacaaffd1..c626b912dc

$ git log cfacaaffd..c626b912d --date=short --no-merges --format='%ad %ae %s'
2020-07-29 dsinclair Update some language usage. (#1124)

Created with:
  roll-dep third_party/shaderc

Roll third_party/spirv-cross/ f5e9f4a17..82d1c43e4 (6 commits)

f5e9f4a172..82d1c43e40

$ git log f5e9f4a17..82d1c43e4 --date=short --no-merges --format='%ad %ae %s'
2020-08-03 cdavis MSL: Fix handling of matrices and structs in the output control point array.
2020-07-29 post Add some test cases for complex type aliasing scenario.
2020-07-29 post Ensure that we use primary alias type when emitting flattened members.
2020-07-29 post GLSL: Be more aggressive about using type_alias.
2020-07-29 post Only rewrite type aliases for the base type.
2020-07-28 post GLSL: Add option to force flattening IO blocks.

Created with:
  roll-dep third_party/spirv-cross

Roll third_party/spirv-headers/ 979924c8b..3fdabd0da (4 commits)

979924c8bc..3fdabd0da2

$ git log 979924c8b..3fdabd0da --date=short --no-merges --format='%ad %ae %s'
2020-08-03 44190824+mmerecki Reserve SPIR-V token range for upcoming Intel extensions. (#165)
2020-07-29 alanbaker Update BUILD.bazel and BUILD.gn (#166)
2020-07-29 alanbaker Publish the headers for the clspv embedded reflection non-semantic extended instruction set (#164)
2020-07-29 johnkslang Update the registry in spir-v.xml to modernize and split out opcodes. (#156)

Created with:
  roll-dep third_party/spirv-headers

Roll third_party/SPIRV-Tools/ 150be20d4..8bc27a1cf (17 commits)

150be20d43..8bc27a1cfb

$ git log 150be20d4..8bc27a1cf --date=short --no-merges --format='%ad %ae %s'
2020-08-04 vasniktel spirv-fuzz: Remove OpFunctionCall operands in correct order (#3630)
2020-08-04 vasniktel spirv-fuzz: Handle capabilities during module donation (#3651)
2020-08-04 vasniktel spirv-fuzz: Refactor boilerplate in TransformationAddParameter (#3625)
2020-08-03 vasniktel spirv-fuzz: TransformationMoveInstructionDown (#3477)
2020-07-31 jaebaek Remove DebugDeclare only for target variables in ssa-rewrite (#3511)
2020-07-31 vasniktel Fix typo in ASAN CI build (#3623)
2020-07-30 stefanomil spirv-fuzz: Transformation to add loop preheader (#3599)
2020-07-30 stefanomil spirv-fuzz: Pass to replace int operands with ints of opposite signedness (#3612)
2020-07-30 jaebaek Debug info preservation in loop-unroll pass (#3548)
2020-07-30 alanbaker Validator support for non-semantic clspv reflection (#3618)
2020-07-30 vasniktel spirv-fuzz: Fix memory bugs (#3622)
2020-07-29 andreperezmaselco.developer spirv-fuzz: Implement the OpOuterProduct linear algebra case (#3617)
2020-07-30 vasniktel spirv-fuzz: Compute corollary facts from OpBitcast (#3538)
2020-07-29 dj2 Update some language usage. (#3611)
2020-07-29 vasniktel spirv-fuzz: Relax type constraints in DataSynonym facts (#3602)
2020-07-29 vasniktel spirv-fuzz: Remove non-deterministic behaviour (#3608)
2020-07-29 afdx Avoid use of 'sanity' and 'sanity check' in the code base (#3585)

Created with:
  roll-dep third_party/SPIRV-Tools

Roll third_party/tint/ c5cd8f5bd..f18d737b4 (26 commits)

https://dawn.googlesource.com/tint/+log/c5cd8f5bd382..f18d737b4e93

$ git log c5cd8f5bd..f18d737b4 --date=short --no-merges --format='%ad %ae %s'
2020-08-04 rharrison Rolling 7 dependencies and fix BUILD.gn
2020-07-30 dsinclair [ast] Add texture types to the AST.
2020-07-30 dsinclair Add SamplerType to AST.
2020-07-30 dsinclair [hlsl-writer] Add loop support.
2020-07-30 dsinclair [hlsl-writer] Add if/else statements.
2020-07-30 dsinclair [hlsl-writer] Emit variable declarations.
2020-07-30 rharrison Add SPIR-V Reader Fuzzer
2020-07-30 rharrison Remove _exe suffix from sample program
2020-07-30 rharrison Change the default for BUILD.gn to build all the modules
2020-07-30 rharrison Simplify fuzzer targets to ease adding additional targets
2020-07-30 dsinclair Fixup build warnings
2020-07-30 dsinclair [wgsl-reader] Add stride support.
2020-07-30 dsinclair [wgsl-writer] Emit array stride decoration.
2020-07-30 idanr Add BlockStatement insert and non-const global_variables
2020-07-30 sarahmashay [Validator] Using pointers instead of refs
2020-07-29 dsinclair [hlsl-writer] Add member accessor emission.
2020-07-29 dsinclair [hlsl-writer] Add AsExpression to the HLSL backend.
2020-07-29 dsinclair [hlsl-writer] Add BlockStatement support.
2020-07-29 dsinclair [hlsl-writer] Emit discard.
2020-07-29 dsinclair [hlsl-writer] Emit array accessors.
2020-07-29 dsinclair [hlsl-writer] Add alias type support.
2020-07-29 dsinclair [hlsl-writer] Add constructor emission.
2020-07-29 dsinclair Add hlsl writer tests to BUILD.gn
2020-07-29 dsinclair [hlsl-writer] Add type emission.
2020-07-29 dsinclair Update some language usage.
2020-07-29 dneto [spirv-reader] Only support column-major matrices

Created with:
  roll-dep third_party/tint

Change-Id: I68064a00fb428d91aa00efa45f729bab1af2b103
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26281
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2020-08-04 21:27:58 +00:00
Austin Eng
0a4342793e Implement depth-only/stencil-only copies on Vulkan and Metal
Bug: dawn:439
Change-Id: I07ab014f4f13b73c09b2eecc48cd38b06d88166a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24684
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2020-08-04 19:46:37 +00:00
Ryan Harrison
f18d737b4e Rolling 7 dependencies and fix BUILD.gn
Roll build/ 9b01e295f..6c915ac2a (140 commits)

9b01e295f8..6c915ac2af

$ git log 9b01e295f..6c915ac2a --date=short --no-merges --format='%ad %ae %s'
2020-08-04 chromium-autoroll Roll Fuchsia SDK from 0.20200803.3.1 to 0.20200804.1.1
2020-08-04 chromium-autoroll Roll Fuchsia SDK from 0.20200803.2.1 to 0.20200803.3.1
2020-08-04 brucedawson Fix gn gen after vcvarsall.bat
2020-08-03 hypan Revert "Reland "emulator: Disable the feature GLDMA.""
2020-08-03 chromium-autoroll Roll Fuchsia SDK from 0.20200803.1.1 to 0.20200803.2.1
2020-08-03 bpastene chromeos: Don't swallow test args when '--' is present.
2020-08-03 hans [build] Disable call-graph-profile-sort by default
2020-08-03 chromium-autoroll Roll Fuchsia SDK from 0.20200803.0.1 to 0.20200803.1.1
2020-08-03 chromium-autoroll Roll Fuchsia SDK from 0.20200802.3.1 to 0.20200803.0.1
2020-08-02 chromium-autoroll Roll Fuchsia SDK from 0.20200802.1.1 to 0.20200802.3.1
2020-08-02 chromium-autoroll Roll Fuchsia SDK from 0.20200802.0.1 to 0.20200802.1.1
2020-08-02 chromium-autoroll Roll Fuchsia SDK from 0.20200801.3.1 to 0.20200802.0.1
2020-08-02 chromium-autoroll Roll Fuchsia SDK from 0.20200801.2.1 to 0.20200801.3.1
2020-08-01 chromium-autoroll Roll Fuchsia SDK from 0.20200801.1.1 to 0.20200801.2.1
2020-08-01 chromium-autoroll Roll Fuchsia SDK from 0.20200731.4.1 to 0.20200801.1.1
2020-08-01 chromium-autoroll Roll Fuchsia SDK from 0.20200731.2.1 to 0.20200731.4.1
2020-08-01 steveroe Log system statistics at beginning and end of emulator session.
2020-08-01 steveroe Fix fuchsia test runner_logs.py directory creation and error format bugs.
2020-07-31 avi Finish conversion to OS_MAC/OS_APPLE
2020-07-31 liaoyuke [lacros] Further increase timeout waiting for ash-chrome
2020-07-31 chromium-autoroll Roll Fuchsia SDK from 0.20200731.1.1 to 0.20200731.2.1
2020-07-31 hypan emulator: Add ram_size to avd.proto
2020-07-31 hans Build with -Wl,--no-call-graph-profile-sort on Android
2020-07-31 chromium-autoroll Roll Fuchsia SDK from 0.20200730.3.1 to 0.20200731.1.1
2020-07-31 smcallis Rewrite is_linux flag for base and build components.
2020-07-31 chromium-autoroll Roll Fuchsia SDK from 0.20200730.2.1 to 0.20200730.3.1
2020-07-31 hypan emulator: Add advanced_features to avd.proto
2020-07-31 ntfschr Permit bundletool to emit stderr
2020-07-30 chouinard Remove unneccessary UnusedResources suppressions
2020-07-30 liaoyuke [lacros] Increase timeout waiting for ash-chrome
2020-07-30 chromium-autoroll Roll Fuchsia SDK from 0.20200730.1.1 to 0.20200730.2.1
2020-07-30 wnwen Android: Removing baseline.xml regenerates it
2020-07-30 torne Remove obsolete build constant.
2020-07-30 bjoyce Fix Jacoco Report exclusion variable.
2020-07-30 agrieve android: Make treat_warnings_as_errors=false work for enable_jdk_library_desugaring
2020-07-30 chromium-autoroll Roll Fuchsia SDK from 0.20200730.0.1 to 0.20200730.1.1
2020-07-30 chromium-autoroll Roll Fuchsia SDK from 0.20200729.3.1 to 0.20200730.0.1
2020-07-29 chromium-autoroll Roll Fuchsia SDK from 0.20200729.1.1 to 0.20200729.3.1
2020-07-29 steveroe Fix typo in comment.
2020-07-29 agrieve Android: Make manifest expectations a bit more diff-friendly
2020-07-29 hans Roll clang n359864-04b9a46c-1 : n361601-7e8d5a90-1.
2020-07-29 avi Migrate to OS_MAC and OS_APPLE in build
2020-07-29 liaoyuke [lacros] Run Lacros test targets with ash_chrome if needed
2020-07-29 wnwen Android: Use a unified lint target
2020-07-29 chromium-autoroll Roll Fuchsia SDK from 0.20200729.0.1 to 0.20200729.1.1
2020-07-29 chromium-autoroll Roll Fuchsia SDK from 0.20200728.3.1 to 0.20200729.0.1
2020-07-29 huangdarwin ChromeOS: Expand build flag comment.
2020-07-29 chromium-autoroll Roll Fuchsia SDK from 0.20200728.1.1 to 0.20200728.3.1
2020-07-28 mheikal Allow material design to be pulled from outside of android_deps
2020-07-28 bjoyce Run host and device code coverage separately.
(...)
2020-07-22 liaoyuke [lacros] Run tests with ash-chrome
2020-07-22 sokcevic Add missing commit change footer
2020-07-22 wnwen Android: Add comments for lint
2020-07-22 chromium-autoroll Roll Fuchsia SDK from 0.20200721.3.1 to 0.20200722.0.1
2020-07-22 chromium-autoroll Roll Fuchsia SDK from 0.20200721.2.1 to 0.20200721.3.1
2020-07-22 hypan android: Update the css/javascript for test_results_presentation.py
2020-07-22 bjoyce Only use device__jacoco_source files.
2020-07-22 liaoyuke [lacros] Download and isolate ash-chrome on bots
2020-07-21 ntfschr [AW][Dev-UI] fix lint issues
2020-07-21 ntfschr Android: expose CommandLine java methods
2020-07-21 agrieve Allow anyone to modify //build/android/lint/baseline.xml
2020-07-21 wfh Allow CFG guards to be generated with gn config.
2020-07-21 ntfschr AW docs: update references to go/clank-webview
2020-07-21 sebmarchand Few fixes for PGO on Linux
2020-07-21 chromium-autoroll Roll Fuchsia SDK from 0.20200721.1.1 to 0.20200721.2.1
2020-07-21 agrieve Reland #2 of "Android: Updates to warnings-as-errors when building"
2020-07-21 tmartino Revert #2 of "Android: Updates to warnings-as-errors when building"
2020-07-21 brucedawson Fix vs_toolchain.py for Python 3
2020-07-21 mheikal Fix build issues with creating R.java in java_library targets (Reland)
2020-07-21 agrieve Reland "Android: Updates to warnings-as-errors when building"
2020-07-21 chromium-autoroll Roll Fuchsia SDK from 0.20200720.3.1 to 0.20200721.1.1
2020-07-21 andruud Revert "Android: Updates to warnings-as-errors when building"
2020-07-21 chromium-autoroll Roll Fuchsia SDK from 0.20200720.2.2 to 0.20200720.3.1
2020-07-21 agrieve Android: Updates to warnings-as-errors when building
2020-07-21 wnwen Android: Fix lint and add baseline
2020-07-20 etiennep Reland "[Clank SSM]: Enable stack sampling in android browsertests."
2020-07-20 Richard.Townsend Fix MIDL cross-compilation for ARM64 Win32 targets
2020-07-20 chromium-autoroll Roll Fuchsia SDK from 0.20200720.1.1 to 0.20200720.2.2
2020-07-20 torne Try to fix ProcessSkiaGoldRenderTestResults.
2020-07-20 bpastene chromeos: Flash the right type of DUT image based on chrome-branding.
2020-07-20 wnwen Android: Add direct deps for chrome/browser
2020-07-20 treib Remove various references to third_party/cacheinvalidation
2020-07-20 agrieve Silence build logs about d8's desugaring
2020-07-20 agrieve Android: Suppress unused resource warning for *_expand_*
2020-07-20 chromium-autoroll Roll Fuchsia SDK from 0.20200719.3.1 to 0.20200720.1.1
2020-07-20 chromium-autoroll Roll Fuchsia SDK from 0.20200718.1.1 to 0.20200719.3.1
2020-07-19 chromium-autoroll Roll Fuchsia SDK from 0.20200717.3.1 to 0.20200718.1.1
2020-07-18 chromium-autoroll Roll Fuchsia SDK from 0.20200717.2.1 to 0.20200717.3.1
2020-07-18 liaoyuke [lacros] Make test runner differentiate different test targets
2020-07-18 mheikal Revert "Fix build issues with creating R.java in java_library targets"
2020-07-17 mheikal Fix build issues with creating R.java in java_library targets
2020-07-17 bjoyce Run jacoco on host jar files.
2020-07-17 chromium-autoroll Roll Fuchsia SDK from 0.20200717.1.1 to 0.20200717.2.1
2020-07-17 bpastene Reland "Simplify Simple Chrome's gclient and GN conditionals."
2020-07-17 chouinard Remove unnecessary UnusedResources suppressions
2020-07-17 liaoyuke [lacros] Remove unused ash-chrome versions
2020-07-17 wfh Re-enable CFG loader config in component builds.
2020-07-17 oysteine Revert "[Clank SSM]: Enable stack sampling in android browsertests."
2020-07-17 etiennep [Clank SSM]: Enable stack sampling in android browsertests.
2020-07-17 sdefresne [ios] Assert that Xcode version is recent enough

Roll buildtools/ eb3987ec7..613921787 (3 commits)

eb3987ec70..6139217878

$ git log eb3987ec7..613921787 --date=short --no-merges --format='%ad %ae %s'
2020-08-03 tikuta sort buildtools/.gitignore
2020-07-31 smcallis Rewrite is_linux flag for base and build components.
2020-07-20 sdefresne Roll GN from d585128c..3028c6a4

Roll testing/ cadd4e1eb..dc9b1969e (124 commits)

cadd4e1eb3..dc9b1969e7

$ git log cadd4e1eb..dc9b1969e --date=short --no-merges --format='%ad %ae %s'
2020-08-04 sinhak Revert "Bring parity between mac coverage and non-coverage build"
2020-08-04 mcdermottm Enable MediaApp in fieldtrial_testing_config.json.
2020-08-03 drubery Add fieldtrial_testing_config for CSD vision model
2020-08-03 pasthana Bring parity between mac coverage and non-coverage build
2020-08-03 svenzheng [lacros] LUCI config for linux-lacros-builder-rel and linux-lacros-tester-rel
2020-08-03 skare Remove "DesktopStudy" suffix from QRCodeGenerator study to match gcl.
2020-08-03 bpastene chromeos: Don't swallow test args when '--' is present.
2020-08-03 mohsen Remove stale field trial testing configs
2020-08-03 dtrainor Add support for reengagement notification
2020-08-03 rmcilroy [Perf] Move android-pixel2-perf bot to 64-bits.
2020-08-03 martiniss Remove production freeze
2020-08-03 seblalancette [iOS] Cleanup Bling QR Code Generation Flag
2020-08-03 ianstruiksma Add target to blink_web_tests for Win10 x64 1909 builder
2020-08-03 talp Create field trial testing config for Per-agent Scheduling experiment.
2020-07-31 mpdenton Add CertVerifierService to field trial testing config.
2020-07-31 isamsonov Remove mac10.13_retina-blink-rel's configurations.
2020-07-31 behdadb Removed Experimental tag from representaives
2020-07-31 liviutinta Enable Field Trial for Browser Verified Mouse User Activation Trigger
2020-07-31 mattm Reland: Add CertVerifierBuiltin fieldtrial_testing_config for mac.
2020-07-31 liviutinta Enable Field Trial for Browser Verified Keyboard User Activation Trigger
2020-07-30 lindsayw [ios] Add missing 2nd generation identifier
2020-07-30 smcallis Rewrite is_linux flag for sandbox, servicse, ski and testing directories.
2020-07-30 jdeblasio [MIX-DL] Update field testing config for M84 stable launch.
2020-07-30 wenbinzhang [benchmarking] stop running ref build for android-pixel2
2020-07-30 lindsayw [ios] Update the iPad Pro naming to include 2nd gen.
2020-07-30 lindsayw [mac]Roll osxbeta to macOS 11.0
2020-07-30 skare Add field trial testing config for desktop QR code generator.
2020-07-30 justincohen Revert "[iOS] Add fieldtrial config for IOSRequestDesktopByDefault"
2020-07-30 collinbaker Include in-product help in DesktopTabGroups default field trial
2020-07-29 svenzheng [lacros] LUCI config for linux-ash-chromium-builder-fyi-rel
2020-07-29 pbos Add UseTextForUpdateButton to fieldtrial test config
2020-07-29 zhaoyangli [iOS][infra] Roll iOS13 builders & tests to Xcode 11e708
2020-07-29 hypan emulator: Disable flaky tests in weblayer_browsertests on MM
2020-07-29 ynovikov Shard SwANGLE angle_deqp_egl_tests
2020-07-29 avi Migrate to OS_MAC and OS_APPLE in testing
2020-07-29 svenzheng [lacros] LUCI rename fyi linux-lacros-builder-rel and linux-lacros-tester-rel
2020-07-29 michaeldo Revert "Roll bots to Xcode 12 beta 3"
2020-07-29 rmhasan weblayer, skew tests: Put Weblayer job configurations in variants.pyl
2020-07-29 mvanouwerkerk Remove Shared Clipboard WebRTC from testing config.
2020-07-29 liaoyuke [lacros] Run Lacros test targets with ash_chrome if needed
2020-07-29 bpastene Revert "Remove telemetry_unittests from the CrOS VM CQ bot."
2020-07-29 asanka [privacy_budget] Enable study for waterfall testing.
2020-07-29 wez [base] Add DisableOffSequenceTaskCancelation fieldtrial test config.
2020-07-29 gambard [iOS] Add fieldtrial config for IOSRequestDesktopByDefault
2020-07-29 alanlxl Add fieldtrial config for SmartDimNewMlAgent
2020-07-29 rushans Add SyncReuploadBookmarkFullTitles experiment to field trial testing config.
2020-07-29 jwata Revert "[mac-rel-swarming] add arm-64 Mac to the target bots"
2020-07-29 kimstephanie Remove chrome_public_test_apk temporarily from android-pie-arm64-rel
2020-07-28 jwata [mac-rel-swarming] add arm-64 Mac to the target bots
2020-07-28 dproy tools/perf: Add system_health.common benchmark with TBMv3 to FYI bots
(...)
2020-07-27 jonross Disable angle_white_box_tests on Linux FYI Release (AMD R7 240) This test suite has been failing consistently for 11 days.
2020-07-27 sdefresne [apple] Add a `is_apple` gn variable and use it
2020-07-27 rsorokin [Sheriff] Disable */PlatformKeysServicePerUnavailableTokenBrowserTest.GenerateRsa/0
2020-07-26 liaoyuke Add xvfb.py as a data deps
2020-07-26 gangwu add field trial config for Omnibox tab switch suggestions
2020-07-25 svenzheng Disable BookmarkBubbleViewBrowserTest.InvokeUi_bookmark_details_signed_in
2020-07-25 gbeaty Revert "Remove GPU's Linux tests from the CQ."
2020-07-25 thestig Add SaveEditedPDFForm experiment to field trial testing config.
2020-07-25 behdadb Failure invalidation of rep_perf tests should show green status
2020-07-24 gbeaty Revert "Remove gl_tests_passthrough and gl_tests_validating from the Linux builders"
2020-07-23 hypan Remove gl_tests_passthrough and gl_tests_validating from the Linux builders
2020-07-23 jonross Revert "Re-add field trial testing config for DisableLatencyRecoveryDesktop"
2020-07-23 hypan Remove GPU's Linux tests from the CQ.
2020-07-23 fdoray [blink scheduler] Enable intensive wake up throttling in testing config.
2020-07-23 hypan android: Add test configs for android-nougat-arm64-rel
2020-07-23 kelvinjiang Revert "Add CertVerifierBuiltin fieldtrial_testing_config for mac."
2020-07-22 ianstruiksma Add luci and test configurations for Win10 x64 Tests 1909.
2020-07-22 gab [base] Enable PM_QS_ALLEVENTS in ProcessPumpReplacementMessage by default
2020-07-22 wylieb Update fieldtrial testing config for Assistant voice search
2020-07-22 ynovikov Revert "Explicitly name webgl/2 conformance tests on Windows"
2020-07-22 mattm Add CertVerifierBuiltin fieldtrial_testing_config for mac.
2020-07-22 jonahr Explicitly name webgl/2 conformance tests on Windows
2020-07-22 bpastene Move perf-fyi's CrOS tester to standard test pool.
2020-07-22 bttk ADCP: Add Field Trial config
2020-07-22 jdapena GCC: in perf result reporter, fix kInvalidCharacters initialization.
2020-07-22 pkotwicz Add compile target for errorprone plugin tests
2020-07-22 jds Adding a field trial config for the context menu performance hints experiment.
2020-07-22 natlee Add --use-gpu-in-tests flag to webgpu blink web tests.
2020-07-22 bpastene Move all CrOS HW tests to standard test pools.
2020-07-22 chriscycheng Adding 'android_lollipop_marshmallow_coverage_gtests'
2020-07-22 liaoyuke [lacros] Download and isolate ash-chrome on bots
2020-07-21 gbeaty Temporarily disable chrome_public_test_apk on android-pie-arm64-rel.
2020-07-21 gatong Infra: Moving mac-arm64 builder from FYI to being part of mac waterfall
2020-07-21 mohsen Re-add field trial testing config for DisableLatencyRecoveryDesktop
2020-07-21 wfh Allow CFG guards to be generated with gn config.
2020-07-21 svenzheng Mark some test suites as experimental
2020-07-21 sreejakshetty Filter out new content_browsertest failure with BackForwardCache
2020-07-21 ewannpv PageInfoRefactoring to Field Trial Testing Configuration
2020-07-21 rakina Check for bfcache flags on places where we check for Proactive BI swap
2020-07-21 hypan emulator: Have the android-marshmallow-x86-rel run on 4-cores GCE bots
2020-07-20 bpastene Enable pre-test flashing for all CrOS HW tests.
2020-07-20 mthiesse Migrate Omnibox native java unittests to batched Instrumentation tests
2020-07-20 bpastene Decrease primary task slice expiration from 10m to 5m for CrOS HW tests.
2020-07-20 alcooper Reland "Update vr_pixeltests exceptions"
2020-07-20 aboxhall Revert "Update vr_pixeltests exceptions"
2020-07-20 xiaochengh Enable FontPreloadingDelaysRendering by default on trunk
2020-07-18 liaoyuke [lacros] Make linux-lacros-tester-rel Run all targets
2020-07-17 alcooper Update vr_pixeltests exceptions
2020-07-17 liaoyuke Fix win coverage config - part 3
2020-07-17 wanderview Update CacheStorageSequenceChromeOS fieldtrial testing config.

Roll third_party/googletest/ a781fe29b..e6e2d3b76 (5 commits)

a781fe29bc..e6e2d3b761

$ git log a781fe29b..e6e2d3b76 --date=short --no-merges --format='%ad %ae %s'
2020-07-28 absl-team Googletest export
2020-07-28 absl-team Googletest export
2020-07-26 ofats Googletest export
2020-07-19 jasjuang fix clang tidy modernize-use-equals-default warnings
2020-07-02 siliconearth Fix test failing when simple regex is used

Roll third_party/spirv-headers/ 308bd0742..3fdabd0da (6 commits)

308bd07424..3fdabd0da2

$ git log 308bd0742..3fdabd0da --date=short --no-merges --format='%ad %ae %s'
2020-08-03 44190824+mmerecki Reserve SPIR-V token range for upcoming Intel extensions. (#165)
2020-07-29 alanbaker Update BUILD.bazel and BUILD.gn (#166)
2020-07-29 alanbaker Publish the headers for the clspv embedded reflection non-semantic extended instruction set (#164)
2020-07-29 johnkslang Update the registry in spir-v.xml to modernize and split out opcodes. (#156)
2020-07-21 alanbaker Support SPV_KHR_terminate_invocation (#163)
2020-07-19 vkushwaha Add changes for SPV_EXT_shader_atomic_float

Roll third_party/spirv-tools/ 717e7877c..d9c73ebd9 (52 commits)

717e7877ca..d9c73ebd9e

$ git log 717e7877c..d9c73ebd9 --date=short --no-merges --format='%ad %ae %s'
2020-08-04 vasniktel spirv-fuzz: Handle capabilities during module donation (#3651)
2020-08-04 vasniktel spirv-fuzz: Refactor boilerplate in TransformationAddParameter (#3625)
2020-08-03 vasniktel spirv-fuzz: TransformationMoveInstructionDown (#3477)
2020-07-31 jaebaek Remove DebugDeclare only for target variables in ssa-rewrite (#3511)
2020-07-31 vasniktel Fix typo in ASAN CI build (#3623)
2020-07-30 stefanomil spirv-fuzz: Transformation to add loop preheader (#3599)
2020-07-30 stefanomil spirv-fuzz: Pass to replace int operands with ints of opposite signedness (#3612)
2020-07-30 jaebaek Debug info preservation in loop-unroll pass (#3548)
2020-07-30 alanbaker Validator support for non-semantic clspv reflection (#3618)
2020-07-30 vasniktel spirv-fuzz: Fix memory bugs (#3622)
2020-07-29 andreperezmaselco.developer spirv-fuzz: Implement the OpOuterProduct linear algebra case (#3617)
2020-07-30 vasniktel spirv-fuzz: Compute corollary facts from OpBitcast (#3538)
2020-07-29 dj2 Update some language usage. (#3611)
2020-07-29 vasniktel spirv-fuzz: Relax type constraints in DataSynonym facts (#3602)
2020-07-29 vasniktel spirv-fuzz: Remove non-deterministic behaviour (#3608)
2020-07-29 afdx Avoid use of 'sanity' and 'sanity check' in the code base (#3585)
2020-07-27 andreperezmaselco.developer spirv-fuzz: Add condition to make functions livesafe (#3587)
2020-07-27 rharrison Rolling 4 dependencies (#3601)
2020-07-27 andreperezmaselco.developer spirv-fuzz: Implement the OpTranspose linear algebra case (#3589)
2020-07-27 rdb Fix SyntaxWarning in Python 3.8 (#3388)
2020-07-27 bclayton CMake: Enable building with BUILD_SHARED_LIBS=1 (#3490)
2020-07-27 dneto Avoid operand type range checks (#3379)
2020-07-27 jaebaek Preserve debug info in scalar replacement pass (#3461)
2020-07-27 pierremoreau Update OpenCL capabilities validation (#3149)
2020-07-27 stevenperron build(deps): bump lodash from 4.17.15 to 4.17.19 in /tools/sva (#3596)
2020-07-27 antonikarp spirv-fuzz: adds TransformationReplaceLoadStoreWithCopyMemory (#3586)
2020-07-27 jaebaek Preserve OpenCL.DebugInfo.100 through private-to-local pass (#3571)
2020-07-27 stefanomil spirv-fuzz: Relax type checking for int contants (#3573)
2020-07-27 stefanomil spirv-fuzz: Generalise transformation access chain (#3546)
2020-07-27 stefanomil spirv-fuzz: Split blocks starting with OpPhi before trying to outline (#3581)
2020-07-27 afdx spirv-fuzz: Set message consumer in replayer when shrinking (#3591)
2020-07-24 vasniktel spirv-fuzz: Don't use default parameters (#3583)
2020-07-23 rharrison Change DEPS rolling script to point at external/ (#3584)
2020-07-23 vasniktel spirv-fuzz: Create a helper in fuzzerutil to reuse function type (#3572)
2020-07-23 vasniktel spirv-fuzz: Test usages of IdIsIrrelevant fact (#3578)
2020-07-23 antonikarp spirv-fuzz: adds TransformationReplaceCopyMemoryWithLoadStore (#3575)
2020-07-23 antonikarp spirv-fuzz: adds TransformationReplaceCopyObjectWithStoreLoad (#3567)
2020-07-22 stevenperron Start SPIRV-Tools v2020.5
2020-07-22 stevenperron Finalize SPIRV-Tools v2020.4
2020-07-22 vasniktel spirv-fuzz: Fix usages of irrelevant constants (#3566)
2020-07-22 stevenperron Update CHANGES
2020-07-22 alanbaker Support SPV_KHR_terminate_invocation (#3568)
2020-07-22 stevenperron Sink pointer instructions in merge return (#3569)
2020-07-21 greg Preserve OpenCL.DebugInfo.100 through elim-dead-code-aggressive (#3542)
2020-07-21 vasniktel spirv-fuzz: TransformationReplaceParamsWithStruct (#3455)
2020-07-21 38144211+vkushwaha-nv Add changes for SPV_EXT_shader_atomic_float (#3562)
2020-07-21 vasniktel spirv-fuzz: Use irrelevant constants (#3565)
2020-07-21 stefanomil spirv-fuzz: Extend TransformationRecordSynonymousConstants to allow composite constants (#3537)
2020-07-21 vasniktel spirv-fuzz: Add is_irrelevant parameter (#3563)
2020-07-20 vasniktel spirv-fuzz: Add IdIsIrrelevant fact (#3561)
2020-07-20 stefanomil spirv-fuzz: refactor to use RemoveAtRandomIndex (#3560)
2020-07-20 antonikarp spirv-fuzz: add TransformationAddRelaxedDecoration (#3545)

Roll tools/clang/ 6412135b3..1078c4141 (5 commits)

6412135b39..1078c4141a

$ git log 6412135b3..1078c4141 --date=short --no-merges --format='%ad %ae %s'
2020-08-02 thakis Roll clang n361601-7e8d5a90-1 : n362116-1bd7046e-2.
2020-08-01 lukasza Skip `ExprWithCleanup` AST node via `ignoringImplicit` AST matcher.
2020-07-29 hans Roll clang n359864-04b9a46c-1 : n361601-7e8d5a90-1.
2020-07-22 aeubanks Clang build.py: Open instrumented temp file as binary
2020-07-22 aeubanks Allow building Clang with ThinLTO

Created with:
  roll-dep build buildtools testing third_party/googletest third_party/gpuweb-cts third_party/spirv-headers third_party/spirv-tools tools/clang

Change-Id: I841ccb15000269ca48d09ac550bc36a06c2b354a
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26280
Reviewed-by: Sarah Mashayekhi <sarahmashay@google.com>
2020-08-04 17:56:27 +00:00
Jiawei Shao
e84a1b1376 Add tests for lazy initializing vertex and index buffers
This patch adds the end2end tests on the buffer lazy-initialization on
vertex and index buffers. In the last patch we have already supported
buffer lazy initialization on all the buffers used in a render pass and
compute pass, so in this patch we just need to add tests to ensure
buffer lazy initializations run as we expect on vertex and index
buffers.

This patch also adds the missing checks on all the BufferZeroInitTests
to ensure the buffers are not lazily initialized when we validate if
their data is all set to zero in these tests.

BUG=dawn:414
TEST=dawn_end2end_tests

Change-Id: If2156027b23e9d90619b7814a542380f48af85ac
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26140
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-08-04 08:18:36 +00:00
Hao Li
c0acb25318 Query API: Timestamp Query on D3D12
- Add implementation of WriteTimestamp and ResolveQuerySet on D3D12, but
not add compute shader to post-process the result yet.
- Add end2end tests for timestamp query on command encoder/render
pass/compute pass.

Bug: dawn:434
Change-Id: I7f763bc46d651818da3f69bc72ea2e403cf2674d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25845
Commit-Queue: Hao Li <hao.x.li@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-08-04 06:41:56 +00:00
Tomek Ponitka
1ea3a22f52 Adding a validation for destroyed textures in Queue::WriteTexture
That was missing. There's a new validation test for that and two
tests for submitting copy commands with destroyed buffer/texture
(I think only a mapped buffer was covered so far).
Also fixing some error state tests.

Bug: dawn:483
Change-Id: I691f34722e96866a06465b4b3b0cae9d31c08a84
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26161
Commit-Queue: Tomek Ponitka <tommek@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2020-08-03 19:22:33 +00:00
Tomek Ponitka
eac38cfbc1 Fixing a deprecated arrayLayer value inside Queue::WriteTexture
Chromium always sends arrayLayer instead of origin.depth since
the migration hasn't been finished yet. This wasn't caught
in Dawn's testing since we are using origin.depth everywhere.

Bug: dawn:483
Change-Id: I13b1ccfb016eea01a3291ca439457db09966e9a3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26160
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Tomek Ponitka <tommek@google.com>
2020-08-03 09:11:52 +00:00