This fixes a failure when use_tint_generator on D3D12, but also preps
the code for the future where WGSL requires that return values from
functions are used.
Bug: None
Change-Id: I6b8a5e0aef6550ef39d2972cdc510e05e4be3662
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46620
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
This is another incremental change towards using the new render
pipeline descriptor throughout the entire stack. Creates blueprints for
hashing with the new descriptor when provided before then converting it
to the old format for the native backend creation.
BUG: dawn:642
Change-Id: I1927b12fd02b2fedf25ef4428f07e339fa666715
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46541
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
This is a preparation CL for 3D texture copy. It refactors texture
result comparison MACROs and their implementations, in order to
add texture result comparison for 3D texture. Prior to this change,
texture result comparison supports 1D/2D texture only.
BUG: dawn:547
Change-Id: Ia242356e05f4762e33a8278ec0d038b8580f7aa9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46320
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Yunchao He <yunchao.he@intel.com>
It was used to avoid requiring the dependency on Tint so it isn't needed
anymore now that Dawn unconditionally dependent on Tint.
Bug: dawn:686
Bug: dawn:706
Change-Id: Ifd12c2f94fcaaa70120ae7ef72bcdc34f970fbea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46004
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
This is in preparation for a change that will change all the
CreateFooInternal to be CreateFoo so they can be called in a
reentrant manner without special refcounting.
This also standardizes all the backends (except OpenGL and Null)
to use Object::Create that returns a Ref<T> or ResultOrError<Ref<T>>,
something we wanted to do for a long time.
Bug: dawn:723
Change-Id: I9e0baced333ffeb0affbc6a276c9bd9de082263a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46440
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This CL propagates errors from reentrant WriteBuffer calls and makes
procy methods on BufferBase to show that it is safe to call
GetMappedRange and Unmap without handling errors.
Bug: dawn:723
Change-Id: I4ea43adc4844505314bf84e2357b2d928f1d1f8c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46003
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
In the service of keeping these changes incremental and easier to
review this change only validates the RenderPipelineDescriptor2
before converting it back to a RenderPipelineDescriptor.
BUG: dawn:642
Change-Id: Ie24c999756fa74f7d3cd10662a6bc95649602b14
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46120
Auto-Submit: Brandon Jones <bajones@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This case is failed weirdly on Intel TGL (Window Vulkan) which says the
destination buffer keep sentinel value in the second case, it cannot be
reproduced with any debug actions including Vulkan validation layers
enabled, and takes time to find out if the WriteBuffer and
ResolveQuerySet are not executed in order or the ResolveQuerySet does
not copy the results to the buffer. In order to integrate end2end tests
to Intel driver CL without unknown issues, skip it until we find the
root cause.
Bug:dawn:434
Change-Id: Ibdba667cb662ba69c8468d5b2ac2e84bcd3df5bc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46321
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Hao Li <hao.x.li@intel.com>
Using the new tint::transform::BindingRemapper.
Provides symmetry with TranslateToHLSLWithSPIRVCross().
Bug: tint:621
Bug: tint:671
Change-Id: I1a26c8cac236ac1133c688cf84bb810e15e30978
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46341
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
BUG=dawn:700
Change-Id: I5234d48867b500aece79b82515818afdfc3a6d9a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45100
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
0c9f22d3a7..9a025fd448
$ git log 0c9f22d3a..9a025fd44 --date=short --no-merges --format='%ad %ae %s'
2021-03-13 jmadill Capture/Replay: add frontend feature to force capture limits
2021-03-15 gert.wollny libAngle: Add Json context serializer library
2021-03-17 lubosz.sarnecki context: Remove endl, since INFO already adds them.
2021-03-05 lubosz.sarnecki capture_replay_expectations: Don't skip passing.
2021-03-26 angle-autoroll Roll SwiftShader from 8969f861fc24 to fb53aa2bb7da (2 revisions)
2021-03-09 lubosz.sarnecki capture_gles_3_2: Set read buffer for glGetPointerv.
2021-03-26 angle-autoroll Roll vulkan-deps from 3f4383f1d450 to 7079d8df17da (2 revisions)
2021-03-26 angle-autoroll Roll Chromium from 7a30f2f0e630 to e0abc3035c46 (431 revisions)
2021-03-04 lubosz.sarnecki capture_gles_1_0: Implement capture functions.
2021-03-25 ynovikov Remove old Win x86 bots from CQ
2021-02-26 syoussefi Vulkan: Call glslang at compile time
2021-03-25 jmadill Trace Tests: Work around autoninja.bat change on Win.
2021-03-24 m.maiya Vulkan: Enable glBlitFramebuffer for EXT_sRGB_write_control
2021-03-25 angle-autoroll Roll vulkan-deps from 91a2a0b15f23 to 3f4383f1d450 (26 revisions)
2021-03-25 angle-autoroll Roll SwiftShader from a98fb3f8380a to 8969f861fc24 (2 revisions)
2021-03-25 angle-autoroll Roll Chromium from bda1e3894abc to 7a30f2f0e630 (468 revisions)
2021-03-24 ynovikov Leave Android devices in portrait orientation after test
2021-03-22 cclao Vulkan: Add A few other *-None-04584 VVL error to skip list
2021-03-20 senorblanco SSBO handling rewrite.
2021-03-22 doughorn Fix potential mod by 0 with invalid formats.
2021-03-24 jmadill Disable Framebuffer Fetch test.
2021-03-24 m.maiya Add missing qualifier type handling in translator
2021-03-24 cnorthrop Scripts: Ignore robin_hood headers in VVL
Created with:
roll-dep third_party/angle
Change-Id: Ia3ac661d66abe7530087401c966a85b45c3356e9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46300
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
https://gpuweb.github.io/gpuweb/wgsl.html#variables:
> "Variables in the storage storage class and variables with a storage texture type must have an access attribute applied to the store type."
Bug: tint:692
Change-Id: I61774bb6bda9a7d31e3a85c24fcdb6e2fc25e7b1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46378
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
An async callback which calls Queue::Submit will cause
reentrance in QueueBase::Tick and CreatePipelineAsyncTracker::Tick,
which invalidates the task queue being used by the original call,
and leads to a crash from an invalid pointer.
The Tick functions should remove the tasks from the queues before
the callbacks are called, so invalidation doesn't cause a crash.
Bug: dawn:729
Change-Id: I0d952d51040a3d1a475767400de3333a8b9b0821
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45900
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Otherwise errors in Tick could cause the device to be lost and further
processing in Queue::SubmitImpl to fail in interesting ways.
Bug: dawn:723
Bug: chromium:1191777
Change-Id: I586c6b0f97c89938b9e7deeb6f31231ec19e826c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46002
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Previously various places in dawn_native were using Device::GetQueue to
get the queue for some operations, and were inadvertently adding a
reference to the queue. Fix this by adding a getter that doesn't add a
ref.
Bug: dawn:723
Bug: chromium:1185070
Change-Id: Iba127dbd631305762f4cc6c37816407056c52cff
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46001
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
This means that calling wgpu::Object::DoStuff will translate to a call
to dawn_native::ObjectBase::APIDoStuff. This will clarify the
difference between reentrant calls and internal calls in dawn_native.
Avoiding issues in the future.
This CL only changes the code generator to prefix with "API", performs
renames needed to make the code compile, and adds TODOs for things that
should be fixed in follow-up CLs.
Bug: dawn:723
Change-Id: Ie24471fa093adc4179d33d13323429847d076ecb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45921
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
DeviceBase implemented its own Reference / Release methods for
historical reasons. Replace them with RefCounted's version that are
similar, just more thread safe.
Bug: dawn:723
Change-Id: Ib26f3e231eb12fe09612c8b5639576e2f26a3cfd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46000
Commit-Queue: Stephen White <senorblanco@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Raises any ICE errors reported by Tint during shader validation as uncaptured
validation errors. This allows them to show up in Chrome's dev tools console, for
example.
BUG: dawn:718
Change-Id: I85741787103e6c1174b7c73be6b9860b988d6130
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45840
Reviewed-by: Ben Clayton <headlessclayton@gmail.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Also does small cleanups in dawn.json
Bug: None
Change-Id: Icbe8c9370496fa63fdd32b43d4f7a0666acf71c4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45920
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
d8557cc88f..0c9f22d3a7
$ git log d8557cc88..0c9f22d3a --date=short --no-merges --format='%ad %ae %s'
2021-03-24 angle-autoroll Roll Chromium from f1617b736428 to bda1e3894abc (469 revisions)
2021-03-18 amy.liu Compression of the data from vkGetPipelineCacheData.
2021-03-23 xiaoxuan.liu Vulkan: Fix gl_SamplePosition XY-flip and rotation.
2021-03-23 reveman [Fuchsia] Add ifndefs to vulkan_fuchsia_ext.h
2021-03-09 syoussefi Vulkan: Use VK_EXT_multisampled_render_to_single_sampled
2021-03-22 ianelliott Update ANGLEWrangling.md with Hotlist-Wrangler
2021-03-22 rafael.cintron Enable D3D11 debug names in ANGLE release builds
2021-03-22 penghuang Disable timestamp queries for Mali-G31 and older GPUs
2021-03-23 jmadill Revert "Save/Load missing members"
2021-03-22 jmadill Vulkan: Rename Uniforms/XFB descriptor desc.
2021-03-23 angle-autoroll Roll Chromium from 3eced2421f5a to f1617b736428 (473 revisions)
2021-03-19 cnorthrop Tests: Add Real Cricket 20 trace
2021-03-22 ianelliott Fix copyright dates of new test files per Shabi
2021-03-08 cclao Vulkan: Add test for filament gltf usage case
2021-03-17 timvp Save/Load missing members
2021-03-19 cnorthrop Tests: Add android log library to traces
2021-03-17 timvp Reorder ShaderVariable functions and members
2021-03-19 m.maiya Handle inactive structure type varyings correctly
2021-03-19 m.maiya Vulkan: Handle compilation error involving gl_InvocationID
2021-03-19 cclao Vulkan: Rename onImageHelperRelease to finalizeImageLayout
2021-03-18 jmadill Vulkan: More cleanups to perf counters.
2021-03-21 cnorthrop Tests: Add Avakin Life - 3D Virtual World trace
2021-03-18 cheryl.wei Skip ResizeWindow test on Linux.
2021-03-20 m.maiya Vulkan: Don't acquire new BufferHelper for external buffers
2021-03-22 angle-autoroll Roll Chromium from c33e21cce932 to 3eced2421f5a (477 revisions)
2021-03-19 ianelliott Add multi-thread/context test for compute shaders
2021-03-19 capn Disable EGL_EXT_buffer_age for SwiftShader Vulkan
2021-03-17 cclao Vulkan: Add VUID-vkCmdDraw-None-04584 validation error to ignore list
2021-03-08 cclao Vulkan: Track images used for both attachment and sampler
2021-03-18 m.maiya Add isYUV to angle::Format
2021-03-08 cclao Vulkan: Defer color image layout changes at endRenderPass time
2021-03-15 geofflang D3D: Mark images dirty after recovering from storage
2021-03-19 angle-autoroll Roll vulkan-deps from 6ea3512e6349 to 91a2a0b15f23 (6 revisions)
2021-03-19 angle-autoroll Roll Chromium from e7ef5f7d0368 to c33e21cce932 (451 revisions)
2021-03-17 cnorthrop Tests: Add Ragnarok M: Eternal Love trace
2021-03-15 jiajia.qin Fix the assert error and inbalence parens for SSBO
2021-03-18 jmadill Vulkan: Use packed enum map for descriptor set index.
2021-03-18 jmadill Vulkan: Clean up shader buffer DS allocation.
2021-03-08 cclao Vulkan: Move CommandBufferHelper::reset() closer to constructor
2021-03-08 cclao Vulkan: Test render and sample the same texture but with different LOD
2021-03-17 gert.wollny scripts: Ignore "rapidsjon/..." when checking includes
2021-03-18 angle-autoroll Roll Chromium from 60fea25f23e6 to e7ef5f7d0368 (472 revisions)
2021-03-18 angle-autoroll Roll vulkan-deps from 105af117f053 to 6ea3512e6349 (13 revisions)
2021-03-17 jdarpinian Fix immutable texture base level validation
2021-03-12 cnorthrop Tests: Add June's Journey trace
2021-03-12 jmadill Use bitset masks for active shader buffers.
2021-03-08 m.maiya Reland "Vulkan: Support EXT_sRGB_write_control"
2021-03-16 syoussefi Vulkan: Fix missing dirty bits for compute
2021-03-17 angle-autoroll Roll SwiftShader from 69b79eec6533 to a98fb3f8380a (2 revisions)
2021-03-03 xiaoxuan.liu Reland "Add support for Linux GPU info with Vulkan backend"
(...)
2021-03-05 ianelliott Work-around eglSwapBuffersWithDamageKHR() bug
2021-03-08 jmadill Allow graceful no-error failure in CastStateValues.
2021-03-04 penghuang Reland "Fix bindFramebuffer problem with GLES2 devices"
2021-03-03 penghuang Reland "Fix two issues with GLES2 devices"
2021-03-09 penghuang Revert "Vulkan: Support EXT_sRGB_write_control"
2021-03-09 penghuang Revert "Fix bindFramebuffer problem with GLES2 devices"
2021-03-09 penghuang Revert "Fix two issues with GLES2 devices"
2021-03-09 angle-autoroll Roll SwiftShader from de7d5775ab25 to 023914a27b63 (2 revisions)
2021-03-09 angle-autoroll Roll vulkan-deps from 6691fcec0bce to 32692e5de307 (12 revisions)
2021-03-04 penghuang Disable worker contexts on Android emulator
2021-03-08 ynovikov Further suppress tests failing on Ozone.
2021-03-04 penghuang Fix bindFramebuffer problem with GLES2 devices
2021-03-06 lexa.knyazev Metal: Enable iOS pixel formats on macOS 11
2021-03-08 m.maiya Vulkan: Support EXT_sRGB_write_control
2021-03-04 penghuang Fix two GL_OES_texture_half_float related problems with GLES2
2021-03-05 ynovikov Add Win x86 chromium.angle bots to CQ
2021-03-03 penghuang Fix two issues with GLES2 devices
2021-03-07 lexa.knyazev Fix PVRTC1 frontend validation
2021-03-02 m.maiya Handle nullptr in GetQueryObjectParameter()
2021-03-08 angle-autoroll Roll SwiftShader from 6846389f25ca to de7d5775ab25 (1 revision)
2020-10-13 lexa.knyazev Metal: Implement OES_draw_buffers_indexed
2021-03-06 angle-autoroll Roll VK-GL-CTS from a9c07acc33bc to c4e6dbe68e04 (15 revisions)
2021-03-05 ynovikov Skip tests failing on Ozone.
2021-03-06 angle-autoroll Roll VK-GL-CTS from 9be79728eafb to a9c07acc33bc (6 revisions)
2021-03-05 angle-autoroll Roll Chromium from e3e89758c942 to 76f6150ffdeb (205 revisions)
2021-03-05 angle-autoroll Roll VK-GL-CTS from 9cdde06fb38a to 9be79728eafb (18 revisions)
2021-03-05 ynovikov Skip vulkan_car_parking_multiplayer on Win Intel
2021-03-05 ynovikov Skip CopyTextureVariationsTest failing on Ozone
2021-03-05 Amy.Liu Revert "Compression of the data from vkGetPipelineCacheData."
2021-03-05 lexa.knyazev Fix Apple GPU detection for M1
2021-03-04 lubosz.sarnecki capture_replay_tests: Don't skip tests that pass.
2021-02-27 syoussefi Vulkan: Keep dynamic buffer's free list trimmed
2021-03-05 angle-autoroll Roll vulkan-deps from c0db6ae3d87d to 6691fcec0bce (2 revisions)
2021-03-05 angle-autoroll Roll SwiftShader from 084529f3a9b9 to 6846389f25ca (1 revision)
2021-03-05 angle-autoroll Roll Chromium from 143c12daa39f to e3e89758c942 (782 revisions)
2021-02-27 m.maiya Add FramebufferAttachmentPerfTest
2021-03-04 enga Revert "Add support for Linux GPU info with Vulkan backend"
2021-03-02 m.maiya Vulkan: Unmap buffer when adding to mBufferFreeList
2021-03-01 natsu Vulkan: Enable EGL_ANDROID_recordable for EGL configs on SwiftShader
2021-03-04 jmadill infra/config: Rename console/list views.
2021-02-25 syoussefi Translator: Rename GLSL to SPIR-V in Vulkan and Metal output
2021-03-02 ynovikov Suppress UNINSTANTIATED_PARAMETERIZED_TEST failures on Ozone
2021-03-03 xiaoxuan.liu Add support for Linux GPU info with Vulkan backend
2021-03-02 lexa.knyazev Partially upgrade codegen to Python 3
2021-03-03 ynovikov Replace Win x64 dEQP GPU.FYI bots with chromium.angle bots
2021-03-04 angle-autoroll Roll SwiftShader from 106e01583a3a to 084529f3a9b9 (1 revision)
2021-03-04 angle-autoroll Roll vulkan-deps from 6c3f8d8c39b9 to c0db6ae3d87d (6 revisions)
2021-03-03 syoussefi Vulkan: Fix overlay graph widgets
2021-03-02 syoussefi Vulkan: Fix Overlay for prerotation
2021-03-02 syoussefi Vulkan: Workaround Overlay draw issue on Android
Created with:
roll-dep third_party/angle
Change-Id: Ifb50462ee7be965e1bac8c377ef021614da56402
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45862
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Corentin Wallez
Brandon Jones
Dawn Autoroller
Yunchao He
Hao Li
Ben Clayton
Ryan Harrison
Stephen White
Aleksi Sapon
Bryan Bernhart