Commit Graph

795 Commits

Author SHA1 Message Date
Lioncash 2732ae8383 CStaticModel: Make use of nullptr 2020-06-22 02:16:27 -04:00
Lioncash 4b3af988ad General: Add missing override specifiers where applicable 2020-06-22 02:15:41 -04:00
Lioncash 46926ef4bf General: Qualify const where applicable 2020-06-22 02:11:03 -04:00
Lioncash 2b7513b156 SSurface: Make IntersectsRay() a const member function 2020-06-21 19:48:39 -04:00
Lioncash 5b0ae09cf3 General: Silence -Wmaybe-uninitialized warnings 2020-06-21 19:43:16 -04:00
Lioncash 03a858d4fa General: Silence some unused variables
These are checked in asserts that aren't present in release builds.
2020-06-21 19:30:24 -04:00
Lioncash ebd1468bbf IProperty: Make use of size_t where applicable 2020-06-21 19:27:44 -04:00
Lioncash 48d0ae5e10 CScriptLoader: Silence unused variable warnings
These will eventually be used.
2020-06-21 19:18:47 -04:00
Lioncash cd55278e3e CMayaSpline: Silence unused variable warnings 2020-06-21 19:15:41 -04:00
Lioncash 3c78cbbeb3 CAreaAttributes: Default destructor 2020-06-21 02:49:11 -04:00
Lioncash 62b08a0b14 CModelNode: Initialize all class variables
Provides a consistent initial state.
2020-06-21 02:46:55 -04:00
Lioncash c19017f7ad CShader: Make use of std::to_string
Same behavior, but standard
2020-06-21 02:42:47 -04:00
Lioncash 79f4866365 CDamageableTriggerExtra: Make use of structured bindings 2020-06-21 02:40:25 -04:00
Lioncash 8c3f77df8a CDamageableTriggerExtra: Mark member functions as const where applicable
These don't modify instance state.
2020-06-21 02:37:42 -04:00
Lioncash 8ad6da5501 CSceneNode: Remove dead conditionals in DrawModelParts()
The condition is alreadt checked against in the if statement, so this
condition will never be true.
2020-06-21 02:32:14 -04:00
Lioncash c11ec0a6fd CDependencyGroup: Make use of ranged for 2020-06-21 02:29:23 -04:00
Lioncash 46b9a6eeb3 CScriptLayer: Make use of ranged for 2020-06-21 02:22:20 -04:00
Lioncash ff848428b7 CVirtualDirectory: Make use of ranged for where applicable 2020-06-21 02:16:30 -04:00
Lioncash bbfa7b364c CPropertyNameGenerator: Make use of unique_ptr
Same behavior, but more exception safe.
2020-06-21 01:54:55 -04:00
Lioncash 74ea300fe5 CAnimEventData: Make use of size_t where applicable 2020-06-21 01:44:28 -04:00
Lioncash c2be854b0f CWorldLoader: Make use of unsigned stream helpers 2020-06-20 04:25:43 -04:00
Lioncash cdc3328051 CWorldCooker: Make use of unsigned stream helpers 2020-06-20 04:10:46 -04:00
Lioncash b3e4807517 CUnsupportedFormatLoader: Make use of unsigned stream helpers 2020-06-20 03:53:07 -04:00
Lioncash f1e115a717 CTweakLoader: Make use of unsigned stream helpers 2020-06-20 03:33:03 -04:00
Lioncash 39fd1f8c75 CTweakCooker: Make use of unsigned stream helpers 2020-06-20 03:13:47 -04:00
Lioncash a1f7459a8d CTextureEncoder: Make use of unsigned stream helpers 2020-06-20 02:58:00 -04:00
Lioncash 3d60eee5b4 CTextureDecoder: Make use of unsigned stream utilities where applicable 2020-06-20 02:50:39 -04:00
Lioncash 70b4da4e9d CTexture: Make CalcTotalSize() a const member function 2020-06-20 02:44:44 -04:00
Lioncash 5363799228 CTexture: Make use of unsigned stream helpers where applicable 2020-06-20 02:44:11 -04:00
Lioncash 4672b75ec1 CStringLoader: Make use of unsigned stream utilities 2020-06-20 02:35:19 -04:00
Lioncash f0b82908d5 CStringCooker: Make use of unsigned stream utilities
Same behavior, less implicit sign conversions.
2020-06-20 02:01:28 -04:00
Lioncash ef57260f0b CWaypointExtra: Make use of ranged-for where applicable
Same behavior, less moving parts.
2020-06-20 00:06:59 -04:00
Lioncash 8c06309364 CSplinePathExtra: Collapse RemoveWaypoint loop into find_if() 2020-06-20 00:00:09 -04:00
Lioncash 487f2ae176 CSkinLoader: Make use of unsigned stream helpers where applicable
Less implicit sign conversions
2020-06-19 23:55:48 -04:00
Lioncash d738ae0d45 CSkeletonLoader: Make use of unsigned stream helpers where applicable
Same behavior, less implicit sign conversions.
2020-06-19 23:52:12 -04:00
Lioncash 71fd2b8754 CScriptTemplate: Collapse loop to find_if() in RemoveObject() 2020-06-19 23:43:40 -04:00
Lioncash 731e34b90b CScriptTemplate: Make use of ranged for where applicable 2020-06-19 23:40:28 -04:00
Lioncash d93810568b CScriptObject: Make use of ranged for where applicable 2020-06-19 23:31:30 -04:00
Lioncash 9f8ecc855b CScriptNode: Tidy up code
- Collapse loops to ranged for where applicable, etc.
2020-06-19 20:55:39 -04:00
Lioncash 0a66503026 CScriptNode: Initialize all class variables
Provides a consistent initial state.
2020-06-19 20:31:08 -04:00
Lioncash 48e182ca80 CScriptLoader: Make use of unsigned stream helpers where applicable 2020-06-19 20:27:49 -04:00
Lioncash 888ceb55d5 CScriptLoader: Make use of in-class initializers
Same behavior, less code.
2020-06-19 20:23:38 -04:00
Lioncash 7629f15f40 CScriptCooker: Make use of unsigned stream helpers
Same behavior, less sign conversion warnings.
2020-06-19 20:21:01 -04:00
Lioncash d9046b4fd9 CScene: Prevent redundant lookups in DeleteNode()
Avoids unnecessary repeated map lookups.
2020-06-19 19:25:12 -04:00
Lioncash d7574a1965 CScene: General tidying up
- Ranged for, sign conversion fixes, etc.
2020-06-19 19:18:13 -04:00
Lioncash 1adb20dc0b CResourceEntry: Eliminate sign conversion warning 2020-06-19 19:03:27 -04:00
Lioncash 92fe105e82 CRenderer: Make use of std::array 2020-06-19 18:57:33 -04:00
Lioncash 9441933ce2 CRenderer: Make use of in-class initializers
Same behavior, less code.
2020-06-19 18:51:45 -04:00
Lioncash f88122b2ed CRenderBucket: Tidy up code 2020-06-19 18:47:24 -04:00
Lioncash b02b507675 CRayCollisionTester: Tidy up code a little 2020-06-19 18:39:21 -04:00
Lioncash 40f0fbca4c CPointOfInterestExtra: Make color instances constexpr
Avoids unnecessary file-scope static constructors.
2020-06-19 18:35:11 -04:00
Lioncash 84506c99fb CModelCooker: Make use of unsigned stream helpers where applicable 2020-06-19 18:04:37 -04:00
Lioncash 0059558efc CScene: Make use of in-class initializers 2020-06-19 03:44:19 -04:00
Lioncash ffbe857c2c CScanLoader: Make use of unsigned stream helpers 2020-06-19 03:41:41 -04:00
Lioncash 125da2d930 CScanCooking: Make use of unsigned stream helpers 2020-06-19 03:40:31 -04:00
Lioncash 61ec2f2e08 CResourceEntry: Make use of static qualifier
This function doesn't depend on instance state.
2020-06-19 03:38:02 -04:00
Lioncash 1e46717b57 CPropertyNameGenerator: Make use of in-class initializers
Same behavior, less code.
2020-06-19 03:32:25 -04:00
Lioncash 53881d1748 CPoiToWorldLoader: Make use of unsigned stream utilities 2020-06-19 03:30:42 -04:00
Lioncash be97a39778 CPoiToWorldCooker: Make use of unsigned stream utilities 2020-06-19 03:30:10 -04:00
Lioncash 5661d0263e CPoiToWorld: Make use of ranged for 2020-06-19 03:27:46 -04:00
Lioncash a6caff1387 CPoiToWorld: Make use of unique_ptr
Safer memory management.
2020-06-19 03:22:24 -04:00
Lioncash df29cc2109 CPackage: Make use of unsigned stream helpers where applicable 2020-06-19 03:13:41 -04:00
Lioncash 9a2580ad03 CModelNode: Make use of in-class initializers
Same behavior, less code.
2020-06-19 02:56:52 -04:00
Lioncash 73d010e6d1 CModelLoader: Make use of unsigned stream helpers where applicable
Same behavior without implicit sign conversions
2020-06-19 02:50:40 -04:00
Lioncash 80e4790384 CFontLoader: Make use of unsigned stream helpers
Same behavior, minus implicit sign conversions.
2020-06-19 02:44:46 -04:00
Lioncash b559df4e0a CDoorExtra: Tidying up
- Fix wonky formatting
- Apply const
2020-06-19 02:38:35 -04:00
Lioncash 0ec31eef71 CDependencyGroupLoader: Make use of unsigned stream helpers
Eliminates implicit sign conversions
2020-06-19 02:35:21 -04:00
Lioncash 3dd325f708 CDamageableTriggerExtra: Make use of unique_ptr
Safer lifetime management.
2020-06-19 00:28:25 -04:00
Lioncash 81560138c0 CDamageableTriggerExtra: add missing override specifier 2020-06-19 00:26:48 -04:00
Lioncash 75be364148 CDamageableTriggerExtra: Make use of std::array
Stronger typing.
2020-06-19 00:26:09 -04:00
Lioncash e875c2bf08 CCollisionLoader: Make use of unsigned helper functions where applicable
Same behavior minus several sign conversion warnings.
2020-06-19 00:19:44 -04:00
Lioncash bcc27ddd5c CAudioGroupLoader: Make use of unsigned stream helpers where applicable
Same behavior, minus implicit sign conversions.
2020-06-18 19:38:22 -04:00
Lioncash 59cfe6fc02 CAreaLoader: Make use of unsigned stream helpers
Same behavior, minus all the implicit sign conversions.
2020-06-18 19:35:11 -04:00
Lioncash d646b896e1 CAreaLoader: Make use of in-class initializers where applicable
Same behavior, less code.
2020-06-18 19:20:01 -04:00
Lioncash 4d4f1490b7 CAreaCooker: Make use of unsigned stream helpers where applicable
Same behavior minus numerous implicit sign conversions.
2020-06-18 19:16:51 -04:00
Lioncash cf0898792a CAnimSetLoader: Make use of unsigned stream helpers where applicable
Same behavior, minus all of the implicit sign conversions.
2020-06-18 19:08:37 -04:00
Lioncash 36e005844f CPackage: std::move strings in constructor where applicable
Allows calling code to completely avoid copies.
2020-06-18 18:47:23 -04:00
Lioncash bf9be7f2ad CGameProject: Mark vars as const where applicable 2020-06-18 18:45:45 -04:00
Lioncash 811447a387 CGameExporter: Mark ShouldExportDiscNode() as a const member function
This doesn't modify internal state.
2020-06-18 18:41:00 -04:00
Lioncash 2d1e6b9672 CGameExporter: Make use of unsigned stream helpers where applicable 2020-06-18 18:39:44 -04:00
Lioncash a603b3a4ef CMaterialLoader: Make use of unsigned stream helpers where applicable 2020-06-18 18:14:33 -04:00
Lioncash 4b20a8ad9f CMaterialCooker: Make use of unsigned write variants where applicable
Gets rid of a bunch of implicit sign conversion warnings.
2020-06-18 17:50:25 -04:00
Lioncash 4b980458ef CAnimationLoader: Make use of ranged for where applicable 2020-06-18 15:55:19 -04:00
Lioncash 87fac0896d CModelLoader: Eliminate some sign conversion warnings 2020-06-18 15:38:52 -04:00
Lioncash 80d5983229 CMaterialPass: Add another missing break for Mode 6 in SetAnimCurrent 2020-06-18 13:51:08 -04:00
Lioncash e65a2a7cc8 CMaterialPass: Add missing break for Mode 6 in SetAnimCurrent 2020-06-18 13:39:20 -04:00
Lioncash 1c0e7a3b1d CGameExporter: Make use of in-class initializers
Same behavior, less code.
2020-06-18 13:35:01 -04:00
Lioncash 7177295cbb CCamera: Make use of in-class initializers
Same behavior, less code.
2020-06-18 13:32:49 -04:00
Lioncash 46e5056ba7 CMaterial: Make use of in-class initializers
Same behavior, less code.
2020-06-18 13:28:25 -04:00
Lioncash b18accfa60 CFramebuffer: Make use of in-class initializers
Same behavior, less code.
2020-06-18 13:23:51 -04:00
Lioncash 3d74639bea CScriptTemplate: Fix debug print formatting in CheckVolumeConditions
Ensures that the proper type is passed in.
2020-06-18 13:17:30 -04:00
Lioncash e75ef00d1c CAreaLoader: Fix debug print formatting
Passes the correct type to the formatting specifier.
2020-06-18 13:15:42 -04:00
Lioncash 9d21516296 CWorldCooker: Prevent signed overflow in CookMLVL
Even if all 32 bits aren't used, this still eliminates a sign-conversion
warning from int to uint64.`
2020-06-18 13:13:26 -04:00
Lioncash 1d54df7185 CAnimSetLoader: Collapse emplace_back() and back() calls into one
emplace_back returns a reference to the emplaced element.
2020-06-18 12:47:37 -04:00
Lioncash 4f4ef28bb1 CUniformBuffer: Convert 0 literal into nullptr
Explicit typing.
2020-06-18 12:43:09 -04:00
Lioncash 82d47e82e9 CUniformBuffer: uint -> uint32 2020-06-18 12:42:34 -04:00
Lioncash db7614be95 CTweakData: uint -> uint32
Makes the assumption about having a 32-bit value explicit in the
class itself.
2020-06-18 12:40:53 -04:00
Lioncash 24bfee8528 DependencyListBuilders: Make use of ranged for where applicable 2020-06-18 12:19:43 -04:00
Lioncash a0ec0d938f GLCommon: Make use of std::array where applicable 2020-06-18 12:00:31 -04:00
Lioncash b781ca7b89 CPointOfInterestExtra: Convert 0 literal to nullptr 2020-06-18 08:03:54 -04:00