Lioncash
2bf190048d
CScriptRoomAcoustics: Brace conditionals where applicable
2020-05-07 12:28:45 -04:00
Lioncash
e691628289
CScriptShadowProjector: Brace conditionals where applicable
2020-05-07 12:27:49 -04:00
Lioncash
7186e57a9d
CScriptSound: Brace conditionals where applicable
2020-05-07 12:26:05 -04:00
Lioncash
ecbcb86bc5
CScriptSpawnPoint: Brace conditionals where applicable
2020-05-07 12:18:57 -04:00
Lioncash
750e0a8643
CScriptSpecialFunction: Brace conditionals where applicable
2020-05-07 12:16:53 -04:00
Lioncash
568e8c0d88
CScriptSpiderBallWaypoint: Brace conditionals where applicable
2020-05-07 12:03:44 -04:00
Lioncash
90e67898e4
CScriptSpindleCamera: Brace conditionals where applicable
2020-05-07 11:59:29 -04:00
Lioncash
5cc1cd799a
CScriptSteam: Brace conditionals where applicable
2020-05-07 11:50:21 -04:00
Lioncash
52cc84374d
CScriptStreamedMusic: Brace conditionals where applicable
2020-05-07 11:49:31 -04:00
Lioncash
79a25cab5e
CScriptSwitch: Brace conditionals where applicable
2020-05-07 11:48:34 -04:00
Lioncash
0fa7e0a73b
CScriptTargetingPoint: Brace conditionals where applicable
2020-05-07 11:47:59 -04:00
Lioncash
bb578468f4
CScriptTimer: Brace conditionals where applicable
2020-05-07 11:47:05 -04:00
Lioncash
ca718f938e
CScriptTrigger: Brace conditionals where applicable
2020-05-07 11:45:53 -04:00
Lioncash
29f6ef0f76
CScriptVisorFlare: Brace conditionals where applicable
2020-05-07 11:41:56 -04:00
Lioncash
d517db5c5d
CScriptVisorGoo: Brace conditionals where applicable
...
Makes the code consistent.
2020-05-07 11:41:14 -04:00
Lioncash
f78c85f37c
CScriptWaypoint: Brace conditionals where applicable
...
Makes the code consistent.
2020-05-07 11:39:11 -04:00
Lioncash
717d422fc4
CScriptWater: Brace conditionals where applicable
2020-05-07 11:36:17 -04:00
Lioncash
2014854f7c
CObjectList: Provide operator== for iterators
...
Makes the interface logically symmetrical in terms of allowed
comparisons.
2020-05-07 08:25:55 -04:00
Lioncash
762a4634cb
CObjectList: Make constructor explicit
...
Prevents error-prone implicit constructions from taking place.
2020-05-07 08:22:54 -04:00
Lioncash
35fd50ded3
CObjectList: Add const overloads for begin() and end()
...
Allows iterating in a ranged for loop in const contexts.
2020-05-07 08:22:32 -04:00
Lioncash
c81d6632bb
CScriptActor: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 08:19:14 -04:00
Lioncash
63fda8f1c7
CScriptActorRotate: Brace statements where applicable
...
Makes code consistent.
2020-05-07 08:11:09 -04:00
Lioncash
e8dc27bfaa
CScriptAiJumpPoint: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 08:01:38 -04:00
Lioncash
bdcf6dee66
CScriptAreaAttributes: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 07:59:20 -04:00
Lioncash
0bb3fcae3b
CScriptBallTrigger: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 07:58:15 -04:00
Lioncash
ec6416e387
CScriptBeam: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 07:55:24 -04:00
Lioncash
23b14232be
CScriptCamera*Keyframe: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 07:54:19 -04:00
Lioncash
d6ad152a97
CScriptCameraHint: Brace statements where applicable
...
Makes code consistent.
2020-05-07 07:51:50 -04:00
Lioncash
a8fd2a1992
CScriptCameraHintTrigger: Brace statements where applicable
...
Same behavior, more consistent code.
2020-05-07 07:45:08 -04:00
Lioncash
ed231b85e9
CScriptCameraPitchVolume: Brace statements where applicable
...
Makes the code consistent.
2020-05-07 07:43:35 -04:00
Lioncash
dab1784302
CScriptDamageableTrigger: Brace conditions where applicable
...
Makes code consistent.
2020-05-07 07:40:26 -04:00
Lioncash
ff0d14b52d
CScriptDamageableTrigger: Mark helper functions as static where applicable
...
Makes them internally linked.
2020-05-07 07:37:04 -04:00
Lioncash
af61cba8db
CScriptDebris: Brace statements where applicable
...
Makes code fully consistent style-wise.
2020-05-07 07:29:21 -04:00
Lioncash
d3ad8e104b
CScriptDebris: Remove redundant constructor initializers
...
These are initialized within the class definition.
2020-05-07 07:18:09 -04:00
Luke Street
d30ce2b218
CScriptPlatform: Fix breakable behavior; CScriptColorModulate fixes
2020-05-07 02:19:58 -04:00
Lioncash
40ede53949
CScriptWorldTeleporter: Unindent code in StartTransition()
...
We can make use of an early-return to unindent code by one level.
2020-05-03 10:28:28 -04:00
Lioncash
d0233b7767
CTeamAiMgr: Make reference parameters to GetTeamAiMgr() const
...
No modifications to these parameters are being made, so we can make that
explicit in the interface.
2020-05-02 22:39:51 -04:00
Lioncash
21a33b01ad
CTeamAiMgr: Collapse two loops into count_if
...
Same behavior, less code.
Ranges in C++20 will allow us to further simplify this in the future.
2020-05-02 22:09:52 -04:00
Lioncash
748dbb8740
CTargetingManager: Mark CheckLoadComplete() as const
...
This member function doesn't alter internal member state.
2020-05-02 21:56:58 -04:00
Lioncash
d3dbe15fcc
CSpawnSystemKeyframeData: Remove unnecessary includes
2020-05-02 21:28:52 -04:00
Luke Street
973eb622c7
CAnimTreeSequence: Add EpsilonZero check
2020-04-30 02:17:06 -04:00
Luke Street
3570ed8e24
Merge pull request #318 from lioncash/draw
...
CGuiWidgetDrawParms: Make constexpr constructible
2020-04-30 01:28:09 -04:00
Luke Street
1578a9481b
CScriptAiJumpPoint: Fix GetInUse
2020-04-29 03:03:14 -04:00
Luke Street
abfd5a464f
CGroundMovement: Fix CheckFalling not being called consistently
2020-04-29 02:09:20 -04:00
Phillip Stephens
92076a3bd3
Implement CBurrower
2020-04-28 07:16:10 -07:00
Phillip Stephens
9b94dd7c3a
Fix compiling CGameOptionsTouchBar
2020-04-26 18:47:01 -07:00
Phillip Stephens
5724be3294
CIceSheegoth: Implement AddToRenderer and AttractProjectiles
2020-04-26 17:43:22 -07:00
Lioncash
1948ec3274
CWallWalker: Remove unused variables in PreThink
...
We can leave a comment documenting this to make the code itself a little
nicer to read.
2020-04-26 03:28:48 -04:00
Lioncash
d4264b6469
CWallWalker: Eliminate signed->unsigned implicit conversion in header
...
Prevents compiler warnings.
2020-04-26 03:22:03 -04:00
Lioncash
4f56bf8eb6
CWallWalker: Simplify CCollisionSurface initializer
...
Allows it to sit on one line.
2020-04-26 03:20:47 -04:00
Lioncash
deff9d054b
CTimeProvider: Move global instance to cpp file
...
This isn't used anywhere externally, so we can keep it hidden in the cpp
file.
2020-04-26 03:05:57 -04:00
Lioncash
002102c530
RumbleFxTable: Make table constexpr
...
Eliminates any potential runtime initializers.
2020-04-26 01:27:46 -04:00
Lioncash
6c475b6764
CGuiWidgetDrawParms: Make constexpr constructible
...
We can allow this structure to be constructed in a constexpr context.
This also allows us to remove the cpp file, given it's no longer
necessary.
2020-04-26 01:15:04 -04:00
Lioncash
07ebdd364c
CDamageVulnerability: Make constructors constexpr
...
Eliminates any potential runtime initializers related to file-scope
constant instances of this class.
2020-04-26 01:06:26 -04:00
Lioncash
0ad1f8ba42
CDamageVulnerability: Amend typo in parameter name
2020-04-26 00:56:45 -04:00
Lioncash
f1ff48c38b
CDamageVulnerability: Remove unnecessary inline specifiers
...
These functions are already marked static, so they're already a
candidate for inlining.
We can mark them as constexpr though, given how trivial they are.
2020-04-26 00:54:36 -04:00
Lioncash
b76b956339
CElementGen: Give all function prototype parameters names
2020-04-25 03:16:08 -04:00
Lioncash
57d953a045
CElementGen: Eliminate sign conversion warnings with function parameters
...
Makes the expected types explicit.
2020-04-25 03:09:29 -04:00
Lioncash
eb4362a4d4
CDecalDataFactory: Remove unused includes
2020-04-25 02:52:53 -04:00
Lioncash
96070f0c89
CGuiTextPane: Eliminate implicit float->int conversions
2020-04-25 02:28:52 -04:00
Phillip Stephens
4e0b933357
CIceSheegoth: Implement ShakePlayer and minor fixes
2020-04-24 16:34:23 -07:00
Phillip Stephens
86acf6dce7
CIceSheegoth: Call the correct PathFind... I'm an idiot
2020-04-24 07:42:54 -07:00
Phillip Stephens
7b9fecfdc6
CIceSheegoth: Final state implementations
2020-04-24 07:36:49 -07:00
Luke Street
3c48da0cdb
Merge remote-tracking branch 'origin/trim'
2020-04-24 02:43:56 -04:00
Lioncash
d7c9135d27
CBomb: Fix boolean parameter not being used within SetFuseDisabled()
...
Prevents silent logic bugs, particularly given this function is called
with true as well inside CTryclops::InMaxRange.
2020-04-24 01:12:04 -04:00
Lioncash
27861d5c78
CUVElement: Convert stateful structs into classes
...
Avoids exposing the internals of the data by default (since they were
previously fully accessible).
2020-04-24 00:59:51 -04:00
Lioncash
b32bc296ad
CUVElement/CVectorElement: Make use of [[maybe_unused]] where applicable
2020-04-24 00:58:44 -04:00
Lioncash
4a9095a2af
CRealElement: Make use of [[maybe_unused]] where applicable
2020-04-24 00:57:13 -04:00
Lioncash
f620b4325f
CIntElement: Make use of [[maybe_unused]] where applicable
2020-04-24 00:55:43 -04:00
Lioncash
102d62846c
CColorElement: Make use of [[maybe_unused]] where applicable
2020-04-24 00:54:08 -04:00
Lioncash
6d53912770
CStringTable: Make use of [[maybe_unused]] where applicable
2020-04-23 21:24:39 -04:00
Lioncash
ee0762db32
CRasterFont: Make use of [[maybe_unused]] where applicable
2020-04-23 21:23:17 -04:00
Lioncash
5e9bf292d7
CTextureCache: Make use of [[maybe_unused]] where applicable
2020-04-23 21:15:30 -04:00
Lioncash
600076030f
CStateManager: Make use of bool parameter in SetWarping()
...
Allows toggling the warping.
2020-04-23 21:12:52 -04:00
Lioncash
25b0c69818
CSaveWorld: Make use of [[maybe_unused]] where applicable
...
Prevents unused parameter warnings.
2020-04-23 20:51:59 -04:00
Lioncash
301eb24301
CInGameTweakManagerBase: Make internal members of CTweakValue private
2020-04-23 20:48:43 -04:00
Lioncash
e4dedac2b6
CInGameTweakManagerBase: Make use of algorithms where applicable
2020-04-23 20:44:31 -04:00
Lioncash
e1dfe9ff8e
CGameOptionsTouchBar: Make use of [[maybe_unused]] where applicable
...
Silences unused parameter warnings
2020-04-23 20:34:05 -04:00
Lioncash
14e0067a97
CDependencyGroup: Make use of [[maybe_unused]] where applicable
2020-04-23 20:31:29 -04:00
Lioncash
4a6c3cde3c
CWorldLight: Eliminate variable shadowing
...
While we're at it, we can make use of structured bindings.
2020-04-23 07:25:07 -04:00
Lioncash
4e3363a98b
CScriptActorKeyframe: Eliminate variable shadowing
2020-04-23 07:22:10 -04:00
Lioncash
9ec9f42457
CPathFindSearch: Eliminate variable shadowing
2020-04-23 07:19:41 -04:00
Lioncash
078acce378
CMorphBall: Eliminate variable shadowing
2020-04-23 07:18:43 -04:00
Lioncash
31cf98646b
CModVectorElement: Eliminate variable shadowing
...
Prevents "a" from clashing with a local variable.
2020-04-23 07:16:49 -04:00
Lioncash
9fa689a806
CMemoryCardSys: Eliminate variable shadowing
...
Prevents names from clashing with variables from outside the loop scope.
2020-04-23 07:13:22 -04:00
Lioncash
e0bb66f7f0
CParticleElectricDataFactory: Remove unused includes
2020-04-23 03:58:10 -04:00
Lioncash
eefeb5cd0b
CGameArea: Remove undefined behavior type-punning in a few functions
...
We can make use of std::memcpy here to get around this.
2020-04-23 03:06:04 -04:00
Lioncash
df3aed75fe
CGameArea: Eliminate implicit sign conversions in Validate()
2020-04-23 02:53:24 -04:00
Lioncash
419d40051d
CGuiTextSupport: Make enum formatting consistent
2020-04-23 02:41:22 -04:00
Lioncash
b700da547e
CGuiTextSupport: Invert conditionals where applicable
...
Unindents code and allows for easier placement of breakpoints when the
conditions are equal to the early exit path.
2020-04-23 02:39:39 -04:00
Lioncash
787fc3276f
CGuiTextSupport: Use const references where applicable
2020-04-23 02:36:45 -04:00
Lioncash
a21fb1da35
CGuiObject: Remove unused includes
2020-04-23 02:27:11 -04:00
Lioncash
2b2edfa871
CGrappleArm: Invert conditionals where applicable
...
Makes early-exit conditions nicer to follow and also unindents some
code.
2020-04-23 01:57:18 -04:00
Phillip Stephens
1b1907d910
CIceSheegoth: Minor fixes
2020-04-22 16:46:52 -07:00
Phillip Stephens
97a25f01e2
Initial state implementations
2020-04-22 15:06:15 -07:00
Phillip Stephens
b1a897d246
CIceSheegoth: Implement Think
2020-04-22 15:06:15 -07:00
Phillip Stephens
3779b205b7
Initial CIceSheegoth stubout
2020-04-22 15:06:15 -07:00
Phillip Stephens
59f979db67
Actually implement AssetNameMap in DNAMP1
2020-04-22 03:38:48 -07:00
Lioncash
535717fbd8
CGameArea: Make use of std::array where applicable
2020-04-22 02:19:14 -04:00
Lioncash
664d08469c
CEnvFxManager: Make use of std::array where applicable
...
Same behavior, less code.
2020-04-22 02:16:37 -04:00
Lioncash
52f51c111a
CAmbientAI: Return std::nullopt in GetTouchBounds()
...
Allows implementations to avoid zeroing out the internal buffer of the
std::optional.
2020-04-22 02:10:55 -04:00
Lioncash
472e97aac0
CAreaOctTree: Make use of std::array where applicable
2020-04-22 02:05:22 -04:00
Lioncash
f24559890a
TSegIdMap: Make use of std::array where applicable
...
Stronger typing and eliminates array to pointer decay.
2020-04-22 01:59:29 -04:00
Lioncash
fe642bde8b
CCameraBlurFilter: Make use of std::array where applicable
...
Same behavior, less hardcoded sizes.
2020-04-22 00:13:43 -04:00
Luke Street
4741172f9f
Merge pull request #316 from lioncash/init2
...
RuntimeCommon: Make use of bitfield initializers where applicable
2020-04-21 22:52:25 -04:00
Luke Street
12d8d534c6
CParticleElectric: Fix CalculatePoints
2020-04-21 22:32:37 -04:00
Luke Street
fc7e8d4993
CElectricBeamProjectile: Finish implementation
2020-04-21 22:04:37 -04:00
Luke Street
8488dca336
CPlayer: Long fall anim/dmg fix
2020-04-21 20:43:34 -04:00
Luke Street
82aa99f858
CScriptCameraWaypoint: Fix Arrived
2020-04-21 20:35:37 -04:00
Lioncash
fa3e639a9d
RuntimeCommon: Make use of bitfield initializers where applicable
...
Continues and finishes the migration towards initializing all bitfield
members where applicable
2020-04-21 17:16:19 -04:00
Luke Street
1571531cd7
CMagdolite: Renaming
2020-04-21 14:15:17 -04:00
Luke Street
449d8409d8
CMagdolite: Fix lock-on, retreat & loader
2020-04-21 04:46:07 -04:00
Luke Street
b4dad2adf5
CMagdolite: Fix SetupCollisionActors
2020-04-21 02:15:02 -04:00
Luke Street
5f66ab2219
CMagdolite: Minor cleanup
2020-04-21 01:32:16 -04:00
Phillip Stephens
0c96380897
Minor fixes, start renaming member variables
2020-04-21 01:06:52 -04:00
Phillip Stephens
d1c796f2a9
Initial CMagdolite imps
2020-04-21 01:06:52 -04:00
Luke Street
d3a44259c3
Merge pull request #315 from lioncash/init
...
RuntimeCommonB: Make use of bitfield initializers where applicable
2020-04-21 00:56:39 -04:00
Lioncash
554893ef85
RuntimeCommonB: Make use of bitfield initializers where applicable
...
Given that we now target C++20, we can make use of bitfield initializers
where applicable.
2020-04-20 15:57:25 -04:00
Luke Street
7b1e041123
Merge pull request #301 from AxioDL/omegapirate
...
OmegaPirate implementation
2020-04-20 03:21:04 -04:00
Luke Street
2ee2bbc0c1
COmegaPirate: Fix CFlash rendering
2020-04-20 03:20:22 -04:00
Luke Street
3563a1c8c4
COmegaPirate: Fix UpdateScale & Landed; renaming
2020-04-20 02:14:17 -04:00
Lioncash
2103c38f54
CCompoundTargetReticle: Remove unused variable
...
This is only used in COrbitPointMarker.
2020-04-20 00:48:29 -04:00
Lioncash
1d0151ccbc
General: Make use of lock deduction guides
2020-04-20 00:38:10 -04:00
Lioncash
dca87e7dce
CPlayerGun: Convert missed literal to a boolean literal
...
whoops.
2020-04-19 23:39:04 -04:00
Lioncash
1f8f3726e6
CPlayerGun: Make use of bool literal where appropriate
...
Avoids a conversion to bool from int.
2020-04-19 23:35:07 -04:00
Luke Street
32c44cbf05
Merge branch 'master' into omegapirate
...
# Conflicts:
# Runtime/GuiSys/CAuiImagePane.cpp
2020-04-19 22:12:18 -04:00
Luke Street
1fd28d3fc3
CStateMachine: Use logvisor report for state logging
2020-04-19 22:11:09 -04:00
Lioncash
f0133c9eef
CAuiImagePane: Eliminate implicit conversions
...
We can make them explicit instead.
2020-04-19 22:06:30 -04:00
Lioncash
ecdedb5d8f
CActorModelParticles: Make IsMediumOrLarge() parameter a const reference
...
Nothing about the parameter is modified.
2020-04-19 21:44:31 -04:00
Luke Street
2185dc30f1
CStateManager: Fix seek again (I tested it this time)
2020-04-19 21:40:08 -04:00
Luke Street
764432882c
CStateManager: Fix wrong stream position on error
2020-04-19 21:27:08 -04:00
Luke Street
d5fcb4a917
CStateManager: Revert debug commit
2020-04-19 21:20:25 -04:00
Luke Street
24acb585f8
MSVC & zeus fixes; update hecl-gui
2020-04-19 21:09:30 -04:00
Luke Street
de5513e277
COmegaPirate: Renaming & fixes
2020-04-19 19:26:25 -04:00
Luke Street
4e88f503ac
COmegaPirate: Implement CFlash
2020-04-19 02:47:25 -04:00
Lioncash
ec5d680be0
CBurstFire: Unindent conditionals where applicable
...
Makes it nicer to read early-exit conditions.
2020-04-19 00:40:46 -04:00
Luke Street
e50d363e88
CPlayerGun: Rename EMissileState; minor CMotionState::Update fix
2020-04-19 00:26:53 -04:00
Luke Street
a3e0c42794
Merge pull request #312 from lioncash/explicit
...
MkCastTo: Make operator bool instances explicit
2020-04-19 00:24:15 -04:00
Luke Street
025a989e12
CElementGen: Use x338_moduColor in RenderModels
2020-04-18 23:41:35 -04:00
Lioncash
2c3e5e205f
MkCastTo: Make operator bool instances explicit
...
Prevents error prone implicit conversions.
2020-04-18 23:02:11 -04:00
Luke Street
0a2d0bcfe9
Merge pull request #313 from lioncash/bug
...
CToken: Amend incorrect return value of TToken's operator=
2020-04-18 18:16:42 -04:00
Luke Street
30f2ac3f26
Merge branch 'master' into omegapirate
2020-04-18 18:14:51 -04:00
Luke Street
7f15390d4f
Editor: Only create Win32 console & redirect logging if not attached
2020-04-18 03:02:44 -04:00
Phillip Stephens
df75c00203
Fix WideScreenFilter crash
2020-04-17 15:32:26 -07:00
Lioncash
76f0b57340
General: Use bool literals where applicable
...
More indicative of the passed in type compared to raw values.
2020-04-17 17:43:56 -04:00
Lioncash
8e5fc3668c
CToken: Amend incorrect return value of TToken's operator=
...
This should be returning by reference, not the pointer of this.
2020-04-17 17:16:33 -04:00
Lioncash
0b05c906df
CScriptEffect: Eliminate variable shadowing
...
Avoids clashing names.
2020-04-17 16:31:02 -04:00
Luke Street
8f5caca1e5
CMemoryCardSysWin: Add includes
2020-04-17 15:10:52 -04:00
Luke Street
61e656e732
CDvdFile: Remove const from auto type for MSVC
2020-04-17 15:01:31 -04:00
Luke Street
36bbc5004f
CDvdFile: Use auto for string_view::begin
2020-04-17 14:52:25 -04:00
Luke Street
4a8f077d92
MP1: Use _SYS_STR where needed
2020-04-17 14:39:40 -04:00
Luke Street
248e7654fa
MP1: char -> boo::SystemChar
2020-04-17 14:31:29 -04:00
Luke Street
73b9d2024b
MP1: Use SystemStringConv for printing version string
2020-04-17 14:24:06 -04:00
Lioncash
5491f3ff23
CKnockBackController: Simplify initialization of x24_ in constructor
...
Same behavior, less code.
2020-04-17 13:17:27 -04:00
Lioncash
26ac3b166d
CKnockBackController: Make use of braces where applicable
...
Makes code more consistent.
Where applicable we can also unindent code.
2020-04-17 13:17:27 -04:00
Phillip Stephens
acf513c6bf
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde
2020-04-17 05:54:17 -07:00
Phillip Stephens
a06594f404
Fix CAutoMapper strings, disable saving on non-USA/GC versions
2020-04-17 05:53:22 -07:00
Lioncash
58040eb53d
CKnockBackController: Make CalculateExtraHurlVelocity() a const member function
...
This doesn't modify internal member state, so it can be marked const
While we're at it we can also invert the conditional to unindent the
main calculation.
2020-04-17 01:07:41 -04:00
Lioncash
b55d1e4c77
CKnockBackController: Make use of const references where applicable
...
In many cases the CPatterned& parameter is only used for read-only
querying. We can make this explicit in the interface.
2020-04-17 01:03:12 -04:00
Lioncash
49cc019699
CKnockBackController: Make GetKnockBackCharacterState() a const member function
...
This doesn't modify internal instance state, so this can be made const.
2020-04-17 00:58:29 -04:00
Lioncash
529d7e58bd
CFishCloud: Initialize x230_whichModel on construction
...
Provides a deterministic initial state.
2020-04-17 00:49:06 -04:00
Lioncash
fa9f0fdc61
CFishCloud: Brace statements where applicable
...
Makes the code more uniform and consistent.
While we're in the same area, we can make use of const where applicable.
2020-04-17 00:47:25 -04:00
Lioncash
3715e6dcbb
CFlameWarp: Make use of const where applicable
...
Makes algorithms easier to follow by explicitly marking immutable
state.
2020-04-17 00:27:22 -04:00
Lioncash
ed125031f3
CFluidUVMotion: Collapse separate resize and assignment into a constructor call
...
We can pre-size and insert the elements all at the same time.
2020-04-16 21:11:31 -04:00
Phillip Stephens
c85f1a64dd
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde
2020-04-16 17:20:25 -07:00
Phillip Stephens
ba3b23edaa
Disable saving on non-NTSC-U versions
2020-04-16 17:19:55 -07:00
Lioncash
20e5595042
CGameState: Always initialize x80_
...
Provides a deterministic initial state.
2020-04-16 20:00:26 -04:00
Lioncash
a551dbc21d
CGameState: Silence implicit truncation warnings
...
Ensures boolean conditions are used where applicable.
2020-04-16 20:00:20 -04:00
Lioncash
f844f2028b
CGameOptions: Give all function prototype parameters a name
...
Makes the interface more self-documenting and also allows better IDE
introspection.
2020-04-16 19:49:35 -04:00
Lioncash
e7ef1e0b5e
CGameOptions: Make TuneScreenBrightness() a const member function
...
This member function doesn't modify internal class state.
2020-04-16 19:42:22 -04:00
Lioncash
c32c42e12b
CGameOptions: Amend wonky formatting of VisorOptsNew
2020-04-16 13:00:08 -04:00
Phillip Stephens
be45be9d67
Fix FrontEnd options screen
2020-04-16 03:35:51 -07:00
Phillip Stephens
9365c35000
Finish fixing STRG indices
2020-04-16 03:25:59 -07:00
Phillip Stephens
8e2636c14c
Undo debug code
2020-04-15 23:58:00 -07:00
Phillip Stephens
c64e3d2ba7
Initial string fixes
2020-04-15 23:57:04 -07:00
Phillip Stephens
582d8a6999
Initial PAL/JP/Trilogy imps, various cleanup
2020-04-15 22:26:14 -07:00
Phillip Stephens
52b4db2f00
Integrate URDEVersionInfo
2020-04-15 06:42:44 -07:00
Phillip Stephens
e553a9022f
Fix CMemoryCardSys
2020-04-15 04:27:06 -07:00
Phillip Stephens
8a974d6e5e
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde
2020-04-15 00:57:37 -07:00
Phillip Stephens
1eade15395
Add version info to extracted data, clean up MP1.*
2020-04-15 00:56:59 -07:00
Luke Street
b020904e84
Comment out printfs entirely
2020-04-14 22:14:27 -04:00
Luke Street
eb89a17817
CDummyWorld: Fix IGetAreaId
2020-04-14 21:15:38 -04:00
Lioncash
6436184a3f
CWorld: Make use of find_if in GetAreaIdForSaveId()
...
Same behavior minus any explicit mutable state.
2020-04-14 16:40:13 -04:00
Lioncash
86b94ad915
CWorld: Make use of std::find_if in IGetAreaId
...
Removes explicit mutable state. This can be further simplified in the
future with ranges.
2020-04-14 16:31:17 -04:00
Lioncash
655805ffcb
CWorld: Add missing override specifier
2020-04-14 16:17:26 -04:00
Lioncash
8e89ac234f
CElementGen: Initialize x80_timeDeltaScale on construction
...
Provides deterministic state upon construction, which is nicer for
debugging.
2020-04-14 16:11:38 -04:00
Lioncash
384efebf55
CElementGen: Collapse loop into a ranged-for loop
...
Same behavior, nicer syntax.
2020-04-14 16:08:21 -04:00
Lioncash
c14721611b
CEnergyProjectile: Make use of const where applicable
...
While we're at it, make use of consistent bracing, given some
conditionals traveled over one line.
2020-04-14 15:47:45 -04:00
Luke Street
9cf95b5c10
Editor: Move cvars to CVarCommons
2020-04-14 15:20:51 -04:00
Luke Street
94be460a1b
MP1: Convert MP1_VARIABLE_DELTA_TIME to cvar
2020-04-14 14:41:02 -04:00
Lioncash
3c8ce3dc99
CGuiTextSupport: Amend typo in debug group label
...
This is within the Render() function, so we can rename the group name.
2020-04-14 13:34:50 -04:00
Lioncash
5381c011a0
CParticleElectric: Eliminate several sign conversion instances
...
Makes sign conversion cases explicit and eliminates them entirely in
other cases.
2020-04-14 12:30:38 -04:00
Lioncash
4cbf8ef513
CParticleElectric: Mark CGlobalRandom instance as maybe unused
...
This has a stateful destructor, so we mark it as unused to silence
unused variable warnings.
2020-04-14 12:16:25 -04:00
Lioncash
8aef2cf95d
CParticleElectric: Make use of const where applicable
...
Makes it easier to read long functions by knowing which variables are
mutable.
2020-04-14 04:20:03 -04:00
Lioncash
fed72614ef
CParticleSwoosh: Use const where applicable
...
Given the length of some functions, this makes following flow nicer,
since it's easier to visually see which variables get modified.
2020-04-14 03:56:27 -04:00
Lioncash
6fbf6734c2
CParticleSwoosh: Eliminate variable shadowing
2020-04-14 03:31:31 -04:00
Lioncash
480d27e68c
CParticleSwoosh: Initialize class data members
...
Makes for deterministic initial state.
2020-04-14 03:27:15 -04:00
Luke Street
112322be5a
Merge pull request #311 from lioncash/sign
...
CScanDisplay: Eliminate implicit sign conversions
2020-04-14 02:10:13 -04:00
Luke Street
594fe2fcbd
Merge pull request #310 from lioncash/table
...
CFluidPlane: Make use of std::array where applicable
2020-04-14 02:09:19 -04:00
Lioncash
59a788a987
CParticleGlobals: Eliminate implicit type conversions
...
Makes them all explicit for the reader.
2020-04-13 18:44:51 -04:00