Commit Graph

908 Commits

Author SHA1 Message Date
Lioncash a9292c1b29 CPoiMapModel: Make use of in-class initializers where applicable 2020-06-28 04:29:46 -04:00
Lioncash 51ba13f988 CPasteNodesCommand: Make use of override where applicable 2020-06-28 04:28:05 -04:00
Lioncash c9fbc0f727 CModelEditorWindow: Mark strings as translatable where applicable 2020-06-28 04:26:40 -04:00
Lioncash 6cdea11377 CModelEditorWindow: Make use of in-class initializers where applicable 2020-06-28 04:15:10 -04:00
Lioncash 16225c278d CModelEditorViewport: Make use of in-class initializers where applicable 2020-06-28 04:11:13 -04:00
Lioncash ae34c2461d CLinkModel: Make strings as translatable where applicable 2020-06-28 04:07:21 -04:00
Lioncash 28e6efb060 CLinkModel: Make use of in-class initializers where applicable 2020-06-28 04:04:47 -04:00
Lioncash 48bef1f346 CLinkDialog: Make strings as translatable where applicable 2020-06-28 04:03:20 -04:00
Lioncash 0d17e8686d CLinkDialog: Make use of in-class initializers where applicable 2020-06-28 04:01:27 -04:00
Lioncash 968fc70cbf CLayerModel: Make use of in-class initializers where applicable 2020-06-28 03:58:13 -04:00
Lioncash d537cfd4b2 CLayerEditor: Make use of in-class initializers where applicable 2020-06-28 03:57:06 -04:00
Lioncash 86bca47221 CInstanceModel: Mark strings as translatable where applicable 2020-06-28 03:54:46 -04:00
Lioncash 6962f8e026 CInstanceModel: Make use of in-class initializers where applicable 2020-06-28 03:48:56 -04:00
Lioncash 832889f029 CGizmo: Make use of in-class initializers where applicable 2020-06-28 03:46:43 -04:00
Lioncash 1dfca12ad6 CGeneratePropertyNamesDialog: Mark strings as translatable where applicable 2020-06-28 03:31:54 -04:00
Lioncash 963b6ccd08 CGeneratePropertyNamesDialog: Make use of in-class initializers where applicable 2020-06-28 03:21:07 -04:00
Lioncash 69f8ff1200 CExportGameDialog: Mark strings as translatable where applicable 2020-06-28 03:17:40 -04:00
Lioncash c4b29106f1 CExportGameDialog: Make use of in-class initializers where applicable 2020-06-28 03:11:41 -04:00
Lioncash fea1c4e115 CEditorApplication: Mark strings as translatable where applicable 2020-06-28 03:06:40 -04:00
Lioncash f1d1c26283 CEditorApplication: Make use of in-class initializers where applicable 2020-06-28 03:02:50 -04:00
Lioncash fb30162a8f CEditLinkCommand: Make use of override where applicable 2020-06-28 02:59:54 -04:00
Lioncash 2a068bdbef CDeleteSelectionCommand: Make use of override where applicable 2020-06-28 02:59:15 -04:00
Lioncash d4a9f73e00 CDeleteLinksCommand: Make use of override where applicable 2020-06-28 02:58:16 -04:00
Lioncash 87be8f6957 CCreateInstanceCommand: Make use of override where applicable 2020-06-28 02:56:43 -04:00
Lioncash 68a8f236fa CCollisionRenderSettingsDialog: Make use of in-class initializers where applicable 2020-06-28 02:54:21 -04:00
Lioncash 4c6080184f CCollisionEditorViewport: Make use of in-class initializers 2020-06-28 02:51:43 -04:00
Lioncash 6bc9c7fdb1 CCollisionEditor: Remove redundant reallocation 2020-06-28 02:49:19 -04:00
Lioncash 720b59919a CCollisionEditor: Default destructor where applicable 2020-06-28 02:48:49 -04:00
Lioncash a4a34da264 CCollisionEditor: Mark strings as translatable 2020-06-28 02:48:29 -04:00
Lioncash ed20e622d7 CCollisionEditor: Tidy up code 2020-06-28 02:47:40 -04:00
Lioncash b42536fdea CCharacterEditorViewport: Make use of in-class initializers where applicable 2020-06-28 02:45:34 -04:00
Lioncash 2f767d6b9a CCharacterEditor: Make use of in-class initializers where applicable 2020-06-28 02:36:13 -04:00
Lioncash 1266b9f041 CCharacterEditor: Make strings localizable 2020-06-28 02:30:08 -04:00
Lioncash 4a9695a698 SScanParametersMP1: Make use of std::array 2020-06-28 02:24:55 -04:00
Lioncash 665d1f3560 IProgressNotifier: Make use of std::move where applicable
Allows calling code to avoid copies entirely.
2020-06-28 01:12:41 -04:00
Lioncash 46e82a99cc CStringList: Simplify assertion in StringByIndex()
This is unsigned, so the lower bound will always be valid.
2020-06-28 01:07:40 -04:00
Lioncash 1c4e8a11d2 CSectionMgrOut: Eliminate sign conversion warnings 2020-06-28 01:05:57 -04:00
Lioncash ecff1a7a2b CSectionMgrIn: Make use of size_t where applicable 2020-06-28 01:05:24 -04:00
Lioncash 8969685254 CScriptLayer: Make pointer parameter in RemoveInstance() const
The pointed to data isn't modified here, so we can mark the parameter as
const to allow it to be used in more scenarios.
2020-06-28 00:50:54 -04:00
Lioncash c6263433a9 CScriptLayer: Make use of size_t where applicable 2020-06-28 00:50:24 -04:00
Lioncash d1939eea95 TPropertyRef: Make use of symmetrical comparison operators
Makes the interface significantly more flexible.
2020-06-28 00:32:47 -04:00
Lioncash a48d3202b6 CScriptNode: Make use of size_t where applicable 2020-06-28 00:27:23 -04:00
Lioncash 8fbc92b0e0 CSavedStateID: Make use of std::array 2020-06-28 00:18:52 -04:00
Lioncash 473e716cb7 CResTypeFilter: Make pointer parameters in Accepts() const
These don't modify the pointed to data.
2020-06-28 00:02:17 -04:00
Lioncash 829613193d CGameInfo: Make use of const reference with LoadGameInfo() 2020-06-22 23:22:30 -04:00
Lioncash a25430eec3 CEnumProperty: Make use of size_t where applicable 2020-06-22 23:15:47 -04:00
Lioncash d3be84ae23 CEnumProperty: Make use of std::move where applicable 2020-06-22 23:07:59 -04:00
Lioncash 315874c0ba CDependencyTree: std::move strings where applicable
Same behavior, more performance
2020-06-22 23:06:19 -04:00
Lioncash 9ed81480cc CDependencyTree: Make use of size_t where applicable 2020-06-22 22:57:02 -04:00
Lioncash 13f0ca07ef CAudioLookupTable: Make use of size_t where applicable 2020-06-22 22:42:53 -04:00
Lioncash e2dedf1b31 CAudioMacro: Make use of size_t where applicable 2020-06-22 22:41:20 -04:00
Lioncash 5d0a08b207 CAudioGroup: Make use of size_t where applicable 2020-06-22 22:38:43 -04:00
Lioncash 5e8062cba1 CAnimSet: Collapse loop into single insert call
We can perform the entire insertion all at once instead of performing
them all one by one.
2020-06-22 22:30:43 -04:00
Lioncash a2ecb2a98c CAnimSet: Make use of size_t where applicable 2020-06-22 22:26:35 -04:00
Lioncash d52b05d71c CMaterial: Implicit conversion to bool cleanup 2020-06-22 03:26:45 -04:00
Lioncash 9c8b65c629 CLightNode: Use structured bindings where applicable 2020-06-22 03:24:04 -04:00
Lioncash 15f151e798 CLight: Combine std::max calls 2020-06-22 03:19:13 -04:00
Lioncash 4c03054109 CLight: Eliminate implicit conversions to bool 2020-06-22 03:14:56 -04:00
Lioncash ea86654935 General: Make use of ranged for where applicable 2020-06-22 03:09:22 -04:00
Lioncash 8dd4fb24d9 General: Make use of in-class initializers 2020-06-22 02:36:07 -04:00
Lioncash 127712f459 CVertexBuffer: Eliminate implicit bool conversions 2020-06-22 02:31:51 -04:00
Lioncash 12cd221c48 CStaticModel: Invert condition in BufferGL 2020-06-22 02:24:40 -04:00
Lioncash 6120e60b05 CStaticModel: Make use of ranged for 2020-06-22 02:23:55 -04:00
Lioncash 2732ae8383 CStaticModel: Make use of nullptr 2020-06-22 02:16:27 -04:00
Lioncash 4b3af988ad General: Add missing override specifiers where applicable 2020-06-22 02:15:41 -04:00
Lioncash 46926ef4bf General: Qualify const where applicable 2020-06-22 02:11:03 -04:00
Lioncash 2b7513b156 SSurface: Make IntersectsRay() a const member function 2020-06-21 19:48:39 -04:00
Lioncash 5b0ae09cf3 General: Silence -Wmaybe-uninitialized warnings 2020-06-21 19:43:16 -04:00
Lioncash 03a858d4fa General: Silence some unused variables
These are checked in asserts that aren't present in release builds.
2020-06-21 19:30:24 -04:00
Lioncash ebd1468bbf IProperty: Make use of size_t where applicable 2020-06-21 19:27:44 -04:00
Lioncash 48d0ae5e10 CScriptLoader: Silence unused variable warnings
These will eventually be used.
2020-06-21 19:18:47 -04:00
Lioncash cd55278e3e CMayaSpline: Silence unused variable warnings 2020-06-21 19:15:41 -04:00
Lioncash 3c78cbbeb3 CAreaAttributes: Default destructor 2020-06-21 02:49:11 -04:00
Lioncash 62b08a0b14 CModelNode: Initialize all class variables
Provides a consistent initial state.
2020-06-21 02:46:55 -04:00
Lioncash c19017f7ad CShader: Make use of std::to_string
Same behavior, but standard
2020-06-21 02:42:47 -04:00
Lioncash 79f4866365 CDamageableTriggerExtra: Make use of structured bindings 2020-06-21 02:40:25 -04:00
Lioncash 8c3f77df8a CDamageableTriggerExtra: Mark member functions as const where applicable
These don't modify instance state.
2020-06-21 02:37:42 -04:00
Lioncash 8ad6da5501 CSceneNode: Remove dead conditionals in DrawModelParts()
The condition is alreadt checked against in the if statement, so this
condition will never be true.
2020-06-21 02:32:14 -04:00
Lioncash c11ec0a6fd CDependencyGroup: Make use of ranged for 2020-06-21 02:29:23 -04:00
Lioncash 46b9a6eeb3 CScriptLayer: Make use of ranged for 2020-06-21 02:22:20 -04:00
Lioncash ff848428b7 CVirtualDirectory: Make use of ranged for where applicable 2020-06-21 02:16:30 -04:00
Lioncash bbfa7b364c CPropertyNameGenerator: Make use of unique_ptr
Same behavior, but more exception safe.
2020-06-21 01:54:55 -04:00
Lioncash 74ea300fe5 CAnimEventData: Make use of size_t where applicable 2020-06-21 01:44:28 -04:00
Lioncash c2be854b0f CWorldLoader: Make use of unsigned stream helpers 2020-06-20 04:25:43 -04:00
Lioncash cdc3328051 CWorldCooker: Make use of unsigned stream helpers 2020-06-20 04:10:46 -04:00
Lioncash b3e4807517 CUnsupportedFormatLoader: Make use of unsigned stream helpers 2020-06-20 03:53:07 -04:00
Lioncash f1e115a717 CTweakLoader: Make use of unsigned stream helpers 2020-06-20 03:33:03 -04:00
Lioncash 39fd1f8c75 CTweakCooker: Make use of unsigned stream helpers 2020-06-20 03:13:47 -04:00
Lioncash a1f7459a8d CTextureEncoder: Make use of unsigned stream helpers 2020-06-20 02:58:00 -04:00
Lioncash 3d60eee5b4 CTextureDecoder: Make use of unsigned stream utilities where applicable 2020-06-20 02:50:39 -04:00
Lioncash 70b4da4e9d CTexture: Make CalcTotalSize() a const member function 2020-06-20 02:44:44 -04:00
Lioncash 5363799228 CTexture: Make use of unsigned stream helpers where applicable 2020-06-20 02:44:11 -04:00
Lioncash 4672b75ec1 CStringLoader: Make use of unsigned stream utilities 2020-06-20 02:35:19 -04:00
Lioncash f0b82908d5 CStringCooker: Make use of unsigned stream utilities
Same behavior, less implicit sign conversions.
2020-06-20 02:01:28 -04:00
Lioncash ef57260f0b CWaypointExtra: Make use of ranged-for where applicable
Same behavior, less moving parts.
2020-06-20 00:06:59 -04:00
Lioncash 8c06309364 CSplinePathExtra: Collapse RemoveWaypoint loop into find_if() 2020-06-20 00:00:09 -04:00
Lioncash 487f2ae176 CSkinLoader: Make use of unsigned stream helpers where applicable
Less implicit sign conversions
2020-06-19 23:55:48 -04:00
Lioncash d738ae0d45 CSkeletonLoader: Make use of unsigned stream helpers where applicable
Same behavior, less implicit sign conversions.
2020-06-19 23:52:12 -04:00
Lioncash 71fd2b8754 CScriptTemplate: Collapse loop to find_if() in RemoveObject() 2020-06-19 23:43:40 -04:00
Lioncash 731e34b90b CScriptTemplate: Make use of ranged for where applicable 2020-06-19 23:40:28 -04:00
Lioncash d93810568b CScriptObject: Make use of ranged for where applicable 2020-06-19 23:31:30 -04:00
Lioncash 9f8ecc855b CScriptNode: Tidy up code
- Collapse loops to ranged for where applicable, etc.
2020-06-19 20:55:39 -04:00
Lioncash 0a66503026 CScriptNode: Initialize all class variables
Provides a consistent initial state.
2020-06-19 20:31:08 -04:00
Lioncash 48e182ca80 CScriptLoader: Make use of unsigned stream helpers where applicable 2020-06-19 20:27:49 -04:00
Lioncash 888ceb55d5 CScriptLoader: Make use of in-class initializers
Same behavior, less code.
2020-06-19 20:23:38 -04:00
Lioncash 7629f15f40 CScriptCooker: Make use of unsigned stream helpers
Same behavior, less sign conversion warnings.
2020-06-19 20:21:01 -04:00
Lioncash d9046b4fd9 CScene: Prevent redundant lookups in DeleteNode()
Avoids unnecessary repeated map lookups.
2020-06-19 19:25:12 -04:00
Lioncash d7574a1965 CScene: General tidying up
- Ranged for, sign conversion fixes, etc.
2020-06-19 19:18:13 -04:00
Lioncash 1adb20dc0b CResourceEntry: Eliminate sign conversion warning 2020-06-19 19:03:27 -04:00
Lioncash 92fe105e82 CRenderer: Make use of std::array 2020-06-19 18:57:33 -04:00
Lioncash 9441933ce2 CRenderer: Make use of in-class initializers
Same behavior, less code.
2020-06-19 18:51:45 -04:00
Lioncash f88122b2ed CRenderBucket: Tidy up code 2020-06-19 18:47:24 -04:00
Lioncash b02b507675 CRayCollisionTester: Tidy up code a little 2020-06-19 18:39:21 -04:00
Lioncash 40f0fbca4c CPointOfInterestExtra: Make color instances constexpr
Avoids unnecessary file-scope static constructors.
2020-06-19 18:35:11 -04:00
Lioncash 84506c99fb CModelCooker: Make use of unsigned stream helpers where applicable 2020-06-19 18:04:37 -04:00
Lioncash 0059558efc CScene: Make use of in-class initializers 2020-06-19 03:44:19 -04:00
Lioncash ffbe857c2c CScanLoader: Make use of unsigned stream helpers 2020-06-19 03:41:41 -04:00
Lioncash 125da2d930 CScanCooking: Make use of unsigned stream helpers 2020-06-19 03:40:31 -04:00
Lioncash 61ec2f2e08 CResourceEntry: Make use of static qualifier
This function doesn't depend on instance state.
2020-06-19 03:38:02 -04:00
Lioncash 1e46717b57 CPropertyNameGenerator: Make use of in-class initializers
Same behavior, less code.
2020-06-19 03:32:25 -04:00
Lioncash 53881d1748 CPoiToWorldLoader: Make use of unsigned stream utilities 2020-06-19 03:30:42 -04:00
Lioncash be97a39778 CPoiToWorldCooker: Make use of unsigned stream utilities 2020-06-19 03:30:10 -04:00
Lioncash 5661d0263e CPoiToWorld: Make use of ranged for 2020-06-19 03:27:46 -04:00
Lioncash a6caff1387 CPoiToWorld: Make use of unique_ptr
Safer memory management.
2020-06-19 03:22:24 -04:00
Lioncash df29cc2109 CPackage: Make use of unsigned stream helpers where applicable 2020-06-19 03:13:41 -04:00
Lioncash 9a2580ad03 CModelNode: Make use of in-class initializers
Same behavior, less code.
2020-06-19 02:56:52 -04:00
Lioncash 73d010e6d1 CModelLoader: Make use of unsigned stream helpers where applicable
Same behavior without implicit sign conversions
2020-06-19 02:50:40 -04:00
Lioncash 80e4790384 CFontLoader: Make use of unsigned stream helpers
Same behavior, minus implicit sign conversions.
2020-06-19 02:44:46 -04:00
Lioncash b559df4e0a CDoorExtra: Tidying up
- Fix wonky formatting
- Apply const
2020-06-19 02:38:35 -04:00
Lioncash 0ec31eef71 CDependencyGroupLoader: Make use of unsigned stream helpers
Eliminates implicit sign conversions
2020-06-19 02:35:21 -04:00
Lioncash 3dd325f708 CDamageableTriggerExtra: Make use of unique_ptr
Safer lifetime management.
2020-06-19 00:28:25 -04:00
Lioncash 81560138c0 CDamageableTriggerExtra: add missing override specifier 2020-06-19 00:26:48 -04:00
Lioncash 75be364148 CDamageableTriggerExtra: Make use of std::array
Stronger typing.
2020-06-19 00:26:09 -04:00
Lioncash e875c2bf08 CCollisionLoader: Make use of unsigned helper functions where applicable
Same behavior minus several sign conversion warnings.
2020-06-19 00:19:44 -04:00
Lioncash bcc27ddd5c CAudioGroupLoader: Make use of unsigned stream helpers where applicable
Same behavior, minus implicit sign conversions.
2020-06-18 19:38:22 -04:00
Lioncash 59cfe6fc02 CAreaLoader: Make use of unsigned stream helpers
Same behavior, minus all the implicit sign conversions.
2020-06-18 19:35:11 -04:00
Lioncash d646b896e1 CAreaLoader: Make use of in-class initializers where applicable
Same behavior, less code.
2020-06-18 19:20:01 -04:00
Lioncash 4d4f1490b7 CAreaCooker: Make use of unsigned stream helpers where applicable
Same behavior minus numerous implicit sign conversions.
2020-06-18 19:16:51 -04:00
Lioncash cf0898792a CAnimSetLoader: Make use of unsigned stream helpers where applicable
Same behavior, minus all of the implicit sign conversions.
2020-06-18 19:08:37 -04:00
Lioncash 36e005844f CPackage: std::move strings in constructor where applicable
Allows calling code to completely avoid copies.
2020-06-18 18:47:23 -04:00
Lioncash bf9be7f2ad CGameProject: Mark vars as const where applicable 2020-06-18 18:45:45 -04:00
Lioncash 811447a387 CGameExporter: Mark ShouldExportDiscNode() as a const member function
This doesn't modify internal state.
2020-06-18 18:41:00 -04:00
Lioncash 2d1e6b9672 CGameExporter: Make use of unsigned stream helpers where applicable 2020-06-18 18:39:44 -04:00
Lioncash a603b3a4ef CMaterialLoader: Make use of unsigned stream helpers where applicable 2020-06-18 18:14:33 -04:00
Lioncash 4b20a8ad9f CMaterialCooker: Make use of unsigned write variants where applicable
Gets rid of a bunch of implicit sign conversion warnings.
2020-06-18 17:50:25 -04:00
Lioncash 4b980458ef CAnimationLoader: Make use of ranged for where applicable 2020-06-18 15:55:19 -04:00
Lioncash 87fac0896d CModelLoader: Eliminate some sign conversion warnings 2020-06-18 15:38:52 -04:00
Lioncash 80d5983229 CMaterialPass: Add another missing break for Mode 6 in SetAnimCurrent 2020-06-18 13:51:08 -04:00
Lioncash e65a2a7cc8 CMaterialPass: Add missing break for Mode 6 in SetAnimCurrent 2020-06-18 13:39:20 -04:00
Lioncash 1c0e7a3b1d CGameExporter: Make use of in-class initializers
Same behavior, less code.
2020-06-18 13:35:01 -04:00